This allows greater flexibility for ordering transfers and barriers
relative to render passes.
#include "pipelinestate.h"
#include "rect.h"
#include "semaphore.h"
#include "pipelinestate.h"
#include "rect.h"
#include "semaphore.h"
+#include "structurebuilder.h"
#include "swapchaintexture.h"
#include "vulkan.h"
#include "swapchaintexture.h"
#include "vulkan.h"
-void VulkanCommands::begin_buffer()
+void VulkanCommands::begin_buffer(VkRenderPass render_pass)
{
if(!current_pool)
throw invalid_operation("VulkanCommands::begin_buffer");
{
if(!current_pool)
throw invalid_operation("VulkanCommands::begin_buffer");
current_pool->in_use = true;
}
current_pool->in_use = true;
}
- if(current_pool->next_buffer>=current_pool->buffers.size())
+ CommandBuffers &buffers = (render_pass ? current_pool->secondary : current_pool->primary);
+
+ if(buffers.next_buffer>=buffers.buffers.size())
{
VkCommandBufferAllocateInfo alloc_info = { };
alloc_info.sType = VK_STRUCTURE_TYPE_COMMAND_BUFFER_ALLOCATE_INFO;
alloc_info.commandPool = handle_cast<::VkCommandPool>(current_pool->pool);
{
VkCommandBufferAllocateInfo alloc_info = { };
alloc_info.sType = VK_STRUCTURE_TYPE_COMMAND_BUFFER_ALLOCATE_INFO;
alloc_info.commandPool = handle_cast<::VkCommandPool>(current_pool->pool);
- alloc_info.level = VK_COMMAND_BUFFER_LEVEL_PRIMARY;
+ alloc_info.level = (render_pass ? VK_COMMAND_BUFFER_LEVEL_SECONDARY : VK_COMMAND_BUFFER_LEVEL_PRIMARY);
alloc_info.commandBufferCount = 1;
VkCommandBuffer buffer;
vk.AllocateCommandBuffers(alloc_info, &buffer);
alloc_info.commandBufferCount = 1;
VkCommandBuffer buffer;
vk.AllocateCommandBuffers(alloc_info, &buffer);
- current_pool->buffers.push_back(buffer);
+ buffers.buffers.push_back(buffer);
- current_buffer = current_pool->buffers[current_pool->next_buffer++];
+ VkCommandBuffer buffer = buffers.buffers[buffers.next_buffer++];
+ (render_pass ? pass_buffer : primary_buffer) = buffer;
VkCommandBufferBeginInfo begin_info = { };
begin_info.sType = VK_STRUCTURE_TYPE_COMMAND_BUFFER_BEGIN_INFO;
begin_info.flags = VK_COMMAND_BUFFER_USAGE_ONE_TIME_SUBMIT_BIT;
VkCommandBufferBeginInfo begin_info = { };
begin_info.sType = VK_STRUCTURE_TYPE_COMMAND_BUFFER_BEGIN_INFO;
begin_info.flags = VK_COMMAND_BUFFER_USAGE_ONE_TIME_SUBMIT_BIT;
+ if(render_pass)
+ begin_info.flags |= VK_COMMAND_BUFFER_USAGE_RENDER_PASS_CONTINUE_BIT;
+
+ VkCommandBufferInheritanceInfo inherit_info = { };
+ if(render_pass)
+ {
+ inherit_info.sType = VK_STRUCTURE_TYPE_COMMAND_BUFFER_INHERITANCE_INFO;
+ inherit_info.renderPass = handle_cast<::VkRenderPass>(render_pass);
+ inherit_info.subpass = 0;
- vk.BeginCommandBuffer(current_buffer, begin_info);
+ begin_info.pInheritanceInfo = &inherit_info;
+ }
+
+ vk.BeginCommandBuffer(buffer, begin_info);
}
void VulkanCommands::begin_render_pass(bool clear, const ClearValue *clear_values)
}
void VulkanCommands::begin_render_pass(bool clear, const ClearValue *clear_values)
viewport = pipeline_state->get_viewport();
viewport = pipeline_state->get_viewport();
- const VulkanFunctions &vk = device.get_functions();
-
- if(!current_buffer)
- begin_buffer();
-
- device.get_transfer_queue().dispatch_transfers(current_buffer);
+ if(!primary_buffer)
+ begin_buffer(0);
Synchronizer &sync = device.get_synchronizer();
sync.reset();
Synchronizer &sync = device.get_synchronizer();
sync.reset();
- sync.barrier(current_buffer);
+ sync.barrier(primary_buffer);
+
+ begin_buffer(render_pass);
+
+ StructureBuilder sb(pass_begin_info, 2);
+ VkRenderPassBeginInfo *&begin_info = sb.add<VkRenderPassBeginInfo>(1);
+ VkClearValue *&vk_clear_values = sb.add<VkClearValue>(FrameFormat::MAX_ATTACHMENTS);
- VkRenderPassBeginInfo begin_info = { };
- begin_info.sType = VK_STRUCTURE_TYPE_RENDER_PASS_BEGIN_INFO;
- begin_info.renderPass = handle_cast<::VkRenderPass>(render_pass);
- begin_info.framebuffer = handle_cast<::VkFramebuffer>(framebuffer->handle);
+ begin_info->sType = VK_STRUCTURE_TYPE_RENDER_PASS_BEGIN_INFO;
+ begin_info->renderPass = handle_cast<::VkRenderPass>(render_pass);
+ begin_info->framebuffer = handle_cast<::VkFramebuffer>(framebuffer->handle);
- begin_info.renderArea.offset.x = viewport->left;
- begin_info.renderArea.offset.y = viewport->bottom;
- begin_info.renderArea.extent.width = viewport->width;
- begin_info.renderArea.extent.height = viewport->height;
+ begin_info->renderArea.offset.x = viewport->left;
+ begin_info->renderArea.offset.y = viewport->bottom;
+ begin_info->renderArea.extent.width = viewport->width;
+ begin_info->renderArea.extent.height = viewport->height;
- begin_info.renderArea.extent.width = framebuffer->get_width();
- begin_info.renderArea.extent.height = framebuffer->get_height();
+ begin_info->renderArea.extent.width = framebuffer->get_width();
+ begin_info->renderArea.extent.height = framebuffer->get_height();
- VkClearValue vk_clear_values[7];
if(clear_values)
{
unsigned i = 0;
if(clear_values)
{
unsigned i = 0;
- begin_info.clearValueCount = framebuffer->get_format().size();
- begin_info.pClearValues = vk_clear_values;
+ begin_info->clearValueCount = framebuffer->get_format().size();
+ begin_info->pClearValues = vk_clear_values;
-
- vk.CmdBeginRenderPass(current_buffer, begin_info, VK_SUBPASS_CONTENTS_INLINE);
}
void VulkanCommands::end_render_pass()
{
const VulkanFunctions &vk = device.get_functions();
}
void VulkanCommands::end_render_pass()
{
const VulkanFunctions &vk = device.get_functions();
- vk.CmdEndRenderPass(current_buffer);
+ vk.EndCommandBuffer(pass_buffer);
+
+ const VkRenderPassBeginInfo &begin_info = *reinterpret_cast<const VkRenderPassBeginInfo *>(pass_begin_info.data());
+ vk.CmdBeginRenderPass(primary_buffer, begin_info, VK_SUBPASS_CONTENTS_SECONDARY_COMMAND_BUFFERS);
+ vk.CmdExecuteCommands(primary_buffer, 1, &pass_buffer);
+ vk.CmdEndRenderPass(primary_buffer);
+
framebuffer = 0;
viewport = 0;
framebuffer = 0;
viewport = 0;
}
void VulkanCommands::begin_frame(unsigned index)
}
void VulkanCommands::begin_frame(unsigned index)
current_pool->fence.wait();
vk.ResetCommandPool(current_pool->pool, 0);
current_pool->in_use = false;
current_pool->fence.wait();
vk.ResetCommandPool(current_pool->pool, 0);
current_pool->in_use = false;
- current_pool->next_buffer = 0;
+ current_pool->primary.next_buffer = 0;
+ current_pool->secondary.next_buffer = 0;
}
}
void VulkanCommands::submit_frame(Semaphore *wait_sem, Semaphore *signal_sem)
{
}
}
void VulkanCommands::submit_frame(Semaphore *wait_sem, Semaphore *signal_sem)
{
return;
const VulkanFunctions &vk = device.get_functions();
return;
const VulkanFunctions &vk = device.get_functions();
if(framebuffer)
end_render_pass();
if(framebuffer)
end_render_pass();
- vk.EndCommandBuffer(current_buffer);
+ vk.EndCommandBuffer(primary_buffer);
VkSubmitInfo submit_info = { };
submit_info.sType = VK_STRUCTURE_TYPE_SUBMIT_INFO;
VkSubmitInfo submit_info = { };
submit_info.sType = VK_STRUCTURE_TYPE_SUBMIT_INFO;
submit_info.pWaitSemaphores = &vk_wait_sem;
submit_info.pWaitDstStageMask = &wait_stages;
submit_info.commandBufferCount = 1;
submit_info.pWaitSemaphores = &vk_wait_sem;
submit_info.pWaitDstStageMask = &wait_stages;
submit_info.commandBufferCount = 1;
- submit_info.pCommandBuffers = handle_cast<::VkCommandBuffer *>(¤t_buffer);
+ submit_info.pCommandBuffers = handle_cast<::VkCommandBuffer *>(&primary_buffer);
submit_info.signalSemaphoreCount = (signal_sem ? 1 : 0);
submit_info.pSignalSemaphores = &vk_signal_sem;
vk.QueueSubmit(1, &submit_info, current_pool->fence.handle);
submit_info.signalSemaphoreCount = (signal_sem ? 1 : 0);
submit_info.pSignalSemaphores = &vk_signal_sem;
vk.QueueSubmit(1, &submit_info, current_pool->fence.handle);
}
void VulkanCommands::use_pipeline(const PipelineState *ps)
}
void VulkanCommands::use_pipeline(const PipelineState *ps)
begin_render_pass(false, 0);
pipeline_state->refresh();
begin_render_pass(false, 0);
pipeline_state->refresh();
- pipeline_state->apply(current_buffer, fb_is_swapchain);
+ pipeline_state->apply(pass_buffer, fb_is_swapchain);
unsigned first_index = batch.get_offset()/batch.get_index_size();
unsigned first_index = batch.get_offset()/batch.get_index_size();
- vk.CmdDrawIndexed(current_buffer, batch.size(), count, first_index, 0, 0);
+ vk.CmdDrawIndexed(pass_buffer, batch.size(), count, first_index, 0, 0);
}
void VulkanCommands::resolve_multisample(Framebuffer &)
}
void VulkanCommands::resolve_multisample(Framebuffer &)
class VulkanCommands
{
protected:
class VulkanCommands
{
protected:
+ struct CommandBuffers
+ {
+ std::vector<VkCommandBuffer> buffers;
+ unsigned next_buffer = 0;
+ };
+
struct CommandPool
{
Device &device;
VkCommandPool pool = 0;
struct CommandPool
{
Device &device;
VkCommandPool pool = 0;
- std::vector<VkCommandBuffer> buffers;
- unsigned next_buffer = 0;
+ CommandBuffers primary;
+ CommandBuffers secondary;
Fence fence;
bool in_use = false;
Fence fence;
bool in_use = false;
Device &device;
std::vector<CommandPool> command_pools;
CommandPool *current_pool = 0;
Device &device;
std::vector<CommandPool> command_pools;
CommandPool *current_pool = 0;
- VkCommandBuffer current_buffer = 0;
+ VkCommandBuffer primary_buffer = 0;
+ VkCommandBuffer pass_buffer = 0;
const PipelineState *pipeline_state = 0;
const Framebuffer *framebuffer = 0;
const Rect *viewport = 0;
bool fb_is_swapchain = false;
const PipelineState *pipeline_state = 0;
const Framebuffer *framebuffer = 0;
const Rect *viewport = 0;
bool fb_is_swapchain = false;
+ std::vector<char> pass_begin_info;
VulkanCommands();
~VulkanCommands();
VulkanCommands();
~VulkanCommands();
+ void begin_buffer(VkRenderPass);
void begin_render_pass(bool, const ClearValue *);
void end_render_pass();
void begin_render_pass(bool, const ClearValue *);
void end_render_pass();
vkBeginCommandBuffer(context.get_function<PFN_vkBeginCommandBuffer>("vkBeginCommandBuffer")),
vkEndCommandBuffer(context.get_function<PFN_vkEndCommandBuffer>("vkEndCommandBuffer")),
vkQueueSubmit(context.get_function<PFN_vkQueueSubmit>("vkQueueSubmit")),
vkBeginCommandBuffer(context.get_function<PFN_vkBeginCommandBuffer>("vkBeginCommandBuffer")),
vkEndCommandBuffer(context.get_function<PFN_vkEndCommandBuffer>("vkEndCommandBuffer")),
vkQueueSubmit(context.get_function<PFN_vkQueueSubmit>("vkQueueSubmit")),
+ vkCmdExecuteCommands(context.get_function<PFN_vkCmdExecuteCommands>("vkCmdExecuteCommands")),
// 7
vkCreateFence(context.get_function<PFN_vkCreateFence>("vkCreateFence")),
vkDestroyFence(context.get_function<PFN_vkDestroyFence>("vkDestroyFence")),
// 7
vkCreateFence(context.get_function<PFN_vkCreateFence>("vkCreateFence")),
vkDestroyFence(context.get_function<PFN_vkDestroyFence>("vkDestroyFence")),
PFN_vkBeginCommandBuffer vkBeginCommandBuffer = 0; // 6.4
PFN_vkEndCommandBuffer vkEndCommandBuffer = 0; // 6.4
PFN_vkQueueSubmit vkQueueSubmit = 0; // 6.5
PFN_vkBeginCommandBuffer vkBeginCommandBuffer = 0; // 6.4
PFN_vkEndCommandBuffer vkEndCommandBuffer = 0; // 6.4
PFN_vkQueueSubmit vkQueueSubmit = 0; // 6.5
+ PFN_vkCmdExecuteCommands vkCmdExecuteCommands = 0; // 6.7
PFN_vkCreateFence vkCreateFence = 0; // 7.3
PFN_vkDestroyFence vkDestroyFence = 0; // 7.3
PFN_vkGetFenceStatus vkGetFenceStatus = 0; // 7.3
PFN_vkCreateFence vkCreateFence = 0; // 7.3
PFN_vkDestroyFence vkDestroyFence = 0; // 7.3
PFN_vkGetFenceStatus vkGetFenceStatus = 0; // 7.3
Result QueueSubmit(std::uint32_t submitCount, const VkSubmitInfo *pSubmits, VkFence fence) const
{ return { vkQueueSubmit(graphicsQueue, submitCount, pSubmits, handle_cast<::VkFence>(fence)), "vkQueueSubmit" }; }
Result QueueSubmit(std::uint32_t submitCount, const VkSubmitInfo *pSubmits, VkFence fence) const
{ return { vkQueueSubmit(graphicsQueue, submitCount, pSubmits, handle_cast<::VkFence>(fence)), "vkQueueSubmit" }; }
+ void CmdExecuteCommands(VkCommandBuffer commandBuffer, std::uint32_t commandBufferCount, const VkCommandBuffer *pCommandBuffers) const
+ { vkCmdExecuteCommands(handle_cast<::VkCommandBuffer>(commandBuffer), commandBufferCount, handle_cast<const ::VkCommandBuffer *>(pCommandBuffers)); }
+
// Chapter 7: Synchronization and Cache Control
Result CreateFence(const VkFenceCreateInfo &rCreateInfo, VkFence &rFence) const
{ return { vkCreateFence(device, &rCreateInfo, 0, handle_cast<::VkFence *>(&rFence)), "vkCreateFence" }; }
// Chapter 7: Synchronization and Cache Control
Result CreateFence(const VkFenceCreateInfo &rCreateInfo, VkFence &rFence) const
{ return { vkCreateFence(device, &rCreateInfo, 0, handle_cast<::VkFence *>(&rFence)), "vkCreateFence" }; }