}
+void DeclarationValidator::apply(Stage &s, const Features &f)
+{
+ stage = &s;
+ features = f;
+ s.content.visit(*this);
+
+ Node *global_err_node = 0;
+ auto i = s.functions.find("main()");
+ if(i!=s.functions.end())
+ global_err_node = i->second;
+ else
+ {
+ for(auto j=s.content.body.begin(); (!global_err_node && j!=s.content.body.end()); ++j)
+ if((*j)->source>0)
+ global_err_node = j->get();
+ }
+
+ if(s.type==Stage::TESS_CONTROL)
+ {
+ if(!have_output_vertex_count)
+ error(*global_err_node, "No vertex count qualifier found on output");
+ }
+ else if(s.type==Stage::TESS_EVAL)
+ {
+ if(!have_input_primitive)
+ error(*global_err_node, "No primitive type qualifier found on input");
+ }
+ else if(s.type==Stage::GEOMETRY)
+ {
+ if(!have_input_primitive)
+ error(*global_err_node, "No primitive type qualifier found on input");
+ if(!have_output_primitive)
+ error(*global_err_node, "No primitive type qualifier found on output");
+ if(!have_output_vertex_count)
+ error(*global_err_node, "No vertex count qualifier found on output");
+ }
+ else if(s.type==Stage::COMPUTE)
+ {
+ if(!have_workgroup_size)
+ error(*global_err_node, "No workgroup size qualifier found");
+ }
+}
+
const char *DeclarationValidator::describe_variable(ScopeType scope)
{
switch(scope)
void DeclarationValidator::visit(Layout &layout)
{
+ bool push_constant = false;
+ bool binding = false;
for(const Layout::Qualifier &q: layout.qualifiers)
{
bool allowed = false;
allowed = (variable && scope==GLOBAL);
else if(q.name=="binding" || q.name=="set")
{
- if(q.name=="set")
+ binding = true;
+
+ if(q.name=="set" && features.target_api!=VULKAN)
{
error(layout, "Layout qualifier 'set' not allowed when targeting OpenGL");
continue;
if(variable)
{
- TypeDeclaration *type = variable->type_declaration;
- while(BasicTypeDeclaration *basic = dynamic_cast<BasicTypeDeclaration *>(type))
- type = basic->base_type;
+ const TypeDeclaration *base_type = get_ultimate_base_type(variable->type_declaration);
bool uniform = (variable->interface=="uniform");
- allowed = (scope==GLOBAL && uniform && dynamic_cast<ImageTypeDeclaration *>(type));
+ allowed = (scope==GLOBAL && uniform && dynamic_cast<const ImageTypeDeclaration *>(base_type));
err_descr = (uniform ? "variable of non-opaque type" : "non-uniform variable");
}
else if(iface_block)
{
allowed = (stage->type==Stage::GEOMETRY && iface_layout && (iface_layout->interface=="in" || iface_layout->interface=="out"));
value = false;
+ if(allowed)
+ {
+ if(iface_layout->interface=="in")
+ have_input_primitive = true;
+ else if(iface_layout->interface=="out")
+ have_output_primitive = true;
+ }
+ }
+ else if(q.name=="triangles")
+ {
+ allowed = ((stage->type==Stage::GEOMETRY || stage->type==Stage::TESS_EVAL) && iface_layout && iface_layout->interface=="in");
+ value = false;
+ if(allowed)
+ have_input_primitive = true;
}
- else if(q.name=="lines" || q.name=="lines_adjacency" || q.name=="triangles" || q.name=="triangles_adjacency")
+ else if(q.name=="lines" || q.name=="lines_adjacency" || q.name=="triangles_adjacency")
{
allowed = (stage->type==Stage::GEOMETRY && iface_layout && iface_layout->interface=="in");
value = false;
+ if(allowed)
+ have_input_primitive = true;
+ }
+ else if(q.name=="quads" || q.name=="isolines")
+ {
+ allowed = (stage->type==Stage::TESS_EVAL && iface_layout && iface_layout->interface=="in");
+ value = false;
+ if(allowed)
+ have_input_primitive = true;
}
else if(q.name=="line_strip" || q.name=="triangle_strip")
{
allowed = (stage->type==Stage::GEOMETRY && iface_layout && iface_layout->interface=="out");
value = false;
+ if(allowed)
+ have_output_primitive = true;
}
else if(q.name=="invocations")
allowed = (stage->type==Stage::GEOMETRY && iface_layout && iface_layout->interface=="in");
else if(q.name=="max_vertices")
+ {
allowed = (stage->type==Stage::GEOMETRY && iface_layout && iface_layout->interface=="out");
+ if(allowed)
+ have_output_vertex_count = true;
+ }
+ else if(q.name=="vertices")
+ {
+ allowed = (stage->type==Stage::TESS_CONTROL && iface_layout && iface_layout->interface=="out");
+ if(allowed)
+ have_output_vertex_count = true;
+ }
+ else if(q.name=="cw" || q.name=="ccw" ||
+ q.name=="equal_spacing" || q.name=="fractional_even_spacing" || q.name=="fractional_odd_spacing")
+ {
+ allowed = (stage->type==Stage::TESS_EVAL && iface_layout && iface_layout->interface=="in");
+ value = false;
+ }
else if(q.name=="std140" || q.name=="std430")
{
allowed = (iface_block && !variable && iface_block->interface=="uniform");
err_descr = "non-matrix variable";
}
}
+ else if(q.name=="push_constant")
+ {
+ push_constant = true;
+ allowed = (iface_block && !variable && iface_block->interface=="uniform");
+ value = false;
+ }
+ else if(q.name=="local_size_x" || q.name=="local_size_y" || q.name=="local_size_z")
+ {
+ allowed = (stage->type==Stage::COMPUTE && iface_layout && iface_layout->interface=="in");
+ if(allowed)
+ have_workgroup_size = true;
+ }
+ else if(q.name=="rgba32f" || q.name=="rgba16f" || q.name=="rg32f" || q.name=="rg16f" || q.name=="r32f" || q.name=="r16f" ||
+ q.name=="rgba16" || q.name=="rgba8" || q.name=="rg16" || q.name=="rg8" || q.name=="r16" || q.name=="r8" ||
+ q.name=="rgba16_snorm" || q.name=="rgba8_snorm" || q.name=="rg16_snorm" || q.name=="rg8_snorm" || q.name=="r16_snorm" || q.name=="r8_snorm")
+ {
+ allowed = variable;
+ value = false;
+ if(allowed)
+ {
+ const TypeDeclaration *base_type = get_ultimate_base_type(variable->type_declaration);
+ const ImageTypeDeclaration *image = dynamic_cast<const ImageTypeDeclaration *>(base_type);
+ allowed = (image && !image->sampled);
+ err_descr = (image ? "sampled image" : "non-image variable");
+ }
+ }
if(!allowed)
{
else if(!value && q.has_value)
error(layout, format("Layout qualifier '%s' does not allow a value", q.name));
}
+
+ if(push_constant && binding)
+ error(layout, "Layout qualifier 'push_constant' not allowed together with 'binding' or 'set'");
}
void DeclarationValidator::visit(InterfaceLayout &layout)
void DeclarationValidator::visit(StructDeclaration &strct)
{
- SetForScope<ScopeType> set_scope(scope, (scope!=INTERFACE_BLOCK ? STRUCT : scope));
+ SetForScope<ScopeType> set_scope(scope, (strct.block_name.empty() ? STRUCT : INTERFACE_BLOCK));
+ SetForScope<VariableDeclaration *> set_iface(iface_block, strct.block_declaration);
TraversingVisitor::visit(strct);
}
void DeclarationValidator::visit(VariableDeclaration &var)
{
- SetForScope<VariableDeclaration *> set_var(variable, &var);
+ SetForScope<VariableDeclaration *> set_var((var.block_declaration ? iface_block : variable), &var);
const char *descr = describe_variable(scope);
if(!var.interpolation.empty() || !var.sampling.empty())
{
- if(var.interface!="in" && stage->type==Stage::VERTEX)
+ if(var.interface=="in" && stage->type==Stage::VERTEX)
error(var, "Interpolation qualifier not allowed on vertex input");
- else if(var.interface!="out" && stage->type==Stage::FRAGMENT)
+ else if(var.interface=="out" && stage->type==Stage::FRAGMENT)
error(var, "Interpolation qualifier not allowed on fragment output");
else if((var.interface!="in" && var.interface!="out") || (scope==FUNCTION_PARAM || scope==FUNCTION))
error(var, "Interpolation qualifier not allowed on non-interpolated variable");
+ else if(var.sampling=="patch" && (stage->type!=Stage::TESS_CONTROL || var.interface!="out") && (stage->type!=Stage::TESS_EVAL || var.interface!="in"))
+ error(var, "Per-patch variables only allowed on tessellation control output or tessellation evaluation input");
+ if(var.sampling=="patch" && !var.interpolation.empty())
+ error(var, "Interpolation qualifier not allowed on per-patch variable");
}
if(!var.interface.empty())
error(var, format("Mismatched interface qualifier '%s' inside '%s' block", var.interface, iface_block->interface));
else if(scope==STRUCT || scope==FUNCTION)
error(var, format("Interface qualifier not allowed on %s", descr));
+ else if(scope==GLOBAL && var.interface=="uniform" && !var.block_declaration && features.target_api==VULKAN)
+ {
+ if(!dynamic_cast<const ImageTypeDeclaration *>(get_ultimate_base_type(var.type_declaration)))
+ error(var, "Interface qualifier 'uniform' not allowed on non-opaque variable in global scope");
+ }
}
TypeDeclaration *type = var.type_declaration;
else if(scope==GLOBAL && var.interface!="uniform")
error(var, format("Type '%s' only allowed with uniform interface", type->name));
}
+ else if(var.block_declaration)
+ {
+ if(stage->type==Stage::VERTEX && var.interface=="in")
+ error(var, "Interface block not allowed on vertex shader input");
+ else if(stage->type==Stage::FRAGMENT && var.interface=="out")
+ error(var, "Interface block not allowed on fragment shader output");
+ }
else if(kind==BasicTypeDeclaration::VOID)
error(var, "Type 'void' not allowed on variable");
else if(kind==BasicTypeDeclaration::BOOL && var.source!=BUILTIN_SOURCE)
error(var, "Type 'bool' not allowed on interface variable");
}
+ if(var.array && !var.array_size)
+ error(var, "Array must have a size");
+
if(var.init_expression)
{
if(scope==GLOBAL && !var.constant)
}
}
-void DeclarationValidator::visit(InterfaceBlock &iface)
-{
- SetForScope<ScopeType> set_scope(scope, INTERFACE_BLOCK);
- SetForScope<InterfaceBlock *> set_iface(iface_block, &iface);
-
- if(stage->type==Stage::VERTEX && iface.interface=="in")
- error(iface, "Interface block not allowed on vertex shader input");
- else if(stage->type==Stage::FRAGMENT && iface.interface=="out")
- error(iface, "Interface block not allowed on fragment shader output");
-
- TraversingVisitor::visit(iface);
- if(iface.struct_declaration)
- iface.struct_declaration->visit(*this);
-}
-
void DeclarationValidator::visit(FunctionDeclaration &func)
{
SetForScope<ScopeType> set_scope(scope, FUNCTION_PARAM);
void IdentifierValidator::visit(TypeDeclaration &type)
{
- check_definition(type.name, type);
+ if(type.source!=INTERNAL_SOURCE)
+ check_definition(type.name, type);
}
void IdentifierValidator::visit(StructDeclaration &strct)
{
- check_definition(strct.name, strct);
+ if(strct.block_name.empty())
+ check_definition(strct.name, strct);
TraversingVisitor::visit(strct);
}
void IdentifierValidator::visit(VariableDeclaration &var)
{
- check_definition(var.name, var);
- TraversingVisitor::visit(var);
-}
+ if(var.block_declaration)
+ {
+ string key = format("%s %s", var.interface, var.block_declaration->block_name);
+ auto i = interface_blocks.find(key);
+ if(i!=interface_blocks.end())
+ multiple_definition(format("interface block '%s %s'", var.interface, var.block_declaration->block_name), var, *i->second);
+ else
+ interface_blocks.insert(make_pair(key, &var));
-void IdentifierValidator::visit(InterfaceBlock &iface)
-{
- string key = format("%s %s", iface.interface, iface.block_name);
- auto i = interface_blocks.find(key);
- if(i!=interface_blocks.end())
- multiple_definition(format("interface block '%s %s'", iface.interface, iface.block_name), iface, *i->second);
- else
- interface_blocks.insert(make_pair(key, &iface));
+ if(Statement *previous = find_definition(var.block_declaration->block_name))
+ {
+ const VariableDeclaration *prev_var = dynamic_cast<const VariableDeclaration *>(previous);
+ if(!prev_var || !prev_var->block_declaration)
+ multiple_definition(format("'%s'", var.block_declaration->block_name), var, *previous);
+ }
+ else
+ record_definition(var.block_declaration->block_name, var);
- if(Statement *previous = find_definition(iface.block_name))
- {
- if(!dynamic_cast<InterfaceBlock *>(previous))
- multiple_definition(format("'%s'", iface.block_name), iface, *previous);
+ if(var.name.find(' ')!=string::npos)
+ {
+ // Inject anonymous interface block members into the global scope
+ for(const auto &kvp: var.block_declaration->members.variables)
+ check_definition(kvp.first, *kvp.second);
+ }
}
- else
- record_definition(iface.block_name, iface);
- if(!iface.instance_name.empty())
- check_definition(iface.instance_name, iface);
+ if(var.name.find(' ')==string::npos)
+ check_definition(var.name, var);
- if(iface.instance_name.empty() && iface.struct_declaration)
- {
- // Inject anonymous interface block members into the global scope
- for(const auto &kvp: iface.struct_declaration->members.variables)
- check_definition(kvp.first, *kvp.second);
- }
+ TraversingVisitor::visit(var);
}
void IdentifierValidator::visit(FunctionDeclaration &func)
if(!var.declaration)
error(var, format("Use of undeclared variable '%s'", var.name));
else if(stage->type!=Stage::VERTEX && var.declaration->interface=="in" && var.name.compare(0, 3, "gl_") && !var.declaration->linked_declaration)
- error(var, format("Use of unlinked input variable '%s'", var.name));
+ error(var, format("Use of unlinked input %s '%s'", (var.declaration->block_declaration ? "block" : "variable"), var.name));
}
void ReferenceValidator::visit(MemberAccess &memacc)
TraversingVisitor::visit(memacc);
}
-void ReferenceValidator::visit(InterfaceBlockReference &iface)
-{
- /* An interface block reference without a declaration should be impossible
- since references are generated based on existing declarations. */
- if(!iface.declaration)
- error(iface, format("Use of undeclared interface block '%s'", iface.name));
- else if(stage->type!=Stage::VERTEX && iface.declaration->interface=="in" && !iface.declaration->linked_block)
- error(iface, format("Use of unlinked input block '%s'", iface.name));
-}
-
void ReferenceValidator::visit(FunctionCall &call)
{
if((!call.constructor && !call.declaration) || (call.constructor && !call.type))
TraversingVisitor::visit(var);
}
-void ReferenceValidator::visit(InterfaceBlock &iface)
-{
- if(!iface.struct_declaration)
- error(iface, format("Interface block '%s %s' lacks a struct declaration", iface.interface, iface.block_name));
- TraversingVisitor::visit(iface);
-}
-
void ReferenceValidator::visit(FunctionDeclaration &func)
{
if(!func.return_type_declaration)
if(var.declaration && constant_expression)
{
if(!var.declaration->constant)
- error(var, format("Reference to non-constant variable '%s' in a constant expression", var.name));
+ {
+ const char *kind = (var.declaration->block_declaration ? "interface block" : "non-constant variable");
+ error(var, format("Reference to %s '%s' in a constant expression", kind, var.name));
+ }
else if(var.declaration->layout && constant_expression==FIXED_CONSTANT)
{
- auto i = find_member(var.declaration->layout->qualifiers, string("constant_id"), &Layout::Qualifier::name);
- if(i!=var.declaration->layout->qualifiers.end())
+ if(has_layout_qualifier(var.declaration->layout.get(), "constant_id"))
error(var, format("Reference to specialization constant '%s' in a fixed constant expression", var.name));
}
}
}
-void ExpressionValidator::visit(InterfaceBlockReference &iface)
-{
- if(constant_expression)
- error(iface, format("Reference to interface block '%s' in a constant expression", iface.name));
-}
-
void ExpressionValidator::visit(Swizzle &swizzle)
{
unsigned size = 0;
var.layout->visit(*this);
if(var.init_expression)
{
- ConstantKind const_kind = (var.constant ? SPEC_CONSTANT : NOT_CONSTANT);
- if(var.layout)
- {
- auto i = find_member(var.layout->qualifiers, string("constant_id"), &Layout::Qualifier::name);
- if(i!=var.layout->qualifiers.end())
- const_kind = FIXED_CONSTANT;
- }
+ ConstantKind const_kind = (!var.constant ? NOT_CONSTANT :
+ has_layout_qualifier(var.layout.get(), "constant_id") ? FIXED_CONSTANT : SPEC_CONSTANT);
SetForScope<ConstantKind> set_const(constant_expression, const_kind);
TraversingVisitor::visit(var.init_expression);
}
-int StageInterfaceValidator::get_location(const Layout &layout)
-{
- return get_layout_value(layout, "location", -1);
-}
-
void StageInterfaceValidator::visit(VariableDeclaration &var)
{
- int location = (var.layout ? get_location(*var.layout) : -1);
+ int location = get_layout_value(var.layout.get(), "location");
if(var.interface=="in" && var.linked_declaration)
{
const Layout *linked_layout = var.linked_declaration->layout.get();
- int linked_location = (linked_layout ? get_location(*linked_layout) : -1);
+ int linked_location = get_layout_value(linked_layout, "location");
if(linked_location!=location)
{
error(var, format("Mismatched location %d for 'in %s'", location, var.name));
if(var.type_declaration && var.linked_declaration->type_declaration)
{
TypeDeclaration *type = var.type_declaration;
- if(stage->type==Stage::GEOMETRY)
+ if(stage->type==Stage::TESS_CONTROL || stage->type==Stage::GEOMETRY)
{
if(const BasicTypeDeclaration *basic = dynamic_cast<const BasicTypeDeclaration *>(type))
if(basic->kind==BasicTypeDeclaration::ARRAY && basic->base_type)
var.linked_declaration->name, var.linked_declaration->type_declaration->name));
}
}
+ if((var.sampling=="patch") != (var.linked_declaration->sampling=="patch"))
+ {
+ error(var, format("Mismatched sampling qualifier '%s' for 'in %s'", var.sampling, var.name));
+ add_info(*var.linked_declaration, format("Linked to 'out %s' qualified as '%s'",
+ var.linked_declaration->name, var.linked_declaration->sampling));
+ }
}
if(location>=0 && !var.interface.empty())
error(*uni.node, format("Mismatched location %d for uniform '%s'", uni.location, uni.name));
add_info(*i->second->node, format("Previously declared here with location %d", i->second->location));
}
+ if(i->second->desc_set!=uni.desc_set)
+ {
+ error(*uni.node, format("Mismatched descriptor set %d for uniform '%s'", uni.desc_set, uni.name));
+ add_info(*i->second->node, format("Previously declared here with descriptor set %d", i->second->desc_set));
+ }
if(uni.bind_point>=0 && i->second->bind_point>=0 && i->second->bind_point!=uni.bind_point)
{
error(*uni.node, format("Mismatched binding %d for uniform '%s'", uni.bind_point, uni.name));
Uniform uni;
uni.node = &var;
uni.type = var.type_declaration;
- uni.name = var.name;
+ uni.name = (var.block_declaration ? var.block_declaration->block_name : var.name);
if(var.layout)
{
- uni.location = get_layout_value(*var.layout, "location");
- uni.loc_count = LocationCounter().apply(var);
- uni.desc_set = get_layout_value(*var.layout, "set", 0);
- uni.bind_point = get_layout_value(*var.layout, "binding");
- }
-
- uniforms.push_back(uni);
- check_uniform(uniforms.back());
- }
-}
-
-void GlobalInterfaceValidator::visit(InterfaceBlock &iface)
-{
- if(iface.interface=="uniform")
- {
- Uniform uni;
- uni.node = &iface;
- uni.type = iface.struct_declaration;
- uni.name = iface.block_name;
- if(iface.layout)
- {
- uni.desc_set = get_layout_value(*iface.layout, "set", 0);
- uni.bind_point = get_layout_value(*iface.layout, "binding");
+ if(!var.block_declaration)
+ {
+ uni.location = get_layout_value(var.layout.get(), "location");
+ uni.loc_count = LocationCounter().apply(var);
+ }
+ uni.desc_set = get_layout_value(var.layout.get(), "set", 0);
+ uni.bind_point = get_layout_value(var.layout.get(), "binding");
}
uniforms.push_back(uni);
projects / libs / gl.git / blobdiff