source/glsl/validate.cpp

   1 #include <cstring>
   2 #include <msp/core/algorithm.h>
   3 #include <msp/core/raii.h>
   4 #include <msp/strings/format.h>
   5 #include <msp/strings/utils.h>
   6 #include "reflect.h"
   7 #include "validate.h"
   8
   9 using namespace std;
  10
  11 namespace Msp {
  12 namespace GL {
  13 namespace SL {
  14
  15 void Validator::diagnose(Node &node, Node &provoking_node, Diagnostic::Severity severity, const string &message)
  16 {
  17         Diagnostic diag;
  18         diag.severity = severity;
  19         diag.source = node.source;
  20         diag.line = node.line;
  21         diag.provoking_source = provoking_node.source;
  22         diag.provoking_line = provoking_node.line;
  23         diag.message = message;
  24         stage->diagnostics.push_back(diag);
  25
  26         last_provoker = &provoking_node;
  27 }
  28
  29 void Validator::add_info(Node &node, const string &message)
  30 {
  31         if(!last_provoker)
  32                 throw logic_error("Tried to add info without a previous provoker");
  33         diagnose(node, *last_provoker, Diagnostic::INFO, message);
  34 }
  35
  36
  37 void DeclarationValidator::apply(Stage &s, const Features &f)
  38 {
  39         stage = &s;
  40         features = f;
  41         s.content.visit(*this);
  42 }
  43
  44 const char *DeclarationValidator::describe_variable(ScopeType scope)
  45 {
  46         switch(scope)
  47         {
  48         case GLOBAL: return "global variable";
  49         case STRUCT: return "struct member";
  50         case INTERFACE_BLOCK: return "interface block member";
  51         case FUNCTION_PARAM: return "function parameter";
  52         case FUNCTION: return "local variable";
  53         default: return "variable";
  54         }
  55 }
  56
  57 void DeclarationValidator::visit(Layout &layout)
  58 {
  59         bool push_constant = false;
  60         bool binding = false;
  61         for(const Layout::Qualifier &q: layout.qualifiers)
  62         {
  63                 bool allowed = false;
  64                 string err_descr;
  65                 bool value = true;
  66                 if(q.name=="location")
  67                         allowed = (variable && scope==GLOBAL);
  68                 else if(q.name=="binding" || q.name=="set")
  69                 {
  70                         binding = true;
  71
  72                         if(q.name=="set" && features.target_api!=VULKAN)
  73                         {
  74                                 error(layout, "Layout qualifier 'set' not allowed when targeting OpenGL");
  75                                 continue;
  76                         }
  77
  78                         if(variable)
  79                         {
  80                                 const TypeDeclaration *base_type = get_ultimate_base_type(variable->type_declaration);
  81                                 bool uniform = (variable->interface=="uniform");
  82                                 allowed = (scope==GLOBAL && uniform && dynamic_cast<const ImageTypeDeclaration *>(base_type));
  83                                 err_descr = (uniform ? "variable of non-opaque type" : "non-uniform variable");
  84                         }
  85                         else if(iface_block)
  86                         {
  87                                 allowed = (iface_block->interface=="uniform");
  88                                 err_descr = "non-uniform interface block";
  89                         }
  90                 }
  91                 else if(q.name=="constant_id")
  92                 {
  93                         allowed = (variable && scope==GLOBAL);
  94                         if(allowed)
  95                         {
  96                                 if(!variable->constant)
  97                                 {
  98                                         allowed = false;
  99                                         err_descr = "non-constant variable";
 100                                 }
 101                                 else
 102                                 {
 103                                         BasicTypeDeclaration *basic = dynamic_cast<BasicTypeDeclaration *>(variable->type_declaration);
 104                                         if(!basic || basic->kind<BasicTypeDeclaration::BOOL || basic->kind>BasicTypeDeclaration::INT)
 105                                         {
 106                                                 allowed = false;
 107                                                 err_descr = format("variable of type '%s'",
 108                                                         (variable->type_declaration ? variable->type_declaration->name : variable->type));
 109                                         }
 110                                 }
 111                         }
 112                 }
 113                 else if(q.name=="offset")
 114                         allowed = (variable && scope==INTERFACE_BLOCK && iface_block->interface=="uniform");
 115                 else if(q.name=="align")
 116                         allowed = (scope==INTERFACE_BLOCK && iface_block->interface=="uniform");
 117                 else if(q.name=="points")
 118                 {
 119                         allowed = (stage->type==Stage::GEOMETRY && iface_layout && (iface_layout->interface=="in" || iface_layout->interface=="out"));
 120                         value = false;
 121                 }
 122                 else if(q.name=="lines" || q.name=="lines_adjacency" || q.name=="triangles" || q.name=="triangles_adjacency")
 123                 {
 124                         allowed = (stage->type==Stage::GEOMETRY && iface_layout && iface_layout->interface=="in");
 125                         value = false;
 126                 }
 127                 else if(q.name=="line_strip" || q.name=="triangle_strip")
 128                 {
 129                         allowed = (stage->type==Stage::GEOMETRY && iface_layout && iface_layout->interface=="out");
 130                         value = false;
 131                 }
 132                 else if(q.name=="invocations")
 133                         allowed = (stage->type==Stage::GEOMETRY && iface_layout && iface_layout->interface=="in");
 134                 else if(q.name=="max_vertices")
 135                         allowed = (stage->type==Stage::GEOMETRY && iface_layout && iface_layout->interface=="out");
 136                 else if(q.name=="std140" || q.name=="std430")
 137                 {
 138                         allowed = (iface_block && !variable && iface_block->interface=="uniform");
 139                         value = false;
 140                 }
 141                 else if(q.name=="column_major" || q.name=="row_major")
 142                 {
 143                         allowed = (variable && scope==INTERFACE_BLOCK);
 144                         if(allowed)
 145                         {
 146                                 BasicTypeDeclaration *basic = dynamic_cast<BasicTypeDeclaration *>(variable->type_declaration);
 147                                 while(basic && basic->kind==BasicTypeDeclaration::ARRAY)
 148                                         basic = dynamic_cast<BasicTypeDeclaration *>(basic->base_type);
 149                                 allowed = (basic && basic->kind==BasicTypeDeclaration::MATRIX);
 150                                 err_descr = "non-matrix variable";
 151                         }
 152                 }
 153                 else if(q.name=="push_constant")
 154                 {
 155                         push_constant = true;
 156                         allowed = (iface_block && !variable && iface_block->interface=="uniform");
 157                         value = false;
 158                 }
 159
 160                 if(!allowed)
 161                 {
 162                         if(err_descr.empty())
 163                         {
 164                                 if(variable)
 165                                         err_descr = describe_variable(scope);
 166                                 else if(iface_block)
 167                                         err_descr = "interface block";
 168                                 else if(iface_layout)
 169                                         err_descr = format("interface '%s'", iface_layout->interface);
 170                                 else
 171                                         err_descr = "unknown declaration";
 172                         }
 173                         error(layout, format("Layout qualifier '%s' not allowed on %s", q.name, err_descr));
 174                 }
 175                 else if(value && !q.has_value)
 176                         error(layout, format("Layout qualifier '%s' requires a value", q.name));
 177                 else if(!value && q.has_value)
 178                         error(layout, format("Layout qualifier '%s' does not allow a value", q.name));
 179         }
 180
 181         if(push_constant && binding)
 182                 error(layout, "Layout qualifier 'push_constant' not allowed together with 'binding' or 'set'");
 183 }
 184
 185 void DeclarationValidator::visit(InterfaceLayout &layout)
 186 {
 187         SetForScope<InterfaceLayout *> set_layout(iface_layout, &layout);
 188         TraversingVisitor::visit(layout);
 189 }
 190
 191 void DeclarationValidator::visit(BasicTypeDeclaration &type)
 192 {
 193         BasicTypeDeclaration *basic_base = dynamic_cast<BasicTypeDeclaration *>(type.base_type);
 194         BasicTypeDeclaration::Kind base_kind = (basic_base ? basic_base->kind : BasicTypeDeclaration::VOID);
 195
 196         if(type.kind==BasicTypeDeclaration::VECTOR && (base_kind<BasicTypeDeclaration::BOOL || base_kind>BasicTypeDeclaration::FLOAT))
 197                 error(type, format("Invalid base type '%s' for vector type '%s'", type.base, type.name));
 198         else if(type.kind==BasicTypeDeclaration::MATRIX && base_kind!=BasicTypeDeclaration::VECTOR)
 199                 error(type, format("Invalid base type '%s' for matrix type '%s'", type.base, type.name));
 200         else if(type.kind==BasicTypeDeclaration::ARRAY && basic_base && base_kind==BasicTypeDeclaration::VOID)
 201                 error(type, format("Invalid base type '%s' for array type '%s'", type.base, type.name));
 202 }
 203
 204 void DeclarationValidator::visit(ImageTypeDeclaration &type)
 205 {
 206         BasicTypeDeclaration::Kind base_kind = BasicTypeDeclaration::VOID;
 207         if(BasicTypeDeclaration *basic_base = dynamic_cast<BasicTypeDeclaration *>(type.base_type))
 208                 base_kind = basic_base->kind;
 209         if(base_kind!=BasicTypeDeclaration::INT && base_kind!=BasicTypeDeclaration::FLOAT)
 210                 error(type, format("Invalid base type '%s' for image type '%s'", type.base, type.name));
 211 }
 212
 213 void DeclarationValidator::visit(StructDeclaration &strct)
 214 {
 215         SetForScope<ScopeType> set_scope(scope, (scope!=INTERFACE_BLOCK ? STRUCT : scope));
 216         TraversingVisitor::visit(strct);
 217 }
 218
 219 void DeclarationValidator::visit(VariableDeclaration &var)
 220 {
 221         SetForScope<VariableDeclaration *> set_var(variable, &var);
 222
 223         const char *descr = describe_variable(scope);
 224
 225         if(var.layout)
 226         {
 227                 if(scope!=GLOBAL && scope!=INTERFACE_BLOCK)
 228                         error(var, format("Layout qualifier not allowed on %s", descr));
 229                 else
 230                         var.layout->visit(*this);
 231         }
 232
 233         if(var.constant)
 234         {
 235                 if(scope==STRUCT || scope==INTERFACE_BLOCK)
 236                         error(var, format("Constant qualifier not allowed on %s", descr));
 237                 if(!var.init_expression)
 238                         error(var, "Constant variable must have an initializer");
 239         }
 240
 241         if(!var.interpolation.empty() || !var.sampling.empty())
 242         {
 243                 if(var.interface!="in" && stage->type==Stage::VERTEX)
 244                         error(var, "Interpolation qualifier not allowed on vertex input");
 245                 else if(var.interface!="out" && stage->type==Stage::FRAGMENT)
 246                         error(var, "Interpolation qualifier not allowed on fragment output");
 247                 else if((var.interface!="in" && var.interface!="out") || (scope==FUNCTION_PARAM || scope==FUNCTION))
 248                         error(var, "Interpolation qualifier not allowed on non-interpolated variable");
 249         }
 250
 251         if(!var.interface.empty())
 252         {
 253                 if(iface_block && var.interface!=iface_block->interface)
 254                         error(var, format("Mismatched interface qualifier '%s' inside '%s' block", var.interface, iface_block->interface));
 255                 else if(scope==STRUCT || scope==FUNCTION)
 256                         error(var, format("Interface qualifier not allowed on %s", descr));
 257                 else if(scope==GLOBAL && variable->interface=="uniform" && features.target_api==VULKAN)
 258                 {
 259                         if(!dynamic_cast<const ImageTypeDeclaration *>(get_ultimate_base_type(variable->type_declaration)))
 260                                 error(var, "Interface qualifier 'uniform' not allowed on non-opaque variable in global scope");
 261                 }
 262         }
 263
 264         TypeDeclaration *type = var.type_declaration;
 265         BasicTypeDeclaration::Kind kind = BasicTypeDeclaration::ALIAS;
 266         while(BasicTypeDeclaration *basic = dynamic_cast<BasicTypeDeclaration *>(type))
 267         {
 268                 kind = basic->kind;
 269                 type = basic->base_type;
 270         }
 271         if(dynamic_cast<ImageTypeDeclaration *>(type))
 272         {
 273                 if(scope!=GLOBAL && scope!=FUNCTION_PARAM)
 274                         error(var, format("Type '%s' not allowed on %s", type->name, descr));
 275                 else if(scope==GLOBAL && var.interface!="uniform")
 276                         error(var, format("Type '%s' only allowed with uniform interface", type->name));
 277         }
 278         else if(kind==BasicTypeDeclaration::VOID)
 279                 error(var, "Type 'void' not allowed on variable");
 280         else if(kind==BasicTypeDeclaration::BOOL && var.source!=BUILTIN_SOURCE)
 281         {
 282                 if(scope==INTERFACE_BLOCK)
 283                         error(var, "Type 'bool' not allowed in an interface block");
 284                 else if(!var.interface.empty())
 285                         error(var, "Type 'bool' not allowed on interface variable");
 286         }
 287
 288         if(var.init_expression)
 289         {
 290                 if(scope==GLOBAL && !var.constant)
 291                         error(var, format("Initializer not allowed on non-constant %s", descr));
 292                 else if(scope!=GLOBAL && scope!=FUNCTION)
 293                         error(var, format("Initializer not allowed on %s", descr));
 294                 else
 295                         var.init_expression->visit(*this);
 296         }
 297 }
 298
 299 void DeclarationValidator::visit(InterfaceBlock &iface)
 300 {
 301         SetForScope<ScopeType> set_scope(scope, INTERFACE_BLOCK);
 302         SetForScope<InterfaceBlock *> set_iface(iface_block, &iface);
 303
 304         if(stage->type==Stage::VERTEX && iface.interface=="in")
 305                 error(iface, "Interface block not allowed on vertex shader input");
 306         else if(stage->type==Stage::FRAGMENT && iface.interface=="out")
 307                 error(iface, "Interface block not allowed on fragment shader output");
 308
 309         TraversingVisitor::visit(iface);
 310         if(iface.struct_declaration)
 311                 iface.struct_declaration->visit(*this);
 312 }
 313
 314 void DeclarationValidator::visit(FunctionDeclaration &func)
 315 {
 316         SetForScope<ScopeType> set_scope(scope, FUNCTION_PARAM);
 317         for(const RefPtr<VariableDeclaration> &p: func.parameters)
 318                 p->visit(*this);
 319         scope = FUNCTION;
 320         func.body.visit(*this);
 321 }
 322
 323
 324 void IdentifierValidator::multiple_definition(const string &name, Statement &statement, Statement &previous)
 325 {
 326         error(statement, format("Multiple definition of %s", name));
 327         add_info(previous, "Previous definition is here");
 328 }
 329
 330 Statement *IdentifierValidator::find_definition(const string &name)
 331 {
 332         BlockDeclarationMap *decls = &declarations[current_block];
 333         auto i = decls->find(name);
 334         if(i==decls->end() && anonymous_block)
 335         {
 336                 decls = &declarations[current_block->parent];
 337                 i = decls->find(name);
 338         }
 339         return (i!=decls->end() ? i->second : 0);
 340 }
 341
 342 void IdentifierValidator::check_definition(const string &name, Statement &statement)
 343 {
 344         if(Statement *previous = find_definition(name))
 345                 multiple_definition(format("'%s'", name), statement, *previous);
 346         else
 347                 record_definition(name, statement);
 348 }
 349
 350 void IdentifierValidator::record_definition(const string &name, Statement &statement)
 351 {
 352         declarations[current_block].insert(make_pair(name, &statement));
 353         if(anonymous_block)
 354                 declarations[current_block->parent].insert(make_pair(name, &statement));
 355 }
 356
 357 void IdentifierValidator::visit(TypeDeclaration &type)
 358 {
 359         check_definition(type.name, type);
 360 }
 361
 362 void IdentifierValidator::visit(StructDeclaration &strct)
 363 {
 364         check_definition(strct.name, strct);
 365         TraversingVisitor::visit(strct);
 366 }
 367
 368 void IdentifierValidator::visit(VariableDeclaration &var)
 369 {
 370         check_definition(var.name, var);
 371         TraversingVisitor::visit(var);
 372 }
 373
 374 void IdentifierValidator::visit(InterfaceBlock &iface)
 375 {
 376         string key = format("%s %s", iface.interface, iface.block_name);
 377         auto i = interface_blocks.find(key);
 378         if(i!=interface_blocks.end())
 379                 multiple_definition(format("interface block '%s %s'", iface.interface, iface.block_name), iface, *i->second);
 380         else
 381                 interface_blocks.insert(make_pair(key, &iface));
 382
 383         if(Statement *previous = find_definition(iface.block_name))
 384         {
 385                 if(!dynamic_cast<InterfaceBlock *>(previous))
 386                         multiple_definition(format("'%s'", iface.block_name), iface, *previous);
 387         }
 388         else
 389                 record_definition(iface.block_name, iface);
 390
 391         if(!iface.instance_name.empty())
 392                 check_definition(iface.instance_name, iface);
 393
 394         if(iface.instance_name.empty() && iface.struct_declaration)
 395         {
 396                 // Inject anonymous interface block members into the global scope
 397                 for(const auto &kvp: iface.struct_declaration->members.variables)
 398                         check_definition(kvp.first, *kvp.second);
 399         }
 400 }
 401
 402 void IdentifierValidator::visit(FunctionDeclaration &func)
 403 {
 404         string key = func.name+func.signature;
 405         auto i = overloaded_functions.find(key);
 406         if(i==overloaded_functions.end())
 407                 overloaded_functions.insert(make_pair(key, &func));
 408         else if(func.return_type_declaration && i->second->return_type_declaration!=func.return_type_declaration)
 409         {
 410                 error(func, format("Conflicting return type '%s' for function '%s'", func.return_type_declaration->name, func.name));
 411                 if(i->second->return_type_declaration)
 412                         add_info(*i->second, format("Previously declared as returning '%s'", i->second->return_type_declaration->name));
 413         }
 414
 415         if(Statement *previous = find_definition(func.name))
 416         {
 417                 if(!dynamic_cast<FunctionDeclaration *>(previous))
 418                         multiple_definition(format("'%s'", func.name), func, *previous);
 419         }
 420         else
 421                 record_definition(func.name, func);
 422
 423         if(func.definition==&func)
 424                 check_definition(func.name+func.signature, func);
 425
 426         TraversingVisitor::visit(func);
 427 }
 428
 429
 430 void ReferenceValidator::visit(BasicTypeDeclaration &type)
 431 {
 432         if(!type.base.empty() && !type.base_type)
 433                 error(type, format("Use of undeclared type '%s'", type.base));
 434 }
 435
 436 void ReferenceValidator::visit(ImageTypeDeclaration &type)
 437 {
 438         if(!type.base.empty() && !type.base_type)
 439                 error(type, format("Use of undeclared type '%s'", type.base));
 440 }
 441
 442 void ReferenceValidator::visit(VariableReference &var)
 443 {
 444         if(!var.declaration)
 445                 error(var, format("Use of undeclared variable '%s'", var.name));
 446         else if(stage->type!=Stage::VERTEX && var.declaration->interface=="in" && var.name.compare(0, 3, "gl_") && !var.declaration->linked_declaration)
 447                 error(var, format("Use of unlinked input variable '%s'", var.name));
 448 }
 449
 450 void ReferenceValidator::visit(MemberAccess &memacc)
 451 {
 452         if(memacc.left->type && !memacc.declaration)
 453                 error(memacc, format("Use of undeclared member '%s'", memacc.member));
 454         TraversingVisitor::visit(memacc);
 455 }
 456
 457 void ReferenceValidator::visit(InterfaceBlockReference &iface)
 458 {
 459         /* An interface block reference without a declaration should be impossible
 460         since references are generated based on existing declarations. */
 461         if(!iface.declaration)
 462                 error(iface, format("Use of undeclared interface block '%s'", iface.name));
 463         else if(stage->type!=Stage::VERTEX && iface.declaration->interface=="in" && !iface.declaration->linked_block)
 464                 error(iface, format("Use of unlinked input block '%s'", iface.name));
 465 }
 466
 467 void ReferenceValidator::visit(FunctionCall &call)
 468 {
 469         if((!call.constructor && !call.declaration) || (call.constructor && !call.type))
 470         {
 471                 bool have_declaration = call.constructor;
 472                 if(!call.constructor)
 473                 {
 474                         auto i = stage->functions.lower_bound(call.name);
 475                         have_declaration = (i!=stage->functions.end() && i->second->name==call.name);
 476                 }
 477
 478                 if(have_declaration)
 479                 {
 480                         bool valid_types = true;
 481                         string signature;
 482                         for(auto j=call.arguments.begin(); (valid_types && j!=call.arguments.end()); ++j)
 483                         {
 484                                 if((*j)->type)
 485                                         append(signature, ", ", (*j)->type->name);
 486                                 else
 487                                         valid_types = false;
 488                         }
 489
 490                         if(valid_types)
 491                                 error(call, format("No matching %s found for '%s(%s)'", (call.constructor ? "constructor" : "overload"), call.name, signature));
 492                 }
 493                 else
 494                         error(call, format("Call to undeclared function '%s'", call.name));
 495         }
 496         TraversingVisitor::visit(call);
 497 }
 498
 499 void ReferenceValidator::visit(VariableDeclaration &var)
 500 {
 501         if(!var.type_declaration)
 502                 error(var, format("Use of undeclared type '%s'", var.type));
 503         TraversingVisitor::visit(var);
 504 }
 505
 506 void ReferenceValidator::visit(InterfaceBlock &iface)
 507 {
 508         if(!iface.struct_declaration)
 509                 error(iface, format("Interface block '%s %s' lacks a struct declaration", iface.interface, iface.block_name));
 510         TraversingVisitor::visit(iface);
 511 }
 512
 513 void ReferenceValidator::visit(FunctionDeclaration &func)
 514 {
 515         if(!func.return_type_declaration)
 516                 error(func, format("Use of undeclared type '%s'", func.return_type));
 517         TraversingVisitor::visit(func);
 518 }
 519
 520
 521 void ExpressionValidator::visit(VariableReference &var)
 522 {
 523         if(var.declaration && constant_expression)
 524         {
 525                 if(!var.declaration->constant)
 526                         error(var, format("Reference to non-constant variable '%s' in a constant expression", var.name));
 527                 else if(var.declaration->layout && constant_expression==FIXED_CONSTANT)
 528                 {
 529                         auto i = find_member(var.declaration->layout->qualifiers, string("constant_id"), &Layout::Qualifier::name);
 530                         if(i!=var.declaration->layout->qualifiers.end())
 531                                 error(var, format("Reference to specialization constant '%s' in a fixed constant expression", var.name));
 532                 }
 533         }
 534 }
 535
 536 void ExpressionValidator::visit(InterfaceBlockReference &iface)
 537 {
 538         if(constant_expression)
 539                 error(iface, format("Reference to interface block '%s' in a constant expression", iface.name));
 540 }
 541
 542 void ExpressionValidator::visit(Swizzle &swizzle)
 543 {
 544         unsigned size = 0;
 545         if(BasicTypeDeclaration *basic = dynamic_cast<BasicTypeDeclaration *>(swizzle.left->type))
 546         {
 547                 if(basic->kind==BasicTypeDeclaration::INT || basic->kind==BasicTypeDeclaration::FLOAT)
 548                         size = 1;
 549                 else if(basic->kind==BasicTypeDeclaration::VECTOR)
 550                         size = basic->size;
 551         }
 552
 553         if(size)
 554         {
 555                 static const char component_names[] = { 'x', 'y', 'z', 'w', 'r', 'g', 'b', 'a', 's', 't', 'p', 'q' };
 556                 int flavour = -1;
 557                 for(unsigned i=0; i<swizzle.count; ++i)
 558                 {
 559                         unsigned component_flavour = (std::find(component_names, component_names+12, swizzle.component_group[i])-component_names)/4;
 560                         if(flavour==-1)
 561                                 flavour = component_flavour;
 562                         else if(flavour>=0 && component_flavour!=static_cast<unsigned>(flavour))
 563                         {
 564                                 error(swizzle, format("Flavour of swizzle component '%c' is inconsistent with '%c'",
 565                                         swizzle.component_group[i], swizzle.component_group[0]));
 566                                 flavour = -2;
 567                         }
 568
 569                         if(swizzle.components[i]>=size)
 570                                 error(swizzle, format("Access to component '%c' which is not present in '%s'",
 571                                         swizzle.component_group[i], swizzle.left->type->name));
 572                 }
 573         }
 574         else if(swizzle.left->type)
 575                 error(swizzle, format("Swizzle applied to '%s' which is neither a scalar nor a vector", swizzle.left->type->name));
 576
 577         TraversingVisitor::visit(swizzle);
 578 }
 579
 580 void ExpressionValidator::visit(UnaryExpression &unary)
 581 {
 582         if(unary.expression->type)
 583         {
 584                 if(!unary.type)
 585                         error(unary, format("No matching operator '%s' found for '%s'", unary.oper->token, unary.expression->type->name));
 586                 else if(unary.oper->token[1]=='+' || unary.oper->token[1]=='-')
 587                 {
 588                         if(constant_expression)
 589                                 error(unary, format("Use of '%s' in a constant expression", unary.oper->token));
 590                         else if(!unary.expression->lvalue)
 591                                 error(unary, format("Operand of '%s' is not an lvalue", unary.oper->token));
 592                 }
 593         }
 594         TraversingVisitor::visit(unary);
 595 }
 596
 597 void ExpressionValidator::visit(BinaryExpression &binary)
 598 {
 599         if(!binary.type && binary.left->type && binary.right->type)
 600         {
 601                 if(binary.oper->token[0]=='[')
 602                         error(binary, format("Can't index element of '%s' with '%s'",
 603                                 binary.left->type->name, binary.right->type->name));
 604                 else
 605                         error(binary, format("No matching operator '%s' found for '%s' and '%s'",
 606                                 binary.oper->token, binary.left->type->name, binary.right->type->name));
 607         }
 608         TraversingVisitor::visit(binary);
 609 }
 610
 611 void ExpressionValidator::visit(Assignment &assign)
 612 {
 613         if(assign.left->type)
 614         {
 615                 if(constant_expression)
 616                         error(assign, "Assignment in constant expression");
 617                 else if(!assign.left->lvalue)
 618                         error(assign, "Target of assignment is not an lvalue");
 619                 if(assign.right->type)
 620                 {
 621                         if(assign.oper->token[0]!='=')
 622                         {
 623                                 if(!assign.type)
 624                                         error(assign, format("No matching operator '%s' found for '%s' and '%s'",
 625                                                 string(assign.oper->token, strlen(assign.oper->token)-1), assign.left->type->name, assign.right->type->name));
 626                         }
 627                         else if(assign.left->type!=assign.right->type)
 628                                 error(assign, format("Assignment to variable of type '%s' from expression of incompatible type '%s'",
 629                                         assign.left->type->name, assign.right->type->name));
 630                 }
 631         }
 632         TraversingVisitor::visit(assign);
 633 }
 634
 635 void ExpressionValidator::visit(TernaryExpression &ternary)
 636 {
 637         if(ternary.condition->type)
 638         {
 639                 BasicTypeDeclaration *basic_cond = dynamic_cast<BasicTypeDeclaration *>(ternary.condition->type);
 640                 if(!basic_cond || basic_cond->kind!=BasicTypeDeclaration::BOOL)
 641                         error(ternary, "Ternary operator condition is not a boolean");
 642                 else if(!ternary.type && ternary.true_expr->type && ternary.false_expr->type)
 643                         error(ternary, format("Ternary operator has incompatible types '%s' and '%s'",
 644                                 ternary.true_expr->type->name, ternary.false_expr->type->name));
 645         }
 646         TraversingVisitor::visit(ternary);
 647 }
 648
 649 void ExpressionValidator::visit(StructDeclaration &strct)
 650 {
 651         SetFlag set_struct(in_struct);
 652         TraversingVisitor::visit(strct);
 653 }
 654
 655 void ExpressionValidator::visit(VariableDeclaration &var)
 656 {
 657         if(var.init_expression && var.init_expression->type && var.type_declaration && var.init_expression->type!=var.type_declaration)
 658                 error(var, format("Initializing a variable of type '%s' with an expression of incompatible type '%s'",
 659                         var.type_declaration->name, var.init_expression->type->name));
 660
 661         if(var.layout)
 662                 var.layout->visit(*this);
 663         if(var.init_expression)
 664         {
 665                 ConstantKind const_kind = (var.constant ? SPEC_CONSTANT : NOT_CONSTANT);
 666                 if(var.layout)
 667                 {
 668                         auto i = find_member(var.layout->qualifiers, string("constant_id"), &Layout::Qualifier::name);
 669                         if(i!=var.layout->qualifiers.end())
 670                                 const_kind = FIXED_CONSTANT;
 671                 }
 672
 673                 SetForScope<ConstantKind> set_const(constant_expression, const_kind);
 674                 TraversingVisitor::visit(var.init_expression);
 675         }
 676         if(var.array_size)
 677         {
 678                 SetForScope<ConstantKind> set_const(constant_expression, (in_struct || !var.interface.empty() ? FIXED_CONSTANT : SPEC_CONSTANT));
 679                 TraversingVisitor::visit(var.array_size);
 680         }
 681 }
 682
 683 void ExpressionValidator::visit(FunctionDeclaration &func)
 684 {
 685         SetForScope<FunctionDeclaration *> set_func(current_function, &func);
 686         TraversingVisitor::visit(func);
 687 }
 688
 689 void ExpressionValidator::visit(Conditional &cond)
 690 {
 691         if(cond.condition->type)
 692         {
 693                 BasicTypeDeclaration *basic_cond = dynamic_cast<BasicTypeDeclaration *>(cond.condition->type);
 694                 if(!basic_cond || basic_cond->kind!=BasicTypeDeclaration::BOOL)
 695                         error(cond, "Condition is not a boolean");
 696         }
 697         TraversingVisitor::visit(cond);
 698 }
 699
 700 void ExpressionValidator::visit(Iteration &iter)
 701 {
 702         if(iter.condition->type)
 703         {
 704                 BasicTypeDeclaration *basic_cond = dynamic_cast<BasicTypeDeclaration *>(iter.condition->type);
 705                 if(!basic_cond || basic_cond->kind!=BasicTypeDeclaration::BOOL)
 706                         error(iter, "Loop condition is not a boolean");
 707         }
 708         TraversingVisitor::visit(iter);
 709 }
 710
 711 void ExpressionValidator::visit(Return &ret)
 712 {
 713         if(current_function && current_function->return_type_declaration)
 714         {
 715                 TypeDeclaration *return_type = current_function->return_type_declaration;
 716                 BasicTypeDeclaration *basic_return = dynamic_cast<BasicTypeDeclaration *>(return_type);
 717                 if(ret.expression)
 718                 {
 719                         if(ret.expression->type && ret.expression->type!=return_type)
 720                                 error(ret, format("Return expression type '%s' is incompatible with declared return type '%s'",
 721                                         ret.expression->type->name, return_type->name));
 722                 }
 723                 else if(!basic_return || basic_return->kind!=BasicTypeDeclaration::VOID)
 724                         error(ret, "Return statement without an expression in a function not returning 'void'");
 725         }
 726
 727         TraversingVisitor::visit(ret);
 728 }
 729
 730
 731 void FlowControlValidator::visit(Block &block)
 732 {
 733         for(const RefPtr<Statement> &s: block.body)
 734         {
 735                 if(!reachable)
 736                 {
 737                         diagnose(*s, Diagnostic::WARN, "Unreachable code detected");
 738                         break;
 739                 }
 740                 s->visit(*this);
 741         }
 742 }
 743
 744 void FlowControlValidator::visit(FunctionDeclaration &func)
 745 {
 746         func.body.visit(*this);
 747
 748         if(func.definition==&func && func.return_type_declaration)
 749         {
 750                 const BasicTypeDeclaration *basic_ret = dynamic_cast<const BasicTypeDeclaration *>(func.return_type_declaration);
 751                 if(reachable && (!basic_ret || basic_ret->kind!=BasicTypeDeclaration::VOID))
 752                         error(func, "Missing return statement at the end of a function not returning 'void'");
 753         }
 754         reachable = true;
 755 }
 756
 757 void FlowControlValidator::visit(Conditional &cond)
 758 {
 759         cond.body.visit(*this);
 760         bool reachable_if_true = reachable;
 761         reachable = true;
 762         cond.else_body.visit(*this);
 763         reachable |= reachable_if_true;
 764 }
 765
 766 void FlowControlValidator::visit(Iteration &iter)
 767 {
 768         iter.body.visit(*this);
 769         reachable = true;
 770 }
 771
 772
 773 int StageInterfaceValidator::get_location(const Layout &layout)
 774 {
 775         return get_layout_value(layout, "location", -1);
 776 }
 777
 778 void StageInterfaceValidator::visit(VariableDeclaration &var)
 779 {
 780         int location = (var.layout ? get_location(*var.layout) : -1);
 781         if(var.interface=="in" && var.linked_declaration)
 782         {
 783                 const Layout *linked_layout = var.linked_declaration->layout.get();
 784                 int linked_location = (linked_layout ? get_location(*linked_layout) : -1);
 785                 if(linked_location!=location)
 786                 {
 787                         error(var, format("Mismatched location %d for 'in %s'", location, var.name));
 788                         add_info(*var.linked_declaration, format("Linked to 'out %s' with location %d",
 789                                 var.linked_declaration->name, linked_location));
 790                 }
 791                 if(var.type_declaration && var.linked_declaration->type_declaration)
 792                 {
 793                         TypeDeclaration *type = var.type_declaration;
 794                         if(stage->type==Stage::GEOMETRY)
 795                         {
 796                                 if(const BasicTypeDeclaration *basic = dynamic_cast<const BasicTypeDeclaration *>(type))
 797                                         if(basic->kind==BasicTypeDeclaration::ARRAY && basic->base_type)
 798                                                 type = basic->base_type;
 799                         }
 800                         if(!TypeComparer().apply(*type, *var.linked_declaration->type_declaration))
 801                         {
 802                                 error(var, format("Mismatched type '%s' for 'in %s'", type->name, var.name));
 803                                 add_info(*var.linked_declaration, format("Linked to 'out %s' with type '%s'",
 804                                         var.linked_declaration->name, var.linked_declaration->type_declaration->name));
 805                         }
 806                 }
 807         }
 808
 809         if(location>=0 && !var.interface.empty())
 810         {
 811                 map<unsigned, VariableDeclaration *> &used = used_locations[var.interface];
 812
 813                 unsigned loc_count = LocationCounter().apply(var);
 814                 for(unsigned i=0; i<loc_count; ++i)
 815                 {
 816                         auto j = used.find(location+i);
 817                         if(j!=used.end())
 818                         {
 819                                 error(var, format("Overlapping location %d for '%s %s'", location+i, var.interface, var.name));
 820                                 add_info(*j->second, format("Previously used here for '%s %s'", j->second->interface, j->second->name));
 821                         }
 822                         else
 823                                 used[location+i] = &var;
 824                 }
 825         }
 826 }
 827
 828
 829 void GlobalInterfaceValidator::apply(Module &module)
 830 {
 831         for(Stage &s: module.stages)
 832         {
 833                 stage = &s;
 834                 s.content.visit(*this);
 835         }
 836 }
 837
 838 void GlobalInterfaceValidator::check_uniform(const Uniform &uni)
 839 {
 840         auto i = used_names.find(uni.name);
 841         if(i!=used_names.end())
 842         {
 843                 if(uni.location>=0 && i->second->location>=0 && i->second->location!=uni.location)
 844                 {
 845                         error(*uni.node, format("Mismatched location %d for uniform '%s'", uni.location, uni.name));
 846                         add_info(*i->second->node, format("Previously declared here with location %d", i->second->location));
 847                 }
 848                 if(uni.bind_point>=0 && i->second->bind_point>=0 && i->second->bind_point!=uni.bind_point)
 849                 {
 850                         error(*uni.node, format("Mismatched binding %d for uniform '%s'", uni.bind_point, uni.name));
 851                         add_info(*i->second->node, format("Previously declared here with binding %d", i->second->bind_point));
 852                 }
 853                 if(uni.type && i->second->type && !TypeComparer().apply(*uni.type, *i->second->type))
 854                 {
 855                         string type_name = (dynamic_cast<const StructDeclaration *>(uni.type) ?
 856                                 "structure" : format("type '%s'", uni.type->name));
 857                         error(*uni.node, format("Mismatched %s for uniform '%s'", type_name, uni.name));
 858
 859                         string message = "Previously declared here";
 860                         if(!dynamic_cast<const StructDeclaration *>(i->second->type))
 861                                 message += format(" with type '%s'", i->second->type->name);
 862                         add_info(*i->second->node, message);
 863                 }
 864         }
 865         else
 866                 used_names.insert(make_pair(uni.name, &uni));
 867
 868         if(uni.location>=0)
 869         {
 870                 auto j = used_locations.find(uni.location);
 871                 if(j!=used_locations.end())
 872                 {
 873                         if(j->second->name!=uni.name)
 874                         {
 875                                 error(*uni.node, format("Overlapping location %d for '%s'", uni.location, uni.name));
 876                                 add_info(*j->second->node, format("Previously used here for '%s'", j->second->name));
 877                         }
 878                 }
 879                 else
 880                 {
 881                         for(unsigned k=0; k<uni.loc_count; ++k)
 882                                 used_locations.insert(make_pair(uni.location+k, &uni));
 883                 }
 884         }
 885
 886         if(uni.bind_point>=0)
 887         {
 888                 map<unsigned, const Uniform *> &used = used_bindings[uni.desc_set];
 889                 auto j = used.find(uni.bind_point);
 890                 if(j!=used.end())
 891                 {
 892                         if(j->second->name!=uni.name)
 893                         {
 894                                 error(*uni.node, format("Overlapping binding %d for '%s'", uni.bind_point, uni.name));
 895                                 add_info(*j->second->node, format("Previously used here for '%s'", j->second->name));
 896                         }
 897                 }
 898                 else
 899                         used.insert(make_pair(uni.bind_point, &uni));
 900         }
 901 }
 902
 903 void GlobalInterfaceValidator::visit(VariableDeclaration &var)
 904 {
 905         if(var.interface=="uniform")
 906         {
 907                 Uniform uni;
 908                 uni.node = &var;
 909                 uni.type = var.type_declaration;
 910                 uni.name = var.name;
 911                 if(var.layout)
 912                 {
 913                         uni.location = get_layout_value(*var.layout, "location");
 914                         uni.loc_count = LocationCounter().apply(var);
 915                         uni.desc_set = get_layout_value(*var.layout, "set", 0);
 916                         uni.bind_point = get_layout_value(*var.layout, "binding");
 917                 }
 918
 919                 uniforms.push_back(uni);
 920                 check_uniform(uniforms.back());
 921         }
 922 }
 923
 924 void GlobalInterfaceValidator::visit(InterfaceBlock &iface)
 925 {
 926         if(iface.interface=="uniform")
 927         {
 928                 Uniform uni;
 929                 uni.node = &iface;
 930                 uni.type = iface.struct_declaration;
 931                 uni.name = iface.block_name;
 932                 if(iface.layout)
 933                 {
 934                         uni.desc_set = get_layout_value(*iface.layout, "set", 0);
 935                         uni.bind_point = get_layout_value(*iface.layout, "binding");
 936                 }
 937
 938                 uniforms.push_back(uni);
 939                 check_uniform(uniforms.back());
 940         }
 941 }
 942
 943 } // namespace SL
 944 } // namespace GL
 945 } // namespace Msp