2 #include <msp/core/algorithm.h>
3 #include <msp/core/raii.h>
4 #include <msp/strings/format.h>
5 #include <msp/strings/utils.h>
15 void Validator::diagnose(Node &node, Node &provoking_node, Diagnostic::Severity severity, const string &message)
18 diag.severity = severity;
19 diag.source = node.source;
20 diag.line = node.line;
21 diag.provoking_source = provoking_node.source;
22 diag.provoking_line = provoking_node.line;
23 diag.message = message;
24 stage->diagnostics.push_back(diag);
26 last_provoker = &provoking_node;
29 void Validator::add_info(Node &node, const string &message)
32 throw logic_error("Tried to add info without a previous provoker");
33 diagnose(node, *last_provoker, Diagnostic::INFO, message);
37 void DeclarationValidator::apply(Stage &s, const Features &f)
41 s.content.visit(*this);
44 const char *DeclarationValidator::describe_variable(ScopeType scope)
48 case GLOBAL: return "global variable";
49 case STRUCT: return "struct member";
50 case INTERFACE_BLOCK: return "interface block member";
51 case FUNCTION_PARAM: return "function parameter";
52 case FUNCTION: return "local variable";
53 default: return "variable";
57 void DeclarationValidator::visit(Layout &layout)
59 bool push_constant = false;
61 for(const Layout::Qualifier &q: layout.qualifiers)
66 if(q.name=="location")
67 allowed = (variable && scope==GLOBAL);
68 else if(q.name=="binding" || q.name=="set")
72 if(q.name=="set" && features.target_api!=VULKAN)
74 error(layout, "Layout qualifier 'set' not allowed when targeting OpenGL");
80 const TypeDeclaration *base_type = get_ultimate_base_type(variable->type_declaration);
81 bool uniform = (variable->interface=="uniform");
82 allowed = (scope==GLOBAL && uniform && dynamic_cast<const ImageTypeDeclaration *>(base_type));
83 err_descr = (uniform ? "variable of non-opaque type" : "non-uniform variable");
87 allowed = (iface_block->interface=="uniform");
88 err_descr = "non-uniform interface block";
91 else if(q.name=="constant_id")
93 allowed = (variable && scope==GLOBAL);
96 if(!variable->constant)
99 err_descr = "non-constant variable";
103 BasicTypeDeclaration *basic = dynamic_cast<BasicTypeDeclaration *>(variable->type_declaration);
104 if(!basic || basic->kind<BasicTypeDeclaration::BOOL || basic->kind>BasicTypeDeclaration::INT)
107 err_descr = format("variable of type '%s'",
108 (variable->type_declaration ? variable->type_declaration->name : variable->type));
113 else if(q.name=="offset")
114 allowed = (variable && scope==INTERFACE_BLOCK && iface_block->interface=="uniform");
115 else if(q.name=="align")
116 allowed = (scope==INTERFACE_BLOCK && iface_block->interface=="uniform");
117 else if(q.name=="points")
119 allowed = (stage->type==Stage::GEOMETRY && iface_layout && (iface_layout->interface=="in" || iface_layout->interface=="out"));
122 else if(q.name=="lines" || q.name=="lines_adjacency" || q.name=="triangles" || q.name=="triangles_adjacency")
124 allowed = (stage->type==Stage::GEOMETRY && iface_layout && iface_layout->interface=="in");
127 else if(q.name=="line_strip" || q.name=="triangle_strip")
129 allowed = (stage->type==Stage::GEOMETRY && iface_layout && iface_layout->interface=="out");
132 else if(q.name=="invocations")
133 allowed = (stage->type==Stage::GEOMETRY && iface_layout && iface_layout->interface=="in");
134 else if(q.name=="max_vertices")
135 allowed = (stage->type==Stage::GEOMETRY && iface_layout && iface_layout->interface=="out");
136 else if(q.name=="std140" || q.name=="std430")
138 allowed = (iface_block && !variable && iface_block->interface=="uniform");
141 else if(q.name=="column_major" || q.name=="row_major")
143 allowed = (variable && scope==INTERFACE_BLOCK);
146 BasicTypeDeclaration *basic = dynamic_cast<BasicTypeDeclaration *>(variable->type_declaration);
147 while(basic && basic->kind==BasicTypeDeclaration::ARRAY)
148 basic = dynamic_cast<BasicTypeDeclaration *>(basic->base_type);
149 allowed = (basic && basic->kind==BasicTypeDeclaration::MATRIX);
150 err_descr = "non-matrix variable";
153 else if(q.name=="push_constant")
155 push_constant = true;
156 allowed = (iface_block && !variable && iface_block->interface=="uniform");
162 if(err_descr.empty())
165 err_descr = describe_variable(scope);
167 err_descr = "interface block";
168 else if(iface_layout)
169 err_descr = format("interface '%s'", iface_layout->interface);
171 err_descr = "unknown declaration";
173 error(layout, format("Layout qualifier '%s' not allowed on %s", q.name, err_descr));
175 else if(value && !q.has_value)
176 error(layout, format("Layout qualifier '%s' requires a value", q.name));
177 else if(!value && q.has_value)
178 error(layout, format("Layout qualifier '%s' does not allow a value", q.name));
181 if(push_constant && binding)
182 error(layout, "Layout qualifier 'push_constant' not allowed together with 'binding' or 'set'");
185 void DeclarationValidator::visit(InterfaceLayout &layout)
187 SetForScope<InterfaceLayout *> set_layout(iface_layout, &layout);
188 TraversingVisitor::visit(layout);
191 void DeclarationValidator::visit(BasicTypeDeclaration &type)
193 BasicTypeDeclaration *basic_base = dynamic_cast<BasicTypeDeclaration *>(type.base_type);
194 BasicTypeDeclaration::Kind base_kind = (basic_base ? basic_base->kind : BasicTypeDeclaration::VOID);
196 if(type.kind==BasicTypeDeclaration::VECTOR && (base_kind<BasicTypeDeclaration::BOOL || base_kind>BasicTypeDeclaration::FLOAT))
197 error(type, format("Invalid base type '%s' for vector type '%s'", type.base, type.name));
198 else if(type.kind==BasicTypeDeclaration::MATRIX && base_kind!=BasicTypeDeclaration::VECTOR)
199 error(type, format("Invalid base type '%s' for matrix type '%s'", type.base, type.name));
200 else if(type.kind==BasicTypeDeclaration::ARRAY && basic_base && base_kind==BasicTypeDeclaration::VOID)
201 error(type, format("Invalid base type '%s' for array type '%s'", type.base, type.name));
204 void DeclarationValidator::visit(ImageTypeDeclaration &type)
206 BasicTypeDeclaration::Kind base_kind = BasicTypeDeclaration::VOID;
207 if(BasicTypeDeclaration *basic_base = dynamic_cast<BasicTypeDeclaration *>(type.base_type))
208 base_kind = basic_base->kind;
209 if(base_kind!=BasicTypeDeclaration::INT && base_kind!=BasicTypeDeclaration::FLOAT)
210 error(type, format("Invalid base type '%s' for image type '%s'", type.base, type.name));
213 void DeclarationValidator::visit(StructDeclaration &strct)
215 SetForScope<ScopeType> set_scope(scope, (strct.block_name.empty() ? STRUCT : INTERFACE_BLOCK));
216 SetForScope<VariableDeclaration *> set_iface(iface_block, strct.block_declaration);
217 TraversingVisitor::visit(strct);
220 void DeclarationValidator::visit(VariableDeclaration &var)
222 SetForScope<VariableDeclaration *> set_var((var.block_declaration ? iface_block : variable), &var);
224 const char *descr = describe_variable(scope);
228 if(scope!=GLOBAL && scope!=INTERFACE_BLOCK)
229 error(var, format("Layout qualifier not allowed on %s", descr));
231 var.layout->visit(*this);
236 if(scope==STRUCT || scope==INTERFACE_BLOCK)
237 error(var, format("Constant qualifier not allowed on %s", descr));
238 if(!var.init_expression)
239 error(var, "Constant variable must have an initializer");
242 if(!var.interpolation.empty() || !var.sampling.empty())
244 if(var.interface!="in" && stage->type==Stage::VERTEX)
245 error(var, "Interpolation qualifier not allowed on vertex input");
246 else if(var.interface!="out" && stage->type==Stage::FRAGMENT)
247 error(var, "Interpolation qualifier not allowed on fragment output");
248 else if((var.interface!="in" && var.interface!="out") || (scope==FUNCTION_PARAM || scope==FUNCTION))
249 error(var, "Interpolation qualifier not allowed on non-interpolated variable");
252 if(!var.interface.empty())
254 if(iface_block && var.interface!=iface_block->interface)
255 error(var, format("Mismatched interface qualifier '%s' inside '%s' block", var.interface, iface_block->interface));
256 else if(scope==STRUCT || scope==FUNCTION)
257 error(var, format("Interface qualifier not allowed on %s", descr));
258 else if(scope==GLOBAL && var.interface=="uniform" && !var.block_declaration && features.target_api==VULKAN)
260 if(!dynamic_cast<const ImageTypeDeclaration *>(get_ultimate_base_type(var.type_declaration)))
261 error(var, "Interface qualifier 'uniform' not allowed on non-opaque variable in global scope");
265 TypeDeclaration *type = var.type_declaration;
266 BasicTypeDeclaration::Kind kind = BasicTypeDeclaration::ALIAS;
267 while(BasicTypeDeclaration *basic = dynamic_cast<BasicTypeDeclaration *>(type))
270 type = basic->base_type;
272 if(dynamic_cast<ImageTypeDeclaration *>(type))
274 if(scope!=GLOBAL && scope!=FUNCTION_PARAM)
275 error(var, format("Type '%s' not allowed on %s", type->name, descr));
276 else if(scope==GLOBAL && var.interface!="uniform")
277 error(var, format("Type '%s' only allowed with uniform interface", type->name));
279 else if(var.block_declaration)
281 if(stage->type==Stage::VERTEX && var.interface=="in")
282 error(var, "Interface block not allowed on vertex shader input");
283 else if(stage->type==Stage::FRAGMENT && var.interface=="out")
284 error(var, "Interface block not allowed on fragment shader output");
286 else if(kind==BasicTypeDeclaration::VOID)
287 error(var, "Type 'void' not allowed on variable");
288 else if(kind==BasicTypeDeclaration::BOOL && var.source!=BUILTIN_SOURCE)
290 if(scope==INTERFACE_BLOCK)
291 error(var, "Type 'bool' not allowed in an interface block");
292 else if(!var.interface.empty())
293 error(var, "Type 'bool' not allowed on interface variable");
296 if(var.array && !var.array_size)
297 error(var, "Array must have a size");
299 if(var.init_expression)
301 if(scope==GLOBAL && !var.constant)
302 error(var, format("Initializer not allowed on non-constant %s", descr));
303 else if(scope!=GLOBAL && scope!=FUNCTION)
304 error(var, format("Initializer not allowed on %s", descr));
306 var.init_expression->visit(*this);
310 void DeclarationValidator::visit(FunctionDeclaration &func)
312 SetForScope<ScopeType> set_scope(scope, FUNCTION_PARAM);
313 for(const RefPtr<VariableDeclaration> &p: func.parameters)
316 func.body.visit(*this);
320 void IdentifierValidator::multiple_definition(const string &name, Statement &statement, Statement &previous)
322 error(statement, format("Multiple definition of %s", name));
323 add_info(previous, "Previous definition is here");
326 Statement *IdentifierValidator::find_definition(const string &name)
328 BlockDeclarationMap *decls = &declarations[current_block];
329 auto i = decls->find(name);
330 if(i==decls->end() && anonymous_block)
332 decls = &declarations[current_block->parent];
333 i = decls->find(name);
335 return (i!=decls->end() ? i->second : 0);
338 void IdentifierValidator::check_definition(const string &name, Statement &statement)
340 if(Statement *previous = find_definition(name))
341 multiple_definition(format("'%s'", name), statement, *previous);
343 record_definition(name, statement);
346 void IdentifierValidator::record_definition(const string &name, Statement &statement)
348 declarations[current_block].insert(make_pair(name, &statement));
350 declarations[current_block->parent].insert(make_pair(name, &statement));
353 void IdentifierValidator::visit(TypeDeclaration &type)
355 if(type.source!=INTERNAL_SOURCE)
356 check_definition(type.name, type);
359 void IdentifierValidator::visit(StructDeclaration &strct)
361 if(strct.block_name.empty())
362 check_definition(strct.name, strct);
363 TraversingVisitor::visit(strct);
366 void IdentifierValidator::visit(VariableDeclaration &var)
368 if(var.block_declaration)
370 string key = format("%s %s", var.interface, var.block_declaration->block_name);
371 auto i = interface_blocks.find(key);
372 if(i!=interface_blocks.end())
373 multiple_definition(format("interface block '%s %s'", var.interface, var.block_declaration->block_name), var, *i->second);
375 interface_blocks.insert(make_pair(key, &var));
377 if(Statement *previous = find_definition(var.block_declaration->block_name))
379 const VariableDeclaration *prev_var = dynamic_cast<const VariableDeclaration *>(previous);
380 if(!prev_var || !prev_var->block_declaration)
381 multiple_definition(format("'%s'", var.block_declaration->block_name), var, *previous);
384 record_definition(var.block_declaration->block_name, var);
386 if(var.name.find(' ')!=string::npos)
388 // Inject anonymous interface block members into the global scope
389 for(const auto &kvp: var.block_declaration->members.variables)
390 check_definition(kvp.first, *kvp.second);
394 if(var.name.find(' ')==string::npos)
395 check_definition(var.name, var);
397 TraversingVisitor::visit(var);
400 void IdentifierValidator::visit(FunctionDeclaration &func)
402 string key = func.name+func.signature;
403 auto i = overloaded_functions.find(key);
404 if(i==overloaded_functions.end())
405 overloaded_functions.insert(make_pair(key, &func));
406 else if(func.return_type_declaration && i->second->return_type_declaration!=func.return_type_declaration)
408 error(func, format("Conflicting return type '%s' for function '%s'", func.return_type_declaration->name, func.name));
409 if(i->second->return_type_declaration)
410 add_info(*i->second, format("Previously declared as returning '%s'", i->second->return_type_declaration->name));
413 if(Statement *previous = find_definition(func.name))
415 if(!dynamic_cast<FunctionDeclaration *>(previous))
416 multiple_definition(format("'%s'", func.name), func, *previous);
419 record_definition(func.name, func);
421 if(func.definition==&func)
422 check_definition(func.name+func.signature, func);
424 TraversingVisitor::visit(func);
428 void ReferenceValidator::visit(BasicTypeDeclaration &type)
430 if(!type.base.empty() && !type.base_type)
431 error(type, format("Use of undeclared type '%s'", type.base));
434 void ReferenceValidator::visit(ImageTypeDeclaration &type)
436 if(!type.base.empty() && !type.base_type)
437 error(type, format("Use of undeclared type '%s'", type.base));
440 void ReferenceValidator::visit(VariableReference &var)
443 error(var, format("Use of undeclared variable '%s'", var.name));
444 else if(stage->type!=Stage::VERTEX && var.declaration->interface=="in" && var.name.compare(0, 3, "gl_") && !var.declaration->linked_declaration)
445 error(var, format("Use of unlinked input %s '%s'", (var.declaration->block_declaration ? "block" : "variable"), var.name));
448 void ReferenceValidator::visit(MemberAccess &memacc)
450 if(memacc.left->type && !memacc.declaration)
451 error(memacc, format("Use of undeclared member '%s'", memacc.member));
452 TraversingVisitor::visit(memacc);
455 void ReferenceValidator::visit(FunctionCall &call)
457 if((!call.constructor && !call.declaration) || (call.constructor && !call.type))
459 bool have_declaration = call.constructor;
460 if(!call.constructor)
462 auto i = stage->functions.lower_bound(call.name);
463 have_declaration = (i!=stage->functions.end() && i->second->name==call.name);
468 bool valid_types = true;
470 for(auto j=call.arguments.begin(); (valid_types && j!=call.arguments.end()); ++j)
473 append(signature, ", ", (*j)->type->name);
479 error(call, format("No matching %s found for '%s(%s)'", (call.constructor ? "constructor" : "overload"), call.name, signature));
482 error(call, format("Call to undeclared function '%s'", call.name));
484 TraversingVisitor::visit(call);
487 void ReferenceValidator::visit(VariableDeclaration &var)
489 if(!var.type_declaration)
490 error(var, format("Use of undeclared type '%s'", var.type));
491 TraversingVisitor::visit(var);
494 void ReferenceValidator::visit(FunctionDeclaration &func)
496 if(!func.return_type_declaration)
497 error(func, format("Use of undeclared type '%s'", func.return_type));
498 TraversingVisitor::visit(func);
502 void ExpressionValidator::visit(VariableReference &var)
504 if(var.declaration && constant_expression)
506 if(!var.declaration->constant)
508 const char *kind = (var.declaration->block_declaration ? "interface block" : "non-constant variable");
509 error(var, format("Reference to %s '%s' in a constant expression", kind, var.name));
511 else if(var.declaration->layout && constant_expression==FIXED_CONSTANT)
513 if(has_layout_qualifier(var.declaration->layout.get(), "constant_id"))
514 error(var, format("Reference to specialization constant '%s' in a fixed constant expression", var.name));
519 void ExpressionValidator::visit(Swizzle &swizzle)
522 if(BasicTypeDeclaration *basic = dynamic_cast<BasicTypeDeclaration *>(swizzle.left->type))
524 if(basic->kind==BasicTypeDeclaration::INT || basic->kind==BasicTypeDeclaration::FLOAT)
526 else if(basic->kind==BasicTypeDeclaration::VECTOR)
532 static const char component_names[] = { 'x', 'y', 'z', 'w', 'r', 'g', 'b', 'a', 's', 't', 'p', 'q' };
534 for(unsigned i=0; i<swizzle.count; ++i)
536 unsigned component_flavour = (std::find(component_names, component_names+12, swizzle.component_group[i])-component_names)/4;
538 flavour = component_flavour;
539 else if(flavour>=0 && component_flavour!=static_cast<unsigned>(flavour))
541 error(swizzle, format("Flavour of swizzle component '%c' is inconsistent with '%c'",
542 swizzle.component_group[i], swizzle.component_group[0]));
546 if(swizzle.components[i]>=size)
547 error(swizzle, format("Access to component '%c' which is not present in '%s'",
548 swizzle.component_group[i], swizzle.left->type->name));
551 else if(swizzle.left->type)
552 error(swizzle, format("Swizzle applied to '%s' which is neither a scalar nor a vector", swizzle.left->type->name));
554 TraversingVisitor::visit(swizzle);
557 void ExpressionValidator::visit(UnaryExpression &unary)
559 if(unary.expression->type)
562 error(unary, format("No matching operator '%s' found for '%s'", unary.oper->token, unary.expression->type->name));
563 else if(unary.oper->token[1]=='+' || unary.oper->token[1]=='-')
565 if(constant_expression)
566 error(unary, format("Use of '%s' in a constant expression", unary.oper->token));
567 else if(!unary.expression->lvalue)
568 error(unary, format("Operand of '%s' is not an lvalue", unary.oper->token));
571 TraversingVisitor::visit(unary);
574 void ExpressionValidator::visit(BinaryExpression &binary)
576 if(!binary.type && binary.left->type && binary.right->type)
578 if(binary.oper->token[0]=='[')
579 error(binary, format("Can't index element of '%s' with '%s'",
580 binary.left->type->name, binary.right->type->name));
582 error(binary, format("No matching operator '%s' found for '%s' and '%s'",
583 binary.oper->token, binary.left->type->name, binary.right->type->name));
585 TraversingVisitor::visit(binary);
588 void ExpressionValidator::visit(Assignment &assign)
590 if(assign.left->type)
592 if(constant_expression)
593 error(assign, "Assignment in constant expression");
594 else if(!assign.left->lvalue)
595 error(assign, "Target of assignment is not an lvalue");
596 if(assign.right->type)
598 if(assign.oper->token[0]!='=')
601 error(assign, format("No matching operator '%s' found for '%s' and '%s'",
602 string(assign.oper->token, strlen(assign.oper->token)-1), assign.left->type->name, assign.right->type->name));
604 else if(assign.left->type!=assign.right->type)
605 error(assign, format("Assignment to variable of type '%s' from expression of incompatible type '%s'",
606 assign.left->type->name, assign.right->type->name));
609 TraversingVisitor::visit(assign);
612 void ExpressionValidator::visit(TernaryExpression &ternary)
614 if(ternary.condition->type)
616 BasicTypeDeclaration *basic_cond = dynamic_cast<BasicTypeDeclaration *>(ternary.condition->type);
617 if(!basic_cond || basic_cond->kind!=BasicTypeDeclaration::BOOL)
618 error(ternary, "Ternary operator condition is not a boolean");
619 else if(!ternary.type && ternary.true_expr->type && ternary.false_expr->type)
620 error(ternary, format("Ternary operator has incompatible types '%s' and '%s'",
621 ternary.true_expr->type->name, ternary.false_expr->type->name));
623 TraversingVisitor::visit(ternary);
626 void ExpressionValidator::visit(StructDeclaration &strct)
628 SetFlag set_struct(in_struct);
629 TraversingVisitor::visit(strct);
632 void ExpressionValidator::visit(VariableDeclaration &var)
634 if(var.init_expression && var.init_expression->type && var.type_declaration && var.init_expression->type!=var.type_declaration)
635 error(var, format("Initializing a variable of type '%s' with an expression of incompatible type '%s'",
636 var.type_declaration->name, var.init_expression->type->name));
639 var.layout->visit(*this);
640 if(var.init_expression)
642 ConstantKind const_kind = (!var.constant ? NOT_CONSTANT :
643 has_layout_qualifier(var.layout.get(), "constant_id") ? FIXED_CONSTANT : SPEC_CONSTANT);
645 SetForScope<ConstantKind> set_const(constant_expression, const_kind);
646 TraversingVisitor::visit(var.init_expression);
650 SetForScope<ConstantKind> set_const(constant_expression, (in_struct || !var.interface.empty() ? FIXED_CONSTANT : SPEC_CONSTANT));
651 TraversingVisitor::visit(var.array_size);
655 void ExpressionValidator::visit(FunctionDeclaration &func)
657 SetForScope<FunctionDeclaration *> set_func(current_function, &func);
658 TraversingVisitor::visit(func);
661 void ExpressionValidator::visit(Conditional &cond)
663 if(cond.condition->type)
665 BasicTypeDeclaration *basic_cond = dynamic_cast<BasicTypeDeclaration *>(cond.condition->type);
666 if(!basic_cond || basic_cond->kind!=BasicTypeDeclaration::BOOL)
667 error(cond, "Condition is not a boolean");
669 TraversingVisitor::visit(cond);
672 void ExpressionValidator::visit(Iteration &iter)
674 if(iter.condition->type)
676 BasicTypeDeclaration *basic_cond = dynamic_cast<BasicTypeDeclaration *>(iter.condition->type);
677 if(!basic_cond || basic_cond->kind!=BasicTypeDeclaration::BOOL)
678 error(iter, "Loop condition is not a boolean");
680 TraversingVisitor::visit(iter);
683 void ExpressionValidator::visit(Return &ret)
685 if(current_function && current_function->return_type_declaration)
687 TypeDeclaration *return_type = current_function->return_type_declaration;
688 BasicTypeDeclaration *basic_return = dynamic_cast<BasicTypeDeclaration *>(return_type);
691 if(ret.expression->type && ret.expression->type!=return_type)
692 error(ret, format("Return expression type '%s' is incompatible with declared return type '%s'",
693 ret.expression->type->name, return_type->name));
695 else if(!basic_return || basic_return->kind!=BasicTypeDeclaration::VOID)
696 error(ret, "Return statement without an expression in a function not returning 'void'");
699 TraversingVisitor::visit(ret);
703 void FlowControlValidator::visit(Block &block)
705 for(const RefPtr<Statement> &s: block.body)
709 diagnose(*s, Diagnostic::WARN, "Unreachable code detected");
716 void FlowControlValidator::visit(FunctionDeclaration &func)
718 func.body.visit(*this);
720 if(func.definition==&func && func.return_type_declaration)
722 const BasicTypeDeclaration *basic_ret = dynamic_cast<const BasicTypeDeclaration *>(func.return_type_declaration);
723 if(reachable && (!basic_ret || basic_ret->kind!=BasicTypeDeclaration::VOID))
724 error(func, "Missing return statement at the end of a function not returning 'void'");
729 void FlowControlValidator::visit(Conditional &cond)
731 cond.body.visit(*this);
732 bool reachable_if_true = reachable;
734 cond.else_body.visit(*this);
735 reachable |= reachable_if_true;
738 void FlowControlValidator::visit(Iteration &iter)
740 iter.body.visit(*this);
745 void StageInterfaceValidator::visit(VariableDeclaration &var)
747 int location = get_layout_value(var.layout.get(), "location");
748 if(var.interface=="in" && var.linked_declaration)
750 const Layout *linked_layout = var.linked_declaration->layout.get();
751 int linked_location = get_layout_value(linked_layout, "location");
752 if(linked_location!=location)
754 error(var, format("Mismatched location %d for 'in %s'", location, var.name));
755 add_info(*var.linked_declaration, format("Linked to 'out %s' with location %d",
756 var.linked_declaration->name, linked_location));
758 if(var.type_declaration && var.linked_declaration->type_declaration)
760 TypeDeclaration *type = var.type_declaration;
761 if(stage->type==Stage::GEOMETRY)
763 if(const BasicTypeDeclaration *basic = dynamic_cast<const BasicTypeDeclaration *>(type))
764 if(basic->kind==BasicTypeDeclaration::ARRAY && basic->base_type)
765 type = basic->base_type;
767 if(!TypeComparer().apply(*type, *var.linked_declaration->type_declaration))
769 error(var, format("Mismatched type '%s' for 'in %s'", type->name, var.name));
770 add_info(*var.linked_declaration, format("Linked to 'out %s' with type '%s'",
771 var.linked_declaration->name, var.linked_declaration->type_declaration->name));
776 if(location>=0 && !var.interface.empty())
778 map<unsigned, VariableDeclaration *> &used = used_locations[var.interface];
780 unsigned loc_count = LocationCounter().apply(var);
781 for(unsigned i=0; i<loc_count; ++i)
783 auto j = used.find(location+i);
786 error(var, format("Overlapping location %d for '%s %s'", location+i, var.interface, var.name));
787 add_info(*j->second, format("Previously used here for '%s %s'", j->second->interface, j->second->name));
790 used[location+i] = &var;
796 void GlobalInterfaceValidator::apply(Module &module)
798 for(Stage &s: module.stages)
801 s.content.visit(*this);
805 void GlobalInterfaceValidator::check_uniform(const Uniform &uni)
807 auto i = used_names.find(uni.name);
808 if(i!=used_names.end())
810 if(uni.location>=0 && i->second->location>=0 && i->second->location!=uni.location)
812 error(*uni.node, format("Mismatched location %d for uniform '%s'", uni.location, uni.name));
813 add_info(*i->second->node, format("Previously declared here with location %d", i->second->location));
815 if(i->second->desc_set!=uni.desc_set)
817 error(*uni.node, format("Mismatched descriptor set %d for uniform '%s'", uni.desc_set, uni.name));
818 add_info(*i->second->node, format("Previously declared here with descriptor set %d", i->second->desc_set));
820 if(uni.bind_point>=0 && i->second->bind_point>=0 && i->second->bind_point!=uni.bind_point)
822 error(*uni.node, format("Mismatched binding %d for uniform '%s'", uni.bind_point, uni.name));
823 add_info(*i->second->node, format("Previously declared here with binding %d", i->second->bind_point));
825 if(uni.type && i->second->type && !TypeComparer().apply(*uni.type, *i->second->type))
827 string type_name = (dynamic_cast<const StructDeclaration *>(uni.type) ?
828 "structure" : format("type '%s'", uni.type->name));
829 error(*uni.node, format("Mismatched %s for uniform '%s'", type_name, uni.name));
831 string message = "Previously declared here";
832 if(!dynamic_cast<const StructDeclaration *>(i->second->type))
833 message += format(" with type '%s'", i->second->type->name);
834 add_info(*i->second->node, message);
838 used_names.insert(make_pair(uni.name, &uni));
842 auto j = used_locations.find(uni.location);
843 if(j!=used_locations.end())
845 if(j->second->name!=uni.name)
847 error(*uni.node, format("Overlapping location %d for '%s'", uni.location, uni.name));
848 add_info(*j->second->node, format("Previously used here for '%s'", j->second->name));
853 for(unsigned k=0; k<uni.loc_count; ++k)
854 used_locations.insert(make_pair(uni.location+k, &uni));
858 if(uni.bind_point>=0)
860 map<unsigned, const Uniform *> &used = used_bindings[uni.desc_set];
861 auto j = used.find(uni.bind_point);
864 if(j->second->name!=uni.name)
866 error(*uni.node, format("Overlapping binding %d for '%s'", uni.bind_point, uni.name));
867 add_info(*j->second->node, format("Previously used here for '%s'", j->second->name));
871 used.insert(make_pair(uni.bind_point, &uni));
875 void GlobalInterfaceValidator::visit(VariableDeclaration &var)
877 if(var.interface=="uniform")
881 uni.type = var.type_declaration;
882 uni.name = (var.block_declaration ? var.block_declaration->block_name : var.name);
885 if(!var.block_declaration)
887 uni.location = get_layout_value(var.layout.get(), "location");
888 uni.loc_count = LocationCounter().apply(var);
890 uni.desc_set = get_layout_value(var.layout.get(), "set", 0);
891 uni.bind_point = get_layout_value(var.layout.get(), "binding");
894 uniforms.push_back(uni);
895 check_uniform(uniforms.back());