]> git.tdb.fi Git - libs/gl.git/blob - source/glsl/validate.cpp
Check the flat qualifier from the correct member
[libs/gl.git] / source / glsl / validate.cpp
1 #include <cstring>
2 #include <msp/core/algorithm.h>
3 #include <msp/core/raii.h>
4 #include <msp/strings/format.h>
5 #include <msp/strings/utils.h>
6 #include "reflect.h"
7 #include "validate.h"
8
9 using namespace std;
10
11 namespace Msp {
12 namespace GL {
13 namespace SL {
14
15 void Validator::diagnose(Node &node, Node &provoking_node, Diagnostic::Severity severity, const string &message)
16 {
17         Diagnostic diag;
18         diag.severity = severity;
19         diag.source = node.source;
20         diag.line = node.line;
21         diag.provoking_source = provoking_node.source;
22         diag.provoking_line = provoking_node.line;
23         diag.message = message;
24         stage->diagnostics.push_back(diag);
25
26         last_provoker = &provoking_node;
27 }
28
29 void Validator::add_info(Node &node, const string &message)
30 {
31         if(!last_provoker)
32                 throw logic_error("Tried to add info without a previous provoker");
33         diagnose(node, *last_provoker, Diagnostic::INFO, message);
34 }
35
36
37 void DeclarationValidator::apply(Stage &s, const Features &f)
38 {
39         stage = &s;
40         features = f;
41         s.content.visit(*this);
42 }
43
44 const char *DeclarationValidator::describe_variable(ScopeType scope)
45 {
46         switch(scope)
47         {
48         case GLOBAL: return "global variable";
49         case STRUCT: return "struct member";
50         case INTERFACE_BLOCK: return "interface block member";
51         case FUNCTION_PARAM: return "function parameter";
52         case FUNCTION: return "local variable";
53         default: return "variable";
54         }
55 }
56
57 void DeclarationValidator::visit(Layout &layout)
58 {
59         bool push_constant = false;
60         bool binding = false;
61         for(const Layout::Qualifier &q: layout.qualifiers)
62         {
63                 bool allowed = false;
64                 string err_descr;
65                 bool value = true;
66                 if(q.name=="location")
67                         allowed = (variable && scope==GLOBAL);
68                 else if(q.name=="binding" || q.name=="set")
69                 {
70                         binding = true;
71
72                         if(q.name=="set" && features.target_api!=VULKAN)
73                         {
74                                 error(layout, "Layout qualifier 'set' not allowed when targeting OpenGL");
75                                 continue;
76                         }
77
78                         if(variable)
79                         {
80                                 const TypeDeclaration *base_type = get_ultimate_base_type(variable->type_declaration);
81                                 bool uniform = (variable->interface=="uniform");
82                                 allowed = (scope==GLOBAL && uniform && dynamic_cast<const ImageTypeDeclaration *>(base_type));
83                                 err_descr = (uniform ? "variable of non-opaque type" : "non-uniform variable");
84                         }
85                         else if(iface_block)
86                         {
87                                 allowed = (iface_block->interface=="uniform");
88                                 err_descr = "non-uniform interface block";
89                         }
90                 }
91                 else if(q.name=="constant_id")
92                 {
93                         allowed = (variable && scope==GLOBAL);
94                         if(allowed)
95                         {
96                                 if(!variable->constant)
97                                 {
98                                         allowed = false;
99                                         err_descr = "non-constant variable";
100                                 }
101                                 else
102                                 {
103                                         BasicTypeDeclaration *basic = dynamic_cast<BasicTypeDeclaration *>(variable->type_declaration);
104                                         if(!basic || basic->kind<BasicTypeDeclaration::BOOL || basic->kind>BasicTypeDeclaration::INT)
105                                         {
106                                                 allowed = false;
107                                                 err_descr = format("variable of type '%s'",
108                                                         (variable->type_declaration ? variable->type_declaration->name : variable->type));
109                                         }
110                                 }
111                         }
112                 }
113                 else if(q.name=="offset")
114                         allowed = (variable && scope==INTERFACE_BLOCK && iface_block->interface=="uniform");
115                 else if(q.name=="align")
116                         allowed = (scope==INTERFACE_BLOCK && iface_block->interface=="uniform");
117                 else if(q.name=="points")
118                 {
119                         allowed = (stage->type==Stage::GEOMETRY && iface_layout && (iface_layout->interface=="in" || iface_layout->interface=="out"));
120                         value = false;
121                 }
122                 else if(q.name=="lines" || q.name=="lines_adjacency" || q.name=="triangles" || q.name=="triangles_adjacency")
123                 {
124                         allowed = (stage->type==Stage::GEOMETRY && iface_layout && iface_layout->interface=="in");
125                         value = false;
126                 }
127                 else if(q.name=="line_strip" || q.name=="triangle_strip")
128                 {
129                         allowed = (stage->type==Stage::GEOMETRY && iface_layout && iface_layout->interface=="out");
130                         value = false;
131                 }
132                 else if(q.name=="invocations")
133                         allowed = (stage->type==Stage::GEOMETRY && iface_layout && iface_layout->interface=="in");
134                 else if(q.name=="max_vertices")
135                         allowed = (stage->type==Stage::GEOMETRY && iface_layout && iface_layout->interface=="out");
136                 else if(q.name=="std140" || q.name=="std430")
137                 {
138                         allowed = (iface_block && !variable && iface_block->interface=="uniform");
139                         value = false;
140                 }
141                 else if(q.name=="column_major" || q.name=="row_major")
142                 {
143                         allowed = (variable && scope==INTERFACE_BLOCK);
144                         if(allowed)
145                         {
146                                 BasicTypeDeclaration *basic = dynamic_cast<BasicTypeDeclaration *>(variable->type_declaration);
147                                 while(basic && basic->kind==BasicTypeDeclaration::ARRAY)
148                                         basic = dynamic_cast<BasicTypeDeclaration *>(basic->base_type);
149                                 allowed = (basic && basic->kind==BasicTypeDeclaration::MATRIX);
150                                 err_descr = "non-matrix variable";
151                         }
152                 }
153                 else if(q.name=="push_constant")
154                 {
155                         push_constant = true;
156                         allowed = (iface_block && !variable && iface_block->interface=="uniform");
157                         value = false;
158                 }
159
160                 if(!allowed)
161                 {
162                         if(err_descr.empty())
163                         {
164                                 if(variable)
165                                         err_descr = describe_variable(scope);
166                                 else if(iface_block)
167                                         err_descr = "interface block";
168                                 else if(iface_layout)
169                                         err_descr = format("interface '%s'", iface_layout->interface);
170                                 else
171                                         err_descr = "unknown declaration";
172                         }
173                         error(layout, format("Layout qualifier '%s' not allowed on %s", q.name, err_descr));
174                 }
175                 else if(value && !q.has_value)
176                         error(layout, format("Layout qualifier '%s' requires a value", q.name));
177                 else if(!value && q.has_value)
178                         error(layout, format("Layout qualifier '%s' does not allow a value", q.name));
179         }
180
181         if(push_constant && binding)
182                 error(layout, "Layout qualifier 'push_constant' not allowed together with 'binding' or 'set'");
183 }
184
185 void DeclarationValidator::visit(InterfaceLayout &layout)
186 {
187         SetForScope<InterfaceLayout *> set_layout(iface_layout, &layout);
188         TraversingVisitor::visit(layout);
189 }
190
191 void DeclarationValidator::visit(BasicTypeDeclaration &type)
192 {
193         BasicTypeDeclaration *basic_base = dynamic_cast<BasicTypeDeclaration *>(type.base_type);
194         BasicTypeDeclaration::Kind base_kind = (basic_base ? basic_base->kind : BasicTypeDeclaration::VOID);
195
196         if(type.kind==BasicTypeDeclaration::VECTOR && (base_kind<BasicTypeDeclaration::BOOL || base_kind>BasicTypeDeclaration::FLOAT))
197                 error(type, format("Invalid base type '%s' for vector type '%s'", type.base, type.name));
198         else if(type.kind==BasicTypeDeclaration::MATRIX && base_kind!=BasicTypeDeclaration::VECTOR)
199                 error(type, format("Invalid base type '%s' for matrix type '%s'", type.base, type.name));
200         else if(type.kind==BasicTypeDeclaration::ARRAY && basic_base && base_kind==BasicTypeDeclaration::VOID)
201                 error(type, format("Invalid base type '%s' for array type '%s'", type.base, type.name));
202 }
203
204 void DeclarationValidator::visit(ImageTypeDeclaration &type)
205 {
206         BasicTypeDeclaration::Kind base_kind = BasicTypeDeclaration::VOID;
207         if(BasicTypeDeclaration *basic_base = dynamic_cast<BasicTypeDeclaration *>(type.base_type))
208                 base_kind = basic_base->kind;
209         if(base_kind!=BasicTypeDeclaration::INT && base_kind!=BasicTypeDeclaration::FLOAT)
210                 error(type, format("Invalid base type '%s' for image type '%s'", type.base, type.name));
211 }
212
213 void DeclarationValidator::visit(StructDeclaration &strct)
214 {
215         SetForScope<ScopeType> set_scope(scope, (strct.block_name.empty() ? STRUCT : INTERFACE_BLOCK));
216         SetForScope<VariableDeclaration *> set_iface(iface_block, strct.block_declaration);
217         TraversingVisitor::visit(strct);
218 }
219
220 void DeclarationValidator::visit(VariableDeclaration &var)
221 {
222         SetForScope<VariableDeclaration *> set_var((var.block_declaration ? iface_block : variable), &var);
223
224         const char *descr = describe_variable(scope);
225
226         if(var.layout)
227         {
228                 if(scope!=GLOBAL && scope!=INTERFACE_BLOCK)
229                         error(var, format("Layout qualifier not allowed on %s", descr));
230                 else
231                         var.layout->visit(*this);
232         }
233
234         if(var.constant)
235         {
236                 if(scope==STRUCT || scope==INTERFACE_BLOCK)
237                         error(var, format("Constant qualifier not allowed on %s", descr));
238                 if(!var.init_expression)
239                         error(var, "Constant variable must have an initializer");
240         }
241
242         if(!var.interpolation.empty() || !var.sampling.empty())
243         {
244                 if(var.interface!="in" && stage->type==Stage::VERTEX)
245                         error(var, "Interpolation qualifier not allowed on vertex input");
246                 else if(var.interface!="out" && stage->type==Stage::FRAGMENT)
247                         error(var, "Interpolation qualifier not allowed on fragment output");
248                 else if((var.interface!="in" && var.interface!="out") || (scope==FUNCTION_PARAM || scope==FUNCTION))
249                         error(var, "Interpolation qualifier not allowed on non-interpolated variable");
250         }
251
252         if(!var.interface.empty())
253         {
254                 if(iface_block && var.interface!=iface_block->interface)
255                         error(var, format("Mismatched interface qualifier '%s' inside '%s' block", var.interface, iface_block->interface));
256                 else if(scope==STRUCT || scope==FUNCTION)
257                         error(var, format("Interface qualifier not allowed on %s", descr));
258                 else if(scope==GLOBAL && var.interface=="uniform" && !var.block_declaration && features.target_api==VULKAN)
259                 {
260                         if(!dynamic_cast<const ImageTypeDeclaration *>(get_ultimate_base_type(var.type_declaration)))
261                                 error(var, "Interface qualifier 'uniform' not allowed on non-opaque variable in global scope");
262                 }
263         }
264
265         TypeDeclaration *type = var.type_declaration;
266         BasicTypeDeclaration::Kind kind = BasicTypeDeclaration::ALIAS;
267         while(BasicTypeDeclaration *basic = dynamic_cast<BasicTypeDeclaration *>(type))
268         {
269                 kind = basic->kind;
270                 type = basic->base_type;
271         }
272         if(dynamic_cast<ImageTypeDeclaration *>(type))
273         {
274                 if(scope!=GLOBAL && scope!=FUNCTION_PARAM)
275                         error(var, format("Type '%s' not allowed on %s", type->name, descr));
276                 else if(scope==GLOBAL && var.interface!="uniform")
277                         error(var, format("Type '%s' only allowed with uniform interface", type->name));
278         }
279         else if(var.block_declaration)
280         {
281                 if(stage->type==Stage::VERTEX && var.interface=="in")
282                         error(var, "Interface block not allowed on vertex shader input");
283                 else if(stage->type==Stage::FRAGMENT && var.interface=="out")
284                         error(var, "Interface block not allowed on fragment shader output");
285         }
286         else if(kind==BasicTypeDeclaration::VOID)
287                 error(var, "Type 'void' not allowed on variable");
288         else if(kind==BasicTypeDeclaration::BOOL && var.source!=BUILTIN_SOURCE)
289         {
290                 if(scope==INTERFACE_BLOCK)
291                         error(var, "Type 'bool' not allowed in an interface block");
292                 else if(!var.interface.empty())
293                         error(var, "Type 'bool' not allowed on interface variable");
294         }
295
296         if(var.array && !var.array_size)
297                 error(var, "Array must have a size");
298
299         if(var.init_expression)
300         {
301                 if(scope==GLOBAL && !var.constant)
302                         error(var, format("Initializer not allowed on non-constant %s", descr));
303                 else if(scope!=GLOBAL && scope!=FUNCTION)
304                         error(var, format("Initializer not allowed on %s", descr));
305                 else
306                         var.init_expression->visit(*this);
307         }
308 }
309
310 void DeclarationValidator::visit(FunctionDeclaration &func)
311 {
312         SetForScope<ScopeType> set_scope(scope, FUNCTION_PARAM);
313         for(const RefPtr<VariableDeclaration> &p: func.parameters)
314                 p->visit(*this);
315         scope = FUNCTION;
316         func.body.visit(*this);
317 }
318
319
320 void IdentifierValidator::multiple_definition(const string &name, Statement &statement, Statement &previous)
321 {
322         error(statement, format("Multiple definition of %s", name));
323         add_info(previous, "Previous definition is here");
324 }
325
326 Statement *IdentifierValidator::find_definition(const string &name)
327 {
328         BlockDeclarationMap *decls = &declarations[current_block];
329         auto i = decls->find(name);
330         if(i==decls->end() && anonymous_block)
331         {
332                 decls = &declarations[current_block->parent];
333                 i = decls->find(name);
334         }
335         return (i!=decls->end() ? i->second : 0);
336 }
337
338 void IdentifierValidator::check_definition(const string &name, Statement &statement)
339 {
340         if(Statement *previous = find_definition(name))
341                 multiple_definition(format("'%s'", name), statement, *previous);
342         else
343                 record_definition(name, statement);
344 }
345
346 void IdentifierValidator::record_definition(const string &name, Statement &statement)
347 {
348         declarations[current_block].insert(make_pair(name, &statement));
349         if(anonymous_block)
350                 declarations[current_block->parent].insert(make_pair(name, &statement));
351 }
352
353 void IdentifierValidator::visit(TypeDeclaration &type)
354 {
355         if(type.source!=INTERNAL_SOURCE)
356                 check_definition(type.name, type);
357 }
358
359 void IdentifierValidator::visit(StructDeclaration &strct)
360 {
361         if(strct.block_name.empty())
362                 check_definition(strct.name, strct);
363         TraversingVisitor::visit(strct);
364 }
365
366 void IdentifierValidator::visit(VariableDeclaration &var)
367 {
368         if(var.block_declaration)
369         {
370                 string key = format("%s %s", var.interface, var.block_declaration->block_name);
371                 auto i = interface_blocks.find(key);
372                 if(i!=interface_blocks.end())
373                         multiple_definition(format("interface block '%s %s'", var.interface, var.block_declaration->block_name), var, *i->second);
374                 else
375                         interface_blocks.insert(make_pair(key, &var));
376
377                 if(Statement *previous = find_definition(var.block_declaration->block_name))
378                 {
379                         const VariableDeclaration *prev_var = dynamic_cast<const VariableDeclaration *>(previous);
380                         if(!prev_var || !prev_var->block_declaration)
381                                 multiple_definition(format("'%s'", var.block_declaration->block_name), var, *previous);
382                 }
383                 else
384                         record_definition(var.block_declaration->block_name, var);
385
386                 if(var.name.find(' ')!=string::npos)
387                 {
388                         // Inject anonymous interface block members into the global scope
389                         for(const auto &kvp: var.block_declaration->members.variables)
390                                 check_definition(kvp.first, *kvp.second);
391                 }
392         }
393
394         if(var.name.find(' ')==string::npos)
395                 check_definition(var.name, var);
396
397         TraversingVisitor::visit(var);
398 }
399
400 void IdentifierValidator::visit(FunctionDeclaration &func)
401 {
402         string key = func.name+func.signature;
403         auto i = overloaded_functions.find(key);
404         if(i==overloaded_functions.end())
405                 overloaded_functions.insert(make_pair(key, &func));
406         else if(func.return_type_declaration && i->second->return_type_declaration!=func.return_type_declaration)
407         {
408                 error(func, format("Conflicting return type '%s' for function '%s'", func.return_type_declaration->name, func.name));
409                 if(i->second->return_type_declaration)
410                         add_info(*i->second, format("Previously declared as returning '%s'", i->second->return_type_declaration->name));
411         }
412
413         if(Statement *previous = find_definition(func.name))
414         {
415                 if(!dynamic_cast<FunctionDeclaration *>(previous))
416                         multiple_definition(format("'%s'", func.name), func, *previous);
417         }
418         else
419                 record_definition(func.name, func);
420
421         if(func.definition==&func)
422                 check_definition(func.name+func.signature, func);
423
424         TraversingVisitor::visit(func);
425 }
426
427
428 void ReferenceValidator::visit(BasicTypeDeclaration &type)
429 {
430         if(!type.base.empty() && !type.base_type)
431                 error(type, format("Use of undeclared type '%s'", type.base));
432 }
433
434 void ReferenceValidator::visit(ImageTypeDeclaration &type)
435 {
436         if(!type.base.empty() && !type.base_type)
437                 error(type, format("Use of undeclared type '%s'", type.base));
438 }
439
440 void ReferenceValidator::visit(VariableReference &var)
441 {
442         if(!var.declaration)
443                 error(var, format("Use of undeclared variable '%s'", var.name));
444         else if(stage->type!=Stage::VERTEX && var.declaration->interface=="in" && var.name.compare(0, 3, "gl_") && !var.declaration->linked_declaration)
445                 error(var, format("Use of unlinked input %s '%s'", (var.declaration->block_declaration ? "block" : "variable"), var.name));
446 }
447
448 void ReferenceValidator::visit(MemberAccess &memacc)
449 {
450         if(memacc.left->type && !memacc.declaration)
451                 error(memacc, format("Use of undeclared member '%s'", memacc.member));
452         TraversingVisitor::visit(memacc);
453 }
454
455 void ReferenceValidator::visit(FunctionCall &call)
456 {
457         if((!call.constructor && !call.declaration) || (call.constructor && !call.type))
458         {
459                 bool have_declaration = call.constructor;
460                 if(!call.constructor)
461                 {
462                         auto i = stage->functions.lower_bound(call.name);
463                         have_declaration = (i!=stage->functions.end() && i->second->name==call.name);
464                 }
465
466                 if(have_declaration)
467                 {
468                         bool valid_types = true;
469                         string signature;
470                         for(auto j=call.arguments.begin(); (valid_types && j!=call.arguments.end()); ++j)
471                         {
472                                 if((*j)->type)
473                                         append(signature, ", ", (*j)->type->name);
474                                 else
475                                         valid_types = false;
476                         }
477
478                         if(valid_types)
479                                 error(call, format("No matching %s found for '%s(%s)'", (call.constructor ? "constructor" : "overload"), call.name, signature));
480                 }
481                 else
482                         error(call, format("Call to undeclared function '%s'", call.name));
483         }
484         TraversingVisitor::visit(call);
485 }
486
487 void ReferenceValidator::visit(VariableDeclaration &var)
488 {
489         if(!var.type_declaration)
490                 error(var, format("Use of undeclared type '%s'", var.type));
491         TraversingVisitor::visit(var);
492 }
493
494 void ReferenceValidator::visit(FunctionDeclaration &func)
495 {
496         if(!func.return_type_declaration)
497                 error(func, format("Use of undeclared type '%s'", func.return_type));
498         TraversingVisitor::visit(func);
499 }
500
501
502 void ExpressionValidator::visit(VariableReference &var)
503 {
504         if(var.declaration && constant_expression)
505         {
506                 if(!var.declaration->constant)
507                 {
508                         const char *kind = (var.declaration->block_declaration ? "interface block" : "non-constant variable");
509                         error(var, format("Reference to %s '%s' in a constant expression", kind, var.name));
510                 }
511                 else if(var.declaration->layout && constant_expression==FIXED_CONSTANT)
512                 {
513                         if(has_layout_qualifier(var.declaration->layout.get(), "constant_id"))
514                                 error(var, format("Reference to specialization constant '%s' in a fixed constant expression", var.name));
515                 }
516         }
517 }
518
519 void ExpressionValidator::visit(Swizzle &swizzle)
520 {
521         unsigned size = 0;
522         if(BasicTypeDeclaration *basic = dynamic_cast<BasicTypeDeclaration *>(swizzle.left->type))
523         {
524                 if(basic->kind==BasicTypeDeclaration::INT || basic->kind==BasicTypeDeclaration::FLOAT)
525                         size = 1;
526                 else if(basic->kind==BasicTypeDeclaration::VECTOR)
527                         size = basic->size;
528         }
529
530         if(size)
531         {
532                 static const char component_names[] = { 'x', 'y', 'z', 'w', 'r', 'g', 'b', 'a', 's', 't', 'p', 'q' };
533                 int flavour = -1;
534                 for(unsigned i=0; i<swizzle.count; ++i)
535                 {
536                         unsigned component_flavour = (std::find(component_names, component_names+12, swizzle.component_group[i])-component_names)/4;
537                         if(flavour==-1)
538                                 flavour = component_flavour;
539                         else if(flavour>=0 && component_flavour!=static_cast<unsigned>(flavour))
540                         {
541                                 error(swizzle, format("Flavour of swizzle component '%c' is inconsistent with '%c'",
542                                         swizzle.component_group[i], swizzle.component_group[0]));
543                                 flavour = -2;
544                         }
545
546                         if(swizzle.components[i]>=size)
547                                 error(swizzle, format("Access to component '%c' which is not present in '%s'",
548                                         swizzle.component_group[i], swizzle.left->type->name));
549                 }
550         }
551         else if(swizzle.left->type)
552                 error(swizzle, format("Swizzle applied to '%s' which is neither a scalar nor a vector", swizzle.left->type->name));
553
554         TraversingVisitor::visit(swizzle);
555 }
556
557 void ExpressionValidator::visit(UnaryExpression &unary)
558 {
559         if(unary.expression->type)
560         {
561                 if(!unary.type)
562                         error(unary, format("No matching operator '%s' found for '%s'", unary.oper->token, unary.expression->type->name));
563                 else if(unary.oper->token[1]=='+' || unary.oper->token[1]=='-')
564                 {
565                         if(constant_expression)
566                                 error(unary, format("Use of '%s' in a constant expression", unary.oper->token));
567                         else if(!unary.expression->lvalue)
568                                 error(unary, format("Operand of '%s' is not an lvalue", unary.oper->token));
569                 }
570         }
571         TraversingVisitor::visit(unary);
572 }
573
574 void ExpressionValidator::visit(BinaryExpression &binary)
575 {
576         if(!binary.type && binary.left->type && binary.right->type)
577         {
578                 if(binary.oper->token[0]=='[')
579                         error(binary, format("Can't index element of '%s' with '%s'",
580                                 binary.left->type->name, binary.right->type->name));
581                 else
582                         error(binary, format("No matching operator '%s' found for '%s' and '%s'",
583                                 binary.oper->token, binary.left->type->name, binary.right->type->name));
584         }
585         TraversingVisitor::visit(binary);
586 }
587
588 void ExpressionValidator::visit(Assignment &assign)
589 {
590         if(assign.left->type)
591         {
592                 if(constant_expression)
593                         error(assign, "Assignment in constant expression");
594                 else if(!assign.left->lvalue)
595                         error(assign, "Target of assignment is not an lvalue");
596                 if(assign.right->type)
597                 {
598                         if(assign.oper->token[0]!='=')
599                         {
600                                 if(!assign.type)
601                                         error(assign, format("No matching operator '%s' found for '%s' and '%s'",
602                                                 string(assign.oper->token, strlen(assign.oper->token)-1), assign.left->type->name, assign.right->type->name));
603                         }
604                         else if(assign.left->type!=assign.right->type)
605                                 error(assign, format("Assignment to variable of type '%s' from expression of incompatible type '%s'",
606                                         assign.left->type->name, assign.right->type->name));
607                 }
608         }
609         TraversingVisitor::visit(assign);
610 }
611
612 void ExpressionValidator::visit(TernaryExpression &ternary)
613 {
614         if(ternary.condition->type)
615         {
616                 BasicTypeDeclaration *basic_cond = dynamic_cast<BasicTypeDeclaration *>(ternary.condition->type);
617                 if(!basic_cond || basic_cond->kind!=BasicTypeDeclaration::BOOL)
618                         error(ternary, "Ternary operator condition is not a boolean");
619                 else if(!ternary.type && ternary.true_expr->type && ternary.false_expr->type)
620                         error(ternary, format("Ternary operator has incompatible types '%s' and '%s'",
621                                 ternary.true_expr->type->name, ternary.false_expr->type->name));
622         }
623         TraversingVisitor::visit(ternary);
624 }
625
626 void ExpressionValidator::visit(StructDeclaration &strct)
627 {
628         SetFlag set_struct(in_struct);
629         TraversingVisitor::visit(strct);
630 }
631
632 void ExpressionValidator::visit(VariableDeclaration &var)
633 {
634         if(var.init_expression && var.init_expression->type && var.type_declaration && var.init_expression->type!=var.type_declaration)
635                 error(var, format("Initializing a variable of type '%s' with an expression of incompatible type '%s'",
636                         var.type_declaration->name, var.init_expression->type->name));
637
638         if(var.layout)
639                 var.layout->visit(*this);
640         if(var.init_expression)
641         {
642                 ConstantKind const_kind = (!var.constant ? NOT_CONSTANT :
643                         has_layout_qualifier(var.layout.get(), "constant_id") ? FIXED_CONSTANT : SPEC_CONSTANT);
644
645                 SetForScope<ConstantKind> set_const(constant_expression, const_kind);
646                 TraversingVisitor::visit(var.init_expression);
647         }
648         if(var.array_size)
649         {
650                 SetForScope<ConstantKind> set_const(constant_expression, (in_struct || !var.interface.empty() ? FIXED_CONSTANT : SPEC_CONSTANT));
651                 TraversingVisitor::visit(var.array_size);
652         }
653 }
654
655 void ExpressionValidator::visit(FunctionDeclaration &func)
656 {
657         SetForScope<FunctionDeclaration *> set_func(current_function, &func);
658         TraversingVisitor::visit(func);
659 }
660
661 void ExpressionValidator::visit(Conditional &cond)
662 {
663         if(cond.condition->type)
664         {
665                 BasicTypeDeclaration *basic_cond = dynamic_cast<BasicTypeDeclaration *>(cond.condition->type);
666                 if(!basic_cond || basic_cond->kind!=BasicTypeDeclaration::BOOL)
667                         error(cond, "Condition is not a boolean");
668         }
669         TraversingVisitor::visit(cond);
670 }
671
672 void ExpressionValidator::visit(Iteration &iter)
673 {
674         if(iter.condition->type)
675         {
676                 BasicTypeDeclaration *basic_cond = dynamic_cast<BasicTypeDeclaration *>(iter.condition->type);
677                 if(!basic_cond || basic_cond->kind!=BasicTypeDeclaration::BOOL)
678                         error(iter, "Loop condition is not a boolean");
679         }
680         TraversingVisitor::visit(iter);
681 }
682
683 void ExpressionValidator::visit(Return &ret)
684 {
685         if(current_function && current_function->return_type_declaration)
686         {
687                 TypeDeclaration *return_type = current_function->return_type_declaration;
688                 BasicTypeDeclaration *basic_return = dynamic_cast<BasicTypeDeclaration *>(return_type);
689                 if(ret.expression)
690                 {
691                         if(ret.expression->type && ret.expression->type!=return_type)
692                                 error(ret, format("Return expression type '%s' is incompatible with declared return type '%s'",
693                                         ret.expression->type->name, return_type->name));
694                 }
695                 else if(!basic_return || basic_return->kind!=BasicTypeDeclaration::VOID)
696                         error(ret, "Return statement without an expression in a function not returning 'void'");
697         }
698
699         TraversingVisitor::visit(ret);
700 }
701
702
703 void FlowControlValidator::visit(Block &block)
704 {
705         for(const RefPtr<Statement> &s: block.body)
706         {
707                 if(!reachable)
708                 {
709                         diagnose(*s, Diagnostic::WARN, "Unreachable code detected");
710                         break;
711                 }
712                 s->visit(*this);
713         }
714 }
715
716 void FlowControlValidator::visit(FunctionDeclaration &func)
717 {
718         func.body.visit(*this);
719
720         if(func.definition==&func && func.return_type_declaration)
721         {
722                 const BasicTypeDeclaration *basic_ret = dynamic_cast<const BasicTypeDeclaration *>(func.return_type_declaration);
723                 if(reachable && (!basic_ret || basic_ret->kind!=BasicTypeDeclaration::VOID))
724                         error(func, "Missing return statement at the end of a function not returning 'void'");
725         }
726         reachable = true;
727 }
728
729 void FlowControlValidator::visit(Conditional &cond)
730 {
731         cond.body.visit(*this);
732         bool reachable_if_true = reachable;
733         reachable = true;
734         cond.else_body.visit(*this);
735         reachable |= reachable_if_true;
736 }
737
738 void FlowControlValidator::visit(Iteration &iter)
739 {
740         iter.body.visit(*this);
741         reachable = true;
742 }
743
744
745 void StageInterfaceValidator::visit(VariableDeclaration &var)
746 {
747         int location = get_layout_value(var.layout.get(), "location");
748         if(var.interface=="in" && var.linked_declaration)
749         {
750                 const Layout *linked_layout = var.linked_declaration->layout.get();
751                 int linked_location = get_layout_value(linked_layout, "location");
752                 if(linked_location!=location)
753                 {
754                         error(var, format("Mismatched location %d for 'in %s'", location, var.name));
755                         add_info(*var.linked_declaration, format("Linked to 'out %s' with location %d",
756                                 var.linked_declaration->name, linked_location));
757                 }
758                 if(var.type_declaration && var.linked_declaration->type_declaration)
759                 {
760                         TypeDeclaration *type = var.type_declaration;
761                         if(stage->type==Stage::GEOMETRY)
762                         {
763                                 if(const BasicTypeDeclaration *basic = dynamic_cast<const BasicTypeDeclaration *>(type))
764                                         if(basic->kind==BasicTypeDeclaration::ARRAY && basic->base_type)
765                                                 type = basic->base_type;
766                         }
767                         if(!TypeComparer().apply(*type, *var.linked_declaration->type_declaration))
768                         {
769                                 error(var, format("Mismatched type '%s' for 'in %s'", type->name, var.name));
770                                 add_info(*var.linked_declaration, format("Linked to 'out %s' with type '%s'",
771                                         var.linked_declaration->name, var.linked_declaration->type_declaration->name));
772                         }
773                 }
774         }
775
776         if(location>=0 && !var.interface.empty())
777         {
778                 map<unsigned, VariableDeclaration *> &used = used_locations[var.interface];
779
780                 unsigned loc_count = LocationCounter().apply(var);
781                 for(unsigned i=0; i<loc_count; ++i)
782                 {
783                         auto j = used.find(location+i);
784                         if(j!=used.end())
785                         {
786                                 error(var, format("Overlapping location %d for '%s %s'", location+i, var.interface, var.name));
787                                 add_info(*j->second, format("Previously used here for '%s %s'", j->second->interface, j->second->name));
788                         }
789                         else
790                                 used[location+i] = &var;
791                 }
792         }
793 }
794
795
796 void GlobalInterfaceValidator::apply(Module &module)
797 {
798         for(Stage &s: module.stages)
799         {
800                 stage = &s;
801                 s.content.visit(*this);
802         }
803 }
804
805 void GlobalInterfaceValidator::check_uniform(const Uniform &uni)
806 {
807         auto i = used_names.find(uni.name);
808         if(i!=used_names.end())
809         {
810                 if(uni.location>=0 && i->second->location>=0 && i->second->location!=uni.location)
811                 {
812                         error(*uni.node, format("Mismatched location %d for uniform '%s'", uni.location, uni.name));
813                         add_info(*i->second->node, format("Previously declared here with location %d", i->second->location));
814                 }
815                 if(i->second->desc_set!=uni.desc_set)
816                 {
817                         error(*uni.node, format("Mismatched descriptor set %d for uniform '%s'", uni.desc_set, uni.name));
818                         add_info(*i->second->node, format("Previously declared here with descriptor set %d", i->second->desc_set));
819                 }
820                 if(uni.bind_point>=0 && i->second->bind_point>=0 && i->second->bind_point!=uni.bind_point)
821                 {
822                         error(*uni.node, format("Mismatched binding %d for uniform '%s'", uni.bind_point, uni.name));
823                         add_info(*i->second->node, format("Previously declared here with binding %d", i->second->bind_point));
824                 }
825                 if(uni.type && i->second->type && !TypeComparer().apply(*uni.type, *i->second->type))
826                 {
827                         string type_name = (dynamic_cast<const StructDeclaration *>(uni.type) ?
828                                 "structure" : format("type '%s'", uni.type->name));
829                         error(*uni.node, format("Mismatched %s for uniform '%s'", type_name, uni.name));
830
831                         string message = "Previously declared here";
832                         if(!dynamic_cast<const StructDeclaration *>(i->second->type))
833                                 message += format(" with type '%s'", i->second->type->name);
834                         add_info(*i->second->node, message);
835                 }
836         }
837         else
838                 used_names.insert(make_pair(uni.name, &uni));
839
840         if(uni.location>=0)
841         {
842                 auto j = used_locations.find(uni.location);
843                 if(j!=used_locations.end())
844                 {
845                         if(j->second->name!=uni.name)
846                         {
847                                 error(*uni.node, format("Overlapping location %d for '%s'", uni.location, uni.name));
848                                 add_info(*j->second->node, format("Previously used here for '%s'", j->second->name));
849                         }
850                 }
851                 else
852                 {
853                         for(unsigned k=0; k<uni.loc_count; ++k)
854                                 used_locations.insert(make_pair(uni.location+k, &uni));
855                 }
856         }
857
858         if(uni.bind_point>=0)
859         {
860                 map<unsigned, const Uniform *> &used = used_bindings[uni.desc_set];
861                 auto j = used.find(uni.bind_point);
862                 if(j!=used.end())
863                 {
864                         if(j->second->name!=uni.name)
865                         {
866                                 error(*uni.node, format("Overlapping binding %d for '%s'", uni.bind_point, uni.name));
867                                 add_info(*j->second->node, format("Previously used here for '%s'", j->second->name));
868                         }
869                 }
870                 else
871                         used.insert(make_pair(uni.bind_point, &uni));
872         }
873 }
874
875 void GlobalInterfaceValidator::visit(VariableDeclaration &var)
876 {
877         if(var.interface=="uniform")
878         {
879                 Uniform uni;
880                 uni.node = &var;
881                 uni.type = var.type_declaration;
882                 uni.name = (var.block_declaration ? var.block_declaration->block_name : var.name);
883                 if(var.layout)
884                 {
885                         if(!var.block_declaration)
886                         {
887                                 uni.location = get_layout_value(var.layout.get(), "location");
888                                 uni.loc_count = LocationCounter().apply(var);
889                         }
890                         uni.desc_set = get_layout_value(var.layout.get(), "set", 0);
891                         uni.bind_point = get_layout_value(var.layout.get(), "binding");
892                 }
893
894                 uniforms.push_back(uni);
895                 check_uniform(uniforms.back());
896         }
897 }
898
899 } // namespace SL
900 } // namespace GL
901 } // namespace Msp