Drop the pretense of C89, put declarations where they make sense

[model-railway-devices.git] / arducontrol / interface.c

diff --git a/arducontrol/interface.c b/arducontrol/interface.c
index a8ae2a28af9a0fce11cd391b5dd80da3634cf38b..014e8e98bcaa0ac5eacbeb061f1a38754e1a2ae5 100644 (file)
--- a/arducontrol/interface.c
+++ b/arducontrol/interface.c
@@ -14,6 +14,7 @@ static uint8_t dispatch_command(const uint8_t *, uint8_t);
 
 void interface_init(void)
 {
+       DDRB |= 0x01;
        DDRD = (DDRD&0xFC)|0x02;
 
        serial_init(9600);
@@ -21,13 +22,13 @@ void interface_init(void)
 
 void interface_check(void)
 {
-       uint8_t count;
        if(serial_read_overrun())
                interface_send1(RECEIVE_OVERRUN);
 
-       count = serial_read_available();
+       uint8_t count = serial_read_available();
        if(count>0)
        {
+               PORTB |= 0x01;
                if(cmd_length==0)
                {
                        uint8_t l = ~serial_read();
@@ -45,10 +46,9 @@ void interface_check(void)
 
                if(cmd_read_pos<cmd_length)
                {
-                       uint8_t i;
                        if(cmd_read_pos+count>cmd_length)
                                count = cmd_length-cmd_read_pos;
-                       for(i=0; i<count; ++i)
+                       for(uint8_t i=0; i<count; ++i)
                                cmd_buffer[cmd_read_pos++] = serial_read();
 
                        if(cmd_read_pos>=cmd_length)
@@ -58,6 +58,7 @@ void interface_check(void)
                                cmd_length = 0;
                        }
                }
+               PORTB &= ~0x01;
        }
 }
 
@@ -82,10 +83,8 @@ static uint8_t dispatch_command(const uint8_t *cmd, uint8_t length)
 
 void interface_send(const uint8_t *cmd, uint8_t length)
 {
-       uint8_t i;
-
        serial_write(~length);
-       for(i=0; i<length; ++i)
+       for(uint8_t i=0; i<length; ++i)
                serial_write(cmd[i]);
 }