]> git.tdb.fi Git - libs/gui.git/commitdiff
Load image signature directly into a string
authorMikko Rasa <tdb@tdb.fi>
Tue, 2 Nov 2021 09:56:07 +0000 (11:56 +0200)
committerMikko Rasa <tdb@tdb.fi>
Tue, 2 Nov 2021 09:56:07 +0000 (11:56 +0200)
source/graphics/imageloader.cpp

index e224af63cd161495a7e13a7ee795c92273864678..d2d3ef9234a470c1c81b08a934939289f9ce41f1 100644 (file)
@@ -59,9 +59,8 @@ ImageLoader *ImageLoader::open_io(IO::Seekable &io)
        if(registry.loaders.empty())
                throw unsupported_image_format("no loaders");
 
-       vector<char> sig_buf(registry.loaders.back()->get_signature_size());
-       unsigned sig_len = io.read(&sig_buf[0], sig_buf.size());
-       string signature(sig_buf.begin(), sig_buf.end());
+       string signature(registry.loaders.back()->get_signature_size(), 0);
+       unsigned sig_len = io.read(&signature[0], signature.size());
 
        ImageLoader *loader = 0;
        for(list<RegisterBase *>::const_iterator i=registry.loaders.begin(); (!loader && i!=registry.loaders.end()); ++i)
@@ -74,7 +73,7 @@ ImageLoader *ImageLoader::open_io(IO::Seekable &io)
        {
                string sig_hex;
                for(unsigned i=0; i<sig_len; ++i)
-                       append(sig_hex, " ", format("%02X", static_cast<unsigned char>(sig_buf[i])));
+                       append(sig_hex, " ", format("%02X", static_cast<unsigned char>(signature[i])));
                throw unsupported_image_format(sig_hex);
        }