Assign a result type to all expressions

[libs/gl.git] / source / glsl / validate.cpp

diff --git a/source/glsl/validate.cpp b/source/glsl/validate.cpp
index 6f0869ea141897813c4e4f3190a81082457ceed1..676dd9e808792867458d8c59d03a62d47ceb8e88 100644 (file)
--- a/source/glsl/validate.cpp
+++ b/source/glsl/validate.cpp
@@ -23,6 +23,57 @@ void Validator::diagnose(Node &node, Diagnostic::Severity severity, const string
 }
 
 
+TypeValidator::TypeValidator():
+       in_struct(false)
+{ }
+
+void TypeValidator::visit(BasicTypeDeclaration &type)
+{
+       if(type.kind==BasicTypeDeclaration::VECTOR)
+       {
+               BasicTypeDeclaration::Kind base_kind = BasicTypeDeclaration::VOID;
+               if(BasicTypeDeclaration *basic_base = dynamic_cast<BasicTypeDeclaration *>(type.base_type))
+                       base_kind = basic_base->kind;
+               if(base_kind!=BasicTypeDeclaration::BOOL && base_kind!=BasicTypeDeclaration::INT && base_kind!=BasicTypeDeclaration::FLOAT)
+                       error(type, format("Invalid base type '%s' for vector type '%s'", type.base, type.name));
+       }
+       else if(type.kind==BasicTypeDeclaration::ARRAY)
+       {
+               if(BasicTypeDeclaration *basic_base = dynamic_cast<BasicTypeDeclaration *>(type.base_type))
+                       if(basic_base->kind==BasicTypeDeclaration::VOID)
+                               error(type, format("Invalid base type '%s' for array type '%s'", type.base, type.name));
+       }
+}
+
+void TypeValidator::visit(ImageTypeDeclaration &type)
+{
+       BasicTypeDeclaration::Kind base_kind = BasicTypeDeclaration::VOID;
+       if(BasicTypeDeclaration *basic_base = dynamic_cast<BasicTypeDeclaration *>(type.base_type))
+               base_kind = basic_base->kind;
+       if(base_kind!=BasicTypeDeclaration::INT && base_kind!=BasicTypeDeclaration::FLOAT)
+               error(type, format("Invalid base type '%s' for image type '%s'", type.base, type.name));
+}
+
+void TypeValidator::visit(StructDeclaration &strct)
+{
+       SetFlag set_struct(in_struct);
+       TraversingVisitor::visit(strct);
+}
+
+void TypeValidator::visit(VariableDeclaration &var)
+{
+       if(in_struct)
+       {
+               if(var.layout)
+                       error(var, "Struct members can't have layouts");
+               if(var.init_expression)
+                       error(var, "Struct members can't have initializers");
+       }
+
+       TraversingVisitor::visit(var);
+}
+
+
 DeclarationValidator::DeclarationValidator():
        anonymous_block(false)
 { }
@@ -113,6 +164,18 @@ void DeclarationValidator::visit(FunctionDeclaration &func)
 }
 
 
+void ReferenceValidator::visit(BasicTypeDeclaration &type)
+{
+       if(!type.base.empty() && !type.base_type)
+               error(type, format("Use of undeclared type '%s'", type.base));
+}
+
+void ReferenceValidator::visit(ImageTypeDeclaration &type)
+{
+       if(!type.base.empty() && !type.base_type)
+               error(type, format("Use of undeclared type '%s'", type.base));
+}
+
 void ReferenceValidator::visit(VariableReference &var)
 {
        if(!var.declaration)
@@ -138,6 +201,52 @@ void ReferenceValidator::visit(VariableDeclaration &var)
        TraversingVisitor::visit(var);
 }
 
+void ReferenceValidator::visit(FunctionDeclaration &func)
+{
+       if(!func.return_type_declaration)
+               error(func, format("Use of undeclared type '%s'", func.return_type));
+       TraversingVisitor::visit(func);
+}
+
+
+void ExpressionValidator::visit(UnaryExpression &unary)
+{
+       if(unary.expression->type)
+       {
+               if(!unary.type)
+                       error(unary, format("No matching operator '%s' found for '%s'", unary.oper->token, unary.expression->type->name));
+               else if((unary.oper->token[1]=='+' || unary.oper->token[1]=='-') && !unary.expression->lvalue)
+                       error(unary, format("Operand of '%s' is not an lvalue", unary.oper->token));
+       }
+       TraversingVisitor::visit(unary);
+}
+
+void ExpressionValidator::visit(BinaryExpression &binary)
+{
+       if(!binary.type && binary.left->type && binary.right->type)
+               error(binary, format("No matching operator '%s' found for '%s' and '%s'",
+                       binary.oper->token, binary.left->type->name, binary.right->type->name));
+       TraversingVisitor::visit(binary);
+}
+
+void ExpressionValidator::visit(Assignment &assign)
+{
+       if(assign.left->type && !assign.left->lvalue)
+               error(assign, "Target of assignment is not an lvalue");
+       if(assign.left->type && assign.right->type && assign.left->type!=assign.right->type)
+               error(assign, format("Assignment to variable of type '%s' from expression of type '%s'",
+                       assign.left->type->name, assign.right->type->name));
+       TraversingVisitor::visit(assign);
+}
+
+void ExpressionValidator::visit(VariableDeclaration &var)
+{
+       if(var.init_expression && var.init_expression->type && var.type_declaration && var.init_expression->type!=var.type_declaration)
+               error(var, format("Initializing a variable of type '%s' with an expression of type '%s'",
+                       var.type_declaration->name, var.init_expression->type->name));
+       TraversingVisitor::visit(var);
+}
+
 } // namespace SL
 } // namespace GL
 } // namespace Msp