]> git.tdb.fi Git - libs/gl.git/blobdiff - source/glsl/optimize.cpp
Use default member initializers for simple types
[libs/gl.git] / source / glsl / optimize.cpp
index 7473fe2ca598ad996ee6c3263385f938986e80e2..8c586e7ad886cf433c4c5cadf6315783980804a6 100644 (file)
@@ -1,6 +1,9 @@
+#include <msp/core/algorithm.h>
 #include <msp/core/raii.h>
 #include <msp/strings/format.h>
+#include <msp/strings/utils.h>
 #include "optimize.h"
+#include "reflect.h"
 
 using namespace std;
 
@@ -8,10 +11,49 @@ namespace Msp {
 namespace GL {
 namespace SL {
 
-InlineableFunctionLocator::InlineableFunctionLocator():
-       current_function(0),
-       return_count(0)
-{ }
+void ConstantSpecializer::apply(Stage &stage, const map<string, int> &v)
+{
+       values = &v;
+       stage.content.visit(*this);
+}
+
+void ConstantSpecializer::visit(VariableDeclaration &var)
+{
+       bool specializable = false;
+       if(var.layout)
+       {
+               vector<Layout::Qualifier> &qualifiers = var.layout->qualifiers;
+               auto i = find_member(qualifiers, string("constant_id"), &Layout::Qualifier::name);
+               if(i!=qualifiers.end())
+               {
+                       specializable = true;
+                       qualifiers.erase(i);
+                       if(qualifiers.empty())
+                               var.layout = 0;
+               }
+       }
+
+       if(specializable)
+       {
+               auto i = values->find(var.name);
+               if(i!=values->end())
+               {
+                       RefPtr<Literal> literal = new Literal;
+                       if(var.type=="bool")
+                       {
+                               literal->token = (i->second ? "true" : "false");
+                               literal->value = static_cast<bool>(i->second);
+                       }
+                       else if(var.type=="int")
+                       {
+                               literal->token = lexical_cast<string>(i->second);
+                               literal->value = i->second;
+                       }
+                       var.init_expression = literal;
+               }
+       }
+}
+
 
 void InlineableFunctionLocator::visit(FunctionCall &call)
 {
@@ -25,7 +67,7 @@ void InlineableFunctionLocator::visit(FunctionCall &call)
                ++count;
                /* Don't inline functions which are called more than once or are called
                recursively. */
-               if(count>1 || def==current_function)
+               if((count>1 && def->source!=BUILTIN_SOURCE) || def==current_function)
                        inlineable.erase(def);
        }
 
@@ -34,8 +76,11 @@ void InlineableFunctionLocator::visit(FunctionCall &call)
 
 void InlineableFunctionLocator::visit(FunctionDeclaration &func)
 {
+       bool has_out_params = any_of(func.parameters.begin(), func.parameters.end(),
+               [](const RefPtr<VariableDeclaration> &p){ return p->interface=="out"; });
+
        unsigned &count = refcounts[func.definition];
-       if(count<=1 && func.parameters.empty())
+       if((count<=1 || func.source==BUILTIN_SOURCE) && !has_out_params)
                inlineable.insert(func.definition);
 
        SetForScope<FunctionDeclaration *> set(current_function, &func);
@@ -64,85 +109,94 @@ void InlineableFunctionLocator::visit(Return &ret)
 }
 
 
-InlineContentInjector::InlineContentInjector():
-       source_func(0),
-       remap_names(false),
-       deps_only(false)
-{ }
-
-const string &InlineContentInjector::apply(Stage &stage, FunctionDeclaration &target_func, Block &tgt_blk, const NodeList<Statement>::iterator &ins_pt, FunctionDeclaration &src)
+string InlineContentInjector::apply(Stage &stage, FunctionDeclaration &target_func, Block &tgt_blk, const NodeList<Statement>::iterator &ins_pt, FunctionCall &call)
 {
-       target_block = &tgt_blk;
-       source_func = &src;
-       remap_prefix = source_func->name;
+       source_func = call.declaration->definition;
+
+       /* Populate referenced_names from the target function so we can rename
+       variables from the inlined function that would conflict. */
+       pass = REFERENCED;
+       target_func.visit(*this);
+
+       /* Inline and rename passes must be interleaved so used variable names are
+       known when inlining the return statement. */
+       pass = INLINE;
+       staging_block.parent = &tgt_blk;
+       staging_block.variables.clear();
+
+       vector<RefPtr<VariableDeclaration> > params;
+       params.reserve(source_func->parameters.size());
+       for(const RefPtr<VariableDeclaration> &p: source_func->parameters)
+       {
+               RefPtr<VariableDeclaration> var = p->clone();
+               var->interface.clear();
+
+               SetForScope<Pass> set_pass(pass, RENAME);
+               var->visit(*this);
+
+               staging_block.body.push_back_nocopy(var);
+               params.push_back(var);
+       }
 
-       vector<RefPtr<Statement> > inlined;
-       inlined.reserve(src.body.body.size());
-       for(NodeList<Statement>::iterator i=src.body.body.begin(); i!=src.body.body.end(); ++i)
+       for(const RefPtr<Statement> &s: source_func->body.body)
        {
                r_inlined_statement = 0;
-               (*i)->visit(*this);
+               s->visit(*this);
                if(!r_inlined_statement)
-                       r_inlined_statement = (*i)->clone();
+                       r_inlined_statement = s->clone();
 
-               SetForScope<unsigned> set_remap(remap_names, 2);
+               SetForScope<Pass> set_pass(pass, RENAME);
                r_inlined_statement->visit(*this);
-               inlined.push_back(r_inlined_statement);
-       }
 
-       // Insert the variables here to enable further inlinings to avoid conflicts.
-       tgt_blk.variables.insert(variable_map.begin(), variable_map.end());
+               staging_block.body.push_back_nocopy(r_inlined_statement);
+       }
 
-       SetForScope<unsigned> set_remap(remap_names, 1);
-       SetForScope<string> set_prefix(remap_prefix, target_func.name);
-       variable_map.clear();
+       /* Now collect names from the staging block.  Local variables that would
+       have conflicted with the target function were renamed earlier. */
+       pass = REFERENCED;
+       referenced_names.clear();
+       staging_block.variables.clear();
+       staging_block.visit(*this);
+
+       /* Rename variables in the target function so they don't interfere with
+       global identifiers used by the source function. */
+       pass = RENAME;
+       staging_block.parent = source_func->body.parent;
        target_func.visit(*this);
 
-       tgt_blk.body.insert(ins_pt, inlined.begin(), inlined.end());
+       // Put the argument expressions in place after all renaming has been done.
+       for(unsigned i=0; i<source_func->parameters.size(); ++i)
+               params[i]->init_expression = call.arguments[i]->clone();
 
-       NodeReorderer().apply(stage, target_func, dependencies);
+       tgt_blk.body.splice(ins_pt, staging_block.body);
+
+       NodeReorderer().apply(stage, target_func, DependencyCollector().apply(*source_func));
 
        return r_result_name;
 }
 
 void InlineContentInjector::visit(VariableReference &var)
 {
-       if(remap_names)
+       if(pass==RENAME)
        {
-               map<string, VariableDeclaration *>::const_iterator i = variable_map.find(var.name);
-               if(i!=variable_map.end())
+               auto i = staging_block.variables.find(var.name);
+               if(i!=staging_block.variables.end())
                        var.name = i->second->name;
        }
-       else if(var.declaration)
-       {
-               SetFlag set_deps(deps_only);
-               if(!variable_map.count(var.name))
-               {
-                       dependencies.insert(var.declaration);
-                       referenced_names.insert(var.name);
-               }
-               var.declaration->visit(*this);
-       }
+       else if(pass==REFERENCED)
+               referenced_names.insert(var.name);
 }
 
 void InlineContentInjector::visit(InterfaceBlockReference &iface)
 {
-       if(!remap_names && iface.declaration)
-       {
-               SetFlag set_deps(deps_only);
-               dependencies.insert(iface.declaration);
+       if(pass==REFERENCED)
                referenced_names.insert(iface.name);
-               iface.declaration->visit(*this);
-       }
 }
 
 void InlineContentInjector::visit(FunctionCall &call)
 {
-       if(!remap_names && call.declaration)
-       {
-               dependencies.insert(call.declaration);
+       if(pass==REFERENCED)
                referenced_names.insert(call.name);
-       }
        TraversingVisitor::visit(call);
 }
 
@@ -150,33 +204,34 @@ void InlineContentInjector::visit(VariableDeclaration &var)
 {
        TraversingVisitor::visit(var);
 
-       if(remap_names)
+       if(pass==RENAME)
        {
-               if(remap_names==2 || referenced_names.count(var.name))
+               /* Check against conflicts with the other context as well as variables
+               already renamed here. */
+               bool conflict = (staging_block.variables.count(var.name) || referenced_names.count(var.name));
+               staging_block.variables[var.name] = &var;
+               if(conflict)
                {
-                       string mapped_name = get_unused_variable_name(*target_block, var.name, remap_prefix);
-                       variable_map[var.name] = &var;
-                       var.name = mapped_name;
+                       string mapped_name = get_unused_variable_name(staging_block, var.name);
+                       if(mapped_name!=var.name)
+                       {
+                               staging_block.variables[mapped_name] = &var;
+                               var.name = mapped_name;
+                       }
                }
        }
-       else if(var.type_declaration)
-       {
-               SetFlag set_deps(deps_only);
-               dependencies.insert(var.type_declaration);
-               referenced_names.insert(var.type_declaration->name);
-               var.type_declaration->visit(*this);
-       }
+       else if(pass==REFERENCED)
+               referenced_names.insert(var.type);
 }
 
 void InlineContentInjector::visit(Return &ret)
 {
        TraversingVisitor::visit(ret);
 
-       if(!remap_names && ret.expression)
+       if(pass==INLINE && ret.expression)
        {
-               /* Create a new variable to hold the return value of the inlined
-               function. */
-               r_result_name = get_unused_variable_name(*target_block, "_return", source_func->name);
+               // Create a new variable to hold the return value of the inlined function.
+               r_result_name = get_unused_variable_name(staging_block, "_return");
                RefPtr<VariableDeclaration> var = new VariableDeclaration;
                var->source = ret.source;
                var->line = ret.line;
@@ -188,11 +243,6 @@ void InlineContentInjector::visit(Return &ret)
 }
 
 
-FunctionInliner::FunctionInliner():
-       current_function(0),
-       r_any_inlined(false)
-{ }
-
 bool FunctionInliner::apply(Stage &s)
 {
        stage = &s;
@@ -218,7 +268,7 @@ void FunctionInliner::visit(Block &block)
 {
        SetForScope<Block *> set_block(current_block, &block);
        SetForScope<NodeList<Statement>::iterator> save_insert_point(insert_point, block.body.begin());
-       for(NodeList<Statement>::iterator i=block.body.begin(); i!=block.body.end(); ++i)
+       for(auto i=block.body.begin(); (!r_inlined_here && i!=block.body.end()); ++i)
        {
                insert_point = i;
                (*i)->visit(*this);
@@ -227,20 +277,23 @@ void FunctionInliner::visit(Block &block)
 
 void FunctionInliner::visit(FunctionCall &call)
 {
-       for(NodeArray<Expression>::iterator i=call.arguments.begin(); i!=call.arguments.end(); ++i)
+       for(auto i=call.arguments.begin(); (!r_inlined_here && i!=call.arguments.end()); ++i)
                visit(*i);
 
+       if(r_inlined_here)
+               return;
+
        FunctionDeclaration *def = call.declaration;
        if(def)
                def = def->definition;
 
        if(def && inlineable.count(def))
        {
-               string result_name = InlineContentInjector().apply(*stage, *current_function, *current_block, insert_point, *def);
+               string result_name = InlineContentInjector().apply(*stage, *current_function, *current_block, insert_point, call);
 
                // This will later get removed by UnusedVariableRemover.
                if(result_name.empty())
-                       result_name = "msp_unused_from_inline";
+                       result_name = "_msp_unused_from_inline";
 
                RefPtr<VariableReference> ref = new VariableReference;
                ref->name = result_name;
@@ -249,6 +302,7 @@ void FunctionInliner::visit(FunctionCall &call)
                /* Inlined variables need to be resolved before this function can be
                inlined further. */
                inlineable.erase(current_function);
+               r_inlined_here = true;
        }
 }
 
@@ -256,6 +310,7 @@ void FunctionInliner::visit(FunctionDeclaration &func)
 {
        SetForScope<FunctionDeclaration *> set_func(current_function, &func);
        TraversingVisitor::visit(func);
+       r_inlined_here = false;
 }
 
 void FunctionInliner::visit(Iteration &iter)
@@ -273,84 +328,51 @@ void FunctionInliner::visit(Iteration &iter)
 }
 
 
-ExpressionInliner::ExpressionInfo::ExpressionInfo():
-       expression(0),
-       assign_scope(0),
-       inline_point(0),
-       trivial(false),
-       available(true)
-{ }
-
-
-ExpressionInliner::ExpressionInliner():
-       r_ref_info(0),
-       r_any_inlined(false),
-       r_trivial(false),
-       mutating(false),
-       iteration_init(false),
-       iteration_body(0),
-       r_oper(0)
-{ }
-
 bool ExpressionInliner::apply(Stage &s)
 {
        s.content.visit(*this);
-       return r_any_inlined;
-}
-
-void ExpressionInliner::inline_expression(Expression &expr, RefPtr<Expression> &ptr)
-{
-       ptr = expr.clone();
-       r_any_inlined = true;
-}
 
-void ExpressionInliner::visit(Block &block)
-{
-       TraversingVisitor::visit(block);
-
-       for(map<string, VariableDeclaration *>::iterator i=block.variables.begin(); i!=block.variables.end(); ++i)
-       {
-               map<Assignment::Target, ExpressionInfo>::iterator j = expressions.lower_bound(i->second);
-               for(; (j!=expressions.end() && j->first.declaration==i->second); )
+       bool any_inlined = false;
+       for(ExpressionInfo &e: expressions)
+               if(e.expression && (e.trivial || e.uses.size()==1))
                {
-                       if(j->second.expression && j->second.inline_point)
-                               inline_expression(*j->second.expression, *j->second.inline_point);
-
-                       expressions.erase(j++);
+                       for(ExpressionUse &u: e.uses)
+                               if(!u.blocked)
+                               {
+                                       *u.reference = e.expression->clone();
+                                       any_inlined = true;
+                               }
                }
-       }
 
-       /* Expressions assigned in this block may depend on local variables of the
-       block.  If this is a conditionally executed block, the assignments might not
-       always happen.  Mark the expressions as not available to any outer blocks. */
-       for(map<Assignment::Target, ExpressionInfo>::iterator i=expressions.begin(); i!=expressions.end(); ++i)
-               if(i->second.assign_scope==&block)
-                       i->second.available = false;
+       return any_inlined;
 }
 
 void ExpressionInliner::visit(RefPtr<Expression> &expr)
 {
        r_ref_info = 0;
        expr->visit(*this);
-       if(r_ref_info && r_ref_info->expression && r_ref_info->available)
+       if(r_ref_info && r_ref_info->expression)
        {
+               ExpressionUse use;
+               use.reference = &expr;
+               use.ref_scope = current_block;
+               use.blocked = access_write;
+
                if(iteration_body && !r_ref_info->trivial)
                {
-                       /* Don't inline non-trivial expressions which were assigned outside
-                       an iteration statement.  The iteration may run multiple times, which
+                       /* Block inlining of non-trivial expressions assigned outside an
+                       iteration statement.  The iteration may run multiple times, which
                        would cause the expression to also be evaluated multiple times. */
-                       Block *i = r_ref_info->assign_scope;
-                       for(; (i && i!=iteration_body); i=i->parent) ;
-                       if(!i)
-                               return;
+                       for(Block *i=iteration_body->parent; (!use.blocked && i); i=i->parent)
+                               use.blocked = (i==r_ref_info->assign_scope);
                }
 
-               if(r_ref_info->trivial)
-                       inline_expression(*r_ref_info->expression, expr);
-               else
-                       /* Record the inline point for a non-trivial expression but don't
-                       inline it yet.  It might turn out it shouldn't be inlined after all. */
-                       r_ref_info->inline_point = &expr;
+               /* Block inlining assignments from from inner scopes.  The assignment may
+               depend on local variables of that scope or may not always be executed. */
+               for(Block *i=r_ref_info->assign_scope->parent; (!use.blocked && i); i=i->parent)
+                       use.blocked = (i==current_block);
+
+               r_ref_info->uses.push_back(use);
        }
        r_oper = expr->oper;
        r_ref_info = 0;
@@ -358,21 +380,11 @@ void ExpressionInliner::visit(RefPtr<Expression> &expr)
 
 void ExpressionInliner::visit(VariableReference &var)
 {
-       if(var.declaration)
+       if(var.declaration && access_read)
        {
-               map<Assignment::Target, ExpressionInfo>::iterator i = expressions.find(var.declaration);
-               if(i!=expressions.end())
-               {
-                       /* If a non-trivial expression is referenced multiple times, don't
-                       inline it. */
-                       if(i->second.inline_point && !i->second.trivial)
-                               i->second.expression = 0;
-                       /* Mutating expressions are analogous to self-referencing assignments
-                       and prevent inlining. */
-                       if(mutating)
-                               i->second.expression = 0;
-                       r_ref_info = &i->second;
-               }
+               auto i = assignments.find(var.declaration);
+               if(i!=assignments.end())
+                       r_ref_info = i->second;
        }
 }
 
@@ -390,7 +402,7 @@ void ExpressionInliner::visit(Swizzle &swizzle)
 
 void ExpressionInliner::visit(UnaryExpression &unary)
 {
-       SetFlag set_target(mutating, mutating || unary.oper->token[1]=='+' || unary.oper->token[1]=='-');
+       SetFlag set_write(access_write, access_write || unary.oper->token[1]=='+' || unary.oper->token[1]=='-');
        visit(unary.expression);
        r_trivial = false;
 }
@@ -399,7 +411,7 @@ void ExpressionInliner::visit(BinaryExpression &binary)
 {
        visit(binary.left);
        {
-               SetFlag clear_target(mutating, false);
+               SetFlag clear_write(access_write, false);
                visit(binary.right);
        }
        r_trivial = false;
@@ -408,21 +420,37 @@ void ExpressionInliner::visit(BinaryExpression &binary)
 void ExpressionInliner::visit(Assignment &assign)
 {
        {
-               SetFlag set_target(mutating);
+               SetFlag set_read(access_read, assign.oper->token[0]!='=');
+               SetFlag set_write(access_write);
                visit(assign.left);
        }
        r_oper = 0;
+       r_trivial = true;
        visit(assign.right);
 
-       map<Assignment::Target, ExpressionInfo>::iterator i = expressions.find(assign.target);
-       if(i!=expressions.end())
+       auto i = assignments.find(assign.target);
+       if(i!=assignments.end())
        {
-               /* Self-referencing assignments can't be inlined without additional
-               work.  Just clear any previous expression. */
-               i->second.expression = (assign.self_referencing ? 0 : assign.right.get());
-               i->second.assign_scope = current_block;
-               i->second.inline_point = 0;
-               i->second.available = true;
+               if(iteration_body && i->second->expression)
+               {
+                       /* Block inlining into previous references within the iteration
+                       statement.  On iterations after the first they would refer to the
+                       assignment within the iteration. */
+                       for(ExpressionUse &u: i->second->uses)
+                               for(Block *k=u.ref_scope; (!u.blocked && k); k=k->parent)
+                                       u.blocked = (k==iteration_body);
+               }
+
+               expressions.push_back(ExpressionInfo());
+               ExpressionInfo &info = expressions.back();
+               info.target = assign.target;
+               // Self-referencing assignments can't be inlined without additional work.
+               if(!assign.self_referencing)
+                       info.expression = assign.right;
+               info.assign_scope = current_block;
+               info.trivial = r_trivial;
+
+               i->second = &info;
        }
 
        r_trivial = false;
@@ -451,8 +479,8 @@ void ExpressionInliner::visit(VariableDeclaration &var)
        bool constant = var.constant;
        if(constant && var.layout)
        {
-               for(vector<Layout::Qualifier>::const_iterator i=var.layout->qualifiers.begin(); (constant && i!=var.layout->qualifiers.end()); ++i)
-                       constant = (i->name!="constant_id");
+               constant = !any_of(var.layout->qualifiers.begin(), var.layout->qualifiers.end(),
+                       [](const Layout::Qualifier &q){ return q.name=="constant_id"; });
        }
 
        /* Only inline global variables if they're constant and have trivial
@@ -460,12 +488,17 @@ void ExpressionInliner::visit(VariableDeclaration &var)
        analyze and non-trivial expressions could be expensive to inline.  */
        if((current_block->parent || (constant && r_trivial)) && var.interface.empty())
        {
-               ExpressionInfo &info = expressions[&var];
+               expressions.push_back(ExpressionInfo());
+               ExpressionInfo &info = expressions.back();
+               info.target = &var;
                /* Assume variables declared in an iteration initialization statement
                will have their values change throughout the iteration. */
-               info.expression = (iteration_init ? 0 : var.init_expression.get());
+               if(!iteration_init)
+                       info.expression = var.init_expression;
                info.assign_scope = current_block;
                info.trivial = r_trivial;
+
+               assignments[&var] = &info;
        }
 }
 
@@ -487,18 +520,6 @@ void ExpressionInliner::visit(Iteration &iter)
 }
 
 
-BasicTypeDeclaration::Kind ConstantFolder::get_value_kind(const Variant &value)
-{
-       if(value.check_type<bool>())
-               return BasicTypeDeclaration::BOOL;
-       else if(value.check_type<int>())
-               return BasicTypeDeclaration::INT;
-       else if(value.check_type<float>())
-               return BasicTypeDeclaration::FLOAT;
-       else
-               return BasicTypeDeclaration::VOID;
-}
-
 template<typename T>
 T ConstantFolder::evaluate_logical(char oper, T left, T right)
 {
@@ -537,6 +558,31 @@ T ConstantFolder::evaluate_arithmetic(char oper, T left, T right)
        }
 }
 
+template<typename T>
+T ConstantFolder::evaluate_int_special_op(char oper, T left, T right)
+{
+       switch(oper)
+       {
+       case '%': return left%right;
+       case '<': return left<<right;
+       case '>': return left>>right;
+       default: return T();
+       }
+}
+
+template<typename T>
+void ConstantFolder::convert_to_result(const Variant &value)
+{
+       if(value.check_type<bool>())
+               set_result(static_cast<T>(value.value<bool>()));
+       else if(value.check_type<int>())
+               set_result(static_cast<T>(value.value<int>()));
+       else if(value.check_type<unsigned>())
+               set_result(static_cast<T>(value.value<unsigned>()));
+       else if(value.check_type<float>())
+               set_result(static_cast<T>(value.value<float>()));
+}
+
 void ConstantFolder::set_result(const Variant &value, bool literal)
 {
        r_constant_value = value;
@@ -557,22 +603,27 @@ void ConstantFolder::visit(RefPtr<Expression> &expr)
        if(!r_constant || r_literal || r_uses_iter_var)
                return;
 
-       BasicTypeDeclaration::Kind kind = get_value_kind(r_constant_value);
-       if(kind==BasicTypeDeclaration::VOID)
+       RefPtr<Literal> literal = new Literal;
+       if(r_constant_value.check_type<bool>())
+               literal->token = (r_constant_value.value<bool>() ? "true" : "false");
+       else if(r_constant_value.check_type<int>())
+               literal->token = lexical_cast<string>(r_constant_value.value<int>());
+       else if(r_constant_value.check_type<unsigned>())
+               literal->token = lexical_cast<string>(r_constant_value.value<unsigned>())+"u";
+       else if(r_constant_value.check_type<float>())
+       {
+               literal->token = lexical_cast<string>(r_constant_value.value<float>(), Fmt().precision(8));
+               if(literal->token.find('.')==string::npos && literal->token.find('e')==string::npos)
+                       literal->token += ".0";
+       }
+       else
        {
                r_constant = false;
                return;
        }
-
-       RefPtr<Literal> literal = new Literal;
-       if(kind==BasicTypeDeclaration::BOOL)
-               literal->token = (r_constant_value.value<bool>() ? "true" : "false");
-       else if(kind==BasicTypeDeclaration::INT)
-               literal->token = lexical_cast<string>(r_constant_value.value<int>());
-       else if(kind==BasicTypeDeclaration::FLOAT)
-               literal->token = lexical_cast<string>(r_constant_value.value<float>());
        literal->value = r_constant_value;
        expr = literal;
+       r_any_folded = true;
 }
 
 void ConstantFolder::visit(Literal &literal)
@@ -612,25 +663,27 @@ void ConstantFolder::visit(UnaryExpression &unary)
        if(!can_fold)
                return;
 
-       BasicTypeDeclaration::Kind kind = get_value_kind(r_constant_value);
-
        char oper = unary.oper->token[0];
        char oper2 = unary.oper->token[1];
        if(oper=='!')
        {
-               if(kind==BasicTypeDeclaration::BOOL)
+               if(r_constant_value.check_type<bool>())
                        set_result(!r_constant_value.value<bool>());
        }
        else if(oper=='~')
        {
-               if(kind==BasicTypeDeclaration::INT)
+               if(r_constant_value.check_type<int>())
                        set_result(~r_constant_value.value<int>());
+               else if(r_constant_value.check_type<unsigned>())
+                       set_result(~r_constant_value.value<unsigned>());
        }
        else if(oper=='-' && !oper2)
        {
-               if(kind==BasicTypeDeclaration::INT)
+               if(r_constant_value.check_type<int>())
                        set_result(-r_constant_value.value<int>());
-               else if(kind==BasicTypeDeclaration::FLOAT)
+               else if(r_constant_value.check_type<unsigned>())
+                       set_result(-r_constant_value.value<unsigned>());
+               else if(r_constant_value.check_type<float>())
                        set_result(-r_constant_value.value<float>());
        }
 }
@@ -650,53 +703,54 @@ void ConstantFolder::visit(BinaryExpression &binary)
        if(!can_fold)
                return;
 
-       BasicTypeDeclaration::Kind left_kind = get_value_kind(left_value);
-       BasicTypeDeclaration::Kind right_kind = get_value_kind(r_constant_value);
        // Currently only expressions with both sides of equal types are handled.
-       if(left_kind!=right_kind)
+       if(!left_value.check_same_type(r_constant_value))
                return;
 
        char oper = binary.oper->token[0];
        char oper2 = binary.oper->token[1];
        if(oper=='&' || oper=='|' || oper=='^')
        {
-               if(oper2==oper && left_kind==BasicTypeDeclaration::BOOL)
+               if(oper2==oper && left_value.check_type<bool>())
                        set_result(evaluate_logical(oper, left_value.value<bool>(), r_constant_value.value<bool>()));
-               else if(!oper2 && left_kind==BasicTypeDeclaration::INT)
+               else if(!oper2 && left_value.check_type<int>())
                        set_result(evaluate_logical(oper, left_value.value<int>(), r_constant_value.value<int>()));
+               else if(!oper2 && left_value.check_type<unsigned>())
+                       set_result(evaluate_logical(oper, left_value.value<unsigned>(), r_constant_value.value<unsigned>()));
        }
        else if((oper=='<' || oper=='>') && oper2!=oper)
        {
-               if(left_kind==BasicTypeDeclaration::INT)
+               if(left_value.check_type<int>())
                        set_result(evaluate_relation(binary.oper->token, left_value.value<int>(), r_constant_value.value<int>()));
-               else if(left_kind==BasicTypeDeclaration::FLOAT)
+               else if(left_value.check_type<unsigned>())
+                       set_result(evaluate_relation(binary.oper->token, left_value.value<unsigned>(), r_constant_value.value<unsigned>()));
+               else if(left_value.check_type<float>())
                        set_result(evaluate_relation(binary.oper->token, left_value.value<float>(), r_constant_value.value<float>()));
        }
        else if((oper=='=' || oper=='!') && oper2=='=')
        {
-               if(left_kind==BasicTypeDeclaration::INT)
+               if(left_value.check_type<int>())
                        set_result((left_value.value<int>()==r_constant_value.value<int>()) == (oper=='='));
-               if(left_kind==BasicTypeDeclaration::FLOAT)
+               else if(left_value.check_type<unsigned>())
+                       set_result((left_value.value<unsigned>()==r_constant_value.value<unsigned>()) == (oper=='='));
+               else if(left_value.check_type<float>())
                        set_result((left_value.value<float>()==r_constant_value.value<float>()) == (oper=='='));
        }
        else if(oper=='+' || oper=='-' || oper=='*' || oper=='/')
        {
-               if(left_kind==BasicTypeDeclaration::INT)
+               if(left_value.check_type<int>())
                        set_result(evaluate_arithmetic(oper, left_value.value<int>(), r_constant_value.value<int>()));
-               else if(left_kind==BasicTypeDeclaration::FLOAT)
+               else if(left_value.check_type<unsigned>())
+                       set_result(evaluate_arithmetic(oper, left_value.value<unsigned>(), r_constant_value.value<unsigned>()));
+               else if(left_value.check_type<float>())
                        set_result(evaluate_arithmetic(oper, left_value.value<float>(), r_constant_value.value<float>()));
        }
        else if(oper=='%' || ((oper=='<' || oper=='>') && oper2==oper))
        {
-               if(left_kind!=BasicTypeDeclaration::INT)
-                       return;
-
-               if(oper=='%')
-                       set_result(left_value.value<int>()%r_constant_value.value<int>());
-               else if(oper=='<')
-                       set_result(left_value.value<int>()<<r_constant_value.value<int>());
-               else if(oper=='>')
-                       set_result(left_value.value<int>()>>r_constant_value.value<int>());
+               if(left_value.check_type<int>())
+                       set_result(evaluate_int_special_op(oper, left_value.value<int>(), r_constant_value.value<int>()));
+               else if(left_value.check_type<unsigned>())
+                       set_result(evaluate_int_special_op(oper, left_value.value<unsigned>(), r_constant_value.value<unsigned>()));
        }
 }
 
@@ -714,6 +768,30 @@ void ConstantFolder::visit(TernaryExpression &ternary)
 
 void ConstantFolder::visit(FunctionCall &call)
 {
+       if(call.constructor && call.type && call.arguments.size()==1)
+       {
+               const BasicTypeDeclaration *basic = dynamic_cast<const BasicTypeDeclaration *>(call.type);
+               if(basic)
+               {
+                       visit(call.arguments[0]);
+                       bool can_fold = r_constant;
+                       r_constant = false;
+                       if(!can_fold)
+                               return;
+
+                       if(basic->kind==BasicTypeDeclaration::BOOL)
+                               convert_to_result<bool>(r_constant_value);
+                       else if(basic->kind==BasicTypeDeclaration::INT && basic->size==32 && basic->sign)
+                               convert_to_result<int>(r_constant_value);
+                       else if(basic->kind==BasicTypeDeclaration::INT && basic->size==32 && !basic->sign)
+                               convert_to_result<unsigned>(r_constant_value);
+                       else if(basic->kind==BasicTypeDeclaration::FLOAT && basic->size==32)
+                               convert_to_result<float>(r_constant_value);
+
+                       return;
+               }
+       }
+
        TraversingVisitor::visit(call);
        r_constant = false;
 }
@@ -785,7 +863,7 @@ ConstantConditionEliminator::ConstantStatus ConstantConditionEliminator::check_c
 void ConstantConditionEliminator::visit(Block &block)
 {
        SetForScope<Block *> set_block(current_block, &block);
-       for(NodeList<Statement>::iterator i=block.body.begin(); i!=block.body.end(); ++i)
+       for(auto i=block.body.begin(); i!=block.body.end(); ++i)
        {
                insert_point = i;
                (*i)->visit(*this);
@@ -801,6 +879,27 @@ void ConstantConditionEliminator::visit(RefPtr<Expression> &expr)
        r_ternary_result = 0;
 }
 
+void ConstantConditionEliminator::visit(UnaryExpression &unary)
+{
+       if(unary.oper->token[1]=='+' || unary.oper->token[1]=='-')
+               if(const VariableReference *var = dynamic_cast<const VariableReference *>(unary.expression.get()))
+               {
+                       auto i = current_block->variables.find(var->name);
+                       r_external_side_effects = (i==current_block->variables.end() || i->second!=var->declaration);
+                       return;
+               }
+
+       TraversingVisitor::visit(unary);
+}
+
+void ConstantConditionEliminator::visit(Assignment &assign)
+{
+       auto i = find_if(current_block->variables, [&assign](const pair<string, VariableDeclaration *> &kvp){ return kvp.second==assign.target.declaration; });
+       if(i==current_block->variables.end())
+               r_external_side_effects = true;
+       TraversingVisitor::visit(assign);
+}
+
 void ConstantConditionEliminator::visit(TernaryExpression &ternary)
 {
        ConstantStatus result = check_constant_condition(*ternary.condition);
@@ -810,6 +909,12 @@ void ConstantConditionEliminator::visit(TernaryExpression &ternary)
                r_ternary_result = 0;
 }
 
+void ConstantConditionEliminator::visit(FunctionCall &call)
+{
+       r_external_side_effects = true;
+       TraversingVisitor::visit(call);
+}
+
 void ConstantConditionEliminator::visit(Conditional &cond)
 {
        ConstantStatus result = check_constant_condition(*cond.condition);
@@ -822,7 +927,11 @@ void ConstantConditionEliminator::visit(Conditional &cond)
                return;
        }
 
+       r_external_side_effects = false;
        TraversingVisitor::visit(cond);
+
+       if(cond.body.body.empty() && cond.else_body.body.empty() && !r_external_side_effects)
+               nodes_to_remove.insert(&cond);
 }
 
 void ConstantConditionEliminator::visit(Iteration &iter)
@@ -837,44 +946,66 @@ void ConstantConditionEliminator::visit(Iteration &iter)
                }
        }
 
+       r_external_side_effects = false;
        TraversingVisitor::visit(iter);
+       if(iter.body.body.empty() && !r_external_side_effects)
+               nodes_to_remove.insert(&iter);
 }
 
 
-bool UnusedTypeRemover::apply(Stage &stage)
+bool UnreachableCodeRemover::apply(Stage &stage)
 {
        stage.content.visit(*this);
-       NodeRemover().apply(stage, unused_nodes);
-       return !unused_nodes.empty();
+       NodeRemover().apply(stage, unreachable_nodes);
+       return !unreachable_nodes.empty();
 }
 
-void UnusedTypeRemover::visit(Literal &literal)
+void UnreachableCodeRemover::visit(Block &block)
 {
-       unused_nodes.erase(literal.type);
+       auto i = block.body.begin();
+       for(; (reachable && i!=block.body.end()); ++i)
+               (*i)->visit(*this);
+       for(; i!=block.body.end(); ++i)
+               unreachable_nodes.insert(i->get());
 }
 
-void UnusedTypeRemover::visit(UnaryExpression &unary)
+void UnreachableCodeRemover::visit(FunctionDeclaration &func)
 {
-       unused_nodes.erase(unary.type);
-       TraversingVisitor::visit(unary);
+       TraversingVisitor::visit(func);
+       reachable = true;
+}
+
+void UnreachableCodeRemover::visit(Conditional &cond)
+{
+       cond.body.visit(*this);
+       bool reachable_if_true = reachable;
+       reachable = true;
+       cond.else_body.visit(*this);
+
+       reachable |= reachable_if_true;
 }
 
-void UnusedTypeRemover::visit(BinaryExpression &binary)
+void UnreachableCodeRemover::visit(Iteration &iter)
 {
-       unused_nodes.erase(binary.type);
-       TraversingVisitor::visit(binary);
+       TraversingVisitor::visit(iter);
+
+       /* Always consider code after a loop reachable, since there's no checking
+       for whether the loop executes. */
+       reachable = true;
 }
 
-void UnusedTypeRemover::visit(TernaryExpression &ternary)
+
+bool UnusedTypeRemover::apply(Stage &stage)
 {
-       unused_nodes.erase(ternary.type);
-       TraversingVisitor::visit(ternary);
+       stage.content.visit(*this);
+       NodeRemover().apply(stage, unused_nodes);
+       return !unused_nodes.empty();
 }
 
-void UnusedTypeRemover::visit(FunctionCall &call)
+void UnusedTypeRemover::visit(RefPtr<Expression> &expr)
 {
-       unused_nodes.erase(call.type);
-       TraversingVisitor::visit(call);
+       unused_nodes.erase(expr->type);
+       TraversingVisitor::visit(expr);
 }
 
 void UnusedTypeRemover::visit(BasicTypeDeclaration &type)
@@ -900,6 +1031,7 @@ void UnusedTypeRemover::visit(StructDeclaration &strct)
 void UnusedTypeRemover::visit(VariableDeclaration &var)
 {
        unused_nodes.erase(var.type_declaration);
+       TraversingVisitor::visit(var);
 }
 
 void UnusedTypeRemover::visit(InterfaceBlock &iface)
@@ -914,46 +1046,34 @@ void UnusedTypeRemover::visit(FunctionDeclaration &func)
 }
 
 
-UnusedVariableRemover::UnusedVariableRemover():
-       stage(0),
-       interface_block(0),
-       r_assignment(0),
-       assignment_target(false),
-       r_side_effects(false)
-{ }
-
 bool UnusedVariableRemover::apply(Stage &s)
 {
        stage = &s;
        s.content.visit(*this);
 
-       for(list<AssignmentInfo>::const_iterator i=assignments.begin(); i!=assignments.end(); ++i)
-               if(i->used_by.empty())
-                       unused_nodes.insert(i->node);
+       for(const AssignmentInfo &a: assignments)
+               if(a.used_by.empty())
+                       unused_nodes.insert(a.node);
 
-       for(map<string, InterfaceBlock *>::const_iterator i=s.interface_blocks.begin(); i!=s.interface_blocks.end(); ++i)
-               if(i->second->instance_name.empty())
-                       unused_nodes.insert(i->second);
-
-       for(BlockVariableMap::const_iterator i=variables.begin(); i!=variables.end(); ++i)
+       for(const auto &kvp: variables)
        {
-               if(i->second.output)
+               if(kvp.second.output)
                {
                        /* The last visible assignments of output variables are used by the
                        next stage or the API. */
-                       for(vector<AssignmentInfo *>::const_iterator j=i->second.assignments.begin(); j!=i->second.assignments.end(); ++j)
-                               unused_nodes.erase((*j)->node);
+                       for(AssignmentInfo *a: kvp.second.assignments)
+                               unused_nodes.erase(a->node);
                }
 
-               if(!i->second.output && !i->second.referenced)
+               if(!kvp.second.output && !kvp.second.referenced)
                {
                        // Don't remove variables from inside interface blocks.
-                       if(!i->second.interface_block)
-                               unused_nodes.insert(i->first);
+                       if(!kvp.second.interface_block)
+                               unused_nodes.insert(kvp.first);
                }
-               else if(i->second.interface_block)
+               else if(kvp.second.interface_block)
                        // Interface blocks are kept if even one member is used.
-                       unused_nodes.erase(i->second.interface_block);
+                       unused_nodes.erase(kvp.second.interface_block);
        }
 
        NodeRemover().apply(s, unused_nodes);
@@ -967,19 +1087,90 @@ void UnusedVariableRemover::referenced(const Assignment::Target &target, Node &n
        var_info.referenced = true;
        if(!assignment_target)
        {
-               for(vector<AssignmentInfo *>::const_iterator i=var_info.assignments.begin(); i!=var_info.assignments.end(); ++i)
-                       (*i)->used_by.push_back(&node);
+               bool loop_external = false;
+               for(AssignmentInfo *a: var_info.assignments)
+               {
+                       bool covered = true;
+                       for(unsigned j=0; (covered && j<a->target.chain_len && j<target.chain_len); ++j)
+                       {
+                               Assignment::Target::ChainType type1 = static_cast<Assignment::Target::ChainType>(a->target.chain[j]&0xC0);
+                               Assignment::Target::ChainType type2 = static_cast<Assignment::Target::ChainType>(target.chain[j]&0xC0);
+                               if(type1==Assignment::Target::SWIZZLE || type2==Assignment::Target::SWIZZLE)
+                               {
+                                       unsigned index1 = a->target.chain[j]&0x3F;
+                                       unsigned index2 = target.chain[j]&0x3F;
+                                       if(type1==Assignment::Target::SWIZZLE && type2==Assignment::Target::SWIZZLE)
+                                               covered = index1&index2;
+                                       else if(type1==Assignment::Target::ARRAY && index1<4)
+                                               covered = index2&(1<<index1);
+                                       else if(type2==Assignment::Target::ARRAY && index2<4)
+                                               covered = index1&(1<<index2);
+                                       /* If it's some other combination (shouldn't happen), leave
+                                       covered as true */
+                               }
+                               else
+                                       covered = (a->target.chain[j]==target.chain[j]);
+                       }
+
+                       if(covered)
+                       {
+                               a->used_by.push_back(&node);
+                               if(a->in_loop<in_loop)
+                                       loop_external = true;
+                       }
+               }
+
+               if(loop_external)
+                       loop_ext_refs.push_back(&node);
        }
 }
 
 void UnusedVariableRemover::visit(VariableReference &var)
 {
-       referenced(var.declaration, var);
+       if(composite_reference)
+               r_reference.declaration = var.declaration;
+       else
+               referenced(var.declaration, var);
 }
 
 void UnusedVariableRemover::visit(InterfaceBlockReference &iface)
 {
-       referenced(iface.declaration, iface);
+       if(composite_reference)
+               r_reference.declaration = iface.declaration;
+       else
+               referenced(iface.declaration, iface);
+}
+
+void UnusedVariableRemover::visit_composite(Expression &expr)
+{
+       if(!composite_reference)
+               r_reference = Assignment::Target();
+
+       SetFlag set_composite(composite_reference);
+       expr.visit(*this);
+}
+
+void UnusedVariableRemover::visit(MemberAccess &memacc)
+{
+       visit_composite(*memacc.left);
+
+       add_to_chain(r_reference, Assignment::Target::MEMBER, memacc.index);
+
+       if(!composite_reference && r_reference.declaration)
+               referenced(r_reference, memacc);
+}
+
+void UnusedVariableRemover::visit(Swizzle &swizzle)
+{
+       visit_composite(*swizzle.left);
+
+       unsigned mask = 0;
+       for(unsigned i=0; i<swizzle.count; ++i)
+               mask |= 1<<swizzle.components[i];
+       add_to_chain(r_reference, Assignment::Target::SWIZZLE, mask);
+
+       if(!composite_reference && r_reference.declaration)
+               referenced(r_reference, swizzle);
 }
 
 void UnusedVariableRemover::visit(UnaryExpression &unary)
@@ -993,12 +1184,30 @@ void UnusedVariableRemover::visit(BinaryExpression &binary)
 {
        if(binary.oper->token[0]=='[')
        {
-               binary.left->visit(*this);
-               SetFlag set(assignment_target, false);
-               binary.right->visit(*this);
+               visit_composite(*binary.left);
+
+               {
+                       SetFlag clear_assignment(assignment_target, false);
+                       SetFlag clear_composite(composite_reference, false);
+                       binary.right->visit(*this);
+               }
+
+               add_to_chain(r_reference, Assignment::Target::ARRAY, 0x3F);
+
+               if(!composite_reference && r_reference.declaration)
+                       referenced(r_reference, binary);
        }
        else
+       {
+               SetFlag clear_composite(composite_reference, false);
                TraversingVisitor::visit(binary);
+       }
+}
+
+void UnusedVariableRemover::visit(TernaryExpression &ternary)
+{
+       SetFlag clear_composite(composite_reference, false);
+       TraversingVisitor::visit(ternary);
 }
 
 void UnusedVariableRemover::visit(Assignment &assign)
@@ -1014,6 +1223,7 @@ void UnusedVariableRemover::visit(Assignment &assign)
 
 void UnusedVariableRemover::visit(FunctionCall &call)
 {
+       SetFlag clear_composite(composite_reference, false);
        TraversingVisitor::visit(call);
        /* Treat function calls as having side effects so expression statements
        consisting of nothing but a function call won't be optimized away. */
@@ -1021,9 +1231,9 @@ void UnusedVariableRemover::visit(FunctionCall &call)
 
        if(stage->type==Stage::GEOMETRY && call.name=="EmitVertex")
        {
-               for(map<Statement *, VariableInfo>::const_iterator i=variables.begin(); i!=variables.end(); ++i)
-                       if(i->second.output)
-                               referenced(i->first, call);
+               for(const auto &kvp: variables)
+                       if(kvp.second.output)
+                               referenced(kvp.first, call);
        }
 }
 
@@ -1033,11 +1243,12 @@ void UnusedVariableRemover::record_assignment(const Assignment::Target &target,
        AssignmentInfo &assign_info = assignments.back();
        assign_info.node = &node;
        assign_info.target = target;
+       assign_info.in_loop = in_loop;
 
        /* An assignment to the target hides any assignments to the same target or
        its subfields. */
        VariableInfo &var_info = variables[target.declaration];
-       for(unsigned i=0; i<var_info.assignments.size(); ++i)
+       for(unsigned i=0; i<var_info.assignments.size(); )
        {
                const Assignment::Target &t = var_info.assignments[i]->target;
 
@@ -1065,15 +1276,26 @@ void UnusedVariableRemover::visit(ExpressionStatement &expr)
                unused_nodes.insert(&expr);
 }
 
+void UnusedVariableRemover::visit(StructDeclaration &strct)
+{
+       SetFlag set_struct(in_struct);
+       TraversingVisitor::visit(strct);
+}
+
 void UnusedVariableRemover::visit(VariableDeclaration &var)
 {
+       TraversingVisitor::visit(var);
+
+       if(in_struct)
+               return;
+
        VariableInfo &var_info = variables[&var];
        var_info.interface_block = interface_block;
 
        /* Mark variables as output if they're used by the next stage or the
        graphics API. */
        if(interface_block)
-               var_info.output = (interface_block->interface=="out" && (interface_block->linked_block || !interface_block->name.compare(0, 3, "gl_")));
+               var_info.output = (interface_block->interface=="out" && (interface_block->linked_block || !interface_block->block_name.compare(0, 3, "gl_")));
        else
                var_info.output = (var.interface=="out" && (stage->type==Stage::FRAGMENT || var.linked_declaration || !var.name.compare(0, 3, "gl_")));
 
@@ -1082,43 +1304,34 @@ void UnusedVariableRemover::visit(VariableDeclaration &var)
                var_info.initialized = true;
                record_assignment(&var, *var.init_expression);
        }
-       TraversingVisitor::visit(var);
 }
 
 void UnusedVariableRemover::visit(InterfaceBlock &iface)
 {
-       if(iface.instance_name.empty())
-       {
-               SetForScope<InterfaceBlock *> set_block(interface_block, &iface);
-               iface.struct_declaration->members.visit(*this);
-       }
-       else
-       {
-               VariableInfo &var_info = variables[&iface];
-               var_info.output = (iface.interface=="out" && (iface.linked_block || !iface.name.compare(0, 3, "gl_")));
-       }
+       VariableInfo &var_info = variables[&iface];
+       var_info.output = (iface.interface=="out" && (iface.linked_block || !iface.block_name.compare(0, 3, "gl_")));
 }
 
 void UnusedVariableRemover::merge_variables(const BlockVariableMap &other_vars)
 {
-       for(BlockVariableMap::const_iterator i=other_vars.begin(); i!=other_vars.end(); ++i)
+       for(const auto &kvp: other_vars)
        {
-               BlockVariableMap::iterator j = variables.find(i->first);
+               auto j = variables.find(kvp.first);
                if(j!=variables.end())
                {
                        /* The merged blocks started as copies of each other so any common
                        assignments must be in the beginning. */
                        unsigned k = 0;
-                       for(; (k<i->second.assignments.size() && k<j->second.assignments.size()); ++k)
-                               if(i->second.assignments[k]!=j->second.assignments[k])
+                       for(; (k<kvp.second.assignments.size() && k<j->second.assignments.size()); ++k)
+                               if(kvp.second.assignments[k]!=j->second.assignments[k])
                                        break;
 
                        // Remaining assignments are unique to each block; merge them.
-                       j->second.assignments.insert(j->second.assignments.end(), i->second.assignments.begin()+k, i->second.assignments.end());
-                       j->second.referenced |= i->second.referenced;
+                       j->second.assignments.insert(j->second.assignments.end(), kvp.second.assignments.begin()+k, kvp.second.assignments.end());
+                       j->second.referenced |= kvp.second.referenced;
                }
                else
-                       variables.insert(*i);
+                       variables.insert(kvp);
        }
 }
 
@@ -1129,17 +1342,17 @@ void UnusedVariableRemover::visit(FunctionDeclaration &func)
 
        BlockVariableMap saved_vars = variables;
        // Assignments from other functions should not be visible.
-       for(BlockVariableMap::iterator i=variables.begin(); i!=variables.end(); ++i)
-               i->second.assignments.resize(i->second.initialized);
+       for(auto &kvp: variables)
+               kvp.second.assignments.resize(kvp.second.initialized);
        TraversingVisitor::visit(func);
        swap(variables, saved_vars);
        merge_variables(saved_vars);
 
        /* Always treat function parameters as referenced.  Removing unused
        parameters is not currently supported. */
-       for(NodeArray<VariableDeclaration>::iterator i=func.parameters.begin(); i!=func.parameters.end(); ++i)
+       for(const RefPtr<VariableDeclaration> &p: func.parameters)
        {
-               BlockVariableMap::iterator j = variables.find(i->get());
+               auto j = variables.find(p.get());
                if(j!=variables.end())
                        j->second.referenced = true;
        }
@@ -1162,7 +1375,18 @@ void UnusedVariableRemover::visit(Conditional &cond)
 void UnusedVariableRemover::visit(Iteration &iter)
 {
        BlockVariableMap saved_vars = variables;
-       TraversingVisitor::visit(iter);
+       vector<Node *> saved_refs;
+       swap(loop_ext_refs, saved_refs);
+       {
+               SetForScope<unsigned> set_loop(in_loop, in_loop+1);
+               TraversingVisitor::visit(iter);
+       }
+       swap(loop_ext_refs, saved_refs);
+
+       /* Visit the external references of the loop again to record assignments
+       done in the loop as used. */
+       for(Node *n: saved_refs)
+               n->visit(*this);
 
        /* Merge assignments from the iteration, without clearing previous state.
        Further analysis is needed to determine which parts of the iteration body