Remove the separate allocation step from textures and buffers

[libs/gl.git] / source / core / texture1d.cpp

diff --git a/source/core/texture1d.cpp b/source/core/texture1d.cpp
index 7c3f02ab5f97988af099937eb6ed52254542b332..3fd1ae0955e88c1d432219506fe960db9e4ecdd2 100644 (file)
--- a/source/core/texture1d.cpp
+++ b/source/core/texture1d.cpp
@@ -11,8 +11,7 @@ namespace GL {
 
 Texture1D::Texture1D():
        Texture(GL_TEXTURE_1D),
-       width(0),
-       allocated(0)
+       width(0)
 {
        static Require _req(MSP_texture1D);
 }
@@ -33,58 +32,34 @@ void Texture1D::storage(PixelFormat fmt, unsigned wd, unsigned lv)
        levels = get_n_levels();
        if(lv)
                levels = min(levels, lv);
-}
-
-void Texture1D::allocate(unsigned level)
-{
-       if(width==0)
-               throw invalid_operation("Texture1D::allocate");
-       if(level>=levels)
-               throw invalid_argument("Texture1D::allocate");
-       if(allocated&(1<<level))
-               return;
 
+       GLenum gl_fmt = get_gl_pixelformat(storage_fmt);
        if(ARB_texture_storage)
        {
-               GLenum fmt = get_gl_pixelformat(storage_fmt);
                if(ARB_direct_state_access)
-                       glTextureStorage1D(id, levels, fmt, width);
+                       glTextureStorage1D(id, levels, gl_fmt, width);
                else
                {
                        bind_scratch();
-                       glTexStorage1D(target, levels, fmt, width);
+                       glTexStorage1D(target, levels, gl_fmt, width);
                }
-               apply_swizzle();
-               allocated |= (1<<levels)-1;
        }
        else
-               image(level, 0);
-}
-
-void Texture1D::image(unsigned level, const void *data)
-{
-       if(width==0)
-               throw invalid_operation("Texture1D::image");
-       if(level>=levels)
-               throw out_of_range("Texture1D::image");
-
-       if(ARB_texture_storage)
-               return sub_image(level, 0, get_level_size(level), data);
-
-       bind_scratch();
-
-       if(!allocated)
        {
+               bind_scratch();
                glTexParameteri(target, GL_TEXTURE_MAX_LEVEL, levels-1);
-               apply_swizzle();
+               GLenum comp = get_gl_components(get_components(storage_fmt));
+               GLenum type = get_gl_type(get_component_type(storage_fmt));
+               for(unsigned i=0; i<levels; ++i)
+                       glTexImage1D(target, i, gl_fmt, get_level_size(i), 0, comp, type, 0);
        }
 
-       GLenum fmt = get_gl_pixelformat(storage_fmt);
-       GLenum comp = get_gl_components(get_components(storage_fmt));
-       GLenum type = get_gl_type(get_component_type(storage_fmt));
-       glTexImage1D(target, level, fmt, get_level_size(level), 0, comp, type, data);
+       apply_swizzle();
+}
 
-       allocated |= 1<<level;
+void Texture1D::image(unsigned level, const void *data)
+{
+       return sub_image(level, 0, get_level_size(level), data);
 }
 
 void Texture1D::sub_image(unsigned level, int x, unsigned wd, const void *data)
@@ -94,8 +69,6 @@ void Texture1D::sub_image(unsigned level, int x, unsigned wd, const void *data)
        if(level>=levels)
                throw out_of_range("Texture1D::sub_image");
 
-       allocate(level);
-
        GLenum comp = get_gl_components(get_components(storage_fmt));
        GLenum type = get_gl_type(get_component_type(storage_fmt));
        if(ARB_direct_state_access)