Fix reflection of image types from Spir-V modules

[libs/gl.git] / source / core / module.h

diff --git a/source/core/module.h b/source/core/module.h
index 9ac54d328ee42a86b97fed32e82383a171138739..c669af0506ab64d26b25bf504ec28533e7e1cf92 100644 (file)
--- a/source/core/module.h
+++ b/source/core/module.h
@@ -6,6 +6,7 @@
 #include <vector>
 #include <msp/io/base.h>
 #include "datatype.h"
+#include "module_backend.h"
 #include "glsl/compiler.h"
 #include "glsl/sourcemap.h"
 
@@ -21,6 +22,14 @@ public:
 
 class Resources;
 
+/**
+Base class for shader modules.  Internal representation depends on the
+concrete type.
+
+Modules can be loaded from files.
+
+Applications normally use the Program class to access shaders.
+*/
 class Module
 {
 public:
@@ -37,13 +46,26 @@ public:
 
        virtual Format get_format() const = 0;
 
+       /** Sets the module's content from GLSL source code. */
        void set_source(const std::string &);
-       void load_source(IO::Base &, Resources *, const std::string &);
+
+       /** Loads GLSL source from a file or other I/O object.  Any import
+       statements are resolved using res. */
+       void load_source(IO::Base &, Resources *res, const std::string &name);
+
+       /** Loads GLSL source from a file or other I/O object.  Only builtin
+       shader fragments can be imported. */
        void load_source(IO::Base &, const std::string &);
+
 private:
        virtual void compile(SL::Compiler &) = 0;
+
+       SL::Features create_features() const;
 };
 
+/**
+A shader module in GLSL source code format.
+*/
 class GlslModule: public Module
 {
 private:
@@ -61,7 +83,16 @@ public:
        const SL::SourceMap &get_source_map() const { return source_map; }
 };
 
-class SpirVModule: public Module
+/**
+A shader module in SPIR-V binary format.
+
+When the module's contents are set from GLSL source, it will be automatically
+compiled to SPIR-V.  Pre-compiled SPIR-V modules can also be loaded.
+
+Afterwards reflection data is available, providing information about variables
+forming the module's interface.
+*/
+class SpirVModule: public Module, public SpirVModuleBackend
 {
 public:
        enum Stage
@@ -76,7 +107,8 @@ public:
                UNIFORM_CONSTANT = 0,
                INPUT = 1,
                UNIFORM = 2,
-               OUTPUT = 3
+               OUTPUT = 3,
+               PUSH_CONSTANT = 9
        };
 
        enum BuiltinSemantic
@@ -106,7 +138,6 @@ public:
                const Structure *struct_type = 0;
                unsigned offset = 0;
                unsigned array_size = 0;
-               const Constant *array_size_spec = 0;
                unsigned array_stride = 0;
                unsigned matrix_stride = 0;
                BuiltinSemantic builtin = NOT_BUILTIN;
@@ -125,10 +156,9 @@ public:
                StorageClass storage = static_cast<StorageClass>(-1);
                DataType type = VOID;
                const Structure *struct_type = 0;
-               const Constant *array_size_spec = 0;
                unsigned array_size = 0;
                int location = -1;
-               int descriptor_set = -1;
+               unsigned descriptor_set = 0;
                int binding = -1;
                BuiltinSemantic builtin = NOT_BUILTIN;
 
@@ -152,7 +182,6 @@ private:
        {
                DataType type = VOID;
                const Structure *struct_type = 0;
-               const Constant *array_size_spec = 0;
                unsigned array_size = 0;
                unsigned array_stride = 0;
                StorageClass storage = static_cast<StorageClass>(-1);
@@ -200,16 +229,10 @@ private:
        std::vector<Variable> variables;
        std::vector<Constant> spec_constants;
 
-public:
-       SpirVModule() = default;
-       SpirVModule(const SpirVModule &);
-       SpirVModule &operator=(const SpirVModule &);
-private:
-       void remap_pointers_from(const SpirVModule &);
-
 public:
        virtual Format get_format() const { return SPIR_V; }
 
+       /** Loads a SPIR-V binary from a file or other I/O object. */
        void load_code(IO::Base &);
 private:
        virtual void compile(SL::Compiler &);