Fix the stupid gtk combo box text reset issue for real

Lubomir's solution to fill them with a newline doesn't work.  Well, it
may work on some versions of gtk, but on mine it just results in an ugly
box for the control character '000a' that tries to show the newline.

So this is a third approach: if we reset the text to empty, first set it
to space (to clear it), and then set it to empty.  That seems to work on
at least one version of gtk, and doesn't have the problem with the space
*remaining* when you cut-and-paste something into the combo box.

Let's see if it breaks anything else, but at worst it should be no worse
than the old "set it to space" approach - iow the combo box might
remember the space, but at least not some random data from the previous
dive that it happened to show.

Lovely gtk bugs.

Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

diff --git a/info.c b/info.c
index 8436a1336b9ee84ae9e57fff1d277a03349da803..11107b1ca91c461eb41245bea72032238305f8fe 100644 (file)
--- a/info.c
+++ b/info.c
@@ -100,7 +100,7 @@ static void set_combo_box_entry_text(GtkComboBoxEntry *combo_box, const char *te
        GtkEntry *entry = GTK_ENTRY(gtk_bin_get_child(GTK_BIN(combo_box)));
        gtk_combo_box_set_active(GTK_COMBO_BOX(combo_box), -1);
        if (!*text)
-               text = "\n";
+               gtk_entry_set_text(entry, " ");
        gtk_entry_set_text(entry, text);
 }