]> git.tdb.fi Git - ext/subsurface.git/commitdiff
Merge branch 'master' into freediving-tweaks
authorMaximilian Güntner <maximilian.guentner@gmail.com>
Tue, 21 Aug 2012 23:15:41 +0000 (01:15 +0200)
committerMaximilian Güntner <maximilian.guentner@gmail.com>
Tue, 21 Aug 2012 23:15:41 +0000 (01:15 +0200)
Signed-off-by: Maximilian Güntner <maximilian.guentner@gmail.com>
1  2 
gtk-gui.c
profile.c

diff --combined gtk-gui.c
index 4b9f002af60d5967c30338e607ed229e0b9fbd78,306e1a5e715ab8e5a6e890c3ce431cc2970ac218..f25fbaa53f6588a7968219784190d0cdcf4fff26
+++ b/gtk-gui.c
@@@ -21,8 -21,9 +21,10 @@@ GtkWidget *main_vbox
  GtkWidget *error_info_bar;
  GtkWidget *error_label;
  GtkWidget *vpane, *hpane;
+ GtkWidget *notebook;
  int        error_count;
 +extern char zoomed_plot;
  
  const char *divelist_font;
  
@@@ -32,12 -33,14 +34,14 @@@ static GtkWidget *dive_profile
  
  visible_cols_t visible_cols = {TRUE, FALSE};
  
- static const char *default_dive_computer;
+ static const char *default_dive_computer_vendor;
+ static const char *default_dive_computer_product;
  static const char *default_dive_computer_device;
  
- static int is_default_dive_computer(const char *name)
+ static int is_default_dive_computer(const char *vendor, const char *product)
  {
-       return default_dive_computer && !strcmp(name, default_dive_computer);
+       return default_dive_computer_vendor && !strcmp(vendor, default_dive_computer_vendor) &&
+               default_dive_computer_product && !strcmp(product, default_dive_computer_product);
  }
  
  static int is_default_dive_computer_device(const char *name)
        return default_dive_computer_device && !strcmp(name, default_dive_computer_device);
  }
  
- static void set_default_dive_computer(const char *name)
+ static void set_default_dive_computer(const char *vendor, const char *product)
  {
-       if (!name || !*name)
+       if (!vendor || !*vendor)
+               return;
+       if (!product || !*product)
                return;
-       if (is_default_dive_computer(name))
+       if (is_default_dive_computer(vendor, product))
                return;
-       default_dive_computer = name;
-       subsurface_set_conf("dive_computer", PREF_STRING, name);
+       default_dive_computer_vendor = vendor;
+       default_dive_computer_product = product;
+       subsurface_set_conf("dive_computer_vendor", PREF_STRING, vendor);
+       subsurface_set_conf("dive_computer_product", PREF_STRING, product);
  }
  
  static void set_default_dive_computer_device(const char *name)
@@@ -165,48 -172,75 +173,75 @@@ static void file_open(GtkWidget *w, gpo
        gtk_widget_destroy(dialog);
  }
  
- static void file_save(GtkWidget *w, gpointer data)
+ static void file_save_as(GtkWidget *w, gpointer data)
  {
        GtkWidget *dialog;
-       dialog = gtk_file_chooser_dialog_new("Save File",
+       char *filename = NULL;
+       dialog = gtk_file_chooser_dialog_new("Save File As",
                GTK_WINDOW(main_window),
                GTK_FILE_CHOOSER_ACTION_SAVE,
                GTK_STOCK_CANCEL, GTK_RESPONSE_CANCEL,
                GTK_STOCK_SAVE, GTK_RESPONSE_ACCEPT,
                NULL);
        gtk_file_chooser_set_do_overwrite_confirmation(GTK_FILE_CHOOSER(dialog), TRUE);
-       if (!existing_filename) {
-               gtk_file_chooser_set_current_name(GTK_FILE_CHOOSER(dialog), "Untitled document");
-       } else
-               gtk_file_chooser_set_filename(GTK_FILE_CHOOSER(dialog), existing_filename);
  
+       gtk_file_chooser_set_current_name(GTK_FILE_CHOOSER(dialog), existing_filename);
        if (gtk_dialog_run(GTK_DIALOG(dialog)) == GTK_RESPONSE_ACCEPT) {
-               char *filename;
                filename = gtk_file_chooser_get_filename(GTK_FILE_CHOOSER(dialog));
+       }
+       gtk_widget_destroy(dialog);
+       if (filename){
                save_dives(filename);
+               set_filename(filename);
                g_free(filename);
                mark_divelist_changed(FALSE);
        }
-       gtk_widget_destroy(dialog);
  }
  
- static void ask_save_changes()
+ static void file_save(GtkWidget *w, gpointer data)
+ {
+       if (!existing_filename)
+               return file_save_as(w, data);
+       save_dives(existing_filename);
+       mark_divelist_changed(FALSE);
+ }
+ static gboolean ask_save_changes()
  {
        GtkWidget *dialog, *label, *content;
+       gboolean quit = TRUE;
        dialog = gtk_dialog_new_with_buttons("Save Changes?",
                GTK_WINDOW(main_window), GTK_DIALOG_MODAL | GTK_DIALOG_DESTROY_WITH_PARENT,
                GTK_STOCK_SAVE, GTK_RESPONSE_ACCEPT,
                GTK_STOCK_NO, GTK_RESPONSE_NO,
+               GTK_STOCK_CANCEL, GTK_RESPONSE_CANCEL,
                NULL);
        content = gtk_dialog_get_content_area (GTK_DIALOG (dialog));
-       label = gtk_label_new ("You have unsaved changes\nWould you like to save those before exiting the program?");
+       if (!existing_filename){
+               label = gtk_label_new (
+                       "You have unsaved changes\nWould you like to save those before exiting the program?");
+       } else {
+               char *label_text = (char*) malloc(sizeof(char) * (92 + strlen(existing_filename)));
+               sprintf(label_text,
+                       "You have unsaved changes to file: %s \nWould you like to save those before exiting the program?",
+                       existing_filename);
+               label = gtk_label_new (label_text);
+               g_free(label_text);
+       }
        gtk_container_add (GTK_CONTAINER (content), label);
        gtk_widget_show_all (dialog);
        gtk_dialog_set_default_response(GTK_DIALOG(dialog), GTK_RESPONSE_ACCEPT);
-       if (gtk_dialog_run(GTK_DIALOG(dialog)) == GTK_RESPONSE_ACCEPT) {
+       gint outcode = gtk_dialog_run(GTK_DIALOG(dialog));
+       if (outcode == GTK_RESPONSE_ACCEPT) {
                file_save(NULL,NULL);
+       } else if (outcode == GTK_RESPONSE_CANCEL) {
+               quit = FALSE;
        }
        gtk_widget_destroy(dialog);
+       return quit;
  }
  
  static gboolean on_delete(GtkWidget* w, gpointer data)
        /* Make sure to flush any modified dive data */
        update_dive(NULL);
  
+       gboolean quit = TRUE;
        if (unsaved_changes())
-               ask_save_changes();
+               quit = ask_save_changes();
  
-       return FALSE; /* go ahead, kill the program, we're good now */
+       if (quit){
+               return FALSE; /* go ahead, kill the program, we're good now */
+       } else {
+               return TRUE; /* We are not leaving */
+       }
  }
  
  static void on_destroy(GtkWidget* w, gpointer data)
@@@ -230,9 -269,13 +270,13 @@@ static void quit(GtkWidget *w, gpointe
        /* Make sure to flush any modified dive data */
        update_dive(NULL);
  
+       gboolean quit = TRUE;
        if (unsaved_changes())
-               ask_save_changes();
-       gtk_main_quit();
+               quit = ask_save_changes();
+       if (quit){
+               gtk_main_quit();
+       }
  }
  
  GtkTreeViewColumn *tree_view_column(GtkWidget *tree_view, int index, const char *title,
@@@ -343,6 -386,8 +387,8 @@@ OPTIONCALLBACK(otu_toggle, visible_cols
  OPTIONCALLBACK(sac_toggle, visible_cols.sac)
  OPTIONCALLBACK(nitrox_toggle, visible_cols.nitrox)
  OPTIONCALLBACK(temperature_toggle, visible_cols.temperature)
+ OPTIONCALLBACK(totalweight_toggle, visible_cols.totalweight)
+ OPTIONCALLBACK(suit_toggle, visible_cols.suit)
  OPTIONCALLBACK(cylinder_toggle, visible_cols.cylinder)
  
  static void event_toggle(GtkWidget *w, gpointer _data)
@@@ -398,37 -443,47 +444,47 @@@ static void preferences_dialog(GtkWidge
                "lbs",  set_lbs, (output_units.weight == LBS),
                NULL);
  
-       frame = gtk_frame_new("Columns");
+       frame = gtk_frame_new("Show Columns");
        gtk_box_pack_start(GTK_BOX(GTK_DIALOG(dialog)->vbox), frame, FALSE, FALSE, 5);
  
        box = gtk_hbox_new(FALSE, 6);
        gtk_container_add(GTK_CONTAINER(frame), box);
  
-       button = gtk_check_button_new_with_label("Show Temp");
+       button = gtk_check_button_new_with_label("Temp");
        gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(button), visible_cols.temperature);
        gtk_box_pack_start(GTK_BOX(box), button, FALSE, FALSE, 6);
        g_signal_connect(G_OBJECT(button), "toggled", G_CALLBACK(temperature_toggle), NULL);
  
-       button = gtk_check_button_new_with_label("Show Cyl");
+       button = gtk_check_button_new_with_label("Cyl");
        gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(button), visible_cols.cylinder);
        gtk_box_pack_start(GTK_BOX(box), button, FALSE, FALSE, 6);
        g_signal_connect(G_OBJECT(button), "toggled", G_CALLBACK(cylinder_toggle), NULL);
  
-       button = gtk_check_button_new_with_label("Show O" UTF8_SUBSCRIPT_2 "%");
+       button = gtk_check_button_new_with_label("O" UTF8_SUBSCRIPT_2 "%");
        gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(button), visible_cols.nitrox);
        gtk_box_pack_start(GTK_BOX(box), button, FALSE, FALSE, 6);
        g_signal_connect(G_OBJECT(button), "toggled", G_CALLBACK(nitrox_toggle), NULL);
  
-       button = gtk_check_button_new_with_label("Show SAC");
+       button = gtk_check_button_new_with_label("SAC");
        gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(button), visible_cols.sac);
        gtk_box_pack_start(GTK_BOX(box), button, FALSE, FALSE, 6);
        g_signal_connect(G_OBJECT(button), "toggled", G_CALLBACK(sac_toggle), NULL);
  
-       button = gtk_check_button_new_with_label("Show OTU");
+       button = gtk_check_button_new_with_label("OTU");
        gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(button), visible_cols.otu);
        gtk_box_pack_start(GTK_BOX(box), button, FALSE, FALSE, 6);
        g_signal_connect(G_OBJECT(button), "toggled", G_CALLBACK(otu_toggle), NULL);
  
+       button = gtk_check_button_new_with_label("Weight");
+       gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(button), visible_cols.totalweight);
+       gtk_box_pack_start(GTK_BOX(box), button, FALSE, FALSE, 6);
+       g_signal_connect(G_OBJECT(button), "toggled", G_CALLBACK(totalweight_toggle), NULL);
+       button = gtk_check_button_new_with_label("Suit");
+       gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(button), visible_cols.suit);
+       gtk_box_pack_start(GTK_BOX(box), button, FALSE, FALSE, 6);
+       g_signal_connect(G_OBJECT(button), "toggled", G_CALLBACK(suit_toggle), NULL);
        font = gtk_font_button_new_with_font(divelist_font);
        gtk_box_pack_start(GTK_BOX(vbox), font, FALSE, FALSE, 5);
  
                subsurface_set_conf("fahrenheit", PREF_BOOL, BOOL_TO_PTR(output_units.temperature == FAHRENHEIT));
                subsurface_set_conf("lbs", PREF_BOOL, BOOL_TO_PTR(output_units.weight == LBS));
                subsurface_set_conf("TEMPERATURE", PREF_BOOL, BOOL_TO_PTR(visible_cols.temperature));
+               subsurface_set_conf("TOTALWEIGHT", PREF_BOOL, BOOL_TO_PTR(visible_cols.totalweight));
+               subsurface_set_conf("SUIT", PREF_BOOL, BOOL_TO_PTR(visible_cols.suit));
                subsurface_set_conf("CYLINDER", PREF_BOOL, BOOL_TO_PTR(visible_cols.cylinder));
                subsurface_set_conf("NITROX", PREF_BOOL, BOOL_TO_PTR(visible_cols.nitrox));
                subsurface_set_conf("SAC", PREF_BOOL, BOOL_TO_PTR(visible_cols.sac));
@@@ -604,31 -661,32 +662,39 @@@ static void view_info(GtkWidget *w, gpo
        gtk_paned_set_position(GTK_PANED(hpane), 65535);
  }
  
- /* Ooh. I don't know how to get the half-way size. So I'm just using random numbers */
  static void view_three(GtkWidget *w, gpointer data)
  {
-       gtk_paned_set_position(GTK_PANED(hpane), 400);
-       gtk_paned_set_position(GTK_PANED(vpane), 200);
+       GtkAllocation alloc;
+       GtkRequisition requisition;
+       gtk_widget_get_allocation(hpane, &alloc);
+       gtk_paned_set_position(GTK_PANED(hpane), alloc.width/2);
+       gtk_widget_get_allocation(vpane, &alloc);
+       gtk_widget_size_request(notebook, &requisition);
+       /* pick the requested size for the notebook plus 6 pixels for frame */
+       gtk_paned_set_position(GTK_PANED(vpane), requisition.height + 6);
  }
  
 +static void toggle_zoom(GtkWidget *w, gpointer data)
 +{
 +      zoomed_plot = (zoomed_plot)?0 : 1;
 +      /*Update dive*/
 +      repaint_dive();
 +}
 +
  static GtkActionEntry menu_items[] = {
-       { "FileMenuAction", GTK_STOCK_FILE, "File", NULL, NULL, NULL},
-       { "LogMenuAction",  GTK_STOCK_FILE, "Log", NULL, NULL, NULL},
-       { "ViewMenuAction",  GTK_STOCK_FILE, "View", NULL, NULL, NULL},
-       { "FilterMenuAction",  GTK_STOCK_FILE, "Filter", NULL, NULL, NULL},
-       { "HelpMenuAction", GTK_STOCK_HELP, "Help", NULL, NULL, NULL},
+       { "FileMenuAction", NULL, "File", NULL, NULL, NULL},
+       { "LogMenuAction",  NULL, "Log", NULL, NULL, NULL},
+       { "ViewMenuAction",  NULL, "View", NULL, NULL, NULL},
+       { "FilterMenuAction",  NULL, "Filter", NULL, NULL, NULL},
+       { "HelpMenuAction", NULL, "Help", NULL, NULL, NULL},
        { "OpenFile",       GTK_STOCK_OPEN, NULL,   CTRLCHAR "O", NULL, G_CALLBACK(file_open) },
        { "SaveFile",       GTK_STOCK_SAVE, NULL,   CTRLCHAR "S", NULL, G_CALLBACK(file_save) },
+       { "SaveAsFile",     GTK_STOCK_SAVE_AS, NULL,   SHIFTCHAR CTRLCHAR "S", NULL, G_CALLBACK(file_save_as) },
        { "Print",          GTK_STOCK_PRINT, NULL,  CTRLCHAR "P", NULL, G_CALLBACK(do_print) },
        { "Import",         NULL, "Import", NULL, NULL, G_CALLBACK(import_dialog) },
-       { "Preferences",    NULL, "Preferences", PREFERENCE_ACCEL, NULL, G_CALLBACK(preferences_dialog) },
+       { "AddDive",        GTK_STOCK_ADD, "Add Dive", NULL, NULL, G_CALLBACK(add_dive_cb) },
+       { "Preferences",    GTK_STOCK_PREFERENCES, "Preferences", PREFERENCE_ACCEL, NULL, G_CALLBACK(preferences_dialog) },
        { "Renumber",       NULL, "Renumber", NULL, NULL, G_CALLBACK(renumber_dialog) },
        { "SelectEvents",   NULL, "SelectEvents", NULL, NULL, G_CALLBACK(selectevents_dialog) },
        { "Quit",           GTK_STOCK_QUIT, NULL,   CTRLCHAR "Q", NULL, G_CALLBACK(quit) },
        { "ViewList",       NULL, "List",  CTRLCHAR "1", NULL, G_CALLBACK(view_list) },
        { "ViewProfile",    NULL, "Profile", CTRLCHAR "2", NULL, G_CALLBACK(view_profile) },
        { "ViewInfo",       NULL, "Info", CTRLCHAR "3", NULL, G_CALLBACK(view_info) },
 -      { "ViewThree",       NULL, "Three", CTRLCHAR "4", NULL, G_CALLBACK(view_three) },
 +      { "ViewThree",      NULL, "Three", CTRLCHAR "4", NULL, G_CALLBACK(view_three) },
 +      { "ToggleZoom",     NULL, "Toggle Zoom", CTRLCHAR "0", NULL, G_CALLBACK(toggle_zoom) },
  };
  static gint nmenu_items = sizeof (menu_items) / sizeof (menu_items[0]);
  
@@@ -647,6 -704,7 +713,7 @@@ static const gchar* ui_string = " 
                        <menu name=\"FileMenu\" action=\"FileMenuAction\"> \
                                <menuitem name=\"Open\" action=\"OpenFile\" /> \
                                <menuitem name=\"Save\" action=\"SaveFile\" /> \
+                               <menuitem name=\"Save As\" action=\"SaveAsFile\" /> \
                                <menuitem name=\"Print\" action=\"Print\" /> \
                                <separator name=\"Separator1\"/> \
                                <menuitem name=\"Preferences\" action=\"Preferences\" /> \
                        </menu> \
                        <menu name=\"LogMenu\" action=\"LogMenuAction\"> \
                                <menuitem name=\"Import\" action=\"Import\" /> \
+                               <menuitem name=\"Add Dive\" action=\"AddDive\" /> \
                                <separator name=\"Separator\"/> \
                                <menuitem name=\"Renumber\" action=\"Renumber\" /> \
 +                              <menuitem name=\"Toggle Zoom\" action=\"ToggleZoom\" /> \
                                <menu name=\"View\" action=\"ViewMenuAction\"> \
                                        <menuitem name=\"List\" action=\"ViewList\" /> \
                                        <menuitem name=\"Profile\" action=\"ViewProfile\" /> \
@@@ -698,11 -756,11 +766,11 @@@ static void switch_page(GtkNotebook *no
  void init_ui(int *argcp, char ***argvp)
  {
        GtkWidget *win;
-       GtkWidget *notebook;
        GtkWidget *nb_page;
        GtkWidget *dive_list;
        GtkWidget *menubar;
        GtkWidget *vbox;
+       GtkWidget *scrolled;
        GdkScreen *screen;
        GtkIconTheme *icon_theme=NULL;
        GtkSettings *settings;
        /* an unset key is FALSE - all these are hidden by default */
        visible_cols.cylinder = PTR_TO_BOOL(subsurface_get_conf("CYLINDER", PREF_BOOL));
        visible_cols.temperature = PTR_TO_BOOL(subsurface_get_conf("TEMPERATURE", PREF_BOOL));
+       visible_cols.totalweight = PTR_TO_BOOL(subsurface_get_conf("TOTALWEIGHT", PREF_BOOL));
+       visible_cols.suit = PTR_TO_BOOL(subsurface_get_conf("SUIT", PREF_BOOL));
        visible_cols.nitrox = PTR_TO_BOOL(subsurface_get_conf("NITROX", PREF_BOOL));
        visible_cols.otu = PTR_TO_BOOL(subsurface_get_conf("OTU", PREF_BOOL));
        visible_cols.sac = PTR_TO_BOOL(subsurface_get_conf("SAC", PREF_BOOL));
  
        divelist_font = subsurface_get_conf("divelist_font", PREF_STRING);
  
-       default_dive_computer = subsurface_get_conf("dive_computer", PREF_STRING);
+       default_dive_computer_vendor = subsurface_get_conf("dive_computer_vendor", PREF_STRING);
+       default_dive_computer_product = subsurface_get_conf("dive_computer_product", PREF_STRING);
        default_dive_computer_device = subsurface_get_conf("dive_computer_device", PREF_STRING);
  
        error_info_bar = NULL;
  
        vpane = gtk_vpaned_new();
        gtk_box_pack_start(GTK_BOX(vbox), vpane, TRUE, TRUE, 3);
        hpane = gtk_hpaned_new();
        gtk_paned_add1(GTK_PANED(vpane), hpane);
+       g_signal_connect_after(G_OBJECT(vbox), "realize", G_CALLBACK(view_three), NULL);
  
        /* Notebook for dive info vs profile vs .. */
        notebook = gtk_notebook_new();
-       gtk_paned_add1(GTK_PANED(hpane), notebook);
+       scrolled = gtk_scrolled_window_new(NULL, NULL);
+       gtk_scrolled_window_set_policy(GTK_SCROLLED_WINDOW(scrolled), GTK_POLICY_NEVER, GTK_POLICY_AUTOMATIC);
+       gtk_paned_add1(GTK_PANED(hpane), scrolled);
+       gtk_scrolled_window_add_with_viewport(GTK_SCROLLED_WINDOW(scrolled), notebook);
        g_signal_connect(notebook, "switch-page", G_CALLBACK(switch_page), NULL);
  
        /* Create the actual divelist */
        gtk_notebook_append_page(GTK_NOTEBOOK(notebook), nb_page, gtk_label_new("Dive Notes"));
  
        /* Frame for dive equipment */
-       nb_page = equipment_widget();
+       nb_page = equipment_widget(W_IDX_PRIMARY);
        gtk_notebook_append_page(GTK_NOTEBOOK(notebook), nb_page, gtk_label_new("Equipment"));
  
        /* Frame for single dive statistics */
@@@ -924,20 -988,45 +998,45 @@@ static int fill_computer_list(GtkListSt
  {
        int index = -1, i;
        GtkTreeIter iter;
-       struct device_list *list = device_list;
+       dc_iterator_t *iterator = NULL;
+       dc_descriptor_t *descriptor = NULL;
+       i = 0;
+       dc_descriptor_iterator(&iterator);
+       while (dc_iterator_next (iterator, &descriptor) == DC_STATUS_SUCCESS) {
+               const char *vendor = dc_descriptor_get_vendor(descriptor);
+               const char *product = dc_descriptor_get_product(descriptor);
  
-       for (list = device_list, i = 0 ; list->name ; list++, i++) {
                gtk_list_store_append(store, &iter);
                gtk_list_store_set(store, &iter,
-                       0, list->name,
-                       1, list->type,
+                       0, descriptor,
                        -1);
-               if (is_default_dive_computer(list->name))
+               if (is_default_dive_computer(vendor, product))
                        index = i;
+               i++;
        }
+       dc_iterator_free(iterator);
        return index;
  }
  
+ void render_dive_computer(GtkCellLayout *cell,
+               GtkCellRenderer *renderer,
+               GtkTreeModel *model,
+               GtkTreeIter *iter,
+               gpointer data)
+ {
+       char buffer[40];
+       dc_descriptor_t *descriptor = NULL;
+       const char *vendor, *product;
+       gtk_tree_model_get(model, iter, 0, &descriptor, -1);
+       vendor = dc_descriptor_get_vendor(descriptor);
+       product = dc_descriptor_get_product(descriptor);
+       snprintf(buffer, sizeof(buffer), "%s %s", vendor, product);
+       g_object_set(renderer, "text", buffer, NULL);
+ }
  static GtkComboBox *dive_computer_selector(GtkWidget *vbox)
  {
        GtkWidget *hbox, *combo_box, *frame;
        hbox = gtk_hbox_new(FALSE, 6);
        gtk_box_pack_start(GTK_BOX(vbox), hbox, FALSE, FALSE, 3);
  
-       model = gtk_list_store_new(2, G_TYPE_STRING, G_TYPE_INT);
+       model = gtk_list_store_new(1, G_TYPE_POINTER);
        default_index = fill_computer_list(model);
  
        frame = gtk_frame_new("Dive computer");
  
        renderer = gtk_cell_renderer_text_new();
        gtk_cell_layout_pack_start(GTK_CELL_LAYOUT(combo_box), renderer, TRUE);
-       gtk_cell_layout_set_attributes(GTK_CELL_LAYOUT(combo_box), renderer, "text", 0, NULL);
+       gtk_cell_layout_set_cell_data_func(GTK_CELL_LAYOUT(combo_box), renderer, render_dive_computer, NULL, NULL);
  
        gtk_combo_box_set_active(GTK_COMBO_BOX(combo_box), default_index);
  
@@@ -1104,10 -1193,9 +1203,9 @@@ repeat
        gtk_widget_show_all(dialog);
        result = gtk_dialog_run(GTK_DIALOG(dialog));
        switch (result) {
-               int type;
+               dc_descriptor_t *descriptor;
                GtkTreeIter iter;
                GtkTreeModel *model;
-               const char *comp;
                GSList *list;
        case GTK_RESPONSE_ACCEPT:
                /* what happened - did the user pick a file? In that case
                        gtk_widget_destroy(info);
                list = gtk_file_chooser_get_filenames(GTK_FILE_CHOOSER(XMLchooser));
                if (g_slist_length(list) == 0) {
+                       const char *vendor, *product;
                        if (!gtk_combo_box_get_active_iter(computer, &iter))
                                break;
                        model = gtk_combo_box_get_model(computer);
                        gtk_tree_model_get(model, &iter,
-                                       0, &comp,
-                                       1, &type,
+                                       0, &descriptor,
                                        -1);
-                       devicedata.type = type;
-                       devicedata.name = comp;
+                       vendor = dc_descriptor_get_vendor(descriptor);
+                       product = dc_descriptor_get_product(descriptor);
+                       devicedata.descriptor = descriptor;
+                       devicedata.vendor = vendor;
+                       devicedata.product = product;
                        devicedata.devname = gtk_entry_get_text(device);
-                       set_default_dive_computer(devicedata.name);
+                       set_default_dive_computer(vendor, product);
                        set_default_dive_computer_device(devicedata.devname);
                        info = import_dive_computer(&devicedata, GTK_DIALOG(dialog));
                        if (info)
@@@ -1156,7 -1250,9 +1260,9 @@@ void update_progressbar_text(progressba
  
  void set_filename(const char *filename)
  {
-       if (!existing_filename && filename)
+       if (existing_filename)
+               free(existing_filename);
+       existing_filename = NULL;
+       if (filename)
                existing_filename = strdup(filename);
-       return;
  }
diff --combined profile.c
index fedc700b4dd1679703e60b33345199bb00c993cb,9618c4680c86f5d146b9bb8a550148a90160bca4..97ea9077d480f871436e89940838f962f72a1d3e
+++ b/profile.c
@@@ -14,7 -14,6 +14,7 @@@
  #include "color.h"
  
  int selected_dive = 0;
 +char zoomed_plot = 0;
  
  typedef enum { STABLE, SLOW, MODERATE, FAST, CRAZY } velocity_t;
  
@@@ -181,40 -180,22 +181,40 @@@ static void dump_pi (struct plot_info *
   * When showing dive profiles, we scale things to the
   * current dive. However, we don't scale past less than
   * 30 minutes or 90 ft, just so that small dives show
 - * up as such.
 - * we also need to add 180 seconds at the end so the min/max
 + * up as such unless zoom is enabled.
 + * We also need to add 180 seconds at the end so the min/max
   * plots correctly
   */
  static int get_maxtime(struct plot_info *pi)
  {
        int seconds = pi->maxtime;
 -      /* min 30 minutes, rounded up to 5 minutes, with at least 2.5 minutes to spare */
 -      return MAX(30*60, ROUND_UP(seconds+150, 60*5));
 +      if (zoomed_plot) {
 +              /* Rounded up to one minute, with at least 2.5 minutes to
 +               * spare.
 +               * For dive times shorter than 10 minutes, we use seconds/4 to
 +               * calculate the space dynamically.
 +               * This is seamless since 600/4 = 150.
 +               */
 +              if ( seconds < 600 )
 +                      return ROUND_UP(seconds+seconds/4, 60);
 +              else
 +                      return ROUND_UP(seconds+150, 60);
 +      } else {
 +              /* min 30 minutes, rounded up to 5 minutes, with at least 2.5 minutes to spare */
 +              return MAX(30*60, ROUND_UP(seconds+150, 60*5));
 +      }
  }
  
  static int get_maxdepth(struct plot_info *pi)
  {
        unsigned mm = pi->maxdepth;
 -      /* Minimum 30m, rounded up to 10m, with at least 3m to spare */
 -      return MAX(30000, ROUND_UP(mm+3000, 10000));
 +      if (zoomed_plot) {
 +              /* Rounded up to 10m, with at least 3m to spare */
 +              return ROUND_UP(mm+3000, 10000);
 +      } else {
 +              /* Minimum 30m, rounded up to 10m, with at least 3m to spare */
 +              return MAX(30000, ROUND_UP(mm+3000, 10000));
 +      }
  }
  
  typedef struct {
@@@ -462,21 -443,20 +462,21 @@@ static void plot_depth_profile(struct g
        int sec, depth;
        struct plot_data *entry;
        int maxtime, maxdepth, marker;
 -      int increments[4] = { 5*60, 10*60, 15*60, 30*60 };
 +      int increments[8] = { 10, 20, 30, 60, 5*60, 10*60, 15*60, 30*60 };
  
        /* Get plot scaling limits */
        maxtime = get_maxtime(pi);
        maxdepth = get_maxdepth(pi);
  
 -      /* Time markers: at most every 5 min, but no more than 12 markers
 -       * and for convenience we do 5, 10, 15 or 30 min intervals.
 +      /* Time markers: at most every 10 seconds, but no more than 12 markers.
 +       * We start out with 10 seconds and increment up to 30 minutes,
 +       * depending on the dive time.
         * This allows for 6h dives - enough (I hope) for even the craziest
         * divers - but just in case, for those 8h depth-record-breaking dives,
         * we double the interval if this still doesn't get us to 12 or fewer
         * time markers */
        i = 0;
 -      while (maxtime / increments[i] > 12 && i < 4)
 +      while (maxtime / increments[i] > 12 && i < 8)
                i++;
        incr = increments[i];
        while (maxtime / incr > 12)
        }
        cairo_stroke(cr);
  
 -      /* now the text on every second time marker */
 +      /* now the text on the time markers */
        text_render_options_t tro = {10, TIME_TEXT, CENTER, TOP};
 -      for (i = incr; i < maxtime; i += 2 * incr)
 -              plot_text(gc, &tro, i, 1, "%d", i/60);
 -
 +      if (maxtime < 600) {
 +              /* Be a bit more verbose with shorter dives */
 +              for (i = incr; i < maxtime; i += incr)
 +                      plot_text(gc, &tro, i, 1, "%d:%d", i/60, i%60);
 +      } else {
 +              /* Only render the time on every second marker for normal dives */
 +              for (i = incr; i < maxtime; i += 2 * incr)
 +                      plot_text(gc, &tro, i, 1, "%d", i/60);
 +      }
        /* Depth markers: every 30 ft or 10 m*/
        gc->leftx = 0; gc->rightx = 1.0;
        gc->topy = 0; gc->bottomy = maxdepth;
@@@ -1074,16 -1048,18 +1074,18 @@@ static void fill_missing_tank_pressures
                                /* there may be multiple segments - so
                                 * let's assemble the length */
                                nlist = list;
-                               pt = list->pressure_time;
-                               while (!nlist->end) {
-                                       nlist = nlist->next;
-                                       if (!nlist) {
-                                               /* oops - we have no end pressure,
-                                                * so this means this is a tank without
-                                                * gas consumption information */
-                                               break;
+                               if (list) {
+                                       pt = list->pressure_time;
+                                       while (!nlist->end) {
+                                               nlist = nlist->next;
+                                               if (!nlist) {
+                                                       /* oops - we have no end pressure,
+                                                        * so this means this is a tank without
+                                                        * gas consumption information */
+                                                       break;
+                                               }
+                                               pt += nlist->pressure_time;
                                        }
-                                       pt += nlist->pressure_time;
                                }
                                if (!nlist) {
                                        /* just continue without calculating
@@@ -1380,12 -1356,15 +1382,15 @@@ void plot(struct graphics_context *gc, 
        int nr = dive->samples;
  
        if (!nr) {
+               /* The dive has no samples, so create a few fake ones.  This assumes an
+               ascent/descent rate of 9 m/min, which is just below the limit for FAST. */
                int duration = dive->duration.seconds;
                int maxdepth = dive->maxdepth.mm;
+               int asc_desc_time = dive->maxdepth.mm*60/9000;
                sample = fake;
-               fake[1].time.seconds = duration * 0.05;
+               fake[1].time.seconds = asc_desc_time;
                fake[1].depth.mm = maxdepth;
-               fake[2].time.seconds = duration * 0.95;
+               fake[2].time.seconds = duration - asc_desc_time;
                fake[2].depth.mm = maxdepth;
                fake[3].time.seconds = duration * 1.00;
                nr = 4;