]> git.tdb.fi Git - libs/gl.git/commitdiff
Always update program uniforms if uniform names have changed
authorMikko Rasa <tdb@tdb.fi>
Mon, 17 Nov 2014 16:24:34 +0000 (18:24 +0200)
committerMikko Rasa <tdb@tdb.fi>
Mon, 17 Nov 2014 16:24:34 +0000 (18:24 +0200)
It's possible for pu.used to be zero, in which case the original code
would never update it.

source/programdata.cpp

index 65e660f038949aa41353eb287382901a28918f25..4b39d196affa388f2db9d005a50be087a2ed6f14 100644 (file)
@@ -265,14 +265,15 @@ void ProgramData::apply() const
        Program::LayoutHash layout = prog->get_uniform_layout_hash();
        ProgramUniforms &pu = programs[layout];
 
-       if((dirty&pu.used)|pu.dirty)
+       Mask force_dirty = (dirty==ALL_ONES ? ALL_ONES : 0U);
+       Mask affected = (dirty&pu.used) | force_dirty;
+       if(affected|pu.dirty)
        {
                /* If the global dirty flag affects this program, add it to per-program
                dirty flags and clear the global flag.  A previously unseen program will
                always cause this to happen. */
-               if(dirty&pu.used)
+               if(affected)
                {
-                       Mask force_dirty = (dirty==ALL_ONES ? ALL_ONES : 0U);
                        for(BlockMap::iterator i=blocks.begin(); i!=blocks.end(); ++i)
                                i->second.dirty |= (dirty&i->second.used) | force_dirty;
                        for(ProgramMap::iterator i=programs.begin(); i!=programs.end(); ++i)