}
+void DeclarationValidator::apply(Stage &s, const Features &f)
+{
+ stage = &s;
+ features = f;
+ s.content.visit(*this);
+}
+
const char *DeclarationValidator::describe_variable(ScopeType scope)
{
switch(scope)
void DeclarationValidator::visit(Layout &layout)
{
+ bool push_constant = false;
+ bool binding = false;
for(const Layout::Qualifier &q: layout.qualifiers)
{
bool allowed = false;
allowed = (variable && scope==GLOBAL);
else if(q.name=="binding" || q.name=="set")
{
- if(q.name=="set")
+ binding = true;
+
+ if(q.name=="set" && features.target_api!=VULKAN)
{
error(layout, "Layout qualifier 'set' not allowed when targeting OpenGL");
continue;
err_descr = "non-matrix variable";
}
}
+ else if(q.name=="push_constant")
+ {
+ push_constant = true;
+ allowed = (iface_block && !variable && iface_block->interface=="uniform");
+ value = false;
+ }
if(!allowed)
{
else if(!value && q.has_value)
error(layout, format("Layout qualifier '%s' does not allow a value", q.name));
}
+
+ if(push_constant && binding)
+ error(layout, "Layout qualifier 'push_constant' not allowed together with 'binding' or 'set'");
}
void DeclarationValidator::visit(InterfaceLayout &layout)
error(var, format("Mismatched interface qualifier '%s' inside '%s' block", var.interface, iface_block->interface));
else if(scope==STRUCT || scope==FUNCTION)
error(var, format("Interface qualifier not allowed on %s", descr));
+ else if(scope==GLOBAL && variable->interface=="uniform" && features.target_api==VULKAN)
+ {
+ TypeDeclaration *type = variable->type_declaration;
+ while(BasicTypeDeclaration *basic = dynamic_cast<BasicTypeDeclaration *>(type))
+ type = basic->base_type;
+ if(!dynamic_cast<ImageTypeDeclaration *>(type))
+ error(var, "Interface qualifier 'uniform' not allowed on non-opaque variable in global scope");
+ }
}
TypeDeclaration *type = var.type_declaration;