]> git.tdb.fi Git - ext/subsurface.git/blobdiff - equipment.c
Make the cylinder table columns unsortable
[ext/subsurface.git] / equipment.c
index 4ac8e3e99dc14dd8140586f0ff07e9e892c50e7f..9c2b4054f31a3b668c2bf4507c5c4de915f55740 100644 (file)
@@ -34,9 +34,7 @@ enum {
 static struct {
        int max_index;
        GtkListStore *model;
-       GtkWidget *tree_view;
        GtkWidget *edit, *add, *del;
-       GtkTreeViewColumn *desc, *size, *workp, *startp, *endp, *o2, *he;
 } cylinder_list;
 
 struct cylinder_widget {
@@ -46,7 +44,7 @@ struct cylinder_widget {
        GtkComboBox *description;
        GtkSpinButton *size, *pressure;
        GtkWidget *start, *end, *pressure_button;
-       GtkWidget *o2, *gasmix_button;
+       GtkWidget *o2, *he, *gasmix_button;
 };
 
 /* we want bar - so let's not use our unit functions */
@@ -264,7 +262,8 @@ static void show_cylinder(cylinder_t *cyl, struct cylinder_widget *cylinder)
 {
        const char *desc;
        int ml, mbar;
-       double o2;
+       int gasmix;
+       double o2, he;
 
        /* Don't show uninitialized cylinder widgets */
        if (!cylinder->description)
@@ -280,15 +279,21 @@ static void show_cylinder(cylinder_t *cyl, struct cylinder_widget *cylinder)
        set_cylinder_type_spinbuttons(cylinder,
                cyl->type.size.mliter, cyl->type.workingpressure.mbar);
        set_cylinder_pressure_spinbuttons(cylinder, cyl);
+
+       gasmix = cyl->gasmix.o2.permille || cyl->gasmix.he.permille;
+       gtk_widget_set_sensitive(cylinder->o2, gasmix);
+       gtk_widget_set_sensitive(cylinder->he, gasmix);
+       gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(cylinder->gasmix_button), gasmix);
+
        o2 = cyl->gasmix.o2.permille / 10.0;
-       gtk_widget_set_sensitive(cylinder->o2, !!o2);
-       gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(cylinder->gasmix_button), !!o2);
+       he = cyl->gasmix.he.permille / 10.0;
        if (!o2)
                o2 = 21.0;
        gtk_spin_button_set_value(GTK_SPIN_BUTTON(cylinder->o2), o2);
+       gtk_spin_button_set_value(GTK_SPIN_BUTTON(cylinder->he), he);
 }
 
-static int cyl_nothing(cylinder_t *cyl)
+int cylinder_none(cylinder_t *cyl)
 {
        return  !cyl->type.size.mliter &&
                !cyl->type.workingpressure.mbar &&
@@ -330,7 +335,7 @@ void show_dive_equipment(struct dive *dive)
        do {
                cylinder_t *cyl = &dive->cylinder[max-1];
 
-               if (!cyl_nothing(cyl))
+               if (!cylinder_none(cyl))
                        break;
        } while (--max);
 
@@ -367,7 +372,7 @@ static GtkWidget *create_spinbutton(GtkWidget *vbox, const char *name, double mi
 }
 
 static void fill_cylinder_info(struct cylinder_widget *cylinder, cylinder_t *cyl, const char *desc,
-               double volume, double pressure, double start, double end, int o2)
+               double volume, double pressure, double start, double end, int o2, int he)
 {
        int mbar, ml;
 
@@ -385,14 +390,21 @@ static void fill_cylinder_info(struct cylinder_widget *cylinder, cylinder_t *cyl
        ml = volume * 1000 + 0.5;
        mbar = pressure * 1000 + 0.5;
 
-       if (o2 < 211)
+       /* Ignore obviously crazy He values */
+       if (o2 + he > 1000)
+               he = 0;
+
+       /* We have a rule that normal air is all zeroes */
+       if (!he && o2 > 208 && o2 < 211)
                o2 = 0;
+
        cyl->type.description = desc;
        cyl->type.size.mliter = ml;
        cyl->type.workingpressure.mbar = mbar;
        cyl->start.mbar = start * 1000 + 0.5;
        cyl->end.mbar = end * 1000 + 0.5;
        cyl->gasmix.o2.permille = o2;
+       cyl->gasmix.he.permille = he;
 
        /*
         * Also, insert it into the model if it doesn't already exist
@@ -405,7 +417,7 @@ static void record_cylinder_changes(cylinder_t *cyl, struct cylinder_widget *cyl
        const gchar *desc;
        GtkComboBox *box;
        double volume, pressure, start, end;
-       int o2;
+       int o2, he;
 
        /* Ignore uninitialized cylinder widgets */
        box = cylinder->description;
@@ -421,11 +433,14 @@ static void record_cylinder_changes(cylinder_t *cyl, struct cylinder_widget *cyl
        } else {
                start = end = 0;
        }
-       if (gtk_toggle_button_get_active(GTK_TOGGLE_BUTTON(cylinder->gasmix_button)))
+       if (gtk_toggle_button_get_active(GTK_TOGGLE_BUTTON(cylinder->gasmix_button))) {
                o2 = gtk_spin_button_get_value(GTK_SPIN_BUTTON(cylinder->o2))*10 + 0.5;
-       else
+               he = gtk_spin_button_get_value(GTK_SPIN_BUTTON(cylinder->he))*10 + 0.5;
+       } else {
                o2 = 0;
-       fill_cylinder_info(cylinder, cyl, desc, volume, pressure, start, end, o2);
+               he = 0;
+       }
+       fill_cylinder_info(cylinder, cyl, desc, volume, pressure, start, end, o2, he);
 }
 
 /*
@@ -499,13 +514,14 @@ static void fill_tank_list(GtkListStore *store)
        }
 }
 
-static void nitrox_cb(GtkToggleButton *button, gpointer data)
+static void gasmix_cb(GtkToggleButton *button, gpointer data)
 {
        struct cylinder_widget *cylinder = data;
        int state;
 
        state = gtk_toggle_button_get_active(button);
        gtk_widget_set_sensitive(cylinder->o2, state);
+       gtk_widget_set_sensitive(cylinder->he, state);
 }
 
 static void pressure_cb(GtkToggleButton *button, gpointer data)
@@ -534,6 +550,41 @@ static void cylinder_activate_cb(GtkComboBox *combo_box, gpointer data)
        cylinder_cb(cylinder->description, data);
 }
 
+/* Return a frame containing a hbox inside a hbox */
+static GtkWidget *frame_box(const char *title, GtkWidget *vbox)
+{
+       GtkWidget *hbox, *frame;
+
+       hbox = gtk_hbox_new(FALSE, 10);
+       gtk_box_pack_start(GTK_BOX(vbox), hbox, TRUE, FALSE, 0);
+
+       frame = gtk_frame_new(title);
+       gtk_box_pack_start(GTK_BOX(hbox), frame, TRUE, FALSE, 0);
+
+       hbox = gtk_hbox_new(FALSE, 10);
+       gtk_container_add(GTK_CONTAINER(frame), hbox);
+
+       return hbox;
+}
+
+static GtkWidget *labeled_spinbutton(GtkWidget *box, const char *name, double min, double max, double incr)
+{
+       GtkWidget *hbox, *label, *button;
+
+       hbox = gtk_hbox_new(FALSE, 0);
+       gtk_box_pack_start(GTK_BOX(box), hbox, TRUE, FALSE, 0);
+
+       label = gtk_label_new(name);
+       gtk_box_pack_start(GTK_BOX(hbox), label, TRUE, FALSE, 0);
+
+       button = gtk_spin_button_new_with_range(min, max, incr);
+       gtk_box_pack_start(GTK_BOX(hbox), button, TRUE, FALSE, 0);
+
+       gtk_spin_button_set_update_policy(GTK_SPIN_BUTTON(button), GTK_UPDATE_IF_VALID);
+
+       return button;
+}
+
 static void cylinder_widget(GtkWidget *vbox, struct cylinder_widget *cylinder, GtkListStore *model)
 {
        GtkWidget *frame, *hbox;
@@ -578,33 +629,30 @@ static void cylinder_widget(GtkWidget *vbox, struct cylinder_widget *cylinder, G
        /*
         * Cylinder start/end pressures
         */
-       hbox = gtk_hbox_new(FALSE, 3);
-       gtk_box_pack_start(GTK_BOX(vbox), hbox, FALSE, TRUE, 0);
+       hbox = frame_box("Pressure", vbox);
 
-       cylinder->pressure_button = gtk_check_button_new();
-       gtk_box_pack_start(GTK_BOX(hbox), cylinder->pressure_button, FALSE, FALSE, 3);
-       g_signal_connect(cylinder->pressure_button, "toggled", G_CALLBACK(pressure_cb), cylinder);
-
-       widget = create_spinbutton(hbox, "Start Pressure", 0, 5000, 1);
+       widget = labeled_spinbutton(hbox, "Start", 0, 5000, 1);
        cylinder->start = widget;
 
-       widget = create_spinbutton(hbox, "End Pressure", 0, 5000, 1);
+       widget = labeled_spinbutton(hbox, "End", 0, 5000, 1);
        cylinder->end = widget;
 
+       cylinder->pressure_button = gtk_check_button_new();
+       gtk_box_pack_start(GTK_BOX(hbox), cylinder->pressure_button, FALSE, FALSE, 3);
+       g_signal_connect(cylinder->pressure_button, "toggled", G_CALLBACK(pressure_cb), cylinder);
+
        /*
         * Cylinder gas mix: Air, Nitrox or Trimix
         */
-       hbox = gtk_hbox_new(FALSE, 3);
-       gtk_box_pack_start(GTK_BOX(vbox), hbox, FALSE, TRUE, 0);
+       hbox = frame_box("Gasmix", vbox);
 
-       widget = create_spinbutton(hbox, "Nitrox", 21, 100, 0.1);
+       widget = labeled_spinbutton(hbox, "O"UTF8_SUBSCRIPT_2 "%", 1, 100, 0.1);
        cylinder->o2 = widget;
+       widget = labeled_spinbutton(hbox, "He%", 0, 100, 0.1);
+       cylinder->he = widget;
        cylinder->gasmix_button = gtk_check_button_new();
-       gtk_box_pack_start(GTK_BOX(gtk_widget_get_parent(cylinder->o2)),
-               cylinder->gasmix_button, FALSE, FALSE, 3);
-       g_signal_connect(cylinder->gasmix_button, "toggled", G_CALLBACK(nitrox_cb), cylinder);
-
-       gtk_spin_button_set_range(GTK_SPIN_BUTTON(cylinder->o2), 21.0, 100.0);
+       gtk_box_pack_start(GTK_BOX(hbox), cylinder->gasmix_button, FALSE, FALSE, 3);
+       g_signal_connect(cylinder->gasmix_button, "toggled", G_CALLBACK(gasmix_cb), cylinder);
 }
 
 static int edit_cylinder_dialog(int index, cylinder_t *cyl)
@@ -661,7 +709,7 @@ static int get_model_index(GtkListStore *model, GtkTreeIter *iter)
        return index;
 }
 
-static void edit_cb(GtkButton *button, gpointer data)
+static void edit_cb(GtkButton *button, GtkTreeView *tree_view)
 {
        int index;
        GtkTreeIter iter;
@@ -669,7 +717,7 @@ static void edit_cb(GtkButton *button, gpointer data)
        GtkTreeSelection *selection;
        cylinder_t cyl;
 
-       selection = gtk_tree_view_get_selection(GTK_TREE_VIEW(cylinder_list.tree_view));
+       selection = gtk_tree_view_get_selection(tree_view);
 
        /* Nothing selected? This shouldn't happen, since the button should be inactive */
        if (!gtk_tree_selection_get_selected(selection, NULL, &iter))
@@ -683,7 +731,7 @@ static void edit_cb(GtkButton *button, gpointer data)
        repaint_dive();
 }
 
-static void add_cb(GtkButton *button, gpointer data)
+static void add_cb(GtkButton *button, GtkTreeView *tree_view)
 {
        int index = cylinder_list.max_index;
        GtkTreeIter iter;
@@ -697,14 +745,14 @@ static void add_cb(GtkButton *button, gpointer data)
        gtk_list_store_append(model, &iter);
        set_one_cylinder(index, &cyl, model, &iter);
 
-       selection = gtk_tree_view_get_selection(GTK_TREE_VIEW(cylinder_list.tree_view));
+       selection = gtk_tree_view_get_selection(tree_view);
        gtk_tree_selection_select_iter(selection, &iter);
 
        cylinder_list.max_index++;
        gtk_widget_set_sensitive(cylinder_list.add, cylinder_list.max_index < MAX_CYLINDERS);
 }
 
-static void del_cb(GtkButton *button, gpointer data)
+static void del_cb(GtkButton *button, GtkTreeView *tree_view)
 {
        int index, nr;
        GtkTreeIter iter;
@@ -713,7 +761,7 @@ static void del_cb(GtkButton *button, gpointer data)
        struct dive *dive;
        cylinder_t *cyl;
 
-       selection = gtk_tree_view_get_selection(GTK_TREE_VIEW(cylinder_list.tree_view));
+       selection = gtk_tree_view_get_selection(tree_view);
 
        /* Nothing selected? This shouldn't happen, since the button should be inactive */
        if (!gtk_tree_selection_get_selected(selection, NULL, &iter))
@@ -827,27 +875,18 @@ static void row_activated_cb(GtkTreeView *tree_view,
                        GtkTreeViewColumn *column,
                        GtkTreeModel *model)
 {
-       edit_cb(NULL, NULL);
+       edit_cb(NULL, tree_view);
 }
 
-static GtkWidget *cylinder_list_create(void)
+GtkWidget *cylinder_list_widget(void)
 {
+       GtkListStore *model = cylinder_list.model;
        GtkWidget *tree_view;
        GtkTreeSelection *selection;
-       GtkListStore *model;
 
-       model = gtk_list_store_new(CYL_COLUMNS,
-               G_TYPE_STRING,          /* CYL_DESC: utf8 */
-               G_TYPE_INT,             /* CYL_SIZE: mliter */
-               G_TYPE_INT,             /* CYL_WORKP: mbar */
-               G_TYPE_INT,             /* CYL_STARTP: mbar */
-               G_TYPE_INT,             /* CYL_ENDP: mbar */
-               G_TYPE_INT,             /* CYL_O2: permille */
-               G_TYPE_INT              /* CYL_HE: permille */
-               );
-       cylinder_list.model = model;
        tree_view = gtk_tree_view_new_with_model(GTK_TREE_MODEL(model));
        gtk_widget_set_can_focus(tree_view, FALSE);
+
        g_signal_connect(tree_view, "row-activated", G_CALLBACK(row_activated_cb), model);
 
        selection = gtk_tree_view_get_selection(GTK_TREE_VIEW(tree_view));
@@ -858,19 +897,36 @@ static GtkWidget *cylinder_list_create(void)
                                          "enable-grid-lines", GTK_TREE_VIEW_GRID_LINES_BOTH,
                                          NULL);
 
-       cylinder_list.desc = tree_view_column(tree_view, CYL_DESC, "Type", NULL, PANGO_ALIGN_LEFT, TRUE);
-       cylinder_list.size = tree_view_column(tree_view, CYL_SIZE, "Size", size_data_func, PANGO_ALIGN_RIGHT, TRUE);
-       cylinder_list.workp = tree_view_column(tree_view, CYL_WORKP, "MaxPress", pressure_data_func, PANGO_ALIGN_RIGHT, TRUE);
-       cylinder_list.startp = tree_view_column(tree_view, CYL_STARTP, "Start", pressure_data_func, PANGO_ALIGN_RIGHT, TRUE);
-       cylinder_list.endp = tree_view_column(tree_view, CYL_ENDP, "End", pressure_data_func, PANGO_ALIGN_RIGHT, TRUE);
-       cylinder_list.o2 = tree_view_column(tree_view, CYL_O2, "O" UTF8_SUBSCRIPT_2 "%", percentage_data_func, PANGO_ALIGN_RIGHT, TRUE);
-       cylinder_list.he = tree_view_column(tree_view, CYL_HE, "He%", percentage_data_func, PANGO_ALIGN_RIGHT, TRUE);
+       tree_view_column(tree_view, CYL_DESC, "Type", NULL, ALIGN_LEFT | UNSORTABLE);
+       tree_view_column(tree_view, CYL_SIZE, "Size", size_data_func, ALIGN_RIGHT | UNSORTABLE);
+       tree_view_column(tree_view, CYL_WORKP, "MaxPress", pressure_data_func, ALIGN_RIGHT | UNSORTABLE);
+       tree_view_column(tree_view, CYL_STARTP, "Start", pressure_data_func, ALIGN_RIGHT | UNSORTABLE);
+       tree_view_column(tree_view, CYL_ENDP, "End", pressure_data_func, ALIGN_RIGHT | UNSORTABLE);
+       tree_view_column(tree_view, CYL_O2, "O" UTF8_SUBSCRIPT_2 "%", percentage_data_func, ALIGN_RIGHT | UNSORTABLE);
+       tree_view_column(tree_view, CYL_HE, "He%", percentage_data_func, ALIGN_RIGHT | UNSORTABLE);
        return tree_view;
 }
 
+static GtkWidget *cylinder_list_create(void)
+{
+       GtkListStore *model;
+
+       model = gtk_list_store_new(CYL_COLUMNS,
+               G_TYPE_STRING,          /* CYL_DESC: utf8 */
+               G_TYPE_INT,             /* CYL_SIZE: mliter */
+               G_TYPE_INT,             /* CYL_WORKP: mbar */
+               G_TYPE_INT,             /* CYL_STARTP: mbar */
+               G_TYPE_INT,             /* CYL_ENDP: mbar */
+               G_TYPE_INT,             /* CYL_O2: permille */
+               G_TYPE_INT              /* CYL_HE: permille */
+               );
+       cylinder_list.model = model;
+       return cylinder_list_widget();
+}
+
 GtkWidget *equipment_widget(void)
 {
-       GtkWidget *vbox, *hbox, *frame, *framebox;
+       GtkWidget *vbox, *hbox, *frame, *framebox, *tree_view;
        GtkWidget *add, *del, *edit;
 
        vbox = gtk_vbox_new(FALSE, 3);
@@ -884,7 +940,7 @@ GtkWidget *equipment_widget(void)
         */
        cylinder_model = create_tank_size_model();
 
-       cylinder_list.tree_view = cylinder_list_create();
+       tree_view = cylinder_list_create();
 
        hbox = gtk_hbox_new(FALSE, 3);
        gtk_box_pack_start(GTK_BOX(vbox), hbox, FALSE, FALSE, 3);
@@ -898,7 +954,7 @@ GtkWidget *equipment_widget(void)
        hbox = gtk_hbox_new(FALSE, 3);
        gtk_box_pack_start(GTK_BOX(framebox), hbox, TRUE, FALSE, 3);
 
-       gtk_box_pack_start(GTK_BOX(hbox), cylinder_list.tree_view, TRUE, FALSE, 3);
+       gtk_box_pack_start(GTK_BOX(hbox), tree_view, TRUE, FALSE, 3);
 
        hbox = gtk_hbox_new(TRUE, 3);
        gtk_box_pack_start(GTK_BOX(framebox), hbox, TRUE, FALSE, 3);
@@ -914,9 +970,9 @@ GtkWidget *equipment_widget(void)
        cylinder_list.add = add;
        cylinder_list.del = del;
 
-       g_signal_connect(edit, "clicked", G_CALLBACK(edit_cb), NULL);
-       g_signal_connect(add, "clicked", G_CALLBACK(add_cb), NULL);
-       g_signal_connect(del, "clicked", G_CALLBACK(del_cb), NULL);
+       g_signal_connect(edit, "clicked", G_CALLBACK(edit_cb), tree_view);
+       g_signal_connect(add, "clicked", G_CALLBACK(add_cb), tree_view);
+       g_signal_connect(del, "clicked", G_CALLBACK(del_cb), tree_view);
 
        return vbox;
 }