2 #include <msp/core/algorithm.h>
3 #include <msp/core/raii.h>
4 #include <msp/strings/format.h>
5 #include <msp/strings/utils.h>
15 void Validator::diagnose(Node &node, Node &provoking_node, Diagnostic::Severity severity, const string &message)
18 diag.severity = severity;
19 diag.source = node.source;
20 diag.line = node.line;
21 diag.provoking_source = provoking_node.source;
22 diag.provoking_line = provoking_node.line;
23 diag.message = message;
24 stage->diagnostics.push_back(diag);
26 last_provoker = &provoking_node;
29 void Validator::add_info(Node &node, const string &message)
32 throw logic_error("Tried to add info without a previous provoker");
33 diagnose(node, *last_provoker, Diagnostic::INFO, message);
37 void DeclarationValidator::apply(Stage &s, const Features &f)
41 s.content.visit(*this);
44 const char *DeclarationValidator::describe_variable(ScopeType scope)
48 case GLOBAL: return "global variable";
49 case STRUCT: return "struct member";
50 case INTERFACE_BLOCK: return "interface block member";
51 case FUNCTION_PARAM: return "function parameter";
52 case FUNCTION: return "local variable";
53 default: return "variable";
57 void DeclarationValidator::visit(Layout &layout)
59 bool push_constant = false;
61 for(const Layout::Qualifier &q: layout.qualifiers)
66 if(q.name=="location")
67 allowed = (variable && scope==GLOBAL);
68 else if(q.name=="binding" || q.name=="set")
72 if(q.name=="set" && features.target_api!=VULKAN)
74 error(layout, "Layout qualifier 'set' not allowed when targeting OpenGL");
80 const TypeDeclaration *base_type = get_ultimate_base_type(variable->type_declaration);
81 bool uniform = (variable->interface=="uniform");
82 allowed = (scope==GLOBAL && uniform && dynamic_cast<const ImageTypeDeclaration *>(base_type));
83 err_descr = (uniform ? "variable of non-opaque type" : "non-uniform variable");
87 allowed = (iface_block->interface=="uniform");
88 err_descr = "non-uniform interface block";
91 else if(q.name=="constant_id")
93 allowed = (variable && scope==GLOBAL);
96 if(!variable->constant)
99 err_descr = "non-constant variable";
103 BasicTypeDeclaration *basic = dynamic_cast<BasicTypeDeclaration *>(variable->type_declaration);
104 if(!basic || basic->kind<BasicTypeDeclaration::BOOL || basic->kind>BasicTypeDeclaration::INT)
107 err_descr = format("variable of type '%s'",
108 (variable->type_declaration ? variable->type_declaration->name : variable->type));
113 else if(q.name=="offset")
114 allowed = (variable && scope==INTERFACE_BLOCK && iface_block->interface=="uniform");
115 else if(q.name=="align")
116 allowed = (scope==INTERFACE_BLOCK && iface_block->interface=="uniform");
117 else if(q.name=="points")
119 allowed = (stage->type==Stage::GEOMETRY && iface_layout && (iface_layout->interface=="in" || iface_layout->interface=="out"));
122 else if(q.name=="lines" || q.name=="lines_adjacency" || q.name=="triangles" || q.name=="triangles_adjacency")
124 allowed = (stage->type==Stage::GEOMETRY && iface_layout && iface_layout->interface=="in");
127 else if(q.name=="line_strip" || q.name=="triangle_strip")
129 allowed = (stage->type==Stage::GEOMETRY && iface_layout && iface_layout->interface=="out");
132 else if(q.name=="invocations")
133 allowed = (stage->type==Stage::GEOMETRY && iface_layout && iface_layout->interface=="in");
134 else if(q.name=="max_vertices")
135 allowed = (stage->type==Stage::GEOMETRY && iface_layout && iface_layout->interface=="out");
136 else if(q.name=="std140" || q.name=="std430")
138 allowed = (iface_block && !variable && iface_block->interface=="uniform");
141 else if(q.name=="column_major" || q.name=="row_major")
143 allowed = (variable && scope==INTERFACE_BLOCK);
146 BasicTypeDeclaration *basic = dynamic_cast<BasicTypeDeclaration *>(variable->type_declaration);
147 while(basic && basic->kind==BasicTypeDeclaration::ARRAY)
148 basic = dynamic_cast<BasicTypeDeclaration *>(basic->base_type);
149 allowed = (basic && basic->kind==BasicTypeDeclaration::MATRIX);
150 err_descr = "non-matrix variable";
153 else if(q.name=="push_constant")
155 push_constant = true;
156 allowed = (iface_block && !variable && iface_block->interface=="uniform");
159 else if(q.name=="rgba32f" || q.name=="rgba16f" || q.name=="rg32f" || q.name=="rg16f" || q.name=="r32f" || q.name=="r16f" ||
160 q.name=="rgba16" || q.name=="rgba8" || q.name=="rg16" || q.name=="rg8" || q.name=="r16" || q.name=="r8" ||
161 q.name=="rgba16_snorm" || q.name=="rgba8_snorm" || q.name=="rg16_snorm" || q.name=="rg8_snorm" || q.name=="r16_snorm" || q.name=="r8_snorm")
167 const TypeDeclaration *base_type = get_ultimate_base_type(variable->type_declaration);
168 const ImageTypeDeclaration *image = dynamic_cast<const ImageTypeDeclaration *>(base_type);
169 allowed = (image && !image->sampled);
170 err_descr = (image ? "sampled image" : "non-image variable");
176 if(err_descr.empty())
179 err_descr = describe_variable(scope);
181 err_descr = "interface block";
182 else if(iface_layout)
183 err_descr = format("interface '%s'", iface_layout->interface);
185 err_descr = "unknown declaration";
187 error(layout, format("Layout qualifier '%s' not allowed on %s", q.name, err_descr));
189 else if(value && !q.has_value)
190 error(layout, format("Layout qualifier '%s' requires a value", q.name));
191 else if(!value && q.has_value)
192 error(layout, format("Layout qualifier '%s' does not allow a value", q.name));
195 if(push_constant && binding)
196 error(layout, "Layout qualifier 'push_constant' not allowed together with 'binding' or 'set'");
199 void DeclarationValidator::visit(InterfaceLayout &layout)
201 SetForScope<InterfaceLayout *> set_layout(iface_layout, &layout);
202 TraversingVisitor::visit(layout);
205 void DeclarationValidator::visit(BasicTypeDeclaration &type)
207 BasicTypeDeclaration *basic_base = dynamic_cast<BasicTypeDeclaration *>(type.base_type);
208 BasicTypeDeclaration::Kind base_kind = (basic_base ? basic_base->kind : BasicTypeDeclaration::VOID);
210 if(type.kind==BasicTypeDeclaration::VECTOR && (base_kind<BasicTypeDeclaration::BOOL || base_kind>BasicTypeDeclaration::FLOAT))
211 error(type, format("Invalid base type '%s' for vector type '%s'", type.base, type.name));
212 else if(type.kind==BasicTypeDeclaration::MATRIX && base_kind!=BasicTypeDeclaration::VECTOR)
213 error(type, format("Invalid base type '%s' for matrix type '%s'", type.base, type.name));
214 else if(type.kind==BasicTypeDeclaration::ARRAY && basic_base && base_kind==BasicTypeDeclaration::VOID)
215 error(type, format("Invalid base type '%s' for array type '%s'", type.base, type.name));
218 void DeclarationValidator::visit(ImageTypeDeclaration &type)
220 BasicTypeDeclaration::Kind base_kind = BasicTypeDeclaration::VOID;
221 if(BasicTypeDeclaration *basic_base = dynamic_cast<BasicTypeDeclaration *>(type.base_type))
222 base_kind = basic_base->kind;
223 if(base_kind!=BasicTypeDeclaration::INT && base_kind!=BasicTypeDeclaration::FLOAT)
224 error(type, format("Invalid base type '%s' for image type '%s'", type.base, type.name));
227 void DeclarationValidator::visit(StructDeclaration &strct)
229 SetForScope<ScopeType> set_scope(scope, (strct.block_name.empty() ? STRUCT : INTERFACE_BLOCK));
230 SetForScope<VariableDeclaration *> set_iface(iface_block, strct.block_declaration);
231 TraversingVisitor::visit(strct);
234 void DeclarationValidator::visit(VariableDeclaration &var)
236 SetForScope<VariableDeclaration *> set_var((var.block_declaration ? iface_block : variable), &var);
238 const char *descr = describe_variable(scope);
242 if(scope!=GLOBAL && scope!=INTERFACE_BLOCK)
243 error(var, format("Layout qualifier not allowed on %s", descr));
245 var.layout->visit(*this);
250 if(scope==STRUCT || scope==INTERFACE_BLOCK)
251 error(var, format("Constant qualifier not allowed on %s", descr));
252 if(!var.init_expression)
253 error(var, "Constant variable must have an initializer");
256 if(!var.interpolation.empty() || !var.sampling.empty())
258 if(var.interface!="in" && stage->type==Stage::VERTEX)
259 error(var, "Interpolation qualifier not allowed on vertex input");
260 else if(var.interface!="out" && stage->type==Stage::FRAGMENT)
261 error(var, "Interpolation qualifier not allowed on fragment output");
262 else if((var.interface!="in" && var.interface!="out") || (scope==FUNCTION_PARAM || scope==FUNCTION))
263 error(var, "Interpolation qualifier not allowed on non-interpolated variable");
266 if(!var.interface.empty())
268 if(iface_block && var.interface!=iface_block->interface)
269 error(var, format("Mismatched interface qualifier '%s' inside '%s' block", var.interface, iface_block->interface));
270 else if(scope==STRUCT || scope==FUNCTION)
271 error(var, format("Interface qualifier not allowed on %s", descr));
272 else if(scope==GLOBAL && var.interface=="uniform" && !var.block_declaration && features.target_api==VULKAN)
274 if(!dynamic_cast<const ImageTypeDeclaration *>(get_ultimate_base_type(var.type_declaration)))
275 error(var, "Interface qualifier 'uniform' not allowed on non-opaque variable in global scope");
279 TypeDeclaration *type = var.type_declaration;
280 BasicTypeDeclaration::Kind kind = BasicTypeDeclaration::ALIAS;
281 while(BasicTypeDeclaration *basic = dynamic_cast<BasicTypeDeclaration *>(type))
284 type = basic->base_type;
286 if(dynamic_cast<ImageTypeDeclaration *>(type))
288 if(scope!=GLOBAL && scope!=FUNCTION_PARAM)
289 error(var, format("Type '%s' not allowed on %s", type->name, descr));
290 else if(scope==GLOBAL && var.interface!="uniform")
291 error(var, format("Type '%s' only allowed with uniform interface", type->name));
293 else if(var.block_declaration)
295 if(stage->type==Stage::VERTEX && var.interface=="in")
296 error(var, "Interface block not allowed on vertex shader input");
297 else if(stage->type==Stage::FRAGMENT && var.interface=="out")
298 error(var, "Interface block not allowed on fragment shader output");
300 else if(kind==BasicTypeDeclaration::VOID)
301 error(var, "Type 'void' not allowed on variable");
302 else if(kind==BasicTypeDeclaration::BOOL && var.source!=BUILTIN_SOURCE)
304 if(scope==INTERFACE_BLOCK)
305 error(var, "Type 'bool' not allowed in an interface block");
306 else if(!var.interface.empty())
307 error(var, "Type 'bool' not allowed on interface variable");
310 if(var.array && !var.array_size)
311 error(var, "Array must have a size");
313 if(var.init_expression)
315 if(scope==GLOBAL && !var.constant)
316 error(var, format("Initializer not allowed on non-constant %s", descr));
317 else if(scope!=GLOBAL && scope!=FUNCTION)
318 error(var, format("Initializer not allowed on %s", descr));
320 var.init_expression->visit(*this);
324 void DeclarationValidator::visit(FunctionDeclaration &func)
326 SetForScope<ScopeType> set_scope(scope, FUNCTION_PARAM);
327 for(const RefPtr<VariableDeclaration> &p: func.parameters)
330 func.body.visit(*this);
334 void IdentifierValidator::multiple_definition(const string &name, Statement &statement, Statement &previous)
336 error(statement, format("Multiple definition of %s", name));
337 add_info(previous, "Previous definition is here");
340 Statement *IdentifierValidator::find_definition(const string &name)
342 BlockDeclarationMap *decls = &declarations[current_block];
343 auto i = decls->find(name);
344 if(i==decls->end() && anonymous_block)
346 decls = &declarations[current_block->parent];
347 i = decls->find(name);
349 return (i!=decls->end() ? i->second : 0);
352 void IdentifierValidator::check_definition(const string &name, Statement &statement)
354 if(Statement *previous = find_definition(name))
355 multiple_definition(format("'%s'", name), statement, *previous);
357 record_definition(name, statement);
360 void IdentifierValidator::record_definition(const string &name, Statement &statement)
362 declarations[current_block].insert(make_pair(name, &statement));
364 declarations[current_block->parent].insert(make_pair(name, &statement));
367 void IdentifierValidator::visit(TypeDeclaration &type)
369 if(type.source!=INTERNAL_SOURCE)
370 check_definition(type.name, type);
373 void IdentifierValidator::visit(StructDeclaration &strct)
375 if(strct.block_name.empty())
376 check_definition(strct.name, strct);
377 TraversingVisitor::visit(strct);
380 void IdentifierValidator::visit(VariableDeclaration &var)
382 if(var.block_declaration)
384 string key = format("%s %s", var.interface, var.block_declaration->block_name);
385 auto i = interface_blocks.find(key);
386 if(i!=interface_blocks.end())
387 multiple_definition(format("interface block '%s %s'", var.interface, var.block_declaration->block_name), var, *i->second);
389 interface_blocks.insert(make_pair(key, &var));
391 if(Statement *previous = find_definition(var.block_declaration->block_name))
393 const VariableDeclaration *prev_var = dynamic_cast<const VariableDeclaration *>(previous);
394 if(!prev_var || !prev_var->block_declaration)
395 multiple_definition(format("'%s'", var.block_declaration->block_name), var, *previous);
398 record_definition(var.block_declaration->block_name, var);
400 if(var.name.find(' ')!=string::npos)
402 // Inject anonymous interface block members into the global scope
403 for(const auto &kvp: var.block_declaration->members.variables)
404 check_definition(kvp.first, *kvp.second);
408 if(var.name.find(' ')==string::npos)
409 check_definition(var.name, var);
411 TraversingVisitor::visit(var);
414 void IdentifierValidator::visit(FunctionDeclaration &func)
416 string key = func.name+func.signature;
417 auto i = overloaded_functions.find(key);
418 if(i==overloaded_functions.end())
419 overloaded_functions.insert(make_pair(key, &func));
420 else if(func.return_type_declaration && i->second->return_type_declaration!=func.return_type_declaration)
422 error(func, format("Conflicting return type '%s' for function '%s'", func.return_type_declaration->name, func.name));
423 if(i->second->return_type_declaration)
424 add_info(*i->second, format("Previously declared as returning '%s'", i->second->return_type_declaration->name));
427 if(Statement *previous = find_definition(func.name))
429 if(!dynamic_cast<FunctionDeclaration *>(previous))
430 multiple_definition(format("'%s'", func.name), func, *previous);
433 record_definition(func.name, func);
435 if(func.definition==&func)
436 check_definition(func.name+func.signature, func);
438 TraversingVisitor::visit(func);
442 void ReferenceValidator::visit(BasicTypeDeclaration &type)
444 if(!type.base.empty() && !type.base_type)
445 error(type, format("Use of undeclared type '%s'", type.base));
448 void ReferenceValidator::visit(ImageTypeDeclaration &type)
450 if(!type.base.empty() && !type.base_type)
451 error(type, format("Use of undeclared type '%s'", type.base));
454 void ReferenceValidator::visit(VariableReference &var)
457 error(var, format("Use of undeclared variable '%s'", var.name));
458 else if(stage->type!=Stage::VERTEX && var.declaration->interface=="in" && var.name.compare(0, 3, "gl_") && !var.declaration->linked_declaration)
459 error(var, format("Use of unlinked input %s '%s'", (var.declaration->block_declaration ? "block" : "variable"), var.name));
462 void ReferenceValidator::visit(MemberAccess &memacc)
464 if(memacc.left->type && !memacc.declaration)
465 error(memacc, format("Use of undeclared member '%s'", memacc.member));
466 TraversingVisitor::visit(memacc);
469 void ReferenceValidator::visit(FunctionCall &call)
471 if((!call.constructor && !call.declaration) || (call.constructor && !call.type))
473 bool have_declaration = call.constructor;
474 if(!call.constructor)
476 auto i = stage->functions.lower_bound(call.name);
477 have_declaration = (i!=stage->functions.end() && i->second->name==call.name);
482 bool valid_types = true;
484 for(auto j=call.arguments.begin(); (valid_types && j!=call.arguments.end()); ++j)
487 append(signature, ", ", (*j)->type->name);
493 error(call, format("No matching %s found for '%s(%s)'", (call.constructor ? "constructor" : "overload"), call.name, signature));
496 error(call, format("Call to undeclared function '%s'", call.name));
498 TraversingVisitor::visit(call);
501 void ReferenceValidator::visit(VariableDeclaration &var)
503 if(!var.type_declaration)
504 error(var, format("Use of undeclared type '%s'", var.type));
505 TraversingVisitor::visit(var);
508 void ReferenceValidator::visit(FunctionDeclaration &func)
510 if(!func.return_type_declaration)
511 error(func, format("Use of undeclared type '%s'", func.return_type));
512 TraversingVisitor::visit(func);
516 void ExpressionValidator::visit(VariableReference &var)
518 if(var.declaration && constant_expression)
520 if(!var.declaration->constant)
522 const char *kind = (var.declaration->block_declaration ? "interface block" : "non-constant variable");
523 error(var, format("Reference to %s '%s' in a constant expression", kind, var.name));
525 else if(var.declaration->layout && constant_expression==FIXED_CONSTANT)
527 if(has_layout_qualifier(var.declaration->layout.get(), "constant_id"))
528 error(var, format("Reference to specialization constant '%s' in a fixed constant expression", var.name));
533 void ExpressionValidator::visit(Swizzle &swizzle)
536 if(BasicTypeDeclaration *basic = dynamic_cast<BasicTypeDeclaration *>(swizzle.left->type))
538 if(basic->kind==BasicTypeDeclaration::INT || basic->kind==BasicTypeDeclaration::FLOAT)
540 else if(basic->kind==BasicTypeDeclaration::VECTOR)
546 static const char component_names[] = { 'x', 'y', 'z', 'w', 'r', 'g', 'b', 'a', 's', 't', 'p', 'q' };
548 for(unsigned i=0; i<swizzle.count; ++i)
550 unsigned component_flavour = (std::find(component_names, component_names+12, swizzle.component_group[i])-component_names)/4;
552 flavour = component_flavour;
553 else if(flavour>=0 && component_flavour!=static_cast<unsigned>(flavour))
555 error(swizzle, format("Flavour of swizzle component '%c' is inconsistent with '%c'",
556 swizzle.component_group[i], swizzle.component_group[0]));
560 if(swizzle.components[i]>=size)
561 error(swizzle, format("Access to component '%c' which is not present in '%s'",
562 swizzle.component_group[i], swizzle.left->type->name));
565 else if(swizzle.left->type)
566 error(swizzle, format("Swizzle applied to '%s' which is neither a scalar nor a vector", swizzle.left->type->name));
568 TraversingVisitor::visit(swizzle);
571 void ExpressionValidator::visit(UnaryExpression &unary)
573 if(unary.expression->type)
576 error(unary, format("No matching operator '%s' found for '%s'", unary.oper->token, unary.expression->type->name));
577 else if(unary.oper->token[1]=='+' || unary.oper->token[1]=='-')
579 if(constant_expression)
580 error(unary, format("Use of '%s' in a constant expression", unary.oper->token));
581 else if(!unary.expression->lvalue)
582 error(unary, format("Operand of '%s' is not an lvalue", unary.oper->token));
585 TraversingVisitor::visit(unary);
588 void ExpressionValidator::visit(BinaryExpression &binary)
590 if(!binary.type && binary.left->type && binary.right->type)
592 if(binary.oper->token[0]=='[')
593 error(binary, format("Can't index element of '%s' with '%s'",
594 binary.left->type->name, binary.right->type->name));
596 error(binary, format("No matching operator '%s' found for '%s' and '%s'",
597 binary.oper->token, binary.left->type->name, binary.right->type->name));
599 TraversingVisitor::visit(binary);
602 void ExpressionValidator::visit(Assignment &assign)
604 if(assign.left->type)
606 if(constant_expression)
607 error(assign, "Assignment in constant expression");
608 else if(!assign.left->lvalue)
609 error(assign, "Target of assignment is not an lvalue");
610 if(assign.right->type)
612 if(assign.oper->token[0]!='=')
615 error(assign, format("No matching operator '%s' found for '%s' and '%s'",
616 string(assign.oper->token, strlen(assign.oper->token)-1), assign.left->type->name, assign.right->type->name));
618 else if(assign.left->type!=assign.right->type)
619 error(assign, format("Assignment to variable of type '%s' from expression of incompatible type '%s'",
620 assign.left->type->name, assign.right->type->name));
623 TraversingVisitor::visit(assign);
626 void ExpressionValidator::visit(TernaryExpression &ternary)
628 if(ternary.condition->type)
630 BasicTypeDeclaration *basic_cond = dynamic_cast<BasicTypeDeclaration *>(ternary.condition->type);
631 if(!basic_cond || basic_cond->kind!=BasicTypeDeclaration::BOOL)
632 error(ternary, "Ternary operator condition is not a boolean");
633 else if(!ternary.type && ternary.true_expr->type && ternary.false_expr->type)
634 error(ternary, format("Ternary operator has incompatible types '%s' and '%s'",
635 ternary.true_expr->type->name, ternary.false_expr->type->name));
637 TraversingVisitor::visit(ternary);
640 void ExpressionValidator::visit(StructDeclaration &strct)
642 SetFlag set_struct(in_struct);
643 TraversingVisitor::visit(strct);
646 void ExpressionValidator::visit(VariableDeclaration &var)
648 if(var.init_expression && var.init_expression->type && var.type_declaration && var.init_expression->type!=var.type_declaration)
649 error(var, format("Initializing a variable of type '%s' with an expression of incompatible type '%s'",
650 var.type_declaration->name, var.init_expression->type->name));
653 var.layout->visit(*this);
654 if(var.init_expression)
656 ConstantKind const_kind = (!var.constant ? NOT_CONSTANT :
657 has_layout_qualifier(var.layout.get(), "constant_id") ? FIXED_CONSTANT : SPEC_CONSTANT);
659 SetForScope<ConstantKind> set_const(constant_expression, const_kind);
660 TraversingVisitor::visit(var.init_expression);
664 SetForScope<ConstantKind> set_const(constant_expression, (in_struct || !var.interface.empty() ? FIXED_CONSTANT : SPEC_CONSTANT));
665 TraversingVisitor::visit(var.array_size);
669 void ExpressionValidator::visit(FunctionDeclaration &func)
671 SetForScope<FunctionDeclaration *> set_func(current_function, &func);
672 TraversingVisitor::visit(func);
675 void ExpressionValidator::visit(Conditional &cond)
677 if(cond.condition->type)
679 BasicTypeDeclaration *basic_cond = dynamic_cast<BasicTypeDeclaration *>(cond.condition->type);
680 if(!basic_cond || basic_cond->kind!=BasicTypeDeclaration::BOOL)
681 error(cond, "Condition is not a boolean");
683 TraversingVisitor::visit(cond);
686 void ExpressionValidator::visit(Iteration &iter)
688 if(iter.condition->type)
690 BasicTypeDeclaration *basic_cond = dynamic_cast<BasicTypeDeclaration *>(iter.condition->type);
691 if(!basic_cond || basic_cond->kind!=BasicTypeDeclaration::BOOL)
692 error(iter, "Loop condition is not a boolean");
694 TraversingVisitor::visit(iter);
697 void ExpressionValidator::visit(Return &ret)
699 if(current_function && current_function->return_type_declaration)
701 TypeDeclaration *return_type = current_function->return_type_declaration;
702 BasicTypeDeclaration *basic_return = dynamic_cast<BasicTypeDeclaration *>(return_type);
705 if(ret.expression->type && ret.expression->type!=return_type)
706 error(ret, format("Return expression type '%s' is incompatible with declared return type '%s'",
707 ret.expression->type->name, return_type->name));
709 else if(!basic_return || basic_return->kind!=BasicTypeDeclaration::VOID)
710 error(ret, "Return statement without an expression in a function not returning 'void'");
713 TraversingVisitor::visit(ret);
717 void FlowControlValidator::visit(Block &block)
719 for(const RefPtr<Statement> &s: block.body)
723 diagnose(*s, Diagnostic::WARN, "Unreachable code detected");
730 void FlowControlValidator::visit(FunctionDeclaration &func)
732 func.body.visit(*this);
734 if(func.definition==&func && func.return_type_declaration)
736 const BasicTypeDeclaration *basic_ret = dynamic_cast<const BasicTypeDeclaration *>(func.return_type_declaration);
737 if(reachable && (!basic_ret || basic_ret->kind!=BasicTypeDeclaration::VOID))
738 error(func, "Missing return statement at the end of a function not returning 'void'");
743 void FlowControlValidator::visit(Conditional &cond)
745 cond.body.visit(*this);
746 bool reachable_if_true = reachable;
748 cond.else_body.visit(*this);
749 reachable |= reachable_if_true;
752 void FlowControlValidator::visit(Iteration &iter)
754 iter.body.visit(*this);
759 void StageInterfaceValidator::visit(VariableDeclaration &var)
761 int location = get_layout_value(var.layout.get(), "location");
762 if(var.interface=="in" && var.linked_declaration)
764 const Layout *linked_layout = var.linked_declaration->layout.get();
765 int linked_location = get_layout_value(linked_layout, "location");
766 if(linked_location!=location)
768 error(var, format("Mismatched location %d for 'in %s'", location, var.name));
769 add_info(*var.linked_declaration, format("Linked to 'out %s' with location %d",
770 var.linked_declaration->name, linked_location));
772 if(var.type_declaration && var.linked_declaration->type_declaration)
774 TypeDeclaration *type = var.type_declaration;
775 if(stage->type==Stage::GEOMETRY)
777 if(const BasicTypeDeclaration *basic = dynamic_cast<const BasicTypeDeclaration *>(type))
778 if(basic->kind==BasicTypeDeclaration::ARRAY && basic->base_type)
779 type = basic->base_type;
781 if(!TypeComparer().apply(*type, *var.linked_declaration->type_declaration))
783 error(var, format("Mismatched type '%s' for 'in %s'", type->name, var.name));
784 add_info(*var.linked_declaration, format("Linked to 'out %s' with type '%s'",
785 var.linked_declaration->name, var.linked_declaration->type_declaration->name));
790 if(location>=0 && !var.interface.empty())
792 map<unsigned, VariableDeclaration *> &used = used_locations[var.interface];
794 unsigned loc_count = LocationCounter().apply(var);
795 for(unsigned i=0; i<loc_count; ++i)
797 auto j = used.find(location+i);
800 error(var, format("Overlapping location %d for '%s %s'", location+i, var.interface, var.name));
801 add_info(*j->second, format("Previously used here for '%s %s'", j->second->interface, j->second->name));
804 used[location+i] = &var;
810 void GlobalInterfaceValidator::apply(Module &module)
812 for(Stage &s: module.stages)
815 s.content.visit(*this);
819 void GlobalInterfaceValidator::check_uniform(const Uniform &uni)
821 auto i = used_names.find(uni.name);
822 if(i!=used_names.end())
824 if(uni.location>=0 && i->second->location>=0 && i->second->location!=uni.location)
826 error(*uni.node, format("Mismatched location %d for uniform '%s'", uni.location, uni.name));
827 add_info(*i->second->node, format("Previously declared here with location %d", i->second->location));
829 if(i->second->desc_set!=uni.desc_set)
831 error(*uni.node, format("Mismatched descriptor set %d for uniform '%s'", uni.desc_set, uni.name));
832 add_info(*i->second->node, format("Previously declared here with descriptor set %d", i->second->desc_set));
834 if(uni.bind_point>=0 && i->second->bind_point>=0 && i->second->bind_point!=uni.bind_point)
836 error(*uni.node, format("Mismatched binding %d for uniform '%s'", uni.bind_point, uni.name));
837 add_info(*i->second->node, format("Previously declared here with binding %d", i->second->bind_point));
839 if(uni.type && i->second->type && !TypeComparer().apply(*uni.type, *i->second->type))
841 string type_name = (dynamic_cast<const StructDeclaration *>(uni.type) ?
842 "structure" : format("type '%s'", uni.type->name));
843 error(*uni.node, format("Mismatched %s for uniform '%s'", type_name, uni.name));
845 string message = "Previously declared here";
846 if(!dynamic_cast<const StructDeclaration *>(i->second->type))
847 message += format(" with type '%s'", i->second->type->name);
848 add_info(*i->second->node, message);
852 used_names.insert(make_pair(uni.name, &uni));
856 auto j = used_locations.find(uni.location);
857 if(j!=used_locations.end())
859 if(j->second->name!=uni.name)
861 error(*uni.node, format("Overlapping location %d for '%s'", uni.location, uni.name));
862 add_info(*j->second->node, format("Previously used here for '%s'", j->second->name));
867 for(unsigned k=0; k<uni.loc_count; ++k)
868 used_locations.insert(make_pair(uni.location+k, &uni));
872 if(uni.bind_point>=0)
874 map<unsigned, const Uniform *> &used = used_bindings[uni.desc_set];
875 auto j = used.find(uni.bind_point);
878 if(j->second->name!=uni.name)
880 error(*uni.node, format("Overlapping binding %d for '%s'", uni.bind_point, uni.name));
881 add_info(*j->second->node, format("Previously used here for '%s'", j->second->name));
885 used.insert(make_pair(uni.bind_point, &uni));
889 void GlobalInterfaceValidator::visit(VariableDeclaration &var)
891 if(var.interface=="uniform")
895 uni.type = var.type_declaration;
896 uni.name = (var.block_declaration ? var.block_declaration->block_name : var.name);
899 if(!var.block_declaration)
901 uni.location = get_layout_value(var.layout.get(), "location");
902 uni.loc_count = LocationCounter().apply(var);
904 uni.desc_set = get_layout_value(var.layout.get(), "set", 0);
905 uni.bind_point = get_layout_value(var.layout.get(), "binding");
908 uniforms.push_back(uni);
909 check_uniform(uniforms.back());