3 #include <msp/core/raii.h>
4 #include <msp/strings/format.h>
5 #include <msp/strings/utils.h>
15 Validator::Validator():
20 void Validator::diagnose(Node &node, Node &provoking_node, Diagnostic::Severity severity, const string &message)
23 diag.severity = severity;
24 diag.source = node.source;
25 diag.line = node.line;
26 diag.provoking_source = provoking_node.source;
27 diag.provoking_line = provoking_node.line;
28 diag.message = message;
29 stage->diagnostics.push_back(diag);
31 last_provoker = &provoking_node;
34 void Validator::add_info(Node &node, const string &message)
37 throw logic_error("Tried to add info without a previous provoker");
38 diagnose(node, *last_provoker, Diagnostic::INFO, message);
42 DeclarationValidator::DeclarationValidator():
49 const char *DeclarationValidator::describe_variable(ScopeType scope)
53 case GLOBAL: return "global variable";
54 case STRUCT: return "struct member";
55 case INTERFACE_BLOCK: return "interface block member";
56 case FUNCTION_PARAM: return "function parameter";
57 case FUNCTION: return "local variable";
58 default: return "variable";
62 void DeclarationValidator::visit(Layout &layout)
64 for(vector<Layout::Qualifier>::const_iterator i=layout.qualifiers.begin(); i!=layout.qualifiers.end(); ++i)
69 if(i->name=="location")
70 allowed = (variable && scope==GLOBAL);
71 else if(i->name=="binding" || i->name=="set")
75 error(layout, "Layout qualifier 'set' not allowed when targeting OpenGL");
81 TypeDeclaration *type = variable->type_declaration;
82 while(BasicTypeDeclaration *basic = dynamic_cast<BasicTypeDeclaration *>(type))
83 type = basic->base_type;
84 bool uniform = (variable->interface=="uniform");
85 allowed = (scope==GLOBAL && uniform && dynamic_cast<ImageTypeDeclaration *>(type));
86 err_descr = (uniform ? "variable of non-opaque type" : "non-uniform variable");
90 allowed = (iface_block->interface=="uniform");
91 err_descr = "non-uniform interface block";
94 else if(i->name=="constant_id")
96 allowed = (variable && scope==GLOBAL);
99 if(!variable->constant)
102 err_descr = "non-constant variable";
106 BasicTypeDeclaration *basic = dynamic_cast<BasicTypeDeclaration *>(variable->type_declaration);
107 if(!basic || basic->kind<BasicTypeDeclaration::BOOL || basic->kind>BasicTypeDeclaration::INT)
110 err_descr = format("variable of type '%s'",
111 (variable->type_declaration ? variable->type_declaration->name : variable->type));
116 else if(i->name=="offset")
117 allowed = (variable && scope==INTERFACE_BLOCK);
118 else if(i->name=="points")
120 allowed = (stage->type==Stage::GEOMETRY && iface_layout && (iface_layout->interface=="in" || iface_layout->interface=="out"));
123 else if(i->name=="lines" || i->name=="lines_adjacency" || i->name=="triangles" || i->name=="triangles_adjacency")
125 allowed = (stage->type==Stage::GEOMETRY && iface_layout && iface_layout->interface=="in");
128 else if(i->name=="line_strip" || i->name=="triangle_strip")
130 allowed = (stage->type==Stage::GEOMETRY && iface_layout && iface_layout->interface=="out");
133 else if(i->name=="invocations")
134 allowed = (stage->type==Stage::GEOMETRY && iface_layout && iface_layout->interface=="in");
135 else if(i->name=="max_vertices")
136 allowed = (stage->type==Stage::GEOMETRY && iface_layout && iface_layout->interface=="out");
137 else if(i->name=="std140" || i->name=="std430")
139 allowed = (iface_block && !variable && iface_block->interface=="uniform");
145 if(err_descr.empty())
148 err_descr = describe_variable(scope);
150 err_descr = "interface block";
151 else if(iface_layout)
152 err_descr = format("interface '%s'", iface_layout->interface);
154 err_descr = "unknown declaration";
156 error(layout, format("Layout qualifier '%s' not allowed on %s", i->name, err_descr));
158 else if(value && !i->has_value)
159 error(layout, format("Layout qualifier '%s' requires a value", i->name));
160 else if(!value && i->has_value)
161 error(layout, format("Layout qualifier '%s' does not allow a value", i->name));
165 void DeclarationValidator::visit(InterfaceLayout &layout)
167 SetForScope<InterfaceLayout *> set_layout(iface_layout, &layout);
168 TraversingVisitor::visit(layout);
171 void DeclarationValidator::visit(BasicTypeDeclaration &type)
173 BasicTypeDeclaration *basic_base = dynamic_cast<BasicTypeDeclaration *>(type.base_type);
174 BasicTypeDeclaration::Kind base_kind = (basic_base ? basic_base->kind : BasicTypeDeclaration::VOID);
176 if(type.kind==BasicTypeDeclaration::VECTOR && (base_kind<BasicTypeDeclaration::BOOL || base_kind>BasicTypeDeclaration::FLOAT))
177 error(type, format("Invalid base type '%s' for vector type '%s'", type.base, type.name));
178 else if(type.kind==BasicTypeDeclaration::MATRIX && base_kind!=BasicTypeDeclaration::VECTOR)
179 error(type, format("Invalid base type '%s' for matrix type '%s'", type.base, type.name));
180 else if(type.kind==BasicTypeDeclaration::ARRAY && basic_base && base_kind==BasicTypeDeclaration::VOID)
181 error(type, format("Invalid base type '%s' for array type '%s'", type.base, type.name));
184 void DeclarationValidator::visit(ImageTypeDeclaration &type)
186 BasicTypeDeclaration::Kind base_kind = BasicTypeDeclaration::VOID;
187 if(BasicTypeDeclaration *basic_base = dynamic_cast<BasicTypeDeclaration *>(type.base_type))
188 base_kind = basic_base->kind;
189 if(base_kind!=BasicTypeDeclaration::INT && base_kind!=BasicTypeDeclaration::FLOAT)
190 error(type, format("Invalid base type '%s' for image type '%s'", type.base, type.name));
193 void DeclarationValidator::visit(StructDeclaration &strct)
195 SetForScope<ScopeType> set_scope(scope, (scope!=INTERFACE_BLOCK ? STRUCT : scope));
196 TraversingVisitor::visit(strct);
199 void DeclarationValidator::visit(VariableDeclaration &var)
201 SetForScope<VariableDeclaration *> set_var(variable, &var);
203 const char *descr = describe_variable(scope);
207 if(scope!=GLOBAL && scope!=INTERFACE_BLOCK)
208 error(var, format("Layout qualifier not allowed on %s", descr));
210 var.layout->visit(*this);
215 if(scope==STRUCT || scope==INTERFACE_BLOCK)
216 error(var, format("Constant qualifier not allowed on %s", descr));
219 if(!var.interpolation.empty() || !var.sampling.empty())
221 if(var.interface!="in" && stage->type==Stage::VERTEX)
222 error(var, "Interpolation qualifier not allowed on vertex input");
223 else if(var.interface!="out" && stage->type==Stage::FRAGMENT)
224 error(var, "Interpolation qualifier not allowed on fragment output");
225 else if((var.interface!="in" && var.interface!="out") || (scope==FUNCTION_PARAM || scope==FUNCTION))
226 error(var, "Interpolation qualifier not allowed on non-interpolated variable");
229 if(!var.interface.empty())
231 if(iface_block && var.interface!=iface_block->interface)
232 error(var, format("Mismatched interface qualifier '%s' inside '%s' block", var.interface, iface_block->interface));
233 else if(scope==STRUCT || scope==FUNCTION)
234 error(var, format("Interface qualifier not allowed on %s", descr));
237 TypeDeclaration *type = var.type_declaration;
238 while(BasicTypeDeclaration *basic = dynamic_cast<BasicTypeDeclaration *>(type))
239 type = basic->base_type;
240 if(dynamic_cast<ImageTypeDeclaration *>(type))
242 if(scope!=GLOBAL && scope!=FUNCTION_PARAM)
243 error(var, format("Type '%s' not allowed on %s", type->name, descr));
244 else if(scope==GLOBAL && var.interface!="uniform")
245 error(var, format("Type '%s' only allowed with uniform interface", type->name));
248 if(var.init_expression)
250 if(scope==GLOBAL && !var.constant)
251 error(var, format("Initializer not allowed on non-constant %s", descr));
252 else if(scope!=GLOBAL && scope!=FUNCTION)
253 error(var, format("Initializer not allowed on %s", descr));
255 var.init_expression->visit(*this);
259 void DeclarationValidator::visit(InterfaceBlock &iface)
261 SetForScope<ScopeType> set_scope(scope, INTERFACE_BLOCK);
262 SetForScope<InterfaceBlock *> set_iface(iface_block, &iface);
264 if(stage->type==Stage::VERTEX && iface.interface=="in")
265 error(iface, "Interface block not allowed on vertex shader input");
266 else if(stage->type==Stage::FRAGMENT && iface.interface=="out")
267 error(iface, "Interface block not allowed on fragment shader output");
269 TraversingVisitor::visit(iface);
270 if(iface.struct_declaration)
271 iface.struct_declaration->visit(*this);
274 void DeclarationValidator::visit(FunctionDeclaration &func)
276 SetForScope<ScopeType> set_scope(scope, FUNCTION_PARAM);
277 for(NodeArray<VariableDeclaration>::const_iterator i=func.parameters.begin(); i!=func.parameters.end(); ++i)
280 func.body.visit(*this);
284 IdentifierValidator::IdentifierValidator():
285 anonymous_block(false)
288 void IdentifierValidator::multiple_definition(const string &name, Statement &statement, Statement &previous)
290 error(statement, format("Multiple definition of %s", name));
291 add_info(previous, "Previous definition is here");
294 Statement *IdentifierValidator::find_definition(const string &name)
296 BlockDeclarationMap *decls = &declarations[current_block];
297 BlockDeclarationMap::const_iterator i = decls->find(name);
298 if(i==decls->end() && anonymous_block)
300 decls = &declarations[current_block->parent];
301 i = decls->find(name);
303 return (i!=decls->end() ? i->second : 0);
306 void IdentifierValidator::check_definition(const string &name, Statement &statement)
308 if(Statement *previous = find_definition(name))
309 multiple_definition(format("'%s'", name), statement, *previous);
311 record_definition(name, statement);
314 void IdentifierValidator::record_definition(const string &name, Statement &statement)
316 declarations[current_block].insert(make_pair(name, &statement));
318 declarations[current_block->parent].insert(make_pair(name, &statement));
321 void IdentifierValidator::visit(TypeDeclaration &type)
323 check_definition(type.name, type);
326 void IdentifierValidator::visit(StructDeclaration &strct)
328 check_definition(strct.name, strct);
329 TraversingVisitor::visit(strct);
332 void IdentifierValidator::visit(VariableDeclaration &var)
334 check_definition(var.name, var);
335 TraversingVisitor::visit(var);
338 void IdentifierValidator::visit(InterfaceBlock &iface)
340 string key = iface.interface+iface.block_name;
341 map<string, InterfaceBlock *>::const_iterator i = interface_blocks.find(key);
342 if(i!=interface_blocks.end())
343 multiple_definition(format("interface block '%s %s'", iface.interface, iface.block_name), iface, *i->second);
345 interface_blocks.insert(make_pair(key, &iface));
347 if(Statement *previous = find_definition(iface.block_name))
349 if(!dynamic_cast<InterfaceBlock *>(previous))
350 multiple_definition(format("'%s'", iface.block_name), iface, *previous);
353 record_definition(iface.block_name, iface);
355 if(!iface.instance_name.empty())
356 check_definition(iface.instance_name, iface);
358 if(iface.instance_name.empty() && iface.struct_declaration)
360 // Inject anonymous interface block members into the global scope
361 const map<string, VariableDeclaration *> &iface_vars = iface.struct_declaration->members.variables;
362 for(map<string, VariableDeclaration *>::const_iterator j=iface_vars.begin(); j!=iface_vars.end(); ++j)
363 check_definition(j->first, *j->second);
367 void IdentifierValidator::visit(FunctionDeclaration &func)
369 string key = func.name+func.signature;
370 map<string, FunctionDeclaration *>::const_iterator i = overloaded_functions.find(key);
371 if(i==overloaded_functions.end())
372 overloaded_functions.insert(make_pair(key, &func));
373 else if(func.return_type_declaration && i->second->return_type_declaration!=func.return_type_declaration)
375 error(func, format("Conflicting return type '%s' for function '%s'", func.return_type_declaration->name, func.name));
376 if(i->second->return_type_declaration)
377 add_info(*i->second, format("Previously declared as returning '%s'", i->second->return_type_declaration->name));
380 if(Statement *previous = find_definition(func.name))
382 if(!dynamic_cast<FunctionDeclaration *>(previous))
383 multiple_definition(format("'%s'", func.name), func, *previous);
386 record_definition(func.name, func);
388 if(func.definition==&func)
389 check_definition(func.name+func.signature, func);
391 TraversingVisitor::visit(func);
395 void ReferenceValidator::visit(BasicTypeDeclaration &type)
397 if(!type.base.empty() && !type.base_type)
398 error(type, format("Use of undeclared type '%s'", type.base));
401 void ReferenceValidator::visit(ImageTypeDeclaration &type)
403 if(!type.base.empty() && !type.base_type)
404 error(type, format("Use of undeclared type '%s'", type.base));
407 void ReferenceValidator::visit(VariableReference &var)
410 error(var, format("Use of undeclared variable '%s'", var.name));
411 else if(stage->type!=Stage::VERTEX && var.declaration->interface=="in" && var.name.compare(0, 3, "gl_") && !var.declaration->linked_declaration)
412 error(var, format("Use of unlinked input variable '%s'", var.name));
415 void ReferenceValidator::visit(MemberAccess &memacc)
417 if(memacc.left->type && !memacc.declaration)
418 error(memacc, format("Use of undeclared member '%s'", memacc.member));
419 TraversingVisitor::visit(memacc);
422 void ReferenceValidator::visit(InterfaceBlockReference &iface)
424 /* An interface block reference without a declaration should be impossible
425 since references are generated based on existing declarations. */
426 if(!iface.declaration)
427 error(iface, format("Use of undeclared interface block '%s'", iface.name));
428 else if(stage->type!=Stage::VERTEX && iface.declaration->interface=="in" && !iface.declaration->linked_block)
429 error(iface, format("Use of unlinked input block '%s'", iface.name));
432 void ReferenceValidator::visit(FunctionCall &call)
434 if((!call.constructor && !call.declaration) || (call.constructor && !call.type))
436 bool have_declaration = call.constructor;
437 if(!call.constructor)
439 map<string, FunctionDeclaration *>::iterator i = stage->functions.lower_bound(call.name);
440 have_declaration = (i!=stage->functions.end() && i->second->name==call.name);
445 bool valid_types = true;
447 for(NodeArray<Expression>::const_iterator j=call.arguments.begin(); (valid_types && j!=call.arguments.end()); ++j)
450 append(signature, ", ", (*j)->type->name);
456 error(call, format("No matching %s found for '%s(%s)'", (call.constructor ? "constructor" : "overload"), call.name, signature));
459 error(call, format("Call to undeclared function '%s'", call.name));
461 TraversingVisitor::visit(call);
464 void ReferenceValidator::visit(VariableDeclaration &var)
466 if(!var.type_declaration)
467 error(var, format("Use of undeclared type '%s'", var.type));
468 TraversingVisitor::visit(var);
471 void ReferenceValidator::visit(InterfaceBlock &iface)
473 if(!iface.struct_declaration)
474 error(iface, format("Interface block '%s %s' lacks a struct declaration", iface.interface, iface.block_name));
475 TraversingVisitor::visit(iface);
478 void ReferenceValidator::visit(FunctionDeclaration &func)
480 if(!func.return_type_declaration)
481 error(func, format("Use of undeclared type '%s'", func.return_type));
482 TraversingVisitor::visit(func);
486 ExpressionValidator::ExpressionValidator():
490 void ExpressionValidator::visit(Swizzle &swizzle)
493 if(BasicTypeDeclaration *basic = dynamic_cast<BasicTypeDeclaration *>(swizzle.left->type))
495 if(basic->kind==BasicTypeDeclaration::INT || basic->kind==BasicTypeDeclaration::FLOAT)
497 else if(basic->kind==BasicTypeDeclaration::VECTOR)
503 static const char component_names[] = { 'x', 'y', 'z', 'w', 'r', 'g', 'b', 'a', 's', 't', 'p', 'q' };
505 for(unsigned i=0; i<swizzle.count; ++i)
507 unsigned component_flavour = (find(component_names, component_names+12, swizzle.component_group[i])-component_names)/4;
509 flavour = component_flavour;
510 else if(flavour>=0 && component_flavour!=static_cast<unsigned>(flavour))
512 error(swizzle, format("Flavour of swizzle component '%c' is inconsistent with '%c'",
513 swizzle.component_group[i], swizzle.component_group[0]));
517 if(swizzle.components[i]>=size)
518 error(swizzle, format("Access to component '%c' which is not present in '%s'",
519 swizzle.component_group[i], swizzle.left->type->name));
522 else if(swizzle.left->type)
523 error(swizzle, format("Swizzle applied to '%s' which is neither a scalar nor a vector", swizzle.left->type->name));
525 TraversingVisitor::visit(swizzle);
528 void ExpressionValidator::visit(UnaryExpression &unary)
530 if(unary.expression->type)
533 error(unary, format("No matching operator '%s' found for '%s'", unary.oper->token, unary.expression->type->name));
534 else if((unary.oper->token[1]=='+' || unary.oper->token[1]=='-') && !unary.expression->lvalue)
535 error(unary, format("Operand of '%s' is not an lvalue", unary.oper->token));
537 TraversingVisitor::visit(unary);
540 void ExpressionValidator::visit(BinaryExpression &binary)
542 if(!binary.type && binary.left->type && binary.right->type)
544 if(binary.oper->token[0]=='[')
545 error(binary, format("Can't index element of '%s' with '%s'",
546 binary.left->type->name, binary.right->type->name));
548 error(binary, format("No matching operator '%s' found for '%s' and '%s'",
549 binary.oper->token, binary.left->type->name, binary.right->type->name));
551 TraversingVisitor::visit(binary);
554 void ExpressionValidator::visit(Assignment &assign)
556 if(assign.left->type)
558 if(!assign.left->lvalue)
559 error(assign, "Target of assignment is not an lvalue");
560 if(assign.right->type)
562 if(assign.oper->token[0]!='=')
565 error(assign, format("No matching operator '%s' found for '%s' and '%s'",
566 string(assign.oper->token, strlen(assign.oper->token)-1), assign.left->type->name, assign.right->type->name));
568 else if(assign.left->type!=assign.right->type)
569 error(assign, format("Assignment to variable of type '%s' from expression of incompatible type '%s'",
570 assign.left->type->name, assign.right->type->name));
573 TraversingVisitor::visit(assign);
576 void ExpressionValidator::visit(TernaryExpression &ternary)
578 if(ternary.condition->type)
580 BasicTypeDeclaration *basic_cond = dynamic_cast<BasicTypeDeclaration *>(ternary.condition->type);
581 if(!basic_cond || basic_cond->kind!=BasicTypeDeclaration::BOOL)
582 error(ternary, "Ternary operator condition is not a boolean");
583 else if(!ternary.type && ternary.true_expr->type && ternary.false_expr->type)
584 error(ternary, format("Ternary operator has incompatible types '%s' and '%s'",
585 ternary.true_expr->type->name, ternary.false_expr->type->name));
587 TraversingVisitor::visit(ternary);
590 void ExpressionValidator::visit(VariableDeclaration &var)
592 if(var.init_expression && var.init_expression->type && var.type_declaration && var.init_expression->type!=var.type_declaration)
593 error(var, format("Initializing a variable of type '%s' with an expression of incompatible type '%s'",
594 var.type_declaration->name, var.init_expression->type->name));
595 TraversingVisitor::visit(var);
598 void ExpressionValidator::visit(FunctionDeclaration &func)
600 SetForScope<FunctionDeclaration *> set_func(current_function, &func);
601 TraversingVisitor::visit(func);
604 void ExpressionValidator::visit(Return &ret)
606 if(current_function && current_function->return_type_declaration)
608 TypeDeclaration *return_type = current_function->return_type_declaration;
609 BasicTypeDeclaration *basic_return = dynamic_cast<BasicTypeDeclaration *>(return_type);
612 if(ret.expression->type && ret.expression->type!=return_type)
613 error(ret, format("Return expression type '%s' is incompatible with declared return type '%s'",
614 ret.expression->type->name, return_type->name));
616 else if(!basic_return || basic_return->kind!=BasicTypeDeclaration::VOID)
617 error(ret, "Return statement without an expression in a function not returning 'void'");
620 TraversingVisitor::visit(ret);
624 int StageInterfaceValidator::get_location(const Layout &layout)
626 for(vector<Layout::Qualifier>::const_iterator i=layout.qualifiers.begin(); i!=layout.qualifiers.end(); ++i)
627 if(i->name=="location")
632 void StageInterfaceValidator::visit(VariableDeclaration &var)
634 int location = (var.layout ? get_location(*var.layout) : -1);
635 if(var.interface=="in" && var.linked_declaration)
637 const Layout *linked_layout = var.linked_declaration->layout.get();
638 int linked_location = (linked_layout ? get_location(*linked_layout) : -1);
639 if(linked_location!=location)
641 error(var, format("Mismatched location %d for 'in %s'", location, var.name));
642 add_info(*var.linked_declaration, format("Linked to 'out %s' with location %d",
643 var.linked_declaration->name, linked_location));
645 if(var.type_declaration && var.linked_declaration->type_declaration)
647 const TypeDeclaration *type = var.type_declaration;
648 if(stage->type==Stage::GEOMETRY)
650 if(const BasicTypeDeclaration *basic = dynamic_cast<const BasicTypeDeclaration *>(type))
651 if(basic->kind==BasicTypeDeclaration::ARRAY && basic->base_type)
652 type = basic->base_type;
654 if(!is_same_type(*type, *var.linked_declaration->type_declaration))
656 error(var, format("Mismatched type '%s' for 'in %s'", type->name, var.name));
657 add_info(*var.linked_declaration, format("Linked to 'out %s' with type '%s'",
658 var.linked_declaration->name, var.linked_declaration->type_declaration->name));
663 if(location>=0 && !var.interface.empty())
665 map<unsigned, VariableDeclaration *> &used = used_locations[var.interface];
667 unsigned loc_count = LocationCounter().apply(var);
668 for(unsigned i=0; i<loc_count; ++i)
670 map<unsigned, VariableDeclaration *>::const_iterator j = used.find(location+i);
673 error(var, format("Overlapping location %d for '%s %s'", location+i, var.interface, var.name));
674 add_info(*j->second, format("Previously used here for '%s %s'", j->second->interface, j->second->name));
677 used[location+i] = &var;
683 void GlobalInterfaceValidator::apply(Module &module)
685 for(list<Stage>::iterator i=module.stages.begin(); i!=module.stages.end(); ++i)
688 i->content.visit(*this);
692 void GlobalInterfaceValidator::check_uniform(const Uniform &uni)
694 map<std::string, const Uniform *>::const_iterator i = used_names.find(uni.name);
695 if(i!=used_names.end())
697 if(uni.location>=0 && i->second->location>=0 && i->second->location!=uni.location)
699 error(*uni.node, format("Mismatched location %d for uniform '%s'", uni.location, uni.name));
700 add_info(*i->second->node, format("Previously declared here with location %d", i->second->location));
702 if(uni.bind_point>=0 && i->second->bind_point>=0 && i->second->bind_point!=uni.bind_point)
704 error(*uni.node, format("Mismatched binding %d for uniform '%s'", uni.bind_point, uni.name));
705 add_info(*i->second->node, format("Previously declared here with binding %d", i->second->bind_point));
707 if(uni.type && i->second->type && !is_same_type(*uni.type, *i->second->type))
709 string type_name = (dynamic_cast<const StructDeclaration *>(uni.type) ?
710 "structure" : format("type '%s'", uni.type->name));
711 error(*uni.node, format("Mismatched %s for uniform '%s'", type_name, uni.name));
713 string message = "Previously declared here";
714 if(!dynamic_cast<const StructDeclaration *>(i->second->type))
715 message += format(" with type '%s'", i->second->type->name);
716 add_info(*i->second->node, message);
720 used_names.insert(make_pair(uni.name, &uni));
724 map<unsigned, const Uniform *>::const_iterator j = used_locations.find(uni.location);
725 if(j!=used_locations.end())
727 if(j->second->name!=uni.name)
729 error(*uni.node, format("Overlapping location %d for '%s'", uni.location, uni.name));
730 add_info(*j->second->node, format("Previously used here for '%s'", j->second->name));
735 for(unsigned k=0; k<uni.loc_count; ++k)
736 used_locations.insert(make_pair(uni.location+k, &uni));
740 if(uni.bind_point>=0)
742 map<unsigned, const Uniform *> &used = used_bindings[uni.desc_set];
743 map<unsigned, const Uniform *>::const_iterator j = used.find(uni.bind_point);
746 if(j->second->name!=uni.name)
748 error(*uni.node, format("Overlapping binding %d for '%s'", uni.bind_point, uni.name));
749 add_info(*j->second->node, format("Previously used here for '%s'", j->second->name));
753 used.insert(make_pair(uni.bind_point, &uni));
757 void GlobalInterfaceValidator::visit(VariableDeclaration &var)
759 if(var.interface=="uniform")
763 uni.type = var.type_declaration;
767 uni.location = get_layout_value(*var.layout, "location");
768 uni.loc_count = LocationCounter().apply(var);
769 uni.desc_set = get_layout_value(*var.layout, "set", 0);
770 uni.bind_point = get_layout_value(*var.layout, "binding");
773 uniforms.push_back(uni);
774 check_uniform(uniforms.back());
778 void GlobalInterfaceValidator::visit(InterfaceBlock &iface)
780 if(iface.interface=="uniform")
784 uni.type = iface.struct_declaration;
785 uni.name = iface.block_name;
788 uni.desc_set = get_layout_value(*iface.layout, "set", 0);
789 uni.bind_point = get_layout_value(*iface.layout, "binding");
792 uniforms.push_back(uni);
793 check_uniform(uniforms.back());