From fdd3c43f654833a19428abf11200ebf627ddbdf1 Mon Sep 17 00:00:00 2001 From: Mikko Rasa Date: Tue, 5 Sep 2023 12:14:08 +0300 Subject: [PATCH] Disable warning C4250 on MSVC It's emitted when a class inherits a virtual base through multiple ways, and one of those ways overrides a virtual function from the base. This feels more annoying than useful; I'll deal with any ambiguities as they arise. --- plugins/msvc/msvccompiler.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/plugins/msvc/msvccompiler.cpp b/plugins/msvc/msvccompiler.cpp index 3206e57..9eac872 100644 --- a/plugins/msvc/msvccompiler.cpp +++ b/plugins/msvc/msvccompiler.cpp @@ -125,6 +125,7 @@ ExternalTask::Arguments MsvcCompiler::_run(const ObjectFile &object, FS::Path &w argv.push_back("/permissive-"); argv.push_back("/wd4068"); // Unknown pragma + argv.push_back("/wd4250"); // Virtual function inherited via dominance argv.push_back("/wd4251"); // Dll-interface required on type of member variable argv.push_back("/wd4275"); // Dll-interface class derives from non-dll-interface class if(binfo.warning_level<4) -- 2.45.2