From: Mikko Rasa <tdb@tdb.fi>
Date: Sun, 26 Jan 2025 00:00:50 +0000 (+0200)
Subject: Use unique_ptr for managing memory allocations
X-Git-Url: https://git.tdb.fi/?a=commitdiff_plain;h=896e8440e8c32443fc3fa5272abbac264177437c;p=libs%2Fmath.git

Use unique_ptr for managing memory allocations
---

diff --git a/Build b/Build
index 2795c66..c1c5d2e 100644
--- a/Build
+++ b/Build
@@ -6,7 +6,7 @@ package "mspmath"
 
 	build_info
 	{
-		standard CXX "c++11";
+		standard CXX "c++14";
 	};
 
 	if_arch "linux"
diff --git a/examples/raytrace.cpp b/examples/raytrace.cpp
index 7827bd3..bed9b1b 100644
--- a/examples/raytrace.cpp
+++ b/examples/raytrace.cpp
@@ -11,7 +11,7 @@ using namespace Msp;
 class RayTracer: public RegisteredApplication<RayTracer>
 {
 private:
-	Geometry::Shape<double, 3> *shape;
+	std::unique_ptr<Geometry::Shape<double, 3>> shape;
 	unsigned width;
 	unsigned height;
 	string filename;
@@ -28,7 +28,6 @@ private:
 
 
 RayTracer::RayTracer(int argc, char **argv):
-	shape(0),
 	width(500),
 	height(500),
 	pixels(new UInt8[width*height])
@@ -42,7 +41,6 @@ RayTracer::RayTracer(int argc, char **argv):
 
 RayTracer::~RayTracer()
 {
-	delete shape;
 	delete[] pixels;
 }
 
@@ -89,5 +87,5 @@ void RayTracer::load_shape()
 	DataFile::Parser parser(in, filename);
 	Geometry::Loader<double, 3> loader;
 	loader.load(parser);
-	shape = loader.get_shape().clone();
+	shape = loader.take_shape();
 }
diff --git a/source/geometry/compositeshape.h b/source/geometry/compositeshape.h
index 012c390..8814ce0 100644
--- a/source/geometry/compositeshape.h
+++ b/source/geometry/compositeshape.h
@@ -2,6 +2,7 @@
 #define MSP_GEOMETRY_COMPOSITESHAPE_H_
 
 #include <algorithm>
+#include <memory>
 #include <stdexcept>
 #include <vector>
 #include "shape.h"
@@ -17,7 +18,7 @@ class CompositeShape: public Shape<T, D>
 {
 protected:
 	typedef O Ops;
-	typedef std::vector<Shape<T, D> *> ShapeArray;
+	typedef std::vector<std::unique_ptr<Shape<T, D>>> ShapeArray;
 
 	ShapeArray shapes;
 	unsigned max_isect;
@@ -31,9 +32,8 @@ private:
 protected:
 	CompositeShape(const CompositeShape &);
 	CompositeShape &operator=(const CompositeShape &);
-public:
-	~CompositeShape() override;
 
+public:
 	BoundingBox<T, D> get_axis_aligned_bounding_box(unsigned = 0) const override;
 	bool contains(const LinAl::Vector<T, D> &) const override;
 	unsigned get_max_ray_intersections() const override { return max_isect; }
@@ -66,39 +66,28 @@ template<typename T, unsigned D, typename O>
 inline void CompositeShape<T, D, O>::init()
 {
 	max_isect = 0;
-	for(Shape<T, D> *s: shapes)
+	for(const std::unique_ptr<Shape<T, D>> &s: shapes)
 		max_isect += s->get_max_ray_intersections();
 }
 
 template<typename T, unsigned D, typename O>
 inline CompositeShape<T, D, O>::CompositeShape(const CompositeShape<T, D, O> &other):
-	shapes(other.shapes),
 	max_isect(other.max_isect)
 {
-	for(Shape<T, D> *&s: shapes)
-		s = s->clone();
+	for(const std::unique_ptr<Shape<T, D>> &s: other.shapes)
+		shapes.push_back(s->clone());
 }
 
 template<typename T, unsigned D, typename O>
 inline CompositeShape<T, D, O> &CompositeShape<T, D, O>::operator=(const CompositeShape<T, D, O> &other)
 {
-	for(Shape<T, D> *s: shapes)
-		delete s;
-
-	shapes = other.shapes;
-	for(Shape<T, D> *&s: shapes)
-		s = s->clone();
+	shapes.clear();
+	for(const std::unique_ptr<Shape<T, D>> &s: shapes)
+		shapes.push_back(s->clone());
 
 	max_isect = other.max_isect;
 }
 
-template<typename T, unsigned D, typename O>
-inline CompositeShape<T, D, O>::~CompositeShape()
-{
-	for(Shape<T, D> *s: shapes)
-		delete s;
-}
-
 template<typename T, unsigned D, typename O>
 inline BoundingBox<T, D> CompositeShape<T, D, O>::get_axis_aligned_bounding_box(unsigned detail) const
 {
@@ -120,7 +109,7 @@ template<typename T, unsigned D, typename O>
 inline bool CompositeShape<T, D, O>::contains(const LinAl::Vector<T, D> &point) const
 {
 	bool inside = false;
-	for(Shape<T, D> *s: shapes)
+	for(const std::unique_ptr<Shape<T, D>> &s: shapes)
 	{
 		inside = s->contains(point);
 		if(Ops::shortcircuit(inside))
diff --git a/source/geometry/extrudedshape.h b/source/geometry/extrudedshape.h
index 027e4f5..f453a9c 100644
--- a/source/geometry/extrudedshape.h
+++ b/source/geometry/extrudedshape.h
@@ -17,16 +17,15 @@ template<typename T, unsigned D>
 class ExtrudedShape: public Shape<T, D>
 {
 private:
-	Shape<T, D-1> *base = nullptr;
+	std::unique_ptr<Shape<T, D-1>> base;
 	T length = T(1);
 
 public:
 	ExtrudedShape(const Shape<T, D-1> &, T);
 	ExtrudedShape(const ExtrudedShape &);
 	ExtrudedShape &operator=(const ExtrudedShape &);
-	~ExtrudedShape() override;
 
-	ExtrudedShape *clone() const override;
+	std::unique_ptr<Shape<T, D>> clone() const override;
 
 	const Shape<T, D-1> &get_base() const { return *base; }
 	T get_length() const { return length; }
@@ -57,21 +56,14 @@ inline ExtrudedShape<T, D>::ExtrudedShape(const ExtrudedShape<T, D> &other):
 template<typename T, unsigned D>
 inline ExtrudedShape<T, D> &ExtrudedShape<T, D>::operator=(const ExtrudedShape<T, D> &other)
 {
-	delete base;
 	base = other.base->clone();
 	length = other.length;
 }
 
 template<typename T, unsigned D>
-inline ExtrudedShape<T, D>::~ExtrudedShape()
+inline std::unique_ptr<Shape<T, D>> ExtrudedShape<T, D>::clone() const
 {
-	delete base;
-}
-
-template<typename T, unsigned D>
-inline ExtrudedShape<T, D> *ExtrudedShape<T, D>::clone() const
-{
-	return new ExtrudedShape<T, D>(*base, length);
+	return std::make_unique<ExtrudedShape<T, D>>(*base, length);
 }
 
 template<typename T, unsigned D>
diff --git a/source/geometry/halfspace.h b/source/geometry/halfspace.h
index 5271bd6..8753198 100644
--- a/source/geometry/halfspace.h
+++ b/source/geometry/halfspace.h
@@ -20,7 +20,7 @@ public:
 	HalfSpace();
 	HalfSpace(const LinAl::Vector<T, D> &);
 
-	HalfSpace *clone() const override;
+	std::unique_ptr<Shape<T, D>> clone() const override;
 
 	const LinAl::Vector<T, D> &get_normal() const { return normal; }
 
@@ -43,9 +43,9 @@ inline HalfSpace<T, D>::HalfSpace(const LinAl::Vector<T, D> &n):
 { }
 
 template<typename T, unsigned D>
-inline HalfSpace<T, D> *HalfSpace<T, D>::clone() const
+inline std::unique_ptr<Shape<T, D>> HalfSpace<T, D>::clone() const
 {
-	return new HalfSpace<T, D>(normal);
+	return std::make_unique<HalfSpace<T, D>>(normal);
 }
 
 template<typename T, unsigned D>
diff --git a/source/geometry/hyperbox.h b/source/geometry/hyperbox.h
index 1743251..cb7a661 100644
--- a/source/geometry/hyperbox.h
+++ b/source/geometry/hyperbox.h
@@ -24,7 +24,7 @@ public:
 	HyperBox();
 	explicit HyperBox(const LinAl::Vector<T, D> &);
 
-	HyperBox *clone() const override;
+	std::unique_ptr<Shape<T, D>> clone() const override;
 
 	const LinAl::Vector<T, D> &get_dimensions() const { return dimensions; }
 	T get_dimension(unsigned) const;
@@ -53,9 +53,9 @@ inline HyperBox<T, D>::HyperBox(const LinAl::Vector<T, D> &d):
 }
 
 template<typename T, unsigned D>
-inline HyperBox<T, D> *HyperBox<T, D>::clone() const
+inline std::unique_ptr<Shape<T, D>> HyperBox<T, D>::clone() const
 {
-	return new HyperBox<T, D>(dimensions);
+	return std::make_unique<HyperBox<T, D>>(dimensions);
 }
 
 template<typename T, unsigned D>
diff --git a/source/geometry/hypersphere.h b/source/geometry/hypersphere.h
index 94ccae9..368549b 100644
--- a/source/geometry/hypersphere.h
+++ b/source/geometry/hypersphere.h
@@ -23,7 +23,7 @@ public:
 	HyperSphere() = default;
 	explicit HyperSphere(T);
 
-	HyperSphere *clone() const override;
+	std::unique_ptr<Shape<T, D>> clone() const override;
 
 	T get_radius() const { return radius; }
 
@@ -43,9 +43,9 @@ inline HyperSphere<T, D>::HyperSphere(T r):
 }
 
 template<typename T, unsigned D>
-inline HyperSphere<T, D> *HyperSphere<T, D>::clone() const
+inline std::unique_ptr<Shape<T, D>> HyperSphere<T, D>::clone() const
 {
-	return new HyperSphere<T, D>(radius);
+	return std::make_unique<HyperSphere<T, D>>(radius);
 }
 
 template<typename T, unsigned D>
diff --git a/source/geometry/intersection.h b/source/geometry/intersection.h
index 6ea0602..cdf41e9 100644
--- a/source/geometry/intersection.h
+++ b/source/geometry/intersection.h
@@ -28,7 +28,7 @@ public:
 	template<typename Iter>
 	static Intersection from_iterator_range(const Iter &, const Iter &);
 
-	Intersection *clone() const override;
+	std::unique_ptr<Shape<T, D>> clone() const override;
 };
 
 template<typename T, unsigned D>
@@ -46,9 +46,9 @@ inline Intersection<T, D> Intersection<T, D>::from_iterator_range(const Iter &be
 }
 
 template<typename T, unsigned D>
-inline Intersection<T, D> *Intersection<T, D>::clone() const
+inline std::unique_ptr<Shape<T, D>> Intersection<T, D>::clone() const
 {
-	return new Intersection<T, D>(*this);
+	return std::make_unique<Intersection<T, D>>(*this);
 }
 
 } // namespace Geometry
diff --git a/source/geometry/loader.h b/source/geometry/loader.h
index 6b03bbb..c3774b7 100644
--- a/source/geometry/loader.h
+++ b/source/geometry/loader.h
@@ -21,13 +21,12 @@ class DimensionIndependentLoader: public DataFile::Loader
 {
 protected:
 	bool single = true;
-	std::list<Shape<T, D> *> shapes;
+	std::list<std::unique_ptr<Shape<T, D>>> shapes;
 
 	DimensionIndependentLoader(bool = true);
-public:
-	~DimensionIndependentLoader() override;
 
-	const Shape<T, D> &get_shape() const;
+public:
+	std::unique_ptr<Shape<T, D>> take_shape();
 
 protected:
 	template<typename S>
@@ -65,7 +64,7 @@ private:
 public:
 	ShapeLoader();
 
-	ExtrudedShape<T, D> *create() const;
+	std::unique_ptr<ExtrudedShape<T, D>> create() const;
 
 private:
 	void length(T);
@@ -80,7 +79,7 @@ private:
 public:
 	ShapeLoader();
 
-	HalfSpace<T, D> *create() const;
+	std::unique_ptr<Shape<T, D>> create() const;
 
 private:
 	void normal(const std::vector<T> &);
@@ -95,7 +94,7 @@ private:
 public:
 	ShapeLoader();
 
-	HyperBox<T, D> *create() const;
+	std::unique_ptr<Shape<T, D>> create() const;
 
 private:
 	void dimensions(const std::vector<T> &);
@@ -110,7 +109,7 @@ private:
 public:
 	ShapeLoader();
 
-	HyperSphere<T, D> *create() const;
+	std::unique_ptr<Shape<T, D>> create() const;
 
 private:
 	void radius(T);
@@ -122,7 +121,7 @@ class CompositeLoader: public Loader<T, D>
 public:
 	CompositeLoader();
 
-	S *create() const;
+	std::unique_ptr<Shape<T, D>> create() const;
 };
 
 template<typename T, unsigned D>
@@ -133,7 +132,7 @@ template<typename T, unsigned D>
 class ShapeLoader<Negation<T, D> >: public Loader<T, D>
 {
 public:
-	Negation<T, D> *create() const;
+	std::unique_ptr<Shape<T, D>> create() const;
 };
 
 template<typename T, unsigned D>
@@ -145,7 +144,7 @@ protected:
 public:
 	TransformationLoader();
 
-	TransformedShape<T, D> *create() const;
+	std::unique_ptr<Shape<T, D>> create() const;
 
 	void translate(const std::vector<T> &);
 	void scale(const std::vector<T> &);
@@ -193,18 +192,11 @@ inline DimensionIndependentLoader<T, D>::DimensionIndependentLoader(bool s):
 }
 
 template<typename T, unsigned D>
-inline DimensionIndependentLoader<T, D>::~DimensionIndependentLoader()
-{
-	for(Shape<T, D> *s: shapes)
-		delete s;
-}
-
-template<typename T, unsigned D>
-inline const Shape<T, D> &DimensionIndependentLoader<T, D>::get_shape() const
+inline std::unique_ptr<Shape<T, D>> DimensionIndependentLoader<T, D>::take_shape()
 {
 	if(shapes.empty())
 		throw std::runtime_error("no shape");
-	return *shapes.front();
+	return std::move(shapes.front());
 }
 
 template<typename T, unsigned D>
@@ -241,9 +233,9 @@ inline ShapeLoader<ExtrudedShape<T, D> >::ShapeLoader():
 }
 
 template<typename T, unsigned D>
-inline ExtrudedShape<T, D> *ShapeLoader<ExtrudedShape<T, D> >::create() const
+inline std::unique_ptr<ExtrudedShape<T, D>> ShapeLoader<ExtrudedShape<T, D> >::create() const
 {
-	return new ExtrudedShape<T, D>(*this->shapes.front(), length_);
+	return std::make_unique<ExtrudedShape<T, D>>(*this->shapes.front(), length_);
 }
 
 template<typename T, unsigned D>
@@ -262,9 +254,9 @@ inline ShapeLoader<HalfSpace<T, D> >::ShapeLoader()
 }
 
 template<typename T, unsigned D>
-inline HalfSpace<T, D> *ShapeLoader<HalfSpace<T, D> >::create() const
+inline std::unique_ptr<Shape<T, D>> ShapeLoader<HalfSpace<T, D> >::create() const
 {
-	return new HalfSpace<T, D>(normal_);
+	return std::make_unique<HalfSpace<T, D>>(normal_);
 }
 
 template<typename T, unsigned D>
@@ -287,9 +279,9 @@ inline ShapeLoader<HyperBox<T, D> >::ShapeLoader()
 }
 
 template<typename T, unsigned D>
-inline HyperBox<T, D> *ShapeLoader<HyperBox<T, D> >::create() const
+inline std::unique_ptr<Shape<T, D>> ShapeLoader<HyperBox<T, D> >::create() const
 {
-	return new HyperBox<T, D>(dimensions_);
+	return std::make_unique<HyperBox<T, D>>(dimensions_);
 }
 
 template<typename T, unsigned D>
@@ -310,9 +302,9 @@ inline ShapeLoader<HyperSphere<T, D> >::ShapeLoader():
 }
 
 template<typename T, unsigned D>
-inline HyperSphere<T, D> *ShapeLoader<HyperSphere<T, D> >::create() const
+inline std::unique_ptr<Shape<T, D>> ShapeLoader<HyperSphere<T, D> >::create() const
 {
-	return new HyperSphere<T, D>(radius_);
+	return std::make_unique<HyperSphere<T, D>>(radius_);
 }
 
 template<typename T, unsigned D>
@@ -323,9 +315,9 @@ inline void ShapeLoader<HyperSphere<T, D> >::radius(T r)
 
 
 template<typename T, unsigned D>
-inline Negation<T, D> *ShapeLoader<Negation<T, D> >::create() const
+inline std::unique_ptr<Shape<T, D>> ShapeLoader<Negation<T, D> >::create() const
 {
-	return new Negation<T, D>(*this->shapes.front());
+	return std::make_unique<Negation<T, D>>(*this->shapes.front());
 }
 
 
@@ -338,9 +330,9 @@ inline TransformationLoader<T, D>::TransformationLoader()
 }
 
 template<typename T, unsigned D>
-inline TransformedShape<T, D> *TransformationLoader<T, D>::create() const
+inline std::unique_ptr<Shape<T, D>> TransformationLoader<T, D>::create() const
 {
-	return new TransformedShape<T, D>(*this->shapes.front(), transformation);
+	return std::make_unique<TransformedShape<T, D>>(*this->shapes.front(), transformation);
 }
 
 template<typename T, unsigned D>
@@ -411,7 +403,7 @@ inline CompositeLoader<T, D, S>::CompositeLoader():
 { }
 
 template<typename T, unsigned D, typename S>
-inline S *CompositeLoader<T, D, S>::create() const
+inline std::unique_ptr<Shape<T, D>> CompositeLoader<T, D, S>::create() const
 {
 	if(this->shapes.empty())
 		throw std::runtime_error("no shapes");
diff --git a/source/geometry/negation.h b/source/geometry/negation.h
index 4947bbf..9c781e9 100644
--- a/source/geometry/negation.h
+++ b/source/geometry/negation.h
@@ -14,15 +14,14 @@ template<typename T, unsigned D>
 class Negation: public Shape<T, D>
 {
 private:
-	Shape<T, D> *shape = nullptr;
+	std::unique_ptr<Shape<T, D>> shape;
 
 public:
 	Negation(const Shape<T, D> &);
 	Negation(const Negation &);
 	Negation &operator=(const Negation &);
-	~Negation();
 
-	Negation *clone() const override;
+	std::unique_ptr<Shape<T, D>> clone() const override;
 
 	const Shape<T, D> &get_shape() const { return *shape; }
 
@@ -46,21 +45,14 @@ inline Negation<T, D>::Negation(const Negation<T, D> &other):
 template<typename T, unsigned D>
 inline Negation<T, D> &Negation<T, D>::operator=(const Negation<T, D> &other)
 {
-	delete shape;
 	shape = other.shape->clone();
 	return *this;
 }
 
 template<typename T, unsigned D>
-inline Negation<T, D>::~Negation()
+inline std::unique_ptr<Shape<T, D>> Negation<T, D>::clone() const
 {
-	delete shape;
-}
-
-template<typename T, unsigned D>
-inline Negation<T, D> *Negation<T, D>::clone() const
-{
-	return new Negation<T, D>(*shape);
+	return std::make_unique<Negation<T, D>>(*shape);
 }
 
 template<typename T, unsigned D>
diff --git a/source/geometry/shape.h b/source/geometry/shape.h
index 543550d..bd90ba6 100644
--- a/source/geometry/shape.h
+++ b/source/geometry/shape.h
@@ -2,6 +2,7 @@
 #define MSP_GEOMETRY_SHAPE_H_
 
 #include <list>
+#include <memory>
 #include <vector>
 #include <msp/linal/vector.h>
 #include "boundingbox.h"
@@ -39,7 +40,7 @@ protected:
 public:
 	virtual ~Shape() = default;
 
-	virtual Shape *clone() const = 0;
+	virtual std::unique_ptr<Shape> clone() const = 0;
 
 	/** Returns the bounding box of the shape.  The detail parameter controls
 	the tightness of the box.  Higher detail will take more time to compute. */
diff --git a/source/geometry/transformedshape.h b/source/geometry/transformedshape.h
index 1cab022..7ea7268 100644
--- a/source/geometry/transformedshape.h
+++ b/source/geometry/transformedshape.h
@@ -14,7 +14,7 @@ template<typename T, unsigned D>
 class TransformedShape: public Shape<T, D>
 {
 private:
-	Shape<T, D> *shape = nullptr;
+	std::unique_ptr<Shape<T, D>> shape;
 	AffineTransform<T, D> transformation;
 	AffineTransform<T, D> inverse_trans;
 
@@ -22,9 +22,8 @@ public:
 	TransformedShape(const Shape<T, D> &, const AffineTransform<T, D> &);
 	TransformedShape(const TransformedShape &);
 	TransformedShape &operator=(const TransformedShape &);
-	~TransformedShape();
 
-	TransformedShape *clone() const override;
+	std::unique_ptr<Shape<T, D>> clone() const override;
 
 	const Shape<T, D> &get_shape() const { return *shape; }
 	const AffineTransform<T, D> &get_transformation() const { return transformation; }
@@ -53,22 +52,15 @@ inline TransformedShape<T, D>::TransformedShape(const TransformedShape<T, D> &ot
 template<typename T, unsigned D>
 inline TransformedShape<T, D> &TransformedShape<T, D>::operator=(const TransformedShape<T, D> &other)
 {
-	delete shape;
 	shape = other.shape->clone();
 	transformation = other.transformation;
 	inverse_trans = other.inverse_trans;
 }
 
 template<typename T, unsigned D>
-inline TransformedShape<T, D>::~TransformedShape()
+inline std::unique_ptr<Shape<T, D>> TransformedShape<T, D>::clone() const
 {
-	delete shape;
-}
-
-template<typename T, unsigned D>
-inline TransformedShape<T, D> *TransformedShape<T, D>::clone() const
-{
-	return new TransformedShape<T, D>(*this);
+	return std::make_unique<TransformedShape<T, D>>(*this);
 }
 
 template<typename T, unsigned D>
diff --git a/source/geometry/union.h b/source/geometry/union.h
index 7d77ed1..e25c750 100644
--- a/source/geometry/union.h
+++ b/source/geometry/union.h
@@ -28,7 +28,7 @@ public:
 	template<typename Iter>
 	static Union from_iterator_range(const Iter &, const Iter &);
 
-	Union *clone() const override;
+	std::unique_ptr<Shape<T, D>> clone() const override;
 };
 
 template<typename T, unsigned D>
@@ -46,9 +46,9 @@ inline Union<T, D> Union<T, D>::from_iterator_range(const Iter &begin, const Ite
 }
 
 template<typename T, unsigned D>
-inline Union<T, D> *Union<T, D>::clone() const
+inline std::unique_ptr<Shape<T, D>> Union<T, D>::clone() const
 {
-	return new Union<T, D>(*this);
+	return std::make_unique<Union<T, D>>(*this);
 }
 
 } // namespace Geometry