]> git.tdb.fi Git - builder.git/commitdiff
Disable warning C4250 on MSVC
authorMikko Rasa <tdb@tdb.fi>
Tue, 5 Sep 2023 09:14:08 +0000 (12:14 +0300)
committerMikko Rasa <tdb@tdb.fi>
Tue, 5 Sep 2023 09:14:08 +0000 (12:14 +0300)
It's emitted when a class inherits a virtual base through multiple ways,
and one of those ways overrides a virtual function from the base.  This
feels more annoying than useful; I'll deal with any ambiguities as they
arise.

plugins/msvc/msvccompiler.cpp

index 3206e5785f9bb9a647aae2d5ee6c3efc95b23168..9eac8724fadbc21b5b170f9f0618d3a76993c641 100644 (file)
@@ -125,6 +125,7 @@ ExternalTask::Arguments MsvcCompiler::_run(const ObjectFile &object, FS::Path &w
                        argv.push_back("/permissive-");
 
                argv.push_back("/wd4068");  // Unknown pragma
+               argv.push_back("/wd4250");  // Virtual function inherited via dominance
                argv.push_back("/wd4251");  // Dll-interface required on type of member variable
                argv.push_back("/wd4275");  // Dll-interface class derives from non-dll-interface class
                if(binfo.warning_level<4)