]> git.tdb.fi Git - libs/game.git/commitdiff
Adjust order of members in Renderer::RenderedEntity
authorMikko Rasa <tdb@tdb.fi>
Sat, 15 Mar 2025 12:55:49 +0000 (14:55 +0200)
committerMikko Rasa <tdb@tdb.fi>
Sat, 15 Mar 2025 12:55:49 +0000 (14:55 +0200)
Since destroying the DynamicMeshSource triggers the destruction of the
MeshRenderer, it's important that the former is destroyed first or there
will be an invalid access to an already destroyed Owned handle.

source/gameview/renderer.h

index 230912bdcafdea9facae4dbb37f8b1ee0a173b73..d26e160c79afcf4199df1b9b42bc309943cfaa9f 100644 (file)
@@ -31,8 +31,8 @@ private:
        struct RenderedEntity
        {
                Game::Handle<Game::Entity> entity;
-               Game::Owned<DynamicMeshSource> generated_mesh;
                Game::Owned<MeshRenderer> mesh_renderer;
+               Game::Owned<DynamicMeshSource> generated_mesh;
                Game::Owned<LightEmitter> light_emitter;
 
                RenderedEntity(Game::Handle<Game::Entity>);