Fix incorrect return value check in get_local_timezone

[libs/core.git] / source / time / timezone.cpp

diff --git a/source/time/timezone.cpp b/source/time/timezone.cpp
index a96e1b51be34ef6672239c358210d4b766d212d5..17d6bad846b981d31e663c1099d7ed81c18fab19 100644 (file)
--- a/source/time/timezone.cpp
+++ b/source/time/timezone.cpp
@@ -6,13 +6,12 @@ Distributed under the LGPL
 */
 
 #include <cstdlib>
-#include <sstream>
-#include <iomanip>
 #ifdef WIN32
 #include <windows.h>
 #else
 #include <fcntl.h>
 #endif
+#include <msp/strings/format.h>
 #include "../core/except.h"
 #include "timestamp.h"
 #include "timezone.h"
@@ -52,7 +51,7 @@ TimeZone get_local_timezone()
        return TimeZone(offset);
 #else
        int fd = open("/etc/localtime", O_RDONLY);
-       if(fd>=-1)
+       if(fd!=-1)
        {
                char hdr[44];
                int len = read(fd, hdr, sizeof(hdr));
@@ -122,12 +121,10 @@ TimeZone::TimeZone(int minutes):
 {
        if(minutes)
        {
-               ostringstream ss;
-               ss.fill('0');
                int m = abs(minutes);
-               ss<<"UTC"<<(minutes<0 ? '-' : '+')<<m/60;
+               name = format("UTC%c%d", (minutes<0 ? '-' : '+'), m/60);
                if(m%60)
-                       ss<<':'<<setw(2)<<m%60;
+                       name += format(":%02d", m%60);
        }
        else
                name = "UTC";