Improvements for handling side effects

[builder.git] / source / filetarget.cpp

diff --git a/source/filetarget.cpp b/source/filetarget.cpp
index b42580a099a0a95eb411bc34fa65345cd72a2b03..6ce5cfdb3bcee336d5b601608c23c8b50b8e2edf 100644 (file)
--- a/source/filetarget.cpp
+++ b/source/filetarget.cpp
@@ -70,7 +70,7 @@ void FileTarget::touch()
 
 void FileTarget::check_rebuild()
 {
-       if(!tool)
+       if(!tool || needs_rebuild())
                return;
 
        if(!mtime)
@@ -89,12 +89,10 @@ void FileTarget::check_rebuild()
 
        if(!needs_rebuild())
        {
+               // Some side effects might not exist
                for(Dependencies::iterator i=side_effects.begin(); (i!=side_effects.end() && !needs_rebuild()); ++i)
-               {
-                       FileTarget *ft = dynamic_cast<FileTarget *>(*i);
-                       if(ft && !ft->get_mtime())
-                               mark_rebuild((*i)->get_name()+" does not exist");
-               }
+                       if((*i)->needs_rebuild())
+                               mark_rebuild((*i)->get_name()+" needs rebuilding");
        }
 
        if(!needs_rebuild() && package)