]> git.tdb.fi Git - r2c2.git/blobdiff - source/libr2c2/arducontrol.cpp
Turn ArduControl command_queue into a Task
[r2c2.git] / source / libr2c2 / arducontrol.cpp
index 47584f44bb8b145496a0b6d9a52c118f4c68fcd9..4acfc60e0e761a0c5aaa7d4c260a0023988a8034 100644 (file)
@@ -1,4 +1,7 @@
 #include <msp/core/maputils.h>
+#include <msp/datafile/writer.h>
+#include <msp/fs/redirectedpath.h>
+#include <msp/fs/stat.h>
 #include <msp/io/print.h>
 #include <msp/time/utils.h>
 #include "arducontrol.h"
@@ -15,19 +18,30 @@ ArduControl::ProtocolInfo ArduControl::protocol_info[2] =
        { 0x3FFF, 126, 15 }  // MFX
 };
 
-ArduControl::ArduControl(const string &dev):
-       serial(dev),
-       debug(1),
+ArduControl::ArduControl(const Options &opts):
+       serial(opts.get<string>(string(), "ttyUSB0")),
+       debug(opts.get<unsigned>("debug")),
+       state_file("arducontrol.state"),
        power(false),
+       halted(false),
        active_accessory(0),
+       command_timeout(200*Time::msec),
        s88(*this),
        mfx_search(*this),
        thread(*this)
 {
+       if(FS::exists(state_file))
+               DataFile::load(*this, state_file.str());
+
+       unsigned max_address = 0;
+       for(MfxInfoArray::const_iterator i=mfx_info.begin(); i!=mfx_info.end(); ++i)
+               max_address = max(max_address, i->address);
+       mfx_search.set_next_address(max_address+1);
+
        PendingCommand cmd;
        cmd.command[0] = READ_POWER_STATE;
        cmd.length = 1;
-       push_command(cmd);
+       command_queue.push(cmd);
 
        cmd.command[0] = MFX_SET_STATION_ID;
        cmd.command[1] = 'R';
@@ -35,7 +49,7 @@ ArduControl::ArduControl(const string &dev):
        cmd.command[3] = 'C';
        cmd.command[4] = '2';
        cmd.length = 5;
-       push_command(cmd);
+       command_queue.push(cmd);
 }
 
 ArduControl::~ArduControl()
@@ -51,12 +65,23 @@ void ArduControl::set_power(bool p)
                cmd.tag.serial = power.serial;
                cmd.command[0] = (p ? POWER_ON : POWER_OFF);
                cmd.length = 1;
-               push_command(cmd);
+               command_queue.push(cmd);
        }
 }
 
-void ArduControl::halt(bool)
+void ArduControl::halt(bool h)
 {
+       if(h==halted)
+               return;
+
+       halted = h;
+       if(halted)
+       {
+               for(LocomotiveMap::const_iterator i=locomotives.begin(); i!=locomotives.end(); ++i)
+                       set_loco_speed(i->first, 0);
+       }
+
+       signal_halt.emit(halted);
 }
 
 const char *ArduControl::enumerate_protocols(unsigned i) const
@@ -107,6 +132,20 @@ unsigned ArduControl::add_loco(unsigned addr, const string &proto_name, const Ve
        return loco.id;
 }
 
+ArduControl::MfxInfoArray::iterator ArduControl::add_mfx_info(const MfxInfo &info)
+{
+       MfxInfoArray::iterator i;
+       for(i=mfx_info.begin(); (i!=mfx_info.end() && i->id!=info.id); ++i) ;
+       if(i==mfx_info.end())
+       {
+               mfx_info.push_back(info);
+               i = --mfx_info.end();
+       }
+       else
+               *i = info;
+       return i;
+}
+
 void ArduControl::remove_loco(unsigned id)
 {
        Locomotive &loco = get_item(locomotives, id);
@@ -120,10 +159,13 @@ void ArduControl::set_loco_speed(unsigned id, unsigned speed)
        if(speed>protocol_info[loco.proto].max_speed)
                throw invalid_argument("ArduControl::set_loco_speed");
 
+       if(speed && halted)
+               return;
+
        if(loco.speed.set(speed))
        {
                PendingCommand cmd(loco, Locomotive::SPEED);
-               push_command(cmd);
+               command_queue.push(cmd);
 
                refresh.add_loco(loco);
        }
@@ -135,7 +177,7 @@ void ArduControl::set_loco_reverse(unsigned id, bool rev)
        if(loco.reverse.set(rev))
        {
                PendingCommand cmd(loco, Locomotive::REVERSE);
-               push_command(cmd);
+               command_queue.push(cmd);
 
                refresh.add_loco(loco);
        }
@@ -153,7 +195,7 @@ void ArduControl::set_loco_function(unsigned id, unsigned func, bool state)
                if(func>0 || loco.proto!=MM)
                {
                        PendingCommand cmd(loco, Locomotive::FUNCTIONS, func);
-                       push_command(cmd);
+                       command_queue.push(cmd);
                }
 
                refresh.add_loco(loco);
@@ -165,7 +207,7 @@ unsigned ArduControl::add_turnout(unsigned addr, const TrackType &type)
        if(!addr || !type.is_turnout())
                throw invalid_argument("ArduControl::add_turnout");
 
-       return add_accessory(Accessory::TURNOUT, addr, type.get_state_bits());
+       return add_accessory(Accessory::TURNOUT, addr, type.get_state_bits(), type.get_paths());
 }
 
 void ArduControl::remove_turnout(unsigned addr)
@@ -185,7 +227,7 @@ unsigned ArduControl::get_turnout(unsigned addr) const
 
 unsigned ArduControl::add_signal(unsigned addr, const SignalType &)
 {
-       return add_accessory(Accessory::SIGNAL, addr, 1);
+       return add_accessory(Accessory::SIGNAL, addr, 1, 3);
 }
 
 void ArduControl::remove_signal(unsigned addr)
@@ -203,7 +245,7 @@ unsigned ArduControl::get_signal(unsigned addr) const
        return get_accessory(Accessory::SIGNAL, addr);
 }
 
-unsigned ArduControl::add_accessory(Accessory::Kind kind, unsigned addr, unsigned bits)
+unsigned ArduControl::add_accessory(Accessory::Kind kind, unsigned addr, unsigned bits, unsigned states)
 {
        AccessoryMap::iterator i = accessories.lower_bound(addr);
        AccessoryMap::iterator j = accessories.upper_bound(addr+bits-1);
@@ -216,7 +258,7 @@ unsigned ArduControl::add_accessory(Accessory::Kind kind, unsigned addr, unsigne
                        throw key_error(addr);
        }
 
-       insert_unique(accessories, addr, Accessory(kind, addr, bits));
+       insert_unique(accessories, addr, Accessory(kind, addr, bits, states));
        return addr;
 }
 
@@ -234,7 +276,7 @@ void ArduControl::set_accessory(Accessory::Kind kind, unsigned addr, unsigned st
        if(acc.kind!=kind)
                throw key_error(addr);
 
-       if(state!=acc.target)
+       if(state!=acc.target || acc.uncertain)
        {
                acc.target = state;
                accessory_queue.push_back(&acc);
@@ -249,6 +291,20 @@ unsigned ArduControl::get_accessory(Accessory::Kind kind, unsigned addr) const
        return acc.state;
 }
 
+void ArduControl::activate_accessory_by_mask(Accessory &acc, unsigned mask)
+{
+       unsigned bit = mask&~(mask-1);
+       for(active_index=0; (bit>>active_index)>1; ++active_index) ;
+       acc.state.set((acc.state&~bit)|(acc.target&bit));
+       if(debug>=1)
+               IO::print("Setting accessory %d bit %d, state=%d\n", acc.address, active_index, acc.state.pending);
+       PendingCommand cmd(acc, Accessory::ACTIVATE, active_index);
+       command_queue.push(cmd);
+       active_accessory = &acc;
+
+       monitor.reset_peak();
+}
+
 unsigned ArduControl::add_sensor(unsigned addr)
 {
        if(!addr)
@@ -273,7 +329,8 @@ bool ArduControl::get_sensor(unsigned addr) const
 
 void ArduControl::tick()
 {
-       while(Tag tag = pop_completed_tag())
+       Tag tag;
+       while(completed_commands.pop(tag))
        {
                if(tag.type==Tag::GENERAL)
                {
@@ -287,15 +344,8 @@ void ArduControl::tick()
                                MfxInfo info;
                                if(mfx_search.pop_info(info))
                                {
-                                       MfxInfoArray::iterator i;
-                                       for(i=mfx_info.begin(); (i!=mfx_info.end() && i->id!=info.id); ++i) ;
-                                       if(i==mfx_info.end())
-                                       {
-                                               mfx_info.push_back(info);
-                                               i = --mfx_info.end();
-                                       }
-                                       else
-                                               *i = info;
+                                       MfxInfoArray::iterator i = add_mfx_info(info);
+                                       save_state();
                                        signal_locomotive_detected.emit(*i);
                                }
                        }
@@ -337,20 +387,11 @@ void ArduControl::tick()
 
                        Accessory &acc = i->second;
                        if(tag.command==Accessory::ACTIVATE)
-                       {
                                off_timeout = Time::now()+acc.active_time;
-                       }
                        else if(tag.command==Accessory::DEACTIVATE)
                        {
                                if(acc.state.commit(tag.serial))
                                {
-                                       if(acc.state==acc.target)
-                                       {
-                                               if(acc.kind==Accessory::TURNOUT)
-                                                       signal_turnout.emit(acc.address, acc.state);
-                                               else if(acc.kind==Accessory::SIGNAL)
-                                                       signal_signal.emit(acc.address, acc.state);
-                                       }
                                        if(&acc==active_accessory)
                                                active_accessory = 0;
                                }
@@ -371,72 +412,104 @@ void ArduControl::tick()
                }
        }
 
-       while(!active_accessory && !accessory_queue.empty())
+       while(power && !active_accessory && !accessory_queue.empty())
        {
                Accessory &acc = *accessory_queue.front();
 
-               if(acc.state!=acc.target)
+               if(acc.uncertain)
+               {
+                       unsigned zeroes = acc.uncertain&~acc.target;
+                       if(zeroes)
+                               activate_accessory_by_mask(acc, zeroes);
+                       else
+                               activate_accessory_by_mask(acc, acc.uncertain);
+               }
+               else if(acc.state!=acc.target)
                {
-                       active_accessory = &acc;
-
                        unsigned changes = acc.state^acc.target;
-                       unsigned lowest_bit = changes&~(changes-1);
-                       unsigned i;
-                       for(i=0; (lowest_bit>>i)>1; ++i) ;
-                       acc.state.set(acc.state^lowest_bit);
-                       PendingCommand cmd(acc, Accessory::ACTIVATE, i);
-                       push_command(cmd);
+                       if(!(changes&((1<<acc.bits)-1)))
+                       {
+                               // All remaining changes are in non-physical bits
+                               acc.state.set(acc.state^changes);
+                               acc.state.commit(acc.state.serial);
+                       }
+                       else
+                       {
+                               unsigned toggle_bit = 0;
+                               for(unsigned bit=1; (!toggle_bit && bit<=changes); bit<<=1)
+                                       if((changes&bit) && (acc.valid_states&(1<<(acc.state^bit))))
+                                               toggle_bit = bit;
+
+                               activate_accessory_by_mask(acc, toggle_bit);
+                       }
                }
                else
+               {
                        accessory_queue.pop_front();
+
+                       if(acc.state==acc.target)
+                       {
+                               if(acc.kind==Accessory::TURNOUT)
+                                       signal_turnout.emit(acc.address, acc.state);
+                               else if(acc.kind==Accessory::SIGNAL)
+                                       signal_signal.emit(acc.address, acc.state);
+                       }
+               }
        }
 
        if(active_accessory && off_timeout)
        {
+               bool success = (monitor.get_peak()>0.35f && monitor.get_current()<monitor.get_peak()-0.2f);
                Time::TimeStamp t = Time::now();
-               if(t>off_timeout)
+               if(t>off_timeout || success)
                {
+                       Accessory &acc = *active_accessory;
+
+                       unsigned bit = 1<<active_index;
+
+                       // Assume success if we were uncertain of the physical setting
+                       if(acc.uncertain&bit)
+                               acc.uncertain &= ~bit;
+                       else if(acc.kind==Accessory::TURNOUT && !success)
+                       {
+                               if(debug>=1)
+                                       IO::print("Peak current only %.2f A\n", monitor.get_peak());
+                               signal_turnout_failed.emit(acc.address);
+                               acc.state.rollback();
+                               if(acc.valid_states&(1<<(acc.target^bit)))
+                                       acc.target ^= bit;
+                               else
+                                       acc.target = acc.state;
+                       }
+
                        off_timeout = Time::TimeStamp();
-                       PendingCommand cmd(*active_accessory, Accessory::DEACTIVATE);
-                       push_command(cmd);
+                       PendingCommand cmd(acc, Accessory::DEACTIVATE, active_index);
+                       command_queue.push(cmd);
                }
        }
 }
 
 void ArduControl::flush()
 {
+       while(!command_queue.empty() || (power && !accessory_queue.empty()))
+               tick();
 }
 
-void ArduControl::push_command(const PendingCommand &cmd)
-{
-       MutexLock lock(mutex);
-       command_queue.push_back(cmd);
-}
-
-bool ArduControl::pop_command(PendingCommand &cmd)
-{
-       MutexLock lock(mutex);
-       if(command_queue.empty())
-               return false;
-       cmd = command_queue.front();
-       command_queue.pop_front();
-       return true;
-}
-
-void ArduControl::push_completed_tag(const Tag &tag)
+void ArduControl::save_state() const
 {
-       MutexLock lock(mutex);
-       completed_commands.push_back(tag);
-}
+       FS::RedirectedPath tmp_file(state_file);
+       IO::BufferedFile out(tmp_file.str(), IO::M_WRITE);
+       DataFile::Writer writer(out);
 
-ArduControl::Tag ArduControl::pop_completed_tag()
-{
-       MutexLock lock(mutex);
-       if(completed_commands.empty())
-               return Tag();
-       Tag tag = completed_commands.front();
-       completed_commands.pop_front();
-       return tag;
+       writer.write((DataFile::Statement("mfx_announce_serial"), mfx_announce.get_serial()));
+       for(MfxInfoArray::const_iterator i=mfx_info.begin(); i!=mfx_info.end(); ++i)
+       {
+               DataFile::Statement st("mfx_locomotive");
+               st.append(i->id);
+               st.sub.push_back((DataFile::Statement("address"), i->address));
+               st.sub.push_back((DataFile::Statement("name"), i->name));
+               writer.write(st);
+       }
 }
 
 
@@ -517,12 +590,15 @@ unsigned ArduControl::Locomotive::create_speed_func_command(unsigned f, char *bu
 }
 
 
-ArduControl::Accessory::Accessory(Kind k, unsigned a, unsigned b):
+ArduControl::Accessory::Accessory(Kind k, unsigned a, unsigned b, unsigned s):
        kind(k),
        address(a),
        bits(b),
+       valid_states(s),
        state(0),
-       active_time(500*Time::msec)
+       uncertain((1<<bits)-1),
+       target(0),
+       active_time((bits*700)*Time::msec)
 { }
 
 unsigned ArduControl::Accessory::create_state_command(unsigned b, bool c, char *buffer) const
@@ -600,6 +676,43 @@ ArduControl::PendingCommand::PendingCommand(Accessory &acc, Accessory::Command c
 }
 
 
+template<typename T>
+void ArduControl::Queue<T>::push(const T &item)
+{
+       MutexLock lock(mutex);
+       items.push_back(item);
+}
+
+template<typename T>
+bool ArduControl::Queue<T>::pop(T &item)
+{
+       MutexLock lock(mutex);
+       if(items.empty())
+               return false;
+
+       item = items.front();
+       items.pop_front();
+       return true;
+}
+
+template<typename T>
+bool ArduControl::Queue<T>::empty() const
+{
+       return items.empty();
+}
+
+
+bool ArduControl::CommandQueueTask::get_work(PendingCommand &cmd)
+{
+       return queue.pop(cmd);
+}
+
+void ArduControl::CommandQueueTask::push(const PendingCommand &cmd)
+{
+       queue.push(cmd);
+}
+
+
 ArduControl::RefreshTask::RefreshTask():
        next(cycle.end()),
        round(0),
@@ -696,11 +809,17 @@ void ArduControl::RefreshTask::advance()
 ArduControl::S88Task::S88Task(ArduControl &c):
        control(c),
        n_octets(0),
-       octets_remaining(0)
+       octets_remaining(0),
+       delay(0)
 { }
 
 bool ArduControl::S88Task::get_work(PendingCommand &cmd)
 {
+       if(delay)
+       {
+               --delay;
+               return false;
+       }
        if(octets_remaining || !n_octets)
                return false;
 
@@ -709,6 +828,8 @@ bool ArduControl::S88Task::get_work(PendingCommand &cmd)
        cmd.command[1] = octets_remaining;
        cmd.length = 2;
 
+       delay = 4;
+
        return true;
 }
 
@@ -733,7 +854,7 @@ void ArduControl::S88Task::process_reply(const char *reply, unsigned length)
                        tag.command = Sensor::STATE;
                        tag.serial = i->second.state.serial;
                        tag.id = i->first;
-                       control.push_completed_tag(tag);
+                       control.completed_commands.push(tag);
                }
 
                if(count>octets_remaining)
@@ -800,7 +921,7 @@ bool ArduControl::MfxSearchTask::get_work(PendingCommand &cmd)
                info.address = next_address;
                info.name = format("%08X", bits);
                info.id = bits;
-               push_info(info);
+               queue.push(info);
 
                cmd.command[0] = MFX_ASSIGN_ADDRESS;
                cmd.command[1] = next_address>>8;
@@ -863,27 +984,70 @@ void ArduControl::MfxSearchTask::process_reply(const char *reply, unsigned lengt
        }
 }
 
-void ArduControl::MfxSearchTask::push_info(const MfxInfo &info)
+void ArduControl::MfxSearchTask::set_next_address(unsigned a)
 {
-       MutexLock lock(mutex);
-       queue.push_back(info);
+       next_address = a;
 }
 
 bool ArduControl::MfxSearchTask::pop_info(MfxInfo &info)
 {
-       MutexLock lock(mutex);
-       if(queue.empty())
+       return queue.pop(info);
+}
+
+
+ArduControl::MonitorTask::MonitorTask():
+       voltage(0),
+       current(0),
+       base_level(0),
+       peak_level(0),
+       next_type(0)
+{ }
+
+bool ArduControl::MonitorTask::get_work(PendingCommand &cmd)
+{
+       Time::TimeStamp t = Time::now();
+       if(t<next_poll)
                return false;
-       info = queue.back();
-       queue.pop_back();
+
+       if(next_type==0)
+               cmd.command[0] = READ_INPUT_VOLTAGE;
+       else
+               cmd.command[0] = READ_TRACK_CURRENT;
+       cmd.length = 1;
+
+       next_poll = t+200*Time::msec;
+       next_type = (next_type+1)%5;
+
        return true;
 }
 
+void ArduControl::MonitorTask::process_reply(const char *reply, unsigned length)
+{
+       unsigned char type = reply[0];
+       if(type==INPUT_VOLTAGE && length==3)
+               voltage = ((static_cast<unsigned char>(reply[1])<<8) | static_cast<unsigned char>(reply[2]))/1000.0f;
+       else if(type==TRACK_CURRENT && length==5)
+       {
+               current = ((static_cast<unsigned char>(reply[1])<<8) | static_cast<unsigned char>(reply[2]))/1000.0f;
+               float peak = ((static_cast<unsigned char>(reply[3])<<8) | static_cast<unsigned char>(reply[4]))/1000.0f;
+               peak_level = max(peak_level, peak);
+               base_level = min(base_level, current);
+       }
+}
+
+void ArduControl::MonitorTask::reset_peak()
+{
+       base_level = current;
+       peak_level = current;
+}
+
 
 ArduControl::ControlThread::ControlThread(ArduControl &c):
        control(c),
        done(false)
 {
+       tasks.push_back(&control.command_queue);
+       tasks.push_back(&control.monitor);
        tasks.push_back(&control.mfx_announce);
        tasks.push_back(&control.mfx_search);
        tasks.push_back(&control.s88);
@@ -908,10 +1072,41 @@ void ArduControl::ControlThread::main()
                if(get_work(cmd))
                {
                        bool success = true;
+                       bool resync = false;
                        for(unsigned i=0; (success && i<cmd.repeat_count); ++i)
-                               success = (do_command(cmd)==COMMAND_OK);
+                       {
+                               unsigned result = do_command(cmd, control.command_timeout);
+                               success = (result==COMMAND_OK);
+                               resync = (result==0);
+                       }
+
                        if(success && cmd.tag)
-                               control.push_completed_tag(cmd.tag);
+                               control.completed_commands.push(cmd.tag);
+
+                       if(resync)
+                       {
+                               if(control.debug>=1)
+                                       IO::print("Synchronization with ArduControl lost, attempting to recover\n");
+                               for(unsigned i=0; (resync && i<16); ++i)
+                               {
+                                       control.serial.put('\xFF');
+                                       while(IO::poll(control.serial, IO::P_INPUT, control.command_timeout))
+                                               resync = (control.serial.get()!=0xFF);
+                               }
+                               if(resync)
+                               {
+                                       if(control.debug>=1)
+                                               IO::print("Resynchronization failed, giving up\n");
+                                       done = true;
+                               }
+                               else
+                               {
+                                       if(control.debug>=1)
+                                               IO::print("Resynchronization successful\n");
+                                       if(cmd.tag)
+                                               control.command_queue.push(cmd);
+                               }
+                       }
                }
                else
                        Time::sleep(10*Time::msec);
@@ -940,6 +1135,14 @@ void ArduControl::ControlThread::init_baud_rate()
                }
        }
 
+       if(!rate)
+       {
+               if(control.debug>=1)
+                       IO::print("ArduControl detection failed\n");
+               done = true;
+               return;
+       }
+
        if(control.debug>=1)
                IO::print("ArduControl detected at %d bits/s\n", rate);
 
@@ -950,12 +1153,12 @@ void ArduControl::ControlThread::init_baud_rate()
                cmd.command[1] = rates[0]>>8;
                cmd.command[2] = rates[0];
                cmd.length = 3;
-               if(do_command(cmd)==COMMAND_OK)
+               if(do_command(cmd, Time::sec)==COMMAND_OK)
                {
                        control.serial.set_baud_rate(rates[0]);
-                       if(do_command(cmd)==COMMAND_OK)
+                       Time::sleep(Time::sec);
+                       if(do_command(cmd, Time::sec)==COMMAND_OK)
                        {
-                               Time::sleep(Time::sec);
                                if(control.debug>=1)
                                        IO::print("Rate changed to %d bits/s\n", rates[0]);
                        }
@@ -965,9 +1168,6 @@ void ArduControl::ControlThread::init_baud_rate()
 
 bool ArduControl::ControlThread::get_work(PendingCommand &cmd)
 {
-       if(control.pop_command(cmd))
-               return true;
-
        for(vector<Task *>::iterator i=tasks.begin(); i!=tasks.end(); ++i)
                if((*i)->get_work(cmd))
                        return true;
@@ -982,7 +1182,7 @@ bool ArduControl::ControlThread::get_work(PendingCommand &cmd)
        return true;
 }
 
-unsigned ArduControl::ControlThread::do_command(const PendingCommand &cmd)
+unsigned ArduControl::ControlThread::do_command(const PendingCommand &cmd, const Time::TimeDelta &timeout)
 {
        if(control.debug>=2)
        {
@@ -1002,7 +1202,7 @@ unsigned ArduControl::ControlThread::do_command(const PendingCommand &cmd)
                if(result)
                        got_data = IO::poll(control.serial, IO::P_INPUT, Time::zero);
                else
-                       got_data = IO::poll(control.serial, IO::P_INPUT);
+                       got_data = IO::poll(control.serial, IO::P_INPUT, timeout);
 
                if(!got_data)
                        break;
@@ -1017,7 +1217,11 @@ unsigned ArduControl::ControlThread::do_command(const PendingCommand &cmd)
                char reply[15];
                unsigned pos = 0;
                while(pos<rlength)
+               {
+                       if(!IO::poll(control.serial, IO::P_INPUT, timeout))
+                               return 0;
                        pos += control.serial.read(reply+pos, rlength-pos);
+               }
 
                if(control.debug>=2)
                {
@@ -1045,14 +1249,11 @@ unsigned ArduControl::ControlThread::process_reply(const char *reply, unsigned r
                return type;
        }
        else if(type==POWER_STATE && rlength==2)
+               set_power(reply[1]);
+       else if(type==OVERCURRENT)
        {
-               control.power.set(reply[1]);
-
-               Tag tag;
-               tag.type = Tag::GENERAL;
-               tag.command = POWER;
-               tag.serial = control.power.serial;
-               control.push_completed_tag(tag);
+               set_power(false);
+               IO::print("Overcurrent detected!\n");
        }
        else
        {
@@ -1063,4 +1264,45 @@ unsigned ArduControl::ControlThread::process_reply(const char *reply, unsigned r
        return 0;
 }
 
+void ArduControl::ControlThread::set_power(bool p)
+{
+       control.power.set(p);
+
+       Tag tag;
+       tag.type = Tag::GENERAL;
+       tag.command = POWER;
+       tag.serial = control.power.serial;
+       control.completed_commands.push(tag);
+}
+
+
+ArduControl::Loader::Loader(ArduControl &c):
+       DataFile::ObjectLoader<ArduControl>(c)
+{
+       add("mfx_announce_serial", &Loader::mfx_announce_serial);
+       add("mfx_locomotive", &Loader::mfx_locomotive);
+}
+
+void ArduControl::Loader::mfx_announce_serial(unsigned s)
+{
+       obj.mfx_announce.set_serial(s);
+}
+
+void ArduControl::Loader::mfx_locomotive(unsigned id)
+{
+       MfxInfo info;
+       info.id = id;
+       info.protocol = "MFX";
+       load_sub(info);
+       obj.add_mfx_info(info);
+}
+
+
+ArduControl::MfxInfo::Loader::Loader(MfxInfo &i):
+       DataFile::ObjectLoader<MfxInfo>(i)
+{
+       add("address", static_cast<unsigned MfxInfo::*>(&MfxInfo::address));
+       add("name", static_cast<string MfxInfo::*>(&MfxInfo::name));
+}
+
 } // namespace R2C2