if(!addr || !type.is_turnout())
throw invalid_argument("ArduControl::add_turnout");
- return add_accessory(Accessory::TURNOUT, addr, type.get_state_bits());
+ return add_accessory(Accessory::TURNOUT, addr, type.get_state_bits(), type.get_paths());
}
void ArduControl::remove_turnout(unsigned addr)
unsigned ArduControl::add_signal(unsigned addr, const SignalType &)
{
- return add_accessory(Accessory::SIGNAL, addr, 1);
+ return add_accessory(Accessory::SIGNAL, addr, 1, 3);
}
void ArduControl::remove_signal(unsigned addr)
return get_accessory(Accessory::SIGNAL, addr);
}
-unsigned ArduControl::add_accessory(Accessory::Kind kind, unsigned addr, unsigned bits)
+unsigned ArduControl::add_accessory(Accessory::Kind kind, unsigned addr, unsigned bits, unsigned states)
{
AccessoryMap::iterator i = accessories.lower_bound(addr);
AccessoryMap::iterator j = accessories.upper_bound(addr+bits-1);
throw key_error(addr);
}
- insert_unique(accessories, addr, Accessory(kind, addr, bits));
+ insert_unique(accessories, addr, Accessory(kind, addr, bits, states));
return addr;
}
return acc.state;
}
+void ArduControl::activate_accessory_by_mask(Accessory &acc, unsigned mask)
+{
+ unsigned bit = mask&~(mask-1);
+ for(active_index=0; (bit>>active_index)>1; ++active_index) ;
+ acc.state.set((acc.state&~bit)|(acc.target&bit));
+ if(debug>=1)
+ IO::print("Setting accessory %d bit %d, state=%d\n", acc.address, active_index, acc.state.pending);
+ PendingCommand cmd(acc, Accessory::ACTIVATE, active_index);
+ command_queue.push(cmd);
+ active_accessory = &acc;
+
+ monitor.reset_peak();
+}
+
unsigned ArduControl::add_sensor(unsigned addr)
{
if(!addr)
{
Accessory &acc = *accessory_queue.front();
- if(acc.state!=acc.target || acc.uncertain)
+ if(acc.uncertain)
+ {
+ unsigned zeroes = acc.uncertain&~acc.target;
+ if(zeroes)
+ activate_accessory_by_mask(acc, zeroes);
+ else
+ activate_accessory_by_mask(acc, acc.uncertain);
+ }
+ else if(acc.state!=acc.target)
{
unsigned changes = acc.state^acc.target;
- unsigned lowest_bit = changes&~(changes-1);
- if(lowest_bit>>acc.bits)
+ if(!(changes&((1<<acc.bits)-1)))
{
// All remaining changes are in non-physical bits
acc.state.set(acc.state^changes);
}
else
{
- unsigned mask = (lowest_bit ? lowest_bit : acc.uncertain);
- for(active_index=0; (mask>>active_index)>1; ++active_index) ;
- acc.state.set(acc.state^lowest_bit);
- PendingCommand cmd(acc, Accessory::ACTIVATE, active_index);
- command_queue.push(cmd);
- active_accessory = &acc;
-
- monitor.reset_peak();
+ unsigned toggle_bit = 0;
+ for(unsigned bit=1; (!toggle_bit && bit<=changes); bit<<=1)
+ if((changes&bit) && (acc.valid_states&(1<<(acc.state^bit))))
+ toggle_bit = bit;
+
+ activate_accessory_by_mask(acc, toggle_bit);
}
}
else
if(active_accessory && off_timeout)
{
+ bool success = (monitor.get_peak()>0.35f && monitor.get_current()<monitor.get_peak()-0.2f);
Time::TimeStamp t = Time::now();
- if(t>off_timeout)
+ if(t>off_timeout || success)
{
Accessory &acc = *active_accessory;
// Assume success if we were uncertain of the physical setting
if(acc.uncertain&bit)
acc.uncertain &= ~bit;
- else if(acc.kind==Accessory::TURNOUT && monitor.get_peak()<0.5f)
+ else if(acc.kind==Accessory::TURNOUT && !success)
{
+ if(debug>=1)
+ IO::print("Peak current only %.2f A\n", monitor.get_peak());
signal_turnout_failed.emit(acc.address);
acc.state.rollback();
- acc.target ^= bit;
+ if(acc.valid_states&(1<<(acc.target^bit)))
+ acc.target ^= bit;
+ else
+ acc.target = acc.state;
}
off_timeout = Time::TimeStamp();
}
-ArduControl::Accessory::Accessory(Kind k, unsigned a, unsigned b):
+ArduControl::Accessory::Accessory(Kind k, unsigned a, unsigned b, unsigned s):
kind(k),
address(a),
bits(b),
+ valid_states(s),
state(0),
uncertain((1<<bits)-1),
target(0),
- active_time(500*Time::msec)
+ active_time((bits*700)*Time::msec)
{ }
unsigned ArduControl::Accessory::create_state_command(unsigned b, bool c, char *buffer) const
}
+bool ArduControl::CommandQueueTask::get_work(PendingCommand &cmd)
+{
+ return queue.pop(cmd);
+}
+
+void ArduControl::CommandQueueTask::push(const PendingCommand &cmd)
+{
+ queue.push(cmd);
+}
+
+
+ArduControl::Task::Task(const string &n, unsigned p):
+ name(n),
+ priority(p)
+{ }
+
+void ArduControl::Task::sleep(const Time::TimeDelta &dt)
+{
+ sleep_timeout = Time::now()+dt;
+}
+
+
+ArduControl::CommandQueueTask::CommandQueueTask():
+ Task("CommandQueue")
+{ }
+
+
ArduControl::RefreshTask::RefreshTask():
+ Task("Refresh", 2),
next(cycle.end()),
round(0),
loco(0),
ArduControl::S88Task::S88Task(ArduControl &c):
+ Task("S88"),
control(c),
n_octets(0),
- octets_remaining(0),
- delay(0)
+ octets_remaining(0)
{ }
bool ArduControl::S88Task::get_work(PendingCommand &cmd)
{
- if(delay)
- {
- --delay;
- return false;
- }
if(octets_remaining || !n_octets)
return false;
cmd.command[1] = octets_remaining;
cmd.length = 2;
- delay = 4;
+ sleep(100*Time::msec);
return true;
}
ArduControl::MfxAnnounceTask::MfxAnnounceTask():
+ Task("MfxAnnounce", 1),
serial(0)
{ }
bool ArduControl::MfxAnnounceTask::get_work(PendingCommand &cmd)
{
- Time::TimeStamp t = Time::now();
- if(t<next)
- return false;
-
cmd.command[0] = MFX_ANNOUNCE;
cmd.command[1] = serial>>8;
cmd.command[2] = serial;
cmd.length = 3;
- next = t+400*Time::msec;
+
+ sleep(400*Time::msec);
return true;
}
ArduControl::MfxSearchTask::MfxSearchTask(ArduControl &c):
+ Task("MfxSearch", 1),
control(c),
next_address(1),
size(0),
return true;
}
- Time::TimeStamp t = Time::now();
- if(t<next)
- return false;
-
cmd.command[0] = MFX_SEARCH;
for(unsigned i=0; i<4; ++i)
cmd.command[1+i] = bits>>(24-i*8);
cmd.command[5] = size;
cmd.length = 6;
- next = t+200*Time::msec;
+ sleep(200*Time::msec);
if(control.debug>=1)
IO::print("Search %08X/%d\n", bits, size);
}
else
{
- next = Time::now()+2*Time::sec;
+ sleep(2*Time::sec);
bits = 0;
size = 0;
misses = 0;
ArduControl::MonitorTask::MonitorTask():
+ Task("Monitor"),
voltage(0),
current(0),
base_level(0),
bool ArduControl::MonitorTask::get_work(PendingCommand &cmd)
{
- Time::TimeStamp t = Time::now();
- if(t<next_poll)
- return false;
-
if(next_type==0)
cmd.command[0] = READ_INPUT_VOLTAGE;
else
cmd.command[0] = READ_TRACK_CURRENT;
cmd.length = 1;
- next_poll = t+200*Time::msec;
+ sleep(200*Time::msec);
next_type = (next_type+1)%5;
return true;
control(c),
done(false)
{
+ tasks.push_back(&control.command_queue);
tasks.push_back(&control.monitor);
tasks.push_back(&control.mfx_announce);
tasks.push_back(&control.mfx_search);
bool ArduControl::ControlThread::get_work(PendingCommand &cmd)
{
- if(control.command_queue.pop(cmd))
- return true;
+ Time::TimeStamp t = Time::now();
+
+ unsigned count = 0;
+ for(; (count<tasks.size() && tasks[count]->get_sleep_timeout()<=t); ++count) ;
+
+ for(; count>0; --count)
+ {
+ unsigned i = 0;
+ for(unsigned j=1; j<count; ++j)
+ if(tasks[j]->get_priority()<tasks[i]->get_priority())
+ i = j;
- for(vector<Task *>::iterator i=tasks.begin(); i!=tasks.end(); ++i)
- if((*i)->get_work(cmd))
+ Task *task = tasks[i];
+ bool result = task->get_work(cmd);
+
+ Time::TimeStamp st = max(task->get_sleep_timeout(), t);
+ for(; (i+1<tasks.size() && tasks[i+1]->get_sleep_timeout()<=st); ++i)
+ tasks[i] = tasks[i+1];
+ tasks[i] = task;
+
+ if(result)
+ {
+ if(control.debug>=2)
+ IO::print("Scheduled task %s\n", task->get_name());
return true;
+ }
+ }
// As fallback, send an idle packet for the MM protocol
cmd.command[0] = MOTOROLA_SPEED;