From: Mikko Rasa <tdb@tdb.fi>
Date: Fri, 17 Aug 2018 15:49:27 +0000 (+0300)
Subject: Remove duplicates when merging choice conditions
X-Git-Url: http://git.tdb.fi/?p=poefilter.git;a=commitdiff_plain;h=3169efbcaa882c427d9cc1bbb6dbd187efe98f45

Remove duplicates when merging choice conditions
---

diff --git a/source/choicecondition.h b/source/choicecondition.h
index 91b5e71..c2f7f0e 100644
--- a/source/choicecondition.h
+++ b/source/choicecondition.h
@@ -1,6 +1,7 @@
 #ifndef CHOICECONDITION_H_
 #define CHOICECONDITION_H_
 
+#include <msp/core/algorithm.h>
 #include "condition.h"
 #include "filter.h"
 
@@ -71,14 +72,13 @@ ChoiceCondition<T> *ChoiceCondition<T>::merge(const std::vector<Condition *> &co
 {
 	if(dynamic_cast<const OrCondition *>(&parent) && !conditions.empty())
 	{
-		ChoiceCondition<T> *result = 0;
+		ChoiceCondition<T> *result = new ChoiceCondition<T>(std::vector<Type>());
 		for(std::vector<Condition *>::const_iterator i=conditions.begin(); i!=conditions.end(); ++i)
 		{
 			const std::vector<Type> &v = static_cast<ChoiceCondition<T> *>(*i)->values;
-			if(!result)
-				result = new ChoiceCondition<T>(v);
-			else
-				result->values.insert(result->values.end(), v.begin(), v.end());
+			for(typename std::vector<Type>::const_iterator j=v.begin(); j!=v.end(); ++j)
+				if(Msp::find(result->values, *j)==result->values.end())
+					result->values.push_back(*j);
 		}
 		return result;
 	}