From 643aa7b2317f88463f66da11e595ebe0f6c9621d Mon Sep 17 00:00:00 2001
From: Mikko Rasa <tdb@tdb.fi>
Date: Tue, 21 May 2013 16:32:49 +0300
Subject: [PATCH] Math function usage fixes

Add using declarations and #includes where needed, and clean up some
unnecessary ones.  abs() is particularly annoying, as the int version
easily gets into the global namespace and doesn't give a warning if
used with floats or doubles.
---
 source/geometry/extrudedshape.h | 2 --
 source/geometry/hyperbox.h      | 2 ++
 source/geometry/hypersphere.h   | 3 +++
 source/linal/squarematrix.h     | 3 +++
 source/linal/vector.h           | 1 +
 5 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/source/geometry/extrudedshape.h b/source/geometry/extrudedshape.h
index 8fac4bc..0d895ac 100644
--- a/source/geometry/extrudedshape.h
+++ b/source/geometry/extrudedshape.h
@@ -107,8 +107,6 @@ inline unsigned ExtrudedShape<T, D>::get_max_ray_intersections() const
 template<typename T, unsigned D>
 inline unsigned ExtrudedShape<T, D>::get_intersections(const Ray<T, D> &ray, SurfacePoint<T, D> *points, unsigned size) const
 {
-	using std::abs;
-	using std::sqrt;
 	using std::swap;
 
 	unsigned n = 0;
diff --git a/source/geometry/hyperbox.h b/source/geometry/hyperbox.h
index 845ca34..865b968 100644
--- a/source/geometry/hyperbox.h
+++ b/source/geometry/hyperbox.h
@@ -64,6 +64,8 @@ inline T HyperBox<T, D>::get_dimension(unsigned i) const
 template<typename T, unsigned D>
 inline bool HyperBox<T, D>::contains(const LinAl::Vector<T, D> &point) const
 {
+	using std::abs;
+
 	for(unsigned i=0; i<D; ++i)
 		if(abs(point[i])>dimensions[i]/2)
 			return false;
diff --git a/source/geometry/hypersphere.h b/source/geometry/hypersphere.h
index ce424e1..01aee0e 100644
--- a/source/geometry/hypersphere.h
+++ b/source/geometry/hypersphere.h
@@ -1,6 +1,7 @@
 #ifndef MSP_GEOMETRY_HYPERSPHERE_H_
 #define MSP_GEOMETRY_HYPERSPHERE_H_
 
+#include <cmath>
 #include <msp/linal/vector.h>
 #include "hyperbox.h"
 #include "ray.h"
@@ -79,6 +80,8 @@ inline bool HyperSphere<T, D>::check_intersection(const Ray<T, D> &ray) const
 template<typename T, unsigned D>
 inline unsigned HyperSphere<T, D>::get_intersections(const Ray<T, D> &ray, SurfacePoint<T, D> *points, unsigned size) const
 {
+	using std::sqrt;
+
 	T mid = -inner_product(ray.get_direction(), ray.get_start());
 	LinAl::Vector<T, D> nearest = ray.get_start()+ray.get_direction()*mid;
 	T offset_sq = radius*radius-inner_product(nearest, nearest);
diff --git a/source/linal/squarematrix.h b/source/linal/squarematrix.h
index 0af9a74..1cdc567 100644
--- a/source/linal/squarematrix.h
+++ b/source/linal/squarematrix.h
@@ -1,6 +1,7 @@
 #ifndef MSP_LINAL_SQUAREMATRIX_H_
 #define MSP_LINAL_SQUAREMATRIX_H_
 
+#include <cmath>
 #include <stdexcept>
 #include "matrix.h"
 
@@ -52,6 +53,8 @@ SquareMatrix<T, S> &SquareMatrix<T, S>::operator*=(const SquareMatrix<T, S> &m)
 template<typename T, unsigned S>
 SquareMatrix<T, S> &SquareMatrix<T, S>::invert()
 {
+	using std::abs;
+
 	SquareMatrix<T, S> r = identity();
 	for(unsigned i=0; i<S; ++i)
 	{
diff --git a/source/linal/vector.h b/source/linal/vector.h
index a5c9a26..9ef46fd 100644
--- a/source/linal/vector.h
+++ b/source/linal/vector.h
@@ -257,6 +257,7 @@ inline T inner_product(const Vector<T, N> &v1, const Vector<T, N> &v2)
 template<typename T, unsigned N>
 inline T Vector<T, N>::norm() const
 {
+	using std::sqrt;
 	return sqrt(inner_product(*this, *this));
 }
 
-- 
2.43.0