Add some state checking to ImageLoader

[libs/gui.git] / source / graphics / imageloader.cpp

diff --git a/source/graphics/imageloader.cpp b/source/graphics/imageloader.cpp
index fbba25cd75ae59ce6e194134caea9141e79a2177..2c6ce217381f4dcbf1f33bec50104eeee6c1987c 100644 (file)
--- a/source/graphics/imageloader.cpp
+++ b/source/graphics/imageloader.cpp
@@ -1,6 +1,7 @@
 #include <msp/core/refptr.h>
 #include <msp/io/file.h>
 #include <msp/strings/format.h>
+#include "bmploader.h"
 #include "imageloader.h"
 #ifdef WITH_LIBPNG
 #include "png/pngloader.h"
@@ -20,10 +21,9 @@ using namespace std;
 namespace Msp {
 namespace Graphics {
 
-bool ImageLoader::registered_loaders_changed = false;
-
 ImageLoader::ImageLoader():
-       source(0)
+       source(0),
+       state(INITIAL)
 { }
 
 ImageLoader::~ImageLoader()
@@ -48,35 +48,22 @@ ImageLoader *ImageLoader::open_file(const string &fn)
 
 ImageLoader *ImageLoader::open_io(IO::Seekable &io)
 {
-#ifdef WITH_LIBPNG
-       (void)RegisteredImageLoader<PngLoader>::reg;
-#endif
-#ifdef WITH_LIBJPEG
-       (void)RegisteredImageLoader<JpegLoader>::reg;
-#endif
-#ifdef WITH_DEVIL
-       (void)RegisteredImageLoader<DevilLoader>::reg;
-#endif
-#ifdef WITH_QUARTZ
-       (void)RegisteredImageLoader<QuartzLoader>::reg;
-#endif
-
-       list<RegisterBase *> &loaders = get_registered_loaders();
-       if(registered_loaders_changed)
+       Registry &registry = get_registry();
+       if(registry.changed)
        {
-               registered_loaders_changed = false;
-               loaders.sort(signature_size_compare);
+               registry.changed = false;
+               registry.loaders.sort(signature_size_compare);
        }
 
-       if(loaders.empty())
+       if(registry.loaders.empty())
                throw unsupported_image_format("no loaders");
 
-       vector<char> sig_buf(loaders.back()->get_signature_size());
+       vector<char> sig_buf(registry.loaders.back()->get_signature_size());
        unsigned sig_len = io.read(&sig_buf[0], sig_buf.size());
        string signature(sig_buf.begin(), sig_buf.end());
 
        ImageLoader *loader = 0;
-       for(list<RegisterBase *>::const_iterator i=loaders.begin(); (!loader && i!=loaders.end()); ++i)
+       for(list<RegisterBase *>::const_iterator i=registry.loaders.begin(); (!loader && i!=registry.loaders.end()); ++i)
                if((*i)->detect(signature))
                        loader = (*i)->create(io);
 
@@ -97,18 +84,37 @@ ImageLoader *ImageLoader::open_io(IO::Seekable &io)
        return loader;
 }
 
-
-ImageLoader::RegisterBase::RegisterBase()
+void ImageLoader::load(Image::Data &data)
 {
-       get_registered_loaders().push_back(this);
-       registered_loaders_changed = true;
-}
+       if(state>=FINISHED)
+               throw logic_error("already loaded");
 
+       load_(data);
+       state = FINISHED;
+}
 
-list<ImageLoader::RegisterBase *> &ImageLoader::get_registered_loaders()
+ImageLoader::Registry &ImageLoader::get_registry()
 {
-       static list<RegisterBase *> regs;
-       return regs;
+       static Registry registry;
+       static bool initialized = false;
+       if(!initialized)
+       {
+               initialized = true;
+               register_loader<BmpLoader>();
+#ifdef WITH_LIBPNG
+               register_loader<PngLoader>();
+#endif
+#ifdef WITH_LIBJPEG
+               register_loader<JpegLoader>();
+#endif
+#ifdef WITH_DEVIL
+               register_loader<DevilLoader>();
+#endif
+#ifdef WITH_QUARTZ
+               register_loader<QuartzLoader>();
+#endif
+       }
+       return registry;
 }
 
 bool ImageLoader::signature_size_compare(RegisterBase *r1, RegisterBase *r2)
@@ -116,5 +122,16 @@ bool ImageLoader::signature_size_compare(RegisterBase *r1, RegisterBase *r2)
        return r1->get_signature_size()<r2->get_signature_size();
 }
 
+
+ImageLoader::Registry::Registry():
+       changed(false)
+{ }
+
+ImageLoader::Registry::~Registry()
+{
+       for(list<RegisterBase *>::iterator i=loaders.begin(); i!=loaders.end(); ++i)
+               delete *i;
+}
+
 } // namespace Graphics
 } // namespace Msp