X-Git-Url: http://git.tdb.fi/?p=libs%2Fgl.git;a=blobdiff_plain;f=source%2Fvertexsetup.cpp;h=d50406a1ab70ce44e7caf645d46009a308c8e86f;hp=53f825697b34b16444e783cfb32262361d10fc4f;hb=bec07999d95b76f4b47cffcc564d0cd0afc0435e;hpb=67f22642d636861f90a016077c9387b7b8397414

diff --git a/source/vertexsetup.cpp b/source/vertexsetup.cpp
index 53f82569..d50406a1 100644
--- a/source/vertexsetup.cpp
+++ b/source/vertexsetup.cpp
@@ -11,6 +11,8 @@
 #include "vertexarray.h"
 #include "vertexsetup.h"
 
+using namespace std;
+
 namespace Msp {
 namespace GL {
 
@@ -36,17 +38,27 @@ VertexSetup::~VertexSetup()
 
 void VertexSetup::set_vertex_array(const VertexArray &a)
 {
+	if(!a.get_buffer())
+		throw invalid_argument("VertexSetup::set_vertex_array");
+
 	vertex_array = &a;
-	update(VERTEX_ARRAY);
+	update(get_update_mask(VERTEX_ARRAY, vertex_format, *vertex_array));
+	vertex_format = vertex_array->get_format();
 }
 
 void VertexSetup::set_instance_array(const VertexArray *a)
 {
 	if(a)
+	{
+		if(!a->get_buffer())
+			throw invalid_argument("VertexSetup::set_instance_array");
+
 		static Require req(ARB_instanced_arrays);
+	}
 
 	inst_array = a;
-	update(INSTANCE_ARRAY);
+	update(get_update_mask(INSTANCE_ARRAY, inst_format, *inst_array));
+	inst_format = inst_array->get_format();
 }
 
 void VertexSetup::set_index_buffer(const Buffer &ibuf)
@@ -55,6 +67,34 @@ void VertexSetup::set_index_buffer(const Buffer &ibuf)
 	update(INDEX_BUFFER);
 }
 
+void VertexSetup::refresh()
+{
+	if(vertex_array && vertex_array->get_format()!=vertex_format)
+		set_vertex_array(*vertex_array);
+
+	if(inst_array && inst_array->get_format()!=inst_format)
+		set_instance_array(inst_array);
+}
+
+unsigned VertexSetup::get_attribs(const VertexFormat &fmt)
+{
+	unsigned mask = 0;
+	for(const unsigned char *c=fmt.begin(); c!=fmt.end(); ++c)
+	{
+		unsigned t = get_component_type(*c);
+		if(t>=get_component_type(ATTRIB1))
+			t -= get_component_type(ATTRIB1);
+		mask |= 1<<t;
+	}
+	return mask;
+}
+
+unsigned VertexSetup::get_update_mask(unsigned base, const VertexFormat &cur_fmt, const VertexArray &new_array)
+{
+	unsigned unused = get_attribs(cur_fmt)&~get_attribs(new_array.get_format());
+	return base | (unused ? UNUSED_ATTRIBS | (unused<<ATTRIB_SHIFT) : 0);
+}
+
 void VertexSetup::update(unsigned mask) const
 {
 	static bool direct = ARB_direct_state_access && ARB_vertex_attrib_binding;
@@ -64,14 +104,23 @@ void VertexSetup::update(unsigned mask) const
 		return;
 	}
 
+	if(mask&UNUSED_ATTRIBS)
+	{
+		for(unsigned i=0, am=mask>>ATTRIB_SHIFT; am; ++i, am>>=1)
+			if(am&1)
+			{
+				if(direct)
+					glDisableVertexArrayAttrib(id, i);
+				else
+					glDisableVertexAttribArray(i);
+			}
+	}
+
 	if(mask&VERTEX_ARRAY)
 		update_vertex_array(*vertex_array, 0, 0, direct);
 
-	if(mask&INSTANCE_ARRAY)
-	{
-		if(inst_array)
-			update_vertex_array(*inst_array, 1, 1, direct);
-	}
+	if((mask&INSTANCE_ARRAY) && inst_array)
+		update_vertex_array(*inst_array, 1, 1, direct);
 
 	if(mask&INDEX_BUFFER)
 	{
@@ -116,7 +165,8 @@ void VertexSetup::update_vertex_array(const VertexArray &array, unsigned binding
 				glVertexAttribPointer(t, 4, GL_UNSIGNED_BYTE, true, stride, reinterpret_cast<unsigned char *>(offset));
 			else
 				glVertexAttribPointer(t, sz, GL_FLOAT, false, stride, reinterpret_cast<float *>(offset));
-			glVertexAttribDivisor(t, divisor);
+			if(ARB_instanced_arrays)
+				glVertexAttribDivisor(t, divisor);
 			glEnableVertexAttribArray(t);
 		}
 		offset += sz*sizeof(float);
@@ -130,6 +180,9 @@ void VertexSetup::bind() const
 
 	if(set_current(this))
 	{
+		vertex_array->refresh();
+		if(inst_array)
+			inst_array->refresh();
 		glBindVertexArray(id);
 		if(dirty)
 		{