X-Git-Url: http://git.tdb.fi/?p=libs%2Fgl.git;a=blobdiff_plain;f=source%2Frenderbuffer.cpp;h=5bea07fc81e60a70c26c7744f3e7d5a6434bc621;hp=17d36846e696cdccb36d4b5a28e14d2e301b6025;hb=42c1534d95e1551c37e64a1dae288e8b75e8d8ba;hpb=08e19bc2b4eba572bc7699378cf55cd8772ac67e

diff --git a/source/renderbuffer.cpp b/source/renderbuffer.cpp
index 17d36846..5bea07fc 100644
--- a/source/renderbuffer.cpp
+++ b/source/renderbuffer.cpp
@@ -1,8 +1,11 @@
 #include <msp/gl/extensions/arb_direct_state_access.h>
 #include <msp/gl/extensions/ext_framebuffer_multisample.h>
 #include <msp/gl/extensions/ext_framebuffer_object.h>
+#include "misc.h"
 #include "renderbuffer.h"
 
+using namespace std;
+
 namespace Msp {
 namespace GL {
 
@@ -21,8 +24,17 @@ Renderbuffer::~Renderbuffer()
 	glDeleteRenderbuffers(1, &id);
 }
 
+PixelFormat Renderbuffer::normalize_format(PixelFormat fmt)
+{
+	if(!get_component_size(fmt) && OES_required_internalformat)
+		return get_default_sized_pixelformat(fmt);
+
+	return fmt;
+}
+
 void Renderbuffer::storage(PixelFormat fmt, unsigned wd, unsigned ht)
 {
+	fmt = normalize_format(fmt);
 	require_pixelformat(fmt);
 	width = wd;
 	height = ht;
@@ -35,9 +47,22 @@ void Renderbuffer::storage(PixelFormat fmt, unsigned wd, unsigned ht)
 	}
 }
 
+unsigned Renderbuffer::get_max_samples()
+{
+	static unsigned max_samples = (EXT_framebuffer_multisample ? get_i(GL_MAX_SAMPLES) : 0);
+	return max_samples;
+}
+
 void Renderbuffer::storage_multisample(unsigned samples, PixelFormat fmt, unsigned wd, unsigned ht)
 {
+	if(!samples)
+		return storage(fmt, wd, ht);
+
 	static Require _req(EXT_framebuffer_multisample);
+	if(samples>get_max_samples())
+		throw out_of_range("Renderbuffer::storage_multisample");
+
+	fmt = normalize_format(fmt);
 	require_pixelformat(fmt);
 
 	width = wd;