X-Git-Url: http://git.tdb.fi/?p=libs%2Fcore.git;a=blobdiff_plain;f=source%2Ftime%2Ftimer.h;h=33257319eba3466d89f28c650efcd26dde0a996d;hp=b080f82f8f3d3713e50dca5b995739f30143e81d;hb=41363aed34382386f915f17c1a961750b4fdcb14;hpb=fc1475d88018934a61df890c192a404a105308fd

diff --git a/source/time/timer.h b/source/time/timer.h
index b080f82..3325731 100644
--- a/source/time/timer.h
+++ b/source/time/timer.h
@@ -4,6 +4,7 @@
 #include <vector>
 #include <sigc++/sigc++.h>
 #include <msp/core/mutex.h>
+#include <msp/core/noncopyable.h>
 #include <msp/core/semaphore.h>
 #include "timedelta.h"
 #include "timestamp.h"
@@ -18,7 +19,7 @@ of the returned slot.
 
 This class is thread-safe, to allow running timers in a separate thread.
 */
-class Timer
+class Timer: private NonCopyable
 {
 public:
 	class Slot
@@ -40,7 +41,7 @@ public:
 private:
 	struct SlotProxy
 	{
-		Slot *slot;
+		Slot *slot = nullptr;
 
 		SlotProxy(Slot *);
 		bool operator<(const SlotProxy &) const;
@@ -49,36 +50,35 @@ private:
 	std::vector<SlotProxy> slots;
 	Semaphore sem;
 	Mutex mutex;
+	bool blocking = false;
 
 public:
+	Timer();
 	~Timer();
 
-	/**
-	Adds a timer that will be executed periodically as long as the timeout
-	signal hander returns true.
-	*/
+	/** Adds a timer that will be executed periodically as long as the timeout
+	signal hander returns true. */
 	Slot &add(const TimeDelta &);
 
-	/**
-	Adds a timer that will be executed once at a specific time.  The return
-	value of the timeout signal handler is ignored.
-	*/
+	/** Adds a timer that will be executed once at a specific time.  The return
+	value of the timeout signal handler is ignored. */
 	Slot &add(const TimeStamp &);
 
-	/**
-	Cancels a previously added timer.
-	*/
+	/** Cancels a previously added timer. */
 	void cancel(Slot &);
 
-	/**
-	Checks all timers, executing any that have timed out.  If block is true,
-	waits until one times out.
+	/** Waits until a timer expires, then executes it.  If no timers have been
+	set, blocks until one is added from another thread. */
+	void tick();
 
-	Note: If there are no active timers when a blocking tick is executed, it
-	won't return until a timer is added from another thread.
-	*/
-	void tick(bool block = true);
+	/** Waits until a timer expires but at most the specified amount of time.
+	If a timer did expire before the timeout, it is executed. */
+	void tick(const TimeDelta &);
 
+private:
+	void do_tick(const TimeDelta &);
+
+public:
 	TimeStamp get_next_timeout() const;
 };