X-Git-Url: http://git.tdb.fi/?p=libs%2Fcore.git;a=blobdiff_plain;f=source%2Fregex.cpp;h=a1babf46d019b77a1db433a92ed447a0fbd2d6a2;hp=d3fd0b7ebc4e58b733947387a6e4f349e83bd7ce;hb=e3c7585b472744c6101bb714022f7545bb650493;hpb=b254c706617223da1dd1b9543a74715e42a8a5b0

diff --git a/source/regex.cpp b/source/regex.cpp
index d3fd0b7..a1babf4 100644
--- a/source/regex.cpp
+++ b/source/regex.cpp
@@ -4,7 +4,9 @@ This file is part of libmspstrings
 Copyright © 2007 Mikko Rasa
 Distributed under the LGPL
 */
+
 #include <stack>
+#include <limits>
 #include <msp/core/except.h>
 #include "formatter.h"
 #include "regex.h"
@@ -244,8 +246,7 @@ Regex::Code Regex::parse_atom(const string &expr, string::const_iterator &i, uns
 
 	if(flag)
 	{
-		if(static_cast<unsigned char>(*i)<=LAST_INSTRUCTION_)
-			result+=MATCH_CHAR;
+		result+=MATCH_CHAR;
 		result+=*i;
 	}
 
@@ -307,7 +308,7 @@ Regex::Code Regex::parse_brackets(const string &str, string::const_iterator &ite
 	}
 
 	string::const_iterator end=iter;
-	for(; (end!=str.end() && (end==iter || *end!=']')); ++end);
+	for(; (end!=str.end() && (end==iter || *end!=']')); ++end) ;
 	if(end==str.end())
 		throw InvalidParameterValue("Unmatched '['");
 
@@ -388,11 +389,7 @@ bool Regex::run(const string &str, const string::const_iterator &begin, RegMatch
 			bool negate_match=false;
 			for(; j->citer!=code.end();)
 			{
-				Instruction instr=static_cast<Instruction>(*j->citer);
-				if(instr>LAST_INSTRUCTION_)
-					instr=MATCH_CHAR;
-				else
-					++j->citer;
+				Instruction instr=static_cast<Instruction>(*j->citer++);
 
 				if(instr==NEGATE)
 					negate_match=true;
@@ -517,11 +514,7 @@ bool Regex::group_compare(const RegMatch::Group &g1, const RegMatch::Group &g2)
 
 string Regex::disassemble_instruction(Code::const_iterator &i) const
 {
-	Instruction instr=static_cast<Instruction>(*i);
-	if(instr>=LAST_INSTRUCTION_)
-		instr=MATCH_CHAR;
-	else
-		++i;
+	Instruction instr=static_cast<Instruction>(*i++);
 
 	ostringstream result;
 	switch(instr)
@@ -575,8 +568,7 @@ string Regex::disassemble_instruction(Code::const_iterator &i) const
 	case MATCH_ANY:
 		result<<"MATCH_ANY";
 		break;
-	case FIRST_INSTRUCTION_:
-	case LAST_INSTRUCTION_:
+	default:
 		result<<"UNKNOWN "<<instr;
 	}