X-Git-Url: http://git.tdb.fi/?p=libs%2Fcore.git;a=blobdiff_plain;f=source%2Fio%2Fpipe.cpp;h=0f206981f11c6d1e205d127d281655965559187e;hp=b3735aa63b6d43a7724aaa13d1109ce96a78b0d2;hb=651cfe05e867ffdef9028a831add3eca54d19d0d;hpb=6e0fd758970bcb5bad5e3f2454b694cc4d7b4b66

diff --git a/source/io/pipe.cpp b/source/io/pipe.cpp
index b3735aa..0f20698 100644
--- a/source/io/pipe.cpp
+++ b/source/io/pipe.cpp
@@ -1,8 +1,11 @@
 #ifndef WIN32
 #include <fcntl.h>
 #include <errno.h>
+#include <unistd.h>
 #endif
-#include <msp/strings/formatter.h>
+#include <msp/core/systemerror.h>
+#include <msp/strings/format.h>
+#include "handle_private.h"
 #include "pipe.h"
 
 using namespace std;
@@ -10,54 +13,43 @@ using namespace std;
 namespace Msp {
 namespace IO {
 
-Pipe::Pipe()
+Pipe::Pipe():
+	reader(read_handle, 1024)
 {
+	mode = M_RDWR;
+
 #ifdef WIN32
 	string name = format("\\\\.\\pipe\\%u.%p", GetCurrentProcessId(), this);
-	handle[0] = CreateNamedPipe(name.c_str(), PIPE_ACCESS_INBOUND|FILE_FLAG_OVERLAPPED, PIPE_TYPE_BYTE, 1, 1024, 1024, 0, 0);
-	if(handle[0]==INVALID_HANDLE_VALUE)
-		throw SystemError("Unable to create pipe", GetLastError());
+	*read_handle = CreateNamedPipe(name.c_str(), PIPE_ACCESS_INBOUND|FILE_FLAG_OVERLAPPED, PIPE_TYPE_BYTE, 1, 1024, 1024, 0, 0);
+	if(!read_handle)
+		throw system_error("CreateNamedPipe");
 
-	handle[1] = CreateFile(name.c_str(), GENERIC_WRITE, 0, 0, OPEN_EXISTING, 0, 0);
-	if(handle[1]==INVALID_HANDLE_VALUE)
+	*write_handle = CreateFile(name.c_str(), GENERIC_WRITE, 0, 0, OPEN_EXISTING, FILE_FLAG_OVERLAPPED, 0);
+	if(!write_handle)
 	{
 		unsigned err = GetLastError();
-		CloseHandle(handle[0]);
-		throw SystemError("Unable to create pipe", err);
+		CloseHandle(*read_handle);
+		throw system_error(format("CreateFile(%s)", name), err);
 	}
-
-	overlapped = 0;
-	event = CreateEvent(0, true, false, 0);
-	buf_size = 1024;
-	buffer = new char[buf_size];
-	buf_avail = 0;
-	buf_next = buffer;
 #else
-	if(pipe(handle)==-1)
-		throw SystemError("Unable to create pipe", errno);
+	int pipe_fd[2];
+	if(pipe(pipe_fd)==-1)
+		throw system_error("pipe");
+
+	*read_handle = pipe_fd[0];
+	*write_handle = pipe_fd[1];
 #endif
 
 	set_events(P_INPUT);
 }
 
 Pipe::~Pipe()
-{
-	close();
-}
-
-void Pipe::close()
 {
 	set_events(P_NONE);
 
 	signal_flush_required.emit();
-#ifdef WIN32
-	CloseHandle(handle[0]);
-	CloseHandle(handle[1]);
-#else
-	::close(handle[0]);
-	::close(handle[1]);
-	signal_closed.emit();
-#endif
+	sys_close(read_handle);
+	sys_close(write_handle);
 }
 
 void Pipe::set_block(bool b)
@@ -67,10 +59,10 @@ void Pipe::set_block(bool b)
 		mode = (mode|M_NONBLOCK);
 
 #ifndef WIN32
-	int flags = fcntl(handle[0], F_GETFD);
-	fcntl(handle[0], F_SETFL, (flags&O_NONBLOCK)|(b?0:O_NONBLOCK));
-	flags = fcntl(handle[1], F_GETFD);
-	fcntl(handle[1], F_SETFL, (flags&O_NONBLOCK)|(b?0:O_NONBLOCK));
+	int flags = fcntl(*read_handle, F_GETFD);
+	fcntl(*read_handle, F_SETFL, (flags&O_NONBLOCK)|(b?0:O_NONBLOCK));
+	flags = fcntl(*write_handle, F_GETFD);
+	fcntl(*write_handle, F_SETFL, (flags&O_NONBLOCK)|(b?0:O_NONBLOCK));
 #endif
 }
 
@@ -79,22 +71,7 @@ unsigned Pipe::do_write(const char *buf, unsigned size)
 	if(size==0)
 		return 0;
 
-#ifdef WIN32
-	DWORD ret;
-	if(!WriteFile(handle[1], buf, size, &ret, 0))
-		throw SystemError("Writing to pipe failed", GetLastError());
-#else
-	int ret = ::write(handle[1], buf, size);
-	if(ret==-1)
-	{
-		if(errno==EAGAIN)
-			return 0;
-		else
-			throw SystemError("Writing to pipe failed", errno);
-	}
-#endif
-
-	return ret;
+	return sys_write(write_handle, buf, size);
 }
 
 unsigned Pipe::do_read(char *buf, unsigned size)
@@ -102,80 +79,21 @@ unsigned Pipe::do_read(char *buf, unsigned size)
 	if(size==0)
 		return 0;
 
-#ifdef WIN32
-	// Initiate overlapped read if needed
-	get_event_handle();
-
-	if(overlapped)
-	{
-		DWORD ret;
-		if(!GetOverlappedResult(handle[0], overlapped, &ret, !buf_avail))
-			throw SystemError("Reading from pipe failed", GetLastError());
-		else
-		{
-			buf_avail += ret;
-			delete overlapped;
-			overlapped = 0;
-		}
-	}
-
-	unsigned ret = min(buf_avail, size);
-	memcpy(buf, buf_next, ret);
-	buf_next += ret;
-	buf_avail -= ret;
-
-	// Initiate another overlapped read in case someone is polling us
-	get_event_handle();
-#else
-	int ret = ::read(handle[0], buf, size);
-	if(ret==-1)
-	{
-		if(errno==EAGAIN)
-			return 0;
-		else
-			throw SystemError("Reading from pipe failed", errno);
-	}
-#endif
-
+	unsigned ret = reader.read(buf, size);
 	if(ret==0)
-	{
-		eof_flag = true;
-		signal_end_of_file.emit();
-	}
+		set_eof();
 
 	return ret;
 }
 
-Handle Pipe::get_event_handle()
+const Handle &Pipe::get_handle(Mode m)
 {
-#ifdef WIN32
-	if(!overlapped && !buf_avail)
-	{
-		overlapped = new OVERLAPPED;
-		memset(overlapped, 0, sizeof(OVERLAPPED));
-		overlapped->hEvent = event;
-
-		DWORD ret;
-		buf_next = buffer;
-		if(!ReadFile(handle[0], buffer, buf_size, &ret, overlapped))
-		{
-			unsigned err = GetLastError();
-			if(err!=ERROR_IO_PENDING)
-				throw SystemError("Failed to start an overlapped read", err);
-		}
-		else
-		{
-			buf_avail = ret;
-			delete overlapped;
-			overlapped = 0;
-			SetEvent(event);
-		}
-	}
-
-	return event;
-#else
-	return handle[0];
-#endif
+	if(m==M_READ)
+		return read_handle;
+	else if(m==M_WRITE)
+		return write_handle;
+	else
+		throw invalid_argument("Pipe::get_handle");
 }
 
 } // namespace IO