X-Git-Url: http://git.tdb.fi/?p=libs%2Fcore.git;a=blobdiff_plain;f=source%2Fcore%2Fvariant.h;h=443befb481620b4242e178a4b377192179af1adc;hp=2dd9732fc60dd4faf1a692eef1be63d9c83328cd;hb=41363aed34382386f915f17c1a961750b4fdcb14;hpb=90fc7638aee23270fe005f86dd1b492d67015c13 diff --git a/source/core/variant.h b/source/core/variant.h index 2dd9732..443befb 100644 --- a/source/core/variant.h +++ b/source/core/variant.h @@ -2,6 +2,7 @@ #define MSP_CORE_VARIANT_H_ #include +#include #include #include "meta.h" @@ -11,7 +12,7 @@ class type_mismatch: public std::runtime_error { public: type_mismatch(const std::type_info &, const std::type_info &); - ~type_mismatch() throw() { } + virtual ~type_mismatch() throw() = default; }; @@ -38,46 +39,46 @@ private: virtual const std::type_info &type_id() const { return typeid(T); } virtual StoreBase *clone() const { return new Store(data); } virtual bool type_equals(const StoreBase &s) const { return dynamic_cast *>(&s); } - virtual bool value_equals(const StoreBase &s) const { return value_equals_(s); } + virtual bool value_equals(const StoreBase &s) const { return _value_equals(s); } template - typename EnableIf::value, bool>::Yes value_equals_(const StoreBase &s) const + typename std::enable_if::value, bool>::type _value_equals(const StoreBase &s) const { const Store *t = dynamic_cast *>(&s); return (t && t->data==data); } template - typename EnableIf::value, bool>::No value_equals_(const StoreBase &) const + typename std::enable_if::value, bool>::type _value_equals(const StoreBase &) const { return false; } }; - StoreBase *store; + StoreBase *store = nullptr; public: - Variant(): store(0) { } + Variant() = default; template - Variant(const T &v): store(new Store::Type>(v)) { } - Variant(const Variant &v): store(v.store ? v.store->clone() : 0) { } + Variant(const T &v): store(new Store::type>(v)) { } + Variant(const Variant &v): store(v.store ? v.store->clone() : nullptr) { } ~Variant() { delete store; } template Variant &operator=(const T &v) { delete store; - store = new Store::Type>(v); + store = new Store::type>(v); return *this; } Variant &operator=(const Variant &v) { delete store; - store = (v.store ? v.store->clone() : 0); + store = (v.store ? v.store->clone() : nullptr); return *this; } private: template - Store::Type> *get_typed_store() const + Store::type> *get_typed_store() const { - typedef typename RemoveConst::Type NCT; + typedef typename std::remove_cv::type NCT; Store *s = dynamic_cast *>(store); if(!s) throw type_mismatch(typeid(T), (store ? store->type_id() : typeid(void))); @@ -100,7 +101,7 @@ public: template bool check_type() const { - return dynamic_cast::Type> *>(store)!=0; + return dynamic_cast::type> *>(store); } bool check_same_type(const Variant &v) const