Mark overridden virtual functions as such

[libs/core.git] / source / io / file.h

diff --git a/source/io/file.h b/source/io/file.h
index d106561e5f599cc31367be5f3de9140a4d349cbf..f23cc93e7d013b71dc33cbe060cd83ce939fbe4a 100644 (file)
--- a/source/io/file.h
+++ b/source/io/file.h
@@ -4,7 +4,6 @@
 #include <stdexcept>
 #include <string>
 #include "buffered.h"
-#include "filtered.h"
 #include "handle.h"
 #include "seekable.h"
 
@@ -15,14 +14,14 @@ class file_not_found: public std::runtime_error
 {
 public:
        file_not_found(const std::string &fn): std::runtime_error(fn) { }
-       ~file_not_found() throw() { }
+       ~file_not_found() throw() override = default;
 };
 
 class file_already_exists: public std::runtime_error
 {
 public:
        file_already_exists(const std::string &fn): std::runtime_error(fn) { }
-       ~file_already_exists() throw() { }
+       ~file_already_exists() throw() override = default;
 };
 
 
@@ -55,21 +54,22 @@ public:
 private:
        void platform_init(const std::string &, CreateMode);
 public:
-       virtual ~File();
+       ~File() override;
 
-       void set_block(bool);
+       void set_block(bool) override;
+       void set_inherit(bool) override;
 
 protected:
-       virtual unsigned do_write(const char *, unsigned);
-       virtual unsigned do_read(char *, unsigned);
+       std::size_t do_write(const char *, std::size_t) override;
+       std::size_t do_read(char *, std::size_t) override;
 
 public:
-       virtual void sync();
+       void sync();
 
-       virtual SeekOffset seek(SeekOffset, SeekType);
-       virtual SeekOffset tell() const;
+       SeekOffset seek(SeekOffset, SeekType) override;
+       SeekOffset tell() const override;
 
-       virtual const Handle &get_handle(Mode);
+       const Handle &get_handle(Mode) override;
 };
 
 inline File::CreateMode operator|(File::CreateMode m, File::CreateMode n)
@@ -81,7 +81,34 @@ inline File::CreateMode operator&(File::CreateMode m, File::CreateMode n)
 inline File::CreateMode operator~(File::CreateMode m)
 { return File::CreateMode(~static_cast<int>(m)); }
 
-typedef Filtered<File, Buffered> BufferedFile;
+
+class BufferedFile: public Seekable
+{
+private:
+       File file;
+       Buffered buffer;
+       SeekOffset position;
+
+public:
+       BufferedFile(const std::string &, Mode = M_READ, File::CreateMode = File::C_OVERWRITE);
+
+       void set_block(bool) override;
+       void set_inherit(bool) override;
+
+protected:
+       std::size_t do_write(const char *, std::size_t) override;
+       std::size_t do_read(char *, std::size_t) override;
+public:
+       std::size_t put(char) override;
+
+       bool getline(std::string &) override;
+       int get() override;
+
+       const Handle &get_handle(Mode) override;
+
+       SeekOffset seek(SeekOffset, SeekType) override;
+       SeekOffset tell() const override { return position; }
+};
 
 } // namespace IO
 } // namespace Msp