Don't complain about missing executable if a tool has no command

[builder.git] / source / tool.cpp

diff --git a/source/tool.cpp b/source/tool.cpp
index e2afe79a204ccea8aebda5294c0dc8a0fd3f583e..28523f677e57bd697d9b2b85ad39d9bcb9461747 100644 (file)
--- a/source/tool.cpp
+++ b/source/tool.cpp
@@ -1,30 +1,14 @@
-#include <algorithm>
+#include <msp/core/algorithm.h>
+#include <msp/fs/utils.h>
 #include <msp/strings/format.h>
 #include "architecture.h"
 #include "builder.h"
+#include "filetarget.h"
 #include "tool.h"
 
 using namespace std;
 using namespace Msp;
 
-Tool::Tool(Builder &b, const string &t):
-       builder(b),
-       architecture(0),
-       tag(t),
-       executable(0),
-       processing_unit(ONE_FILE),
-       prepared(false)
-{ }
-
-Tool::Tool(Builder &b, const Architecture &a, const string &t):
-       builder(b),
-       architecture(&a),
-       tag(t),
-       executable(0),
-       processing_unit(ONE_FILE),
-       prepared(false)
-{ }
-
 void Tool::set_command(const string &cmd, bool cross)
 {
        if(cmd.empty())
@@ -36,19 +20,19 @@ void Tool::set_command(const string &cmd, bool cross)
                command = cmd;
 }
 
+void Tool::set_run(function<Task *(const Target &)> f)
+{
+       run_func = move(f);
+}
+
 bool Tool::accepts_suffix(const string &suffix, bool aux) const
 {
-       if(find(input_suffixes.begin(), input_suffixes.end(), suffix)!=input_suffixes.end())
-               return true;
-       else if(aux)
-               return find(aux_suffixes.begin(), aux_suffixes.end(), suffix)!=aux_suffixes.end();
-       else
-               return false;
+       return (any_equals(input_suffixes, suffix) || (aux && any_equals(aux_suffixes, suffix)));
 }
 
 Target *Tool::create_target(Target &source, const string &arg)
 {
-       list<Target *> sources;
+       vector<Target *> sources;
        sources.push_back(&source);
        return create_target(sources, arg);
 }
@@ -59,20 +43,49 @@ void Tool::prepare()
                return;
 
        prepared = true;
+       if(!command.empty())
+               executable = builder.get_vfs().find_binary(command);
        do_prepare();
-       if(!executable && !command.empty())
+       if(!command.empty() && !executable)
        {
-               executable = builder.get_vfs().find_binary(command);
-               if(!executable)
-                       problems.push_back(format("Can't find executable %s", command));
+               builder.get_logger().log("problems", "Can't find executable %s for %s", command, tag);
+               problems.push_back(format("Can't find executable %s", command));
        }
 }
 
+string Tool::create_build_signature(const BuildInfo &) const
+{
+       if(executable)
+               return format("%s=%s", tag, FS::basename(executable->get_path()));
+       else
+               return string();
+}
 
-SubTool::SubTool(Tool &p):
-       Tool(p),
-       parent(p)
-{ }
+
+Target *SubTool::create_source(const Component &c, const FS::Path &p) const
+{
+       return parent.create_source(c, p);
+}
+
+Target *SubTool::create_source(const FS::Path &p) const
+{
+       return parent.create_source(p);
+}
+
+Target *SubTool::create_target(const vector<Target *> &s, const string &a)
+{
+       return parent.create_target(s, a);
+}
+
+Target *SubTool::create_install(Target &t) const
+{
+       return parent.create_install(t);
+}
+
+string SubTool::create_build_signature(const BuildInfo &bi) const
+{
+       return parent.create_build_signature(bi);
+}
 
 
 void operator>>(const LexicalConverter &conv, Tool::ProcessingUnit &unit)