]> git.tdb.fi Git - builder.git/blobdiff - source/target.cpp
Add logging for some problem situations
[builder.git] / source / target.cpp
index f17b88e103c6a8a3725d079ecaf046339b1c0824..9006a570cb360f42c00589bd08abc7e54b25ca05 100644 (file)
@@ -1,39 +1,75 @@
-/* $Id$
-
-This file is part of builder
-Copyright © 2006-2007 Mikko Rasa, Mikkosoft Productions
-Distributed under the LGPL
-*/
-
-#include <msp/path/utils.h>
-#include <msp/time/utils.h>
-#include "action.h"
+#include <algorithm>
+#include <msp/fs/stat.h>
+#include <msp/fs/utils.h>
+#include <msp/strings/format.h>
 #include "builder.h"
-#include "package.h"
+#include "filetarget.h"
 #include "sourcepackage.h"
 #include "target.h"
+#include "task.h"
+#include "tool.h"
 
 using namespace std;
 using namespace Msp;
 
-/**
-Tries to locate a target that will help getting this target built.  If all
-dependencies are up-to-date, returns this target.  If there are no targets
-ready to be built (maybe because they are being built right now), returns 0.
-*/
+Target::Target(Builder &b, const string &n):
+       builder(b),
+       package(0),
+       component(0),
+       name(n),
+       tool(0),
+       state(INIT),
+       primary_target(0)
+{
+       builder.get_build_graph().add_target(this);
+}
+
+void Target::add_dependency(Target &dep)
+{
+       if(&dep==this)
+               throw invalid_argument("Target::add_depend");
+       depends.push_back(&dep);
+       if(state>PREPARING)
+               dep.signal_bubble_rebuild.connect(sigc::mem_fun(this, &Target::check_rebuild));
+}
+
+void Target::add_transitive_dependency(Target &dep)
+{
+       if(&dep==this)
+               throw invalid_argument("Target::add_transitive_dependency");
+       trans_depends.push_back(&dep);
+}
+
+void Target::add_side_effect(Target &se)
+{
+       side_effects.push_back(&se);
+       if(tool)
+               se.set_tool(*tool);
+       se.primary_target = this;
+       /* Side effects are checked for rebuild after the primary target.  Recheck
+       the primary if a side effect is marked for rebuild. */
+       se.signal_bubble_rebuild.connect(sigc::mem_fun(this, &Target::check_rebuild));
+}
+
 Target *Target::get_buildable_target()
 {
-       if(!rebuild)
+       if(primary_target)
+               return primary_target->get_buildable_target();
+       if(!needs_rebuild())
                return 0;
 
-       bool self_ok=!building;
-       for(TargetList::iterator i=depends.begin(); i!=depends.end(); ++i)
+       bool self_ok = state!=BUILDING;
+       for(Dependencies::iterator i=depends.begin(); i!=depends.end(); ++i)
        {
-               Target *tgt=(*i)->get_buildable_target();
+               // Avoid infinite recursion if a target repends on its own side effect
+               if(find(side_effects.begin(), side_effects.end(), *i)!=side_effects.end())
+                       continue;
+
+               Target *tgt = (*i)->get_buildable_target();
                if(tgt)
                        return tgt;
-               else if((*i)->get_rebuild())
-                       self_ok=false;
+               else if((*i)->needs_rebuild())
+                       self_ok = false;
        }
 
        if(self_ok)
@@ -42,135 +78,116 @@ Target *Target::get_buildable_target()
        return 0;
 }
 
-void Target::add_depend(Target *dep)
+void Target::set_tool(Tool &t)
 {
-       if(dep==this)
-               throw InvalidParameterValue("A target can't depend on itself");
-       depends.push_back(dep);
-       dep->rdepends.push_back(this);
+       tool = &t;
+       for(Dependencies::const_iterator i=side_effects.begin(); i!=side_effects.end(); ++i)
+               (*i)->set_tool(t);
 }
 
-/**
-Prepares the target by recursively preparing dependencies, then checking
-whether rebuilding is needed.  A flag is used to prevent unnecessary
-executions.
-*/
-void Target::prepare()
+void Target::collect_build_info(BuildInfo &binfo) const
 {
-       if(prepared)
-               return;
+       if(tool)
+               binfo.update_from(tool->get_build_info());
+       if(component)
+               binfo.update_from(component->get_build_info());
+       else if(package)
+               binfo.update_from(package->get_build_info());
+}
 
-       prepared=true;
-       for(TargetList::iterator i=depends.begin(); i!=depends.end(); ++i)
-               (*i)->prepare();
+void Target::force_rebuild()
+{
+       if(!is_buildable())
+               throw logic_error("Target::force_rebuild");
+       mark_rebuild("Forced rebuild");
+}
 
-       check_rebuild();
+void Target::mark_rebuild(const string &reason)
+{
+       if(reason.empty())
+               throw invalid_argument("No reason given for rebuilding "+name);
+
+       state = REBUILD;
+       rebuild_reason = reason;
+
+       builder.get_logger().log("rebuild", format("Rebuilding %s: %s", name, reason));
 
+       signal_bubble_rebuild.emit();
 }
 
-Action *Target::build()
+void Target::prepare()
 {
-       if(!buildable)
+       if(state>PREPARING)
+               return;
+       if(state==PREPARING)
        {
-               rebuild=false;
-               return 0;
+               builder.get_logger().log("problems", format("Dependency cycle detected at %s", name));
+               problems.push_back("Dependency cycle detected");
+               state = BROKEN;
+               return;
        }
 
-       if(!builder.get_dry_run() && exists(name))
-               unlink(name);
+       state = PREPARING;
+       if(tool)
+               tool->prepare();
 
-       Action *action=create_action();
-       if(action)
-       {
-               action->signal_done.connect(sigc::mem_fun(this, &Target::build_done));
+       find_dependencies();
+       bool broken = !problems.empty();
 
-               building=true;
+       if(tool)
+       {
+               if(FileTarget *tool_exe = tool->get_executable())
+                       add_dependency(*tool_exe);
+               broken |= !tool->get_problems().empty();
+
+               // Only check package and component problems for buildable targets
+               // XXX How to propagate nested package problems?
+               broken |= (package && !package->get_problems().empty());
+               broken |= (component && !component->get_problems().empty());
        }
 
-       return action;
-}
+       for(Dependencies::iterator i=depends.begin(); i!=depends.end(); ++i)
+       {
+               (*i)->prepare();
+               broken |= (*i)->is_broken();
+       }
+       for(Dependencies::iterator i=trans_depends.begin(); i!=trans_depends.end(); ++i)
+               (*i)->prepare();
 
-/**
-Returns the number of targets that need to be rebuilt in order to get this
-target up-to-date.
-*/
-unsigned Target::count_rebuild()
-{
-       if(counted)
-               return 0;
+       check_rebuild();
+       if(broken)
+               state = BROKEN;
+       else if(state==PREPARING)
+               state = UPTODATE;
 
-       counted=true;
-       unsigned count=rebuild;
-       for(TargetList::iterator i=depends.begin(); i!=depends.end(); ++i)
-               count+=(*i)->count_rebuild();
-       return count;
+       for(Dependencies::iterator i=depends.begin(); i!=depends.end(); ++i)
+               (*i)->signal_bubble_rebuild.connect(sigc::mem_fun(this, &Target::check_rebuild));
 }
 
-/**
-Changes the mtime of the target to the current time.
-*/
-void Target::touch()
+Task *Target::build()
 {
-       mtime=Time::now();
-}
+       if(primary_target)
+               return primary_target->build();
 
-Target::Target(Builder &b, const Package *p, const string &n):
-       builder(b),
-       package(p),
-       name(n),
-       buildable(false),
-       building(false),
-       rebuild(false),
-       deps_ready(false),
-       prepared(false),
-       counted(false)
-{
-       builder.add_target(this);
+       Task *task = tool->run(*this);
+       task->signal_finished.connect(sigc::mem_fun(this, &Target::build_finished));
+       state = BUILDING;
 
-       struct stat st;
-       if(!stat(name, st))
-               mtime=Time::TimeStamp::from_unixtime(st.st_mtime);
-}
+       build(*task);
+       for(Dependencies::const_iterator i=side_effects.begin(); i!=side_effects.end(); ++i)
+               (*i)->build(*task);
 
-void Target::mark_rebuild(const std::string &reason)
-{
-       rebuild=true;
-       rebuild_reason=reason;
+       return task;
 }
 
-/**
-Checks if this target needs to be rebuilt and why.
-*/
-void Target::check_rebuild()
+void Target::build_finished(bool success)
 {
-       if(!buildable)
-               return;
-
-       if(builder.get_build_all())
-               mark_rebuild("Rebuilding everything");
-       else if(!mtime)
-               mark_rebuild("Does not exist");
-       else
+       state = UPTODATE;
+       if(success)
        {
-               for(TargetList::iterator i=depends.begin(); (i!=depends.end() && !rebuild); ++i)
-               {
-                       if((*i)->get_mtime()>mtime)
-                               mark_rebuild(basename((*i)->get_name())+" has changed");
-                       else if((*i)->get_rebuild())
-                               mark_rebuild(basename((*i)->get_name())+" needs rebuilding");
-               }
+               modified();
+               for(Dependencies::const_iterator i=side_effects.begin(); i!=side_effects.end(); ++i)
+                       (*i)->build_finished(success);
+               signal_modified.emit();
        }
-
-       const SourcePackage *spkg=dynamic_cast<const SourcePackage *>(package);
-       if(!rebuild && spkg && spkg->get_config().get_mtime()>mtime)
-               mark_rebuild("Package options changed");
-}
-
-/**
-Handles for the build_done signal of Action.
-*/
-void Target::build_done()
-{
-       building=false;
-       rebuild=false;
 }