More flexible way to manage filename patterns

[builder.git] / source / sharedlibrary.cpp

diff --git a/source/sharedlibrary.cpp b/source/sharedlibrary.cpp
index 6600b740332a23dff7a882a0a63e6c99afcbd8ec..5e479f3c9f652f64c03a9ab3eb472ae645c807ed 100644 (file)
--- a/source/sharedlibrary.cpp
+++ b/source/sharedlibrary.cpp
@@ -1,7 +1,7 @@
 #include <msp/fs/utils.h>
 #include <msp/strings/format.h>
+#include "binarycomponent.h"
 #include "builder.h"
-#include "component.h"
 #include "objectfile.h"
 #include "sharedlibrary.h"
 #include "sourcepackage.h"
@@ -28,7 +28,8 @@ SharedLibrary::SharedLibrary(Builder &b, const Component &c, const list<ObjectFi
        else
                install_location = "lib";
 
-       if(component->get_type()==Component::MODULE)
+       const BinaryComponent &bcomp = dynamic_cast<const BinaryComponent &>(*component);
+       if(bcomp.get_type()==BinaryComponent::MODULE)
                install_location /= package->get_name();
        else
        {
@@ -36,18 +37,12 @@ SharedLibrary::SharedLibrary(Builder &b, const Component &c, const list<ObjectFi
                if(!version.empty())
                {
                        const Architecture &arch = builder.get_current_arch();
-                       const Pattern &pattern = arch.get_shared_library_patterns().front();
                        if(arch.get_system()=="windows")
-                               soname = pattern.apply(format("%s-%s", component->get_name(), version));
+                               soname = arch.create_filename<SharedLibrary>(format("%s-%s", libname, version));
                        else if(arch.get_system()=="darwin")
-                       {
-                               string filename = pattern.apply(component->get_name());
-                               string base = FS::basepart(filename);
-                               string ext = FS::extpart(filename);
-                               soname = format("%s.%s%s", base, version, ext);
-                       }
+                               soname = arch.create_filename<SharedLibrary>(format("%s.%s", libname, version));
                        else
-                               soname = format("%s.%s", pattern.apply(component->get_name()), version);
+                               soname = format("%s.%s", arch.create_filename<SharedLibrary>(libname), version);
 
                        install_filename = soname;
                }
@@ -59,12 +54,13 @@ SharedLibrary::SharedLibrary(Builder &b, const Component &c, const list<ObjectFi
 
 string SharedLibrary::generate_filename(const Component &comp)
 {
-       if(comp.get_type()==Component::MODULE)
-               return comp.get_name()+".m";
+       const BinaryComponent &bcomp = dynamic_cast<const BinaryComponent &>(comp);
+       if(bcomp.get_type()==BinaryComponent::MODULE)
+               return comp.get_name()+".dlm";
        else
        {
                const Architecture &arch = comp.get_package().get_builder().get_current_arch();
-               return arch.get_shared_library_patterns().front().apply(comp.get_name());
+               return arch.create_filename<SharedLibrary>(comp.get_name());
        }
 }