]> git.tdb.fi Git - builder.git/blobdiff - source/builder.cpp
Refactor logger to do message formatting internally
[builder.git] / source / builder.cpp
index cf49f41663e71b45d16dd16bc2a73d0ff5915449..239258196632ca82d8928c0aeceb9d64700b2af0 100644 (file)
@@ -1,4 +1,6 @@
+#include <deque>
 #include <set>
+#include <msp/core/except.h>
 #include <msp/core/maputils.h>
 #include <msp/datafile/parser.h>
 #include <msp/fs/dir.h>
@@ -7,14 +9,17 @@
 #include <msp/io/file.h>
 #include <msp/io/print.h>
 #include <msp/strings/format.h>
-#include <msp/time/units.h>
+#include <msp/time/timedelta.h>
 #include <msp/time/utils.h>
+#include "androidtools.h"
 #include "binarypackage.h"
 #include "builder.h"
 #include "builtintools.h"
+#include "clangtools.h"
 #include "datatool.h"
 #include "gnutools.h"
 #include "installedfile.h"
+#include "microsofttools.h"
 #include "package.h"
 #include "sharedlibrary.h"
 #include "sourcepackage.h"
@@ -58,6 +63,22 @@ void Builder::set_architecture(const string &name)
        }
 }
 
+vector<string> Builder::get_build_types() const
+{
+       vector<string> keys;
+       keys.reserve(build_types.size());
+       for(const auto &kvp: build_types)
+               keys.push_back(kvp.first);
+       return keys;
+}
+
+const BuildType &Builder::get_build_type() const
+{
+       if(!build_type)
+               throw invalid_state("no build type");
+       return *build_type;
+}
+
 void Builder::set_build_type(const string &name)
 {
        build_type = &get_item(build_types, name);
@@ -75,7 +96,15 @@ void Builder::set_temp_directory(const FS::Path &p)
 
 void Builder::add_default_tools()
 {
-       toolchain.add_toolchain(new GnuTools(*this, *current_arch));
+       const string &arch_tc = current_arch->get_toolchain();
+       if(current_arch->get_system()=="android")
+               toolchain.add_toolchain(new AndroidTools(*this, *current_arch));
+       else if(arch_tc=="msvc")
+               toolchain.add_toolchain(new MicrosoftTools(*this, *current_arch));
+       else if(arch_tc=="clang")
+               toolchain.add_toolchain(new ClangTools(*this, *current_arch));
+       else if(arch_tc=="gnu")
+               toolchain.add_toolchain(new GnuTools(*this, *current_arch));
        toolchain.add_toolchain(new BuiltinTools(*this));
        toolchain.add_tool(new DataTool(*this));
 }
@@ -85,55 +114,44 @@ void Builder::set_logger(const Logger *l)
        logger = (l ? l : &default_logger);
 }
 
-list<string> Builder::collect_problems() const
+vector<string> Builder::collect_problems() const
 {
-       list<string> problems;
+       vector<string> problems;
        set<const Package *> broken_packages;
        set<const Component *> broken_components;
        set<const Tool *> broken_tools;
 
-       const BuildGraph::TargetMap &targets = build_graph.get_targets();
-       for(BuildGraph::TargetMap::const_iterator i=targets.begin(); i!=targets.end(); ++i)
-               if(i->second->is_broken())
+       for(const auto &kvp: build_graph.get_targets())
+               if(kvp.second->is_broken())
                {
-                       const list<string> &tgt_problems = i->second->get_problems();
-                       for(list<string>::const_iterator j=tgt_problems.begin(); j!=tgt_problems.end(); ++j)
-                               problems.push_back(format("%s: %s", i->second->get_name(), *j));
+                       for(const string &p: kvp.second->get_problems())
+                               problems.push_back(format("%s: %s", kvp.second->get_name(), p));
 
-                       const Package *package = i->second->get_package();
+                       const Package *package = kvp.second->get_package();
                        if(package && !package->get_problems().empty())
                                broken_packages.insert(package);
 
-                       const Component *component = i->second->get_component();
+                       const Component *component = kvp.second->get_component();
                        if(component && !component->get_problems().empty())
                                broken_components.insert(component);
 
-                       const Tool *tool = i->second->get_tool();
+                       const Tool *tool = kvp.second->get_tool();
                        if(tool && !tool->get_problems().empty())
                                broken_tools.insert(tool);
                }
 
        // TODO Sort components after their packages, and targets last
-       for(set<const Package *>::const_iterator i=broken_packages.begin(); i!=broken_packages.end(); ++i)
-       {
-               const list<string> &pkg_problems = (*i)->get_problems();
-               for(list<string>::const_iterator j=pkg_problems.begin(); j!=pkg_problems.end(); ++j)
-                       problems.push_back(format("%s: %s", (*i)->get_name(), *j));
-       }
+       for(const Package *p: broken_packages)
+               for(const string &b: p->get_problems())
+                       problems.push_back(format("%s: %s", p->get_name(), b));
 
-       for(set<const Component *>::const_iterator i=broken_components.begin(); i!=broken_components.end(); ++i)
-       {
-               const list<string> &comp_problems = (*i)->get_problems();
-               for(list<string>::const_iterator j=comp_problems.begin(); j!=comp_problems.end(); ++j)
-                       problems.push_back(format("%s/%s: %s", (*i)->get_package().get_name(), (*i)->get_name(), *j));
-       }
+       for(const Component *c: broken_components)
+               for(const string &b: c->get_problems())
+                       problems.push_back(format("%s/%s: %s", c->get_package().get_name(), c->get_name(), b));
 
-       for(set<const Tool *>::const_iterator i=broken_tools.begin(); i!=broken_tools.end(); ++i)
-       {
-               const list<string> &tool_problems = (*i)->get_problems();
-               for(list<string>::const_iterator j=tool_problems.begin(); j!=tool_problems.end(); ++j)
-                       problems.push_back(format("%s: %s", (*i)->get_tag(), *j));
-       }
+       for(const Tool *t: broken_tools)
+               for(const string &b: t->get_problems())
+                       problems.push_back(format("%s: %s", t->get_tag(), b));
 
        return problems;
 }
@@ -142,13 +160,19 @@ void Builder::load_build_file(const FS::Path &fn, const Config::InputOptions *op
 {
        IO::BufferedFile in(fn.str());
 
-       get_logger().log("files", format("Reading %s", fn));
+       get_logger().log("files", "Reading %s", fn);
 
        DataFile::Parser parser(in, fn.str());
        Loader loader(*this, opts, all);
        loader.load(parser);
 }
 
+void Builder::save_caches()
+{
+       for(const auto &kvp: package_manager.get_packages())
+               kvp.second->save_caches();
+}
+
 int Builder::build(unsigned jobs, bool dry_run, bool show_progress)
 {
        unsigned total = build_graph.count_rebuild_targets();
@@ -158,7 +182,7 @@ int Builder::build(unsigned jobs, bool dry_run, bool show_progress)
                get_logger().log("summary", "Already up to date");
                return 0;
        }
-       get_logger().log("summary", format("Will build %d target%s", total, (total!=1 ? "s" : "")));
+       get_logger().log("summary", "Will build %d target%s", total, (total!=1 ? "s" : ""));
 
        vector<Task *> tasks;
 
@@ -176,11 +200,11 @@ int Builder::build(unsigned jobs, bool dry_run, bool show_progress)
                        if(tgt)
                        {
                                if(tgt->get_tool())
-                                       get_logger().log("tasks", format("%-4s  %s", tgt->get_tool()->get_tag(), tgt->get_name()));
+                                       get_logger().log("tasks", "%-4s  %s", tgt->get_tool()->get_tag(), tgt->get_name());
                                Task *task = tgt->build();
                                if(task)
                                {
-                                       get_logger().log("commands", format("%s", task->get_command()));
+                                       get_logger().log("commands", "%s", task->get_command());
                                        if(dry_run)
                                        {
                                                task->signal_finished.emit(true);
@@ -236,13 +260,6 @@ int Builder::build(unsigned jobs, bool dry_run, bool show_progress)
        else if(show_progress)
                get_logger().log("summary", "Build complete");
 
-       if(!dry_run)
-       {
-               const PackageManager::PackageMap &packages = package_manager.get_packages();
-               for(PackageManager::PackageMap::const_iterator i=packages.begin(); i!=packages.end(); ++i)
-                       i->second->save_caches();
-       }
-
        return fail;
 }
 
@@ -251,28 +268,27 @@ int Builder::clean(bool all, bool dry_run)
        // Cleaning doesn't care about ordering, so a simpler method can be used
 
        set<Target *> clean_tgts;
-       list<Target *> queue;
-       queue.push_back(build_graph.get_target("cmdline"));
+       deque<Target *> queue;
+       queue.push_back(&build_graph.get_goals());
 
        while(!queue.empty())
        {
                Target *tgt = queue.front();
-               queue.erase(queue.begin());
+               queue.pop_front();
 
                if(tgt->is_buildable() && (tgt->get_package()==&package_manager.get_main_package() || all))
                        clean_tgts.insert(tgt);
 
-               const Target::Dependencies &deps = tgt->get_dependencies();
-               for(list<Target *>::const_iterator i=deps.begin(); i!=deps.end(); ++i)
-                       if(!clean_tgts.count(*i))
-                               queue.push_back(*i);
+               for(Target *t: tgt->get_dependencies())
+                       if(!clean_tgts.count(t))
+                               queue.push_back(t);
        }
 
-       for(set<Target *>::iterator i=clean_tgts.begin(); i!=clean_tgts.end(); ++i)
+       for(Target *t: clean_tgts)
        {
-               get_logger().log("tasks", format("RM    %s", (*i)->get_name()));
+               get_logger().log("tasks", "RM    %s", t->get_name());
                if(!dry_run)
-                       (*i)->clean();
+                       t->clean();
        }
 
        return 0;
@@ -317,7 +333,7 @@ void Builder::Loader::build_type(const string &n)
 {
        BuildType btype(n);
        load_sub(btype);
-       BuildTypeMap::iterator i = obj.build_types.insert(BuildTypeMap::value_type(n, btype)).first;
+       auto i = obj.build_types.insert({ n, btype }).first;
        if(!obj.build_type)
                obj.build_type = &i->second;
 }
@@ -326,10 +342,7 @@ void Builder::Loader::package(const string &n)
 {
        SourcePackage *pkg = new SourcePackage(obj, n, get_source());
 
-       if(options)
-               load_sub(*pkg, *options);
-       else
-               load_sub(*pkg);
+       load_sub(*pkg, options);
 
        if(obj.build_type)
                pkg->set_build_type(*obj.build_type);