From cc51208545c3941fcfdb078ad0c70c7fd607614e Mon Sep 17 00:00:00 2001
From: Mikko Rasa <tdb@tdb.fi>
Date: Tue, 21 May 2013 16:35:40 +0300
Subject: [PATCH] Verify that parameters make sense

---
 source/geometry/hyperbox.h    | 7 ++++++-
 source/geometry/hypersphere.h | 6 +++++-
 2 files changed, 11 insertions(+), 2 deletions(-)

diff --git a/source/geometry/hyperbox.h b/source/geometry/hyperbox.h
index 865b968..0e4efd8 100644
--- a/source/geometry/hyperbox.h
+++ b/source/geometry/hyperbox.h
@@ -3,6 +3,7 @@
 
 #include <algorithm>
 #include <cmath>
+#include <stdexcept>
 #include <msp/linal/vector.h>
 #include "ray.h"
 #include "shape.h"
@@ -47,7 +48,11 @@ inline HyperBox<T, D>::HyperBox()
 template<typename T, unsigned D>
 inline HyperBox<T, D>::HyperBox(const LinAl::Vector<T, D> &d):
 	dimensions(d)
-{ }
+{
+	for(unsigned i=0; i<D; ++i)
+		if(dimensions[i]<=T(0))
+			throw std::invalid_argument("HyperBox::HyperBox");
+}
 
 template<typename T, unsigned D>
 inline HyperBox<T, D> *HyperBox<T, D>::clone() const
diff --git a/source/geometry/hypersphere.h b/source/geometry/hypersphere.h
index 01aee0e..de028fa 100644
--- a/source/geometry/hypersphere.h
+++ b/source/geometry/hypersphere.h
@@ -2,6 +2,7 @@
 #define MSP_GEOMETRY_HYPERSPHERE_H_
 
 #include <cmath>
+#include <stdexcept>
 #include <msp/linal/vector.h>
 #include "hyperbox.h"
 #include "ray.h"
@@ -44,7 +45,10 @@ inline HyperSphere<T, D>::HyperSphere():
 template<typename T, unsigned D>
 inline HyperSphere<T, D>::HyperSphere(T r):
 	radius(r)
-{ }
+{
+	if(r<=T(0))
+		throw std::invalid_argument("HyperSphere::HyperShpere");
+}
 
 template<typename T, unsigned D>
 inline HyperSphere<T, D> *HyperSphere<T, D>::clone() const
-- 
2.45.2