From 182ee232f01d5bb25ddc4cf6e00249698871412f Mon Sep 17 00:00:00 2001 From: Mikko Rasa Date: Mon, 27 Sep 2010 20:34:00 +0000 Subject: [PATCH] Move the TrainControl inside the Controller class Rename a field in AIControl --- source/libmarklin/aicontrol.cpp | 40 ++++++++--------- source/libmarklin/aicontrol.h | 9 ++-- .../{traincontrol.cpp => controller.cpp} | 16 +++---- source/libmarklin/controller.h | 33 ++++++++++++-- source/libmarklin/simplecontroller.cpp | 6 +-- source/libmarklin/simplecontroller.h | 7 ++- source/libmarklin/train.cpp | 2 +- source/libmarklin/train.h | 5 +-- source/libmarklin/traincontrol.h | 44 ------------------- 9 files changed, 70 insertions(+), 92 deletions(-) rename source/libmarklin/{traincontrol.cpp => controller.cpp} (73%) delete mode 100644 source/libmarklin/traincontrol.h diff --git a/source/libmarklin/aicontrol.cpp b/source/libmarklin/aicontrol.cpp index 8876724..553159c 100644 --- a/source/libmarklin/aicontrol.cpp +++ b/source/libmarklin/aicontrol.cpp @@ -17,20 +17,20 @@ namespace Marklin { AIControl::AIControl(Train &t, Controller *n): train(t), - next_model(n), - target_speed(TrainControl::continuous("speed", 0, 1000)), + next_ctrl(n), + target_speed(Control::continuous("speed", 0, 1000)), blocked(false), approach(false) { target_speed.set(0); train.signal_arrived.connect(sigc::mem_fun(this, &AIControl::arrived)); - next_model->signal_control_changed.connect(sigc::mem_fun(this, &AIControl::control_changed)); + next_ctrl->signal_control_changed.connect(sigc::mem_fun(this, &AIControl::control_changed)); } AIControl::~AIControl() { - delete next_model; + delete next_ctrl; } void AIControl::set_control(const string &n, float v) @@ -45,45 +45,45 @@ void AIControl::set_control(const string &n, float v) { float approach_speed = 5*train.get_layout().get_catalogue().get_scale(); if(approach && target_speed.value>approach_speed) - next_model->set_control("speed", approach_speed); + next_ctrl->set_control("speed", approach_speed); else - next_model->set_control("speed", target_speed.value); + next_ctrl->set_control("speed", target_speed.value); } signal_control_changed.emit(target_speed); } else - next_model->set_control(n, v); + next_ctrl->set_control(n, v); } -const TrainControl &AIControl::get_control(const string &n) const +const Controller::Control &AIControl::get_control(const string &n) const { if(n=="speed") return target_speed; else - return next_model->get_control(n); + return next_ctrl->get_control(n); } float AIControl::get_speed() const { - return next_model->get_speed(); + return next_ctrl->get_speed(); } bool AIControl::get_reverse() const { - return next_model->get_reverse(); + return next_ctrl->get_reverse(); } float AIControl::get_braking_distance() const { - return next_model->get_braking_distance(); + return next_ctrl->get_braking_distance(); } void AIControl::tick(const Time::TimeDelta &dt) { float scale = train.get_layout().get_catalogue().get_scale(); float rsv_dist = train.get_reserved_distance(); - float brake_dist = next_model->get_braking_distance(); + float brake_dist = next_ctrl->get_braking_distance(); float approach_margin = 50*scale; float approach_speed = 5*scale; float margin = 10*scale; @@ -91,31 +91,31 @@ void AIControl::tick(const Time::TimeDelta &dt) if(!blocked && rsv_distset_control("speed", 0); + next_ctrl->set_control("speed", 0); } else if((!approach && rsv_distbrake_dist+margin*2)) { blocked = false; approach = true; if(target_speed.value>approach_speed) - next_model->set_control("speed", approach_speed); + next_ctrl->set_control("speed", approach_speed); else - next_model->set_control("speed", target_speed.value); + next_ctrl->set_control("speed", target_speed.value); } else if((blocked || approach) && rsv_dist>brake_dist*1.3+approach_margin*2) { blocked = false; approach = false; - next_model->set_control("speed", target_speed.value); + next_ctrl->set_control("speed", target_speed.value); } - next_model->tick(dt); + next_ctrl->tick(dt); - if(!target_speed.value && !next_model->get_speed() && train.is_active()) + if(!target_speed.value && !next_ctrl->get_speed() && train.is_active()) train.set_active(false); } -void AIControl::control_changed(const TrainControl &ctrl) +void AIControl::control_changed(const Control &ctrl) { if(ctrl.name!="speed") signal_control_changed.emit(ctrl); diff --git a/source/libmarklin/aicontrol.h b/source/libmarklin/aicontrol.h index 90906ca..462a114 100644 --- a/source/libmarklin/aicontrol.h +++ b/source/libmarklin/aicontrol.h @@ -10,7 +10,6 @@ Distributed under the GPL #include #include "controller.h" -#include "traincontrol.h" namespace Marklin { @@ -20,8 +19,8 @@ class AIControl: public Controller, public sigc::trackable { private: Train &train; - Controller *next_model; - TrainControl target_speed; + Controller *next_ctrl; + Control target_speed; bool blocked; bool approach; @@ -30,7 +29,7 @@ public: virtual ~AIControl(); virtual void set_control(const std::string &, float); - virtual const TrainControl &get_control(const std::string &) const; + virtual const Control &get_control(const std::string &) const; virtual float get_speed() const; virtual bool get_reverse() const; @@ -39,7 +38,7 @@ public: virtual void tick(const Msp::Time::TimeDelta &); private: - void control_changed(const TrainControl &); + void control_changed(const Control &); void arrived(); }; diff --git a/source/libmarklin/traincontrol.cpp b/source/libmarklin/controller.cpp similarity index 73% rename from source/libmarklin/traincontrol.cpp rename to source/libmarklin/controller.cpp index a9a5a84..8d7be31 100644 --- a/source/libmarklin/traincontrol.cpp +++ b/source/libmarklin/controller.cpp @@ -7,14 +7,14 @@ Distributed under the GPL #include #include -#include "traincontrol.h" +#include "controller.h" using namespace std; using namespace Msp; namespace Marklin { -void TrainControl::set(float v) +void Controller::Control::set(float v) { if(v signal_control_changed; + struct Control + { + enum Type + { + BINARY, + DISCRETE, + CONTINUOUS + }; + + std::string name; + Type type; + float min_value; + float max_value; + float step; + float value; + + private: + Control() { } + + public: + void set(float); + + static Control binary(const std::string &); + static Control discrete(const std::string &, float, float, float); + static Control continuous(const std::string &, float, float); + }; + + sigc::signal signal_control_changed; protected: Controller() { } @@ -31,7 +56,7 @@ public: virtual ~Controller() { } virtual void set_control(const std::string &, float) = 0; - virtual const TrainControl &get_control(const std::string &) const = 0; + virtual const Control &get_control(const std::string &) const = 0; /** Returns the current speed. Always non-negative. */ virtual float get_speed() const = 0; diff --git a/source/libmarklin/simplecontroller.cpp b/source/libmarklin/simplecontroller.cpp index 01d0411..5744188 100644 --- a/source/libmarklin/simplecontroller.cpp +++ b/source/libmarklin/simplecontroller.cpp @@ -15,8 +15,8 @@ using namespace Msp; namespace Marklin { SimpleController::SimpleController(): - target_speed(TrainControl::continuous("speed", 0, 1000)), - reverse(TrainControl::binary("reverse")), + target_speed(Control::continuous("speed", 0, 1000)), + reverse(Control::binary("reverse")), accel(0.07), speed(0) { @@ -39,7 +39,7 @@ void SimpleController::set_control(const string &name, float v) } } -const TrainControl &SimpleController::get_control(const string &name) const +const Controller::Control &SimpleController::get_control(const string &name) const { if(name=="speed") return target_speed; diff --git a/source/libmarklin/simplecontroller.h b/source/libmarklin/simplecontroller.h index c86d537..9b0df26 100644 --- a/source/libmarklin/simplecontroller.h +++ b/source/libmarklin/simplecontroller.h @@ -10,15 +10,14 @@ Distributed under the GPL #include #include "controller.h" -#include "traincontrol.h" namespace Marklin { class SimpleController: public Controller { private: - TrainControl target_speed; - TrainControl reverse; + Control target_speed; + Control reverse; float accel; float speed; @@ -26,7 +25,7 @@ public: SimpleController(); virtual void set_control(const std::string &, float); - virtual const TrainControl &get_control(const std::string &) const; + virtual const Control &get_control(const std::string &) const; virtual float get_speed() const { return speed; } virtual bool get_reverse() const { return reverse.value; } diff --git a/source/libmarklin/train.cpp b/source/libmarklin/train.cpp index 920ae4a..d87d376 100644 --- a/source/libmarklin/train.cpp +++ b/source/libmarklin/train.cpp @@ -514,7 +514,7 @@ void Train::save(list &st) const } } -void Train::control_changed(const TrainControl &ctrl) +void Train::control_changed(const Controller::Control &ctrl) { signal_control_changed.emit(ctrl.name, ctrl.value); } diff --git a/source/libmarklin/train.h b/source/libmarklin/train.h index e4458be..319119b 100644 --- a/source/libmarklin/train.h +++ b/source/libmarklin/train.h @@ -12,15 +12,14 @@ Distributed under the GPL #include #include #include "block.h" +#include "controller.h" namespace Marklin { -class Controller; class Route; class Timetable; class Vehicle; class VehicleType; -struct TrainControl; class Train: public sigc::trackable { @@ -145,7 +144,7 @@ public: void save(std::list &) const; private: - void control_changed(const TrainControl &); + void control_changed(const Controller::Control &); void loco_speed_event(unsigned, unsigned, bool); void loco_func_event(unsigned, unsigned, bool); void sensor_event(unsigned, bool); diff --git a/source/libmarklin/traincontrol.h b/source/libmarklin/traincontrol.h deleted file mode 100644 index ac86bc4..0000000 --- a/source/libmarklin/traincontrol.h +++ /dev/null @@ -1,44 +0,0 @@ -/* $Id$ - -This file is part of the MSP Märklin suite -Copyright © 2010 Mikkosoft Productions, Mikko Rasa -Distributed under the GPL -*/ - -#ifndef LIBMARKLIN_TRAINCONTROL_H_ -#define LIBMARKLIN_TRAINCONTROL_H_ - -#include - -namespace Marklin { - -struct TrainControl -{ - enum Type - { - BINARY, - DISCRETE, - CONTINUOUS - }; - - std::string name; - Type type; - float min_value; - float max_value; - float step; - float value; - -private: - TrainControl() { } - -public: - void set(float); - - static TrainControl binary(const std::string &); - static TrainControl discrete(const std::string &, float, float, float); - static TrainControl continuous(const std::string &, float, float); -}; - -} // namespace Marklin - -#endif -- 2.45.2