From: Dirk Hohndel <dirk@hohndel.org>
Date: Tue, 3 Jan 2012 04:13:45 +0000 (-0800)
Subject: Correctly free the GSList in file_open
X-Git-Url: http://git.tdb.fi/?a=commitdiff_plain;h=43530d397bd8d754202d0e97d13c32c1f0685f01;p=ext%2Fsubsurface.git

Correctly free the GSList in file_open

Passing a value that is known to be NULL to g_slist_free seems like the
wrong approach...

Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
---

diff --git a/gtk-gui.c b/gtk-gui.c
index f171203..ddae481 100644
--- a/gtk-gui.c
+++ b/gtk-gui.c
@@ -106,9 +106,9 @@ static void file_open(GtkWidget *w, gpointer data)
 	gtk_file_chooser_set_filter(GTK_FILE_CHOOSER(dialog), filter);
 
 	if (gtk_dialog_run(GTK_DIALOG(dialog)) == GTK_RESPONSE_ACCEPT) {
-		GSList *filenames;
+		GSList *filenames, *fn_glist;
 		char *filename;
-		filenames = gtk_file_chooser_get_filenames(GTK_FILE_CHOOSER(dialog));
+		filenames = fn_glist = gtk_file_chooser_get_filenames(GTK_FILE_CHOOSER(dialog));
 		
 		GError *error = NULL;
 		while(filenames != NULL) {
@@ -124,7 +124,7 @@ static void file_open(GtkWidget *w, gpointer data)
 			g_free(filename);
 			filenames = g_slist_next(filenames);
 		}
-		g_slist_free(filenames);
+		g_slist_free(fn_glist);
 		report_dives(FALSE);
 	}
 	gtk_widget_destroy(dialog);