From: Mikko Rasa <tdb@tdb.fi>
Date: Thu, 5 Jul 2018 14:29:28 +0000 (+0300)
Subject: Fix sound file signature comparisons
X-Git-Url: http://git.tdb.fi/?a=commitdiff_plain;h=1e7141871d33e3e184456ba063fcf3448a8cc12a;p=libs%2Fal.git

Fix sound file signature comparisons

The standard states that if a length is not given, the character array
must be nul-terminated.
---

diff --git a/source/mp3decoder.cpp b/source/mp3decoder.cpp
index 34604e3..cc32356 100644
--- a/source/mp3decoder.cpp
+++ b/source/mp3decoder.cpp
@@ -84,7 +84,7 @@ bool Mp3Decoder::detect(const string &sig)
 	static const char id3_sig[] = { 'I', 'D', '3' };
 	if(sig.size()<sizeof(id3_sig))
 		return false;
-	return !sig.compare(0, sizeof(id3_sig), id3_sig);
+	return !sig.compare(0, sizeof(id3_sig), id3_sig, sizeof(id3_sig));
 }
 
 void Mp3Decoder::seek(unsigned pos)
diff --git a/source/oggdecoder.cpp b/source/oggdecoder.cpp
index cd2def8..374cf0b 100644
--- a/source/oggdecoder.cpp
+++ b/source/oggdecoder.cpp
@@ -106,7 +106,7 @@ bool OggDecoder::detect(const std::string &sig)
 	static const char ogg_sig[] = { 'O', 'g', 'g', 'S' };
 	if(sig.size()<sizeof(ogg_sig))
 		return false;
-	return !sig.compare(0, sizeof(ogg_sig), ogg_sig);
+	return !sig.compare(0, sizeof(ogg_sig), ogg_sig, sizeof(ogg_sig));
 }
 
 void OggDecoder::seek(unsigned pos)