Mark parameterless functions as such with a void argument list

diff --git a/arducontrol/arducontrol.c b/arducontrol/arducontrol.c
index 882f280b9e432b3dd3399f0230a011b4404d34d4..1c8cde9db4830a4e17bcd44726c85fc4e39614d0 100644 (file)
--- a/arducontrol/arducontrol.c
+++ b/arducontrol/arducontrol.c
@@ -39,7 +39,7 @@ its data to the track can start.
 #include "monitor.h"
 #include "output.h"
 
-int main()
+int main(void)
 {
        output_init();
        interface_init();

diff --git a/arducontrol/interface.c b/arducontrol/interface.c
index 9d21e9cbfe1ddf874d0e41b9807aa29a2164686e..041dd67bafc05f07fb9ef096b9f9b8a0668f9c8b 100644 (file)
--- a/arducontrol/interface.c
+++ b/arducontrol/interface.c
@@ -12,17 +12,17 @@ volatile uint8_t recv_overrun = 0;
 uint8_t cmd_buf[15];
 uint8_t cmd_length;
 
-void process_commands();
-uint8_t process_command();
+void process_commands(void);
+uint8_t process_command(void);
 
-void interface_init()
+void interface_init(void)
 {
        DDRD = (DDRD&0xFC)|0x02;
 
        serial_init(9600);
 }
 
-void interface_check()
+void interface_check(void)
 {
        if(recv_overrun)
        {
@@ -34,7 +34,7 @@ void interface_check()
                process_commands();
 }
 
-void process_commands()
+void process_commands(void)
 {
        while(recv_fill>0)
        {
@@ -80,7 +80,7 @@ void process_commands()
        }
 }
 
-uint8_t process_command()
+uint8_t process_command(void)
 {
        uint8_t type = cmd_buf[0]>>4;
        if(type==0)

diff --git a/arducontrol/interface.h b/arducontrol/interface.h
index f95244f99b5204ab658604205aefc25d20f7d0e0..7e89e2e0e91208602b4f722ab55b95bdfacaa6e8 100644 (file)
--- a/arducontrol/interface.h
+++ b/arducontrol/interface.h
@@ -7,7 +7,7 @@
 extern uint8_t cmd_buf[];
 extern uint8_t cmd_length;
 
-void interface_init();
-void interface_check();
+void interface_init(void);
+void interface_check(void);
 
 #endif

diff --git a/arducontrol/monitor.c b/arducontrol/monitor.c
index 679c62a1b2e1bd4617d6da240a7ad0fb53673bf3..112e1ac56486c2317dce74d189e815de0f6afe83 100644 (file)
--- a/arducontrol/monitor.c
+++ b/arducontrol/monitor.c
@@ -17,15 +17,15 @@ volatile uint16_t input_voltage_sum = 0;
 volatile uint8_t adc_state = 0;
 volatile uint16_t adc_value = 0;
 
-uint16_t track_current_milliamps();
-uint16_t input_voltage_millivolts();
+uint16_t track_current_milliamps(void);
+uint16_t input_voltage_millivolts(void);
 
-void monitor_init()
+void monitor_init(void)
 {
        adc_init();
 }
 
-void monitor_check()
+void monitor_check(void)
 {
        if(!(adc_state&1))
        {
@@ -66,7 +66,7 @@ void monitor_check()
        }
 }
 
-uint8_t monitor_command()
+uint8_t monitor_command(void)
 {
        if(cmd_buf[0]==READ_TRACK_CURRENT)
        {
@@ -110,7 +110,7 @@ uint8_t monitor_command()
        return COMMAND_OK;
 }
 
-uint16_t track_current_milliamps()
+uint16_t track_current_milliamps(void)
 {
        uint16_t value = track_current_sum;
 
@@ -127,7 +127,7 @@ uint16_t track_current_milliamps()
        }
 }
 
-uint16_t input_voltage_millivolts()
+uint16_t input_voltage_millivolts(void)
 {
        uint16_t value = input_voltage_sum;
 

diff --git a/arducontrol/monitor.h b/arducontrol/monitor.h
index d5761e3d150842b6084590cfd68e394e573e869f..b21763d097c9b6e6036cdd9a8f22e239d689c11c 100644 (file)
--- a/arducontrol/monitor.h
+++ b/arducontrol/monitor.h
@@ -3,8 +3,8 @@
 
 #include <stdint.h>
 
-void monitor_init();
-void monitor_check();
-uint8_t monitor_command();
+void monitor_init(void);
+void monitor_check(void);
+uint8_t monitor_command(void);
 
 #endif

diff --git a/arducontrol/motorola.c b/arducontrol/motorola.c
index 5bf15ad9e37ed8422cd93f063d128d34c0beada9..33cf1c0a9209054391b6c380000cdf34ce1ebd85 100644 (file)
--- a/arducontrol/motorola.c
+++ b/arducontrol/motorola.c
@@ -125,7 +125,7 @@ void motorola_solenoid_packet(uint8_t addr, uint8_t output, uint8_t state)
        packet.ready = 1;
 }
 
-uint8_t motorola_command()
+uint8_t motorola_command(void)
 {
        if(cmd_buf[0]==MOTOROLA_SPEED || cmd_buf[0]==MOTOROLA_SPEED_DIRECTION || cmd_buf[0]==MOTOROLA_SPEED_FUNCTION)
        {

diff --git a/arducontrol/motorola.h b/arducontrol/motorola.h
index 5a3057a9fb3432d39d0f74aadad83a9b36fc7be7..4a64d62255cb4202aec4d7da95c26926088bf43d 100644 (file)
--- a/arducontrol/motorola.h
+++ b/arducontrol/motorola.h
@@ -9,6 +9,6 @@ void motorola_locomotive_speed_direction_packet(uint8_t, uint8_t, uint8_t, uint8
 void motorola_locomotive_speed_function_packet(uint8_t, uint8_t, uint8_t, uint8_t, uint8_t);
 void motorola_solenoid_packet(uint8_t, uint8_t, uint8_t);
 void motorola_set_repeat_count(uint8_t);
-uint8_t motorola_command();
+uint8_t motorola_command(void);
 
 #endif

diff --git a/arducontrol/output.c b/arducontrol/output.c
index 4b662960977e9b5762e237b96b8fe7be57ac4960..748c554d32cc6028347bbcc2d7bc9138f385fee7 100644 (file)
--- a/arducontrol/output.c
+++ b/arducontrol/output.c
@@ -13,7 +13,7 @@ uint8_t out_time;
 uint8_t out_data;
 uint8_t delay_time;
 
-void output_init()
+void output_init(void)
 {
        DDRD = (DDRD&0xF3)|0x0C;
        PORTD &= ~BIT(ENABLE);
@@ -21,7 +21,7 @@ void output_init()
        timer_start_hz(0, 80000, 1);
 }
 
-void clear_packet()
+void clear_packet(void)
 {
        packet.ready = 0;
        packet.sending = 0;
@@ -36,7 +36,7 @@ void output_set_power(uint8_t p)
                PORTD &= ~BIT(ENABLE);
 }
 
-uint8_t output_command()
+uint8_t output_command(void)
 {
        if(cmd_buf[0]==POWER_ON || cmd_buf[0]==POWER_OFF)
        {
@@ -51,7 +51,7 @@ uint8_t output_command()
        return COMMAND_OK;
 }
 
-static inline void output_tick()
+static inline void output_tick(void)
 {
        if(delay_time && --delay_time)
                return;

diff --git a/arducontrol/output.h b/arducontrol/output.h
index b4498ad391e9c954204f3962eb201cbcbb51ae19..05c9a21ef713f1988f9b83768c6436cfc196fb25 100644 (file)
--- a/arducontrol/output.h
+++ b/arducontrol/output.h
@@ -18,9 +18,9 @@ typedef struct
 
 extern OutputPacket packet;
 
-void output_init();
-void clear_packet();
+void output_init(void);
+void clear_packet(void);
 void output_set_power(uint8_t);
-uint8_t output_command();
+uint8_t output_command(void);
 
 #endif