Comment cleanup and other cosmetic fixes

diff --git a/plugins/android/androidtools.cpp b/plugins/android/androidtools.cpp
index 5053682a885502ef3c22f96a0c19c718210ae23a..bb2cd89fc824a960019f6fb4d12d3750b3630004 100644 (file)
--- a/plugins/android/androidtools.cpp
+++ b/plugins/android/androidtools.cpp
@@ -19,8 +19,6 @@
 using namespace std;
 using namespace Msp;
 
-// TODO Mark problems somewhere instead of throwing exceptions
-
 unsigned parse_version(const std::string &version_str)
 {
        vector<string> version_parts = split(version_str, '.');

diff --git a/plugins/base/compilecommandsjson.h b/plugins/base/compilecommandsjson.h
index be9c4480f2871564d39a3b2f786f40e1b08a4efc..1ad6e96adab2d196c802044ebef3c2a03ce83ba5 100644 (file)
--- a/plugins/base/compilecommandsjson.h
+++ b/plugins/base/compilecommandsjson.h
@@ -6,8 +6,6 @@
 
 class CompileCommandsJson: public FileTarget
 {
-private:
-       
 public:
        CompileCommandsJson(Builder &, const SourcePackage &);
 

diff --git a/plugins/gnu/gnucompiler.h b/plugins/gnu/gnucompiler.h
index 98c71ede09e0973a3c705bbbdbb35b51eb1c0550..572e376fa354b9e24451b0b5d33b056a0a32fbc5 100644 (file)
--- a/plugins/gnu/gnucompiler.h
+++ b/plugins/gnu/gnucompiler.h
@@ -6,11 +6,8 @@
 class ObjectFile;
 
 /**
-Common base class for GNU compilers.  Turns SourceFiles into ObjectFiles.
-
-Since invocation is mostly the same for all language frontends, most of the
-logic is here and the individual tools only handle creating source files of
-appropriate type.
+The GNU compiler.  Can be created with different tags for different languages.
+Turns SourceFiles into ObjectFiles.
 */
 class GnuCompiler: public Tool
 {

diff --git a/plugins/gnu/gnulinker.h b/plugins/gnu/gnulinker.h
index 11a0fb1edd9d9a5d6727005be306041e4e25133b..a669bc7be0767ea60a297ab32794a703360682b8 100644 (file)
--- a/plugins/gnu/gnulinker.h
+++ b/plugins/gnu/gnulinker.h
@@ -9,8 +9,6 @@ class Binary;
 The GNU linker.  Turns ObjectFiles into Executables and SharedLibraries.  To
 create a shared library, specify "shared" as the second argument to
 create_target.
-
-Uses either gcc or g++ depending on what was used to compile the object files.
 */
 class GnuLinker: public Tool
 {

diff --git a/source/lib/builder.h b/source/lib/builder.h
index 28379ed73a452409ad66715fc134e3a60365f754..62fc21494e066baee9d5e9c5517974554f549012 100644 (file)
--- a/source/lib/builder.h
+++ b/source/lib/builder.h
@@ -17,7 +17,6 @@
 #include "toolchain.h"
 #include "virtualfilesystem.h"
 
-class FileTarget;
 class Package;
 class Plugin;
 

diff --git a/source/lib/externaltask.h b/source/lib/externaltask.h
index 9b9bc438867ce5884241249dedbe6b511af87ed8..4a789201b64848c35123f9e4fb3d6394760968d8 100644 (file)
--- a/source/lib/externaltask.h
+++ b/source/lib/externaltask.h
@@ -68,7 +68,7 @@ public:
        void set_stderr(StreamAction);
 
        /** Returns captured output, if any.  This may be called while the task is
-       still running, but it will always return all output. */
+       still running, but it will always return all output produced so far. */
        const std::string &get_output() const { return output; }
 
        /** Executes a command and captures its output.  If the command exits with

diff --git a/source/lib/package.h b/source/lib/package.h
index 8e0c6924fc33b85b461cca7b808cc856237adde2..9a10991ec8e94028ae74d27e553ceec233424d87 100644 (file)
--- a/source/lib/package.h
+++ b/source/lib/package.h
@@ -9,7 +9,6 @@
 #include "config.h"
 
 class Builder;
-class Package;
 
 /**
 A package is a distributable piece of software.  Package information may be

diff --git a/source/lib/sourcepackage.h b/source/lib/sourcepackage.h
index 2c2e57c70a4503e8f21ad980cda88ac1e84f935e..d458c9094208c9c86ff4755bb34d9bb47aa6d3b7 100644 (file)
--- a/source/lib/sourcepackage.h
+++ b/source/lib/sourcepackage.h
@@ -14,7 +14,6 @@
 #include "package.h"
 #include "toolchain.h"
 
-class Builder;
 class BuildType;
 class FileTarget;
 class SourceArchiveComponent;

diff --git a/source/lib/virtualfilesystem.cpp b/source/lib/virtualfilesystem.cpp
index 16d4de8584a37dab7e8c2d426d8125fb56569351..714b89c80dcd128d22ca7cc50a269a9e264bdb5a 100644 (file)
--- a/source/lib/virtualfilesystem.cpp
+++ b/source/lib/virtualfilesystem.cpp
@@ -4,7 +4,6 @@
 #include <msp/io/print.h>
 #include <msp/strings/utils.h>
 #include "builder.h"
-#include "csourcefile.h"
 #include "executable.h"
 #include "importlibrary.h"
 #include "sharedlibrary.h"