X-Git-Url: http://git.tdb.fi/?a=blobdiff_plain;f=source%2Ftime%2Ftimer.cpp;h=9471463216206b701d285562bb41e0af1901fafc;hb=5b0c36c9c6c9c30f1eb42186fed7acc7e99faf3e;hp=efe22cc39d94b032e99c58032a7a8819364f7dfe;hpb=bb49a2de46849a9ffa509148661d4c574c43fe24;p=libs%2Fcore.git

diff --git a/source/time/timer.cpp b/source/time/timer.cpp
index efe22cc..9471463 100644
--- a/source/time/timer.cpp
+++ b/source/time/timer.cpp
@@ -1,9 +1,11 @@
-/*
+/* $Id$
+
 This file is part of libmspcore     
-Copyright © 2006  Mikko Rasa, Mikkosoft Productions
+Copyright © 2006, 2009  Mikko Rasa, Mikkosoft Productions
 Distributed under the LGPL
 */
 
+#include <algorithm>
 #include "timer.h"
 #include "utils.h"
 
@@ -14,7 +16,7 @@ namespace Time {
 
 Timer::~Timer()
 {
-	for(set<SlotProxy>::iterator i=slots.begin(); i!=slots.end(); ++i)
+	for(vector<SlotProxy>::iterator i=slots.begin(); i!=slots.end(); ++i)
 		delete i->slot;
 }
 
@@ -22,7 +24,8 @@ Timer::Slot &Timer::add(const TimeDelta &td)
 {
 	Slot *s=new Slot(td);
 	mutex.lock();
-	slots.insert(s);
+	slots.push_back(s);
+	push_heap(slots.begin(), slots.end());
 	mutex.unlock();
 	sem.signal();
 	return *s;
@@ -33,7 +36,8 @@ Timer::Slot &Timer::add(const TimeStamp &ts)
 	Slot *s=new Slot(ts);
 	{
 		MutexLock l(mutex);
-		slots.insert(s);
+		slots.push_back(s);
+		push_heap(slots.begin(), slots.end());
 	}
 	sem.signal();
 	return *s;
@@ -42,36 +46,62 @@ Timer::Slot &Timer::add(const TimeStamp &ts)
 void Timer::cancel(Slot &slot)
 {
 	MutexLock l(mutex);
-	if(slots.erase(&slot))
-		delete &slot;
+	for(vector<SlotProxy>::iterator i=slots.begin(); i!=slots.end(); ++i)
+		if(i->slot==&slot)
+		{
+			delete i->slot;
+			slots.erase(i);
+			make_heap(slots.begin(), slots.end());
+			return;
+		}
 }
 
 void Timer::tick(bool block)
 {
-	if(slots.empty())
-	{
-		if(block)
-			sem.wait();
-		else
-			return;
-	}
-
-	Slot *next;
+	Slot *next=0;
 	{
 		MutexLock l(mutex);
-		next=slots.begin()->slot;
+		while(1)
+		{
+			if(slots.empty())
+			{
+				if(block)
+					sem.wait();
+				else
+					return;
+			}
+
+			next=slots.begin()->slot;
+			const TimeStamp &stamp=next->get_timeout();
+			const TimeStamp t=now();
+			if(stamp<=t)
+				break;
+			else if(block)
+				sem.wait(stamp-t);
+			else
+				return;
+		}
+
+		pop_heap(slots.begin(), slots.end());
+		slots.pop_back();
 	}
 
-	const TimeStamp &stamp=next->get_timeout();
-	const TimeStamp t=now();
-	if(stamp<=t || (block && sem.wait(stamp-t)==1))
+	try
 	{
-		slots.erase(slots.begin());
 		if(next->signal_timeout.emit() && next->increment())
-			slots.insert(next);
+		{
+			MutexLock l(mutex);
+			slots.push_back(next);
+			push_heap(slots.begin(), slots.end());
+		}
 		else
 			delete next;
 	}
+	catch(...)
+	{
+		delete next;
+		throw;
+	}
 }
 
 TimeStamp Timer::get_next_timeout() const
@@ -106,7 +136,7 @@ Timer::SlotProxy::SlotProxy(Slot *s):
 
 bool Timer::SlotProxy::operator<(const SlotProxy &sp) const
 {
-	return slot->get_timeout()<sp.slot->get_timeout();
+	return slot->get_timeout()>sp.slot->get_timeout();
 }
 
 } // namespace Time