X-Git-Url: http://git.tdb.fi/?a=blobdiff_plain;f=source%2Ftarget.cpp;h=cd4cf36370b252ca55ca6a954a1d51b5c1c10dd9;hb=5cfcbc7507b14df81018f734ae47f92b231b10d2;hp=2d4a2de034f45a49186792dcb7a64d8919fe24b6;hpb=0368a9c1972ff5fd6cd8984901ff0bdbd86afc9f;p=builder.git

diff --git a/source/target.cpp b/source/target.cpp
index 2d4a2de..cd4cf36 100644
--- a/source/target.cpp
+++ b/source/target.cpp
@@ -22,6 +22,15 @@ Target::Target(Builder &b, const string &n):
 	builder.add_target(this);
 }
 
+void Target::add_dependency(Target &dep)
+{
+	if(&dep==this)
+		throw invalid_argument("Target::add_depend");
+	depends.push_back(&dep);
+	if(state>PREPARING)
+		dep.signal_bubble_rebuild.connect(sigc::mem_fun(this, &Target::check_rebuild));
+}
+
 Target *Target::get_buildable_target()
 {
 	if(!needs_rebuild())
@@ -55,13 +64,17 @@ void Target::force_rebuild()
 	mark_rebuild("Forced rebuild");
 }
 
-void Target::add_depend(Target *dep)
+void Target::mark_rebuild(const string &reason)
 {
-	if(dep==this)
-		throw invalid_argument("Target::add_depend");
-	depends.push_back(dep);
-	if(state>PREPARING)
-		dep->signal_bubble_rebuild.connect(sigc::mem_fun(this, &Target::check_rebuild));
+	if(reason.empty())
+		throw invalid_argument("No reason given for rebuilding "+name);
+
+	state = REBUILD;
+	rebuild_reason = reason;
+
+	builder.get_logger().log("rebuild", format("Rebuilding %s: %s", name, reason));
+
+	signal_bubble_rebuild.emit();
 }
 
 void Target::prepare()
@@ -75,11 +88,11 @@ void Target::prepare()
 	}
 
 	state = PREPARING;
-	find_depends();
+	find_dependencies();
 	if(tool)
 	{
 		if(FileTarget *tool_exe = tool->get_executable())
-			add_depend(tool_exe);
+			add_dependency(*tool_exe);
 	}
 
 	for(Dependencies::iterator i=depends.begin(); i!=depends.end(); ++i)
@@ -102,11 +115,6 @@ Task *Target::build()
 		return 0;
 	}
 
-	// XXX Minor breach of OO here
-	if(FileTarget *ft = dynamic_cast<FileTarget *>(this))
-		if(!builder.get_dry_run() && FS::exists(ft->get_path()))
-			FS::unlink(ft->get_path());
-
 	Task *task = tool->run(*this);
 	task->signal_finished.connect(sigc::mem_fun(this, &Target::build_finished));
 	state = BUILDING;
@@ -114,19 +122,6 @@ Task *Target::build()
 	return task;
 }
 
-void Target::mark_rebuild(const string &reason)
-{
-	if(reason.empty())
-		throw invalid_argument("No reason given for rebuilding "+name);
-
-	state = REBUILD;
-	rebuild_reason = reason;
-
-	builder.get_logger().log("rebuild", format("Rebuilding %s: %s", name, reason));
-
-	signal_bubble_rebuild.emit();
-}
-
 void Target::build_finished(bool /*success*/)
 {
 	state = UPTODATE;