X-Git-Url: http://git.tdb.fi/?a=blobdiff_plain;f=source%2Ftarget.cpp;h=9006a570cb360f42c00589bd08abc7e54b25ca05;hb=92d81529ec8f3b84f5471162d0b27914eff7adb5;hp=2005d25cfc55817792d47289a2c1c2dabb58ce9d;hpb=4629d189a531c962cf15a511df787f30c3adcb02;p=builder.git diff --git a/source/target.cpp b/source/target.cpp index 2005d25..9006a57 100644 --- a/source/target.cpp +++ b/source/target.cpp @@ -1,50 +1,75 @@ -/* $Id$ - -This file is part of builder -Copyright © 2006-2009 Mikko Rasa, Mikkosoft Productions -Distributed under the LGPL -*/ - +#include #include #include -#include -#include "action.h" +#include #include "builder.h" #include "filetarget.h" -#include "package.h" #include "sourcepackage.h" #include "target.h" +#include "task.h" +#include "tool.h" using namespace std; using namespace Msp; -Target::Target(Builder &b, const Package *p, const string &n): +Target::Target(Builder &b, const string &n): builder(b), - package(p), + package(0), + component(0), name(n), - buildable(false), - building(false), - rebuild(false), - deps_ready(false), - preparing(false), - prepared(false) + tool(0), + state(INIT), + primary_target(0) +{ + builder.get_build_graph().add_target(this); +} + +void Target::add_dependency(Target &dep) +{ + if(&dep==this) + throw invalid_argument("Target::add_depend"); + depends.push_back(&dep); + if(state>PREPARING) + dep.signal_bubble_rebuild.connect(sigc::mem_fun(this, &Target::check_rebuild)); +} + +void Target::add_transitive_dependency(Target &dep) +{ + if(&dep==this) + throw invalid_argument("Target::add_transitive_dependency"); + trans_depends.push_back(&dep); +} + +void Target::add_side_effect(Target &se) { - builder.add_target(this); + side_effects.push_back(&se); + if(tool) + se.set_tool(*tool); + se.primary_target = this; + /* Side effects are checked for rebuild after the primary target. Recheck + the primary if a side effect is marked for rebuild. */ + se.signal_bubble_rebuild.connect(sigc::mem_fun(this, &Target::check_rebuild)); } Target *Target::get_buildable_target() { - if(!rebuild) + if(primary_target) + return primary_target->get_buildable_target(); + if(!needs_rebuild()) return 0; - bool self_ok=!building; - for(TargetList::iterator i=depends.begin(); i!=depends.end(); ++i) + bool self_ok = state!=BUILDING; + for(Dependencies::iterator i=depends.begin(); i!=depends.end(); ++i) { - Target *tgt=(*i)->get_buildable_target(); + // Avoid infinite recursion if a target repends on its own side effect + if(find(side_effects.begin(), side_effects.end(), *i)!=side_effects.end()) + continue; + + Target *tgt = (*i)->get_buildable_target(); if(tgt) return tgt; - else if((*i)->get_rebuild()) - self_ok=false; + else if((*i)->needs_rebuild()) + self_ok = false; } if(self_ok) @@ -53,94 +78,116 @@ Target *Target::get_buildable_target() return 0; } -void Target::add_depend(Target *dep) +void Target::set_tool(Tool &t) +{ + tool = &t; + for(Dependencies::const_iterator i=side_effects.begin(); i!=side_effects.end(); ++i) + (*i)->set_tool(t); +} + +void Target::collect_build_info(BuildInfo &binfo) const { - if(dep==this) - throw InvalidParameterValue("A target can't depend on itself"); - depends.push_back(dep); - dep->rdepends.push_back(this); + if(tool) + binfo.update_from(tool->get_build_info()); + if(component) + binfo.update_from(component->get_build_info()); + else if(package) + binfo.update_from(package->get_build_info()); +} + +void Target::force_rebuild() +{ + if(!is_buildable()) + throw logic_error("Target::force_rebuild"); + mark_rebuild("Forced rebuild"); +} + +void Target::mark_rebuild(const string &reason) +{ + if(reason.empty()) + throw invalid_argument("No reason given for rebuilding "+name); + + state = REBUILD; + rebuild_reason = reason; + + builder.get_logger().log("rebuild", format("Rebuilding %s: %s", name, reason)); + + signal_bubble_rebuild.emit(); } void Target::prepare() { - if(prepared) + if(state>PREPARING) return; - if(preparing) + if(state==PREPARING) { - builder.problem((package ? package->get_name() : string()), "Dependency cycle detected at "+name); + builder.get_logger().log("problems", format("Dependency cycle detected at %s", name)); + problems.push_back("Dependency cycle detected"); + state = BROKEN; return; } - preparing=true; - for(TargetList::iterator i=depends.begin(); i!=depends.end(); ++i) - (*i)->prepare(); + state = PREPARING; + if(tool) + tool->prepare(); - check_rebuild(); - preparing=false; - prepared=true; -} + find_dependencies(); + bool broken = !problems.empty(); -Action *Target::build() -{ - if(!buildable) + if(tool) { - rebuild=false; - return 0; + if(FileTarget *tool_exe = tool->get_executable()) + add_dependency(*tool_exe); + broken |= !tool->get_problems().empty(); + + // Only check package and component problems for buildable targets + // XXX How to propagate nested package problems? + broken |= (package && !package->get_problems().empty()); + broken |= (component && !component->get_problems().empty()); } - if(FileTarget *ft=dynamic_cast(this)) - if(!builder.get_dry_run() && FS::exists(ft->get_path())) - FS::unlink(ft->get_path()); - - Action *action=create_action(); - if(action) + for(Dependencies::iterator i=depends.begin(); i!=depends.end(); ++i) { - action->signal_done.connect(sigc::mem_fun(this, &Target::build_done)); - - building=true; + (*i)->prepare(); + broken |= (*i)->is_broken(); } + for(Dependencies::iterator i=trans_depends.begin(); i!=trans_depends.end(); ++i) + (*i)->prepare(); - return action; -} + check_rebuild(); + if(broken) + state = BROKEN; + else if(state==PREPARING) + state = UPTODATE; -void Target::touch() -{ - mtime=Time::now(); + for(Dependencies::iterator i=depends.begin(); i!=depends.end(); ++i) + (*i)->signal_bubble_rebuild.connect(sigc::mem_fun(this, &Target::check_rebuild)); } -void Target::mark_rebuild(const std::string &reason) +Task *Target::build() { - rebuild=true; - rebuild_reason=reason; -} + if(primary_target) + return primary_target->build(); -void Target::check_rebuild() -{ - if(!buildable) - return; + Task *task = tool->run(*this); + task->signal_finished.connect(sigc::mem_fun(this, &Target::build_finished)); + state = BUILDING; - if(builder.get_build_all()) - mark_rebuild("Rebuilding everything"); - else if(!mtime) - mark_rebuild("Does not exist"); - else - { - for(TargetList::iterator i=depends.begin(); (i!=depends.end() && !rebuild); ++i) - { - if((*i)->get_mtime()>mtime) - mark_rebuild(FS::basename((*i)->get_name())+" has changed"); - else if((*i)->get_rebuild()) - mark_rebuild(FS::basename((*i)->get_name())+" needs rebuilding"); - } - } + build(*task); + for(Dependencies::const_iterator i=side_effects.begin(); i!=side_effects.end(); ++i) + (*i)->build(*task); - const SourcePackage *spkg=dynamic_cast(package); - if(!rebuild && spkg && spkg->get_config().get_mtime()>mtime) - mark_rebuild("Package options changed"); + return task; } -void Target::build_done() +void Target::build_finished(bool success) { - building=false; - rebuild=false; + state = UPTODATE; + if(success) + { + modified(); + for(Dependencies::const_iterator i=side_effects.begin(); i!=side_effects.end(); ++i) + (*i)->build_finished(success); + signal_modified.emit(); + } }