X-Git-Url: http://git.tdb.fi/?a=blobdiff_plain;f=source%2Ftarget.cpp;h=64e1115adbd7bdc43134c3ef185764f944a40848;hb=cbc6c684472ee8120f29358c0167d98524f1f939;hp=b0273e9ff535d9a5a80d0d6ecee5948245298b8c;hpb=b067981c0da0c1a4616ed175d0ce8ac5564cbdbf;p=builder.git diff --git a/source/target.cpp b/source/target.cpp index b0273e9..64e1115 100644 --- a/source/target.cpp +++ b/source/target.cpp @@ -22,7 +22,7 @@ Target::Target(Builder &b, const string &n): builder.add_target(this); } -void Target::add_depend(Target &dep) +void Target::add_dependency(Target &dep) { if(&dep==this) throw invalid_argument("Target::add_depend"); @@ -88,11 +88,11 @@ void Target::prepare() } state = PREPARING; - find_depends(); + find_dependencies(); if(tool) { if(FileTarget *tool_exe = tool->get_executable()) - add_depend(*tool_exe); + add_dependency(*tool_exe); } for(Dependencies::iterator i=depends.begin(); i!=depends.end(); ++i) @@ -115,11 +115,6 @@ Task *Target::build() return 0; } - // XXX Minor breach of OO here - if(FileTarget *ft = dynamic_cast(this)) - if(!builder.get_dry_run() && FS::exists(ft->get_path())) - FS::unlink(ft->get_path()); - Task *task = tool->run(*this); task->signal_finished.connect(sigc::mem_fun(this, &Target::build_finished)); state = BUILDING; @@ -127,7 +122,9 @@ Task *Target::build() return task; } -void Target::build_finished(bool /*success*/) +void Target::build_finished(bool success) { state = UPTODATE; + if(success) + modified(); }