X-Git-Url: http://git.tdb.fi/?a=blobdiff_plain;f=source%2Ftarget.cpp;h=352b788823534b464ddf609833b826108723c45f;hb=0dd3d23846e7fdb729359a57d3f4b190f65aed55;hp=577438b3528dce736aa3c22077e0857a24f5a0b4;hpb=f2b26f1929a8209a746bcf4944165b0ba9ef303f;p=builder.git

diff --git a/source/target.cpp b/source/target.cpp
index 577438b..352b788 100644
--- a/source/target.cpp
+++ b/source/target.cpp
@@ -17,13 +17,34 @@ Target::Target(Builder &b, const string &n):
 	component(0),
 	name(n),
 	tool(0),
-	state(INIT)
+	state(INIT),
+	primary_target(0)
 {
 	builder.add_target(this);
 }
 
+void Target::add_dependency(Target &dep)
+{
+	if(&dep==this)
+		throw invalid_argument("Target::add_depend");
+	depends.push_back(&dep);
+	if(state>PREPARING)
+		dep.signal_bubble_rebuild.connect(sigc::mem_fun(this, &Target::check_rebuild));
+}
+
+void Target::add_side_effect(Target &se)
+{
+	side_effects.push_back(&se);
+	se.add_dependency(*this);
+	if(tool)
+		se.set_tool(*tool);
+	se.primary_target = this;
+}
+
 Target *Target::get_buildable_target()
 {
+	if(primary_target)
+		return primary_target->get_buildable_target();
 	if(!needs_rebuild())
 		return 0;
 
@@ -46,6 +67,8 @@ Target *Target::get_buildable_target()
 void Target::set_tool(const Tool &t)
 {
 	tool = &t;
+	for(Dependencies::const_iterator i=side_effects.begin(); i!=side_effects.end(); ++i)
+		(*i)->set_tool(t);
 }
 
 void Target::force_rebuild()
@@ -55,13 +78,17 @@ void Target::force_rebuild()
 	mark_rebuild("Forced rebuild");
 }
 
-void Target::add_depend(Target &dep)
+void Target::mark_rebuild(const string &reason)
 {
-	if(&dep==this)
-		throw invalid_argument("Target::add_depend");
-	depends.push_back(&dep);
-	if(state>PREPARING)
-		dep.signal_bubble_rebuild.connect(sigc::mem_fun(this, &Target::check_rebuild));
+	if(reason.empty())
+		throw invalid_argument("No reason given for rebuilding "+name);
+
+	state = REBUILD;
+	rebuild_reason = reason;
+
+	builder.get_logger().log("rebuild", format("Rebuilding %s: %s", name, reason));
+
+	signal_bubble_rebuild.emit();
 }
 
 void Target::prepare()
@@ -75,11 +102,11 @@ void Target::prepare()
 	}
 
 	state = PREPARING;
-	find_depends();
+	find_dependencies();
 	if(tool)
 	{
 		if(FileTarget *tool_exe = tool->get_executable())
-			add_depend(*tool_exe);
+			add_dependency(*tool_exe);
 	}
 
 	for(Dependencies::iterator i=depends.begin(); i!=depends.end(); ++i)
@@ -102,11 +129,6 @@ Task *Target::build()
 		return 0;
 	}
 
-	// XXX Minor breach of OO here
-	if(FileTarget *ft = dynamic_cast<FileTarget *>(this))
-		if(!builder.get_dry_run() && FS::exists(ft->get_path()))
-			FS::unlink(ft->get_path());
-
 	Task *task = tool->run(*this);
 	task->signal_finished.connect(sigc::mem_fun(this, &Target::build_finished));
 	state = BUILDING;
@@ -114,20 +136,13 @@ Task *Target::build()
 	return task;
 }
 
-void Target::mark_rebuild(const string &reason)
-{
-	if(reason.empty())
-		throw invalid_argument("No reason given for rebuilding "+name);
-
-	state = REBUILD;
-	rebuild_reason = reason;
-
-	builder.get_logger().log("rebuild", format("Rebuilding %s: %s", name, reason));
-
-	signal_bubble_rebuild.emit();
-}
-
-void Target::build_finished(bool /*success*/)
+void Target::build_finished(bool success)
 {
 	state = UPTODATE;
+	if(success)
+	{
+		modified();
+		for(Dependencies::const_iterator i=side_effects.begin(); i!=side_effects.end(); ++i)
+			(*i)->build_finished(success);
+	}
 }